)]}'
{"manifests/backend/dellemc_powermax.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"d6502c5012765f9439c9c1f42002f564abadd14c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#   Defaults to $::os_service_default."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"# [*volume_driver*]"},{"line_number":44,"context_line":"#   (optional) The Dell EMC PowerMAx Driver"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# [*manage_volume_type*]"},{"line_number":47,"context_line":"#   (Optional) Whether or not manage Cinder Volume type."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1fa4df85_7e1183ac","line":44,"range":{"start_line":44,"start_character":33,"end_line":44,"end_character":36},"updated":"2020-03-11 22:59:24.000000000","message":"MAx-\u003eMax","commit_id":"a93c8f55bcd96fafa039a1fb1fa32f39018df12a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"75a06a9f8e422e9514db6f9988749de595976d14","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# [*san_password*]"},{"line_number":16,"context_line":"#   (required) PowerMax Unisphere user password."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*powermax_storage_protocol*]"},{"line_number":19,"context_line":"#   (required) The Storage protocol, iSCSI or FC."},{"line_number":20,"context_line":"#   This will determine"},{"line_number":21,"context_line":"#   which Volume Driver will be configured; PowerMaxISCSIDriver or PowerMaxFCDriver."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1fa4df85_ed6b6bee","line":18,"updated":"2020-03-13 18:11:51.000000000","message":"I was going to suggest using \u0027storage_protocol\u0027 because that\u0027s cinder\u0027s preferred term (see [1]), but then I noticed the PowerMax driver doesn\u0027t follow that standard. *sigh*\n\nThis is OK because it matches the driver\u0027s parameter name.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/driver.py#L221","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1754efde961bf9208f82a8419c925c3a365c082c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# [*san_password*]"},{"line_number":16,"context_line":"#   (required) PowerMax Unisphere user password."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*powermax_storage_protocol*]"},{"line_number":19,"context_line":"#   (required) The Storage protocol, iSCSI or FC."},{"line_number":20,"context_line":"#   This will determine"},{"line_number":21,"context_line":"#   which Volume Driver will be configured; PowerMaxISCSIDriver or PowerMaxFCDriver."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df33271e_96981a6b","line":18,"in_reply_to":"1fa4df85_ed6b6bee","updated":"2020-03-20 21:51:33.000000000","message":"OK","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"75a06a9f8e422e9514db6f9988749de595976d14","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (required) PowerMax Unisphere user password."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*powermax_storage_protocol*]"},{"line_number":19,"context_line":"#   (required) The Storage protocol, iSCSI or FC."},{"line_number":20,"context_line":"#   This will determine"},{"line_number":21,"context_line":"#   which Volume Driver will be configured; PowerMaxISCSIDriver or PowerMaxFCDriver."},{"line_number":22,"context_line":"#   Defaults to \u0027iSCSI\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1fa4df85_4d35dff6","line":19,"updated":"2020-03-13 18:11:51.000000000","message":"-1: it\u0027s optional (has a default value). Please also reorder the parameter comments to match the order of the arguments. From L65, this one should follow powermax_port_groups.","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1754efde961bf9208f82a8419c925c3a365c082c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (required) PowerMax Unisphere user password."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*powermax_storage_protocol*]"},{"line_number":19,"context_line":"#   (required) The Storage protocol, iSCSI or FC."},{"line_number":20,"context_line":"#   This will determine"},{"line_number":21,"context_line":"#   which Volume Driver will be configured; PowerMaxISCSIDriver or PowerMaxFCDriver."},{"line_number":22,"context_line":"#   Defaults to \u0027iSCSI\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df33271e_36930e52","line":19,"in_reply_to":"1fa4df85_4d35dff6","updated":"2020-03-20 21:51:33.000000000","message":"Done","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"75a06a9f8e422e9514db6f9988749de595976d14","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $volume_driver \u003d $powermax_storage_protocol ? {"},{"line_number":76,"context_line":"    \u0027FC\u0027    \u003d\u003e \u0027cinder.volume.drivers.dell_emc.powermax.fc.PowerMaxFCDriver\u0027,"},{"line_number":77,"context_line":"    \u0027iSCSI\u0027 \u003d\u003e \u0027cinder.volume.drivers.dell_emc.powermax.iscsi.PowerMaxISCSIDriver\u0027"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  cinder_config {"},{"line_number":81,"context_line":"    \"${name}/volume_backend_name\":       value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1fa4df85_e807d917","line":78,"updated":"2020-03-13 18:11:51.000000000","message":"Should probably fail on an invalid value.","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"75a06a9f8e422e9514db6f9988749de595976d14","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"${name}/san_ip\":                    value \u003d\u003e $san_ip;"},{"line_number":85,"context_line":"    \"${name}/san_login\":                 value \u003d\u003e $san_login;"},{"line_number":86,"context_line":"    \"${name}/san_password\":              value \u003d\u003e $san_password, secret \u003d\u003e true;"},{"line_number":87,"context_line":"    \"${name}/powermax_storage_protocol\": value \u003d\u003e $powermax_storage_protocol;"},{"line_number":88,"context_line":"    \"${name}/powermax_array\":            value \u003d\u003e $powermax_array;"},{"line_number":89,"context_line":"    \"${name}/powermax_srp\":              value \u003d\u003e $powermax_srp;"},{"line_number":90,"context_line":"    \"${name}/powermax_port_groups\":      value \u003d\u003e $powermax_port_groups;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1fa4df85_cd09cf31","line":87,"updated":"2020-03-13 18:11:51.000000000","message":"Wait, is this an actual cinder parameter? I don\u0027t see one, and figured the volume_driver would dictate.","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1754efde961bf9208f82a8419c925c3a365c082c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"${name}/san_ip\":                    value \u003d\u003e $san_ip;"},{"line_number":85,"context_line":"    \"${name}/san_login\":                 value \u003d\u003e $san_login;"},{"line_number":86,"context_line":"    \"${name}/san_password\":              value \u003d\u003e $san_password, secret \u003d\u003e true;"},{"line_number":87,"context_line":"    \"${name}/powermax_storage_protocol\": value \u003d\u003e $powermax_storage_protocol;"},{"line_number":88,"context_line":"    \"${name}/powermax_array\":            value \u003d\u003e $powermax_array;"},{"line_number":89,"context_line":"    \"${name}/powermax_srp\":              value \u003d\u003e $powermax_srp;"},{"line_number":90,"context_line":"    \"${name}/powermax_port_groups\":      value \u003d\u003e $powermax_port_groups;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1fa4df85_88d665f1","line":87,"in_reply_to":"1fa4df85_cd09cf31","updated":"2020-03-20 21:51:33.000000000","message":"It is not a cinder parameter. You are right","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b3a2d39be171580458538ae9327ebeebc0090010","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"${name}/powermax_array\":            value \u003d\u003e $powermax_array;"},{"line_number":92,"context_line":"    \"${name}/powermax_srp\":              value \u003d\u003e $powermax_srp;"},{"line_number":93,"context_line":"    \"${name}/powermax_port_groups\":      value \u003d\u003e $powermax_port_groups;"},{"line_number":94,"context_line":"    \"${name}/powermax_storage_protocol\": value \u003d\u003e $powermax_storage_protocol;"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  if $manage_volume_type {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"df33271e_bd7d23e9","line":94,"updated":"2020-03-23 20:31:18.000000000","message":"-1: unless things recently changed, this is not a valid cinder parameter","commit_id":"30e5986b18d67fd556a4ce42a5b5bc75da1d0206"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"4d6d0bcd56d0d802d287d100518a82469a147b88","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"${name}/powermax_array\":            value \u003d\u003e $powermax_array;"},{"line_number":92,"context_line":"    \"${name}/powermax_srp\":              value \u003d\u003e $powermax_srp;"},{"line_number":93,"context_line":"    \"${name}/powermax_port_groups\":      value \u003d\u003e $powermax_port_groups;"},{"line_number":94,"context_line":"    \"${name}/powermax_storage_protocol\": value \u003d\u003e $powermax_storage_protocol;"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  if $manage_volume_type {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"df33271e_7dfa7b42","line":94,"in_reply_to":"df33271e_bd7d23e9","updated":"2020-03-23 20:35:29.000000000","message":"Good catch. Done","commit_id":"30e5986b18d67fd556a4ce42a5b5bc75da1d0206"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4bfa9859481ae9567b4a54a6cd1d3947c627f2d4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#   Defaults to $::os_service_default."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"# [*volume_driver*]"},{"line_number":44,"context_line":"#   (optional) The Dell EMC PowerMAx Driver"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# [*manage_volume_type*]"},{"line_number":47,"context_line":"#   (Optional) Whether or not manage Cinder Volume type."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"df33271e_44603c33","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":37},"updated":"2020-03-27 02:11:25.000000000","message":"PowerMax","commit_id":"9fa54568b49862657be9429b7ca81891134e4a05"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"12be554ebc5034d26df86434082de5618ed7eb25","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#   Defaults to $::os_service_default."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"# [*volume_driver*]"},{"line_number":44,"context_line":"#   (optional) The Dell EMC PowerMAx Driver"},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"# [*manage_volume_type*]"},{"line_number":47,"context_line":"#   (Optional) Whether or not manage Cinder Volume type."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"df33271e_4f0e823b","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":37},"in_reply_to":"df33271e_44603c33","updated":"2020-03-27 23:40:01.000000000","message":"Done","commit_id":"9fa54568b49862657be9429b7ca81891134e4a05"}],"manifests/backend/dellemc_vmax_iscsi.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"75a06a9f8e422e9514db6f9988749de595976d14","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include cinder::deps"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  warning(\u0027The dellemc_vmax_iscsi class is not supported, please use the dellemc_powermax resource instead.\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  cinder_config {"},{"line_number":52,"context_line":"    \"${name}/volume_backend_name\":             value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1fa4df85_2d2ae3e6","line":49,"updated":"2020-03-13 18:11:51.000000000","message":"nit: it\u0027s actually not a class :-/ You could refer both of them using their puppet nomenclature (cinder::backend::\u003cblah\u003e), but this is fine for a warning message.","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1754efde961bf9208f82a8419c925c3a365c082c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include cinder::deps"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  warning(\u0027The dellemc_vmax_iscsi class is not supported, please use the dellemc_powermax resource instead.\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  cinder_config {"},{"line_number":52,"context_line":"    \"${name}/volume_backend_name\":             value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1fa4df85_e8fef969","line":49,"in_reply_to":"1fa4df85_2d2ae3e6","updated":"2020-03-20 21:51:33.000000000","message":"Done","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"12be554ebc5034d26df86434082de5618ed7eb25","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include cinder::deps"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  warning(\u0027The cinder::backend::dellemc_vmax_iscsi is not supported, please use cinder::backend::dellemc_powermax resource instead.\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  cinder_config {"},{"line_number":52,"context_line":"    \"${name}/volume_backend_name\":             value \u003d\u003e $volume_backend_name;"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"df33271e_2f097e30","line":49,"updated":"2020-03-27 23:40:01.000000000","message":"Moving deprecation to a separate patch","commit_id":"9fa54568b49862657be9429b7ca81891134e4a05"}],"releasenotes/notes/powermax-driver-d428e372280c44e6.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"75a06a9f8e422e9514db6f9988749de595976d14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1fa4df85_ed0ccb95","line":4,"updated":"2020-03-13 18:11:51.000000000","message":"Should also mention vmax in the deprecations section.","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1754efde961bf9208f82a8419c925c3a365c082c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1fa4df85_4e0955db","line":4,"in_reply_to":"1fa4df85_ed0ccb95","updated":"2020-03-20 21:51:33.000000000","message":"Done","commit_id":"c79dcefddd068e911dad5f3645a5b80c0db42c5e"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"12be554ebc5034d26df86434082de5618ed7eb25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add new PowerMax backend driver options"},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - cinder::backend::dellemc_vmax_iscsi is not supported anymore,"},{"line_number":6,"context_line":"    use resource cinder::backend::dellemc_powermax resource instead."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df33271e_8f088a2c","line":4,"updated":"2020-03-27 23:40:01.000000000","message":"Moving deprecation to a diff path","commit_id":"9fa54568b49862657be9429b7ca81891134e4a05"}],"spec/defines/cinder_backend_dellemc_powermax_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a1b4b065311743a4dbe39e70677076a94335bf2b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  shared_examples \u0027dellemc_powermax volume driver\u0027 do"},{"line_number":33,"context_line":"    let :params_hash do"},{"line_number":34,"context_line":"      default_params.merge(params)"},{"line_number":35,"context_line":"    end"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    it { is_expected.to contain_cinder__backend__dellemc_powermax(config_group_name) }"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"df33271e_463d24ba","line":34,"updated":"2020-03-23 23:09:58.000000000","message":"This won\u0027t work, as there isn\u0027t a 1:1 correspondence between the puppet parameters and the cinder.conf parameters. You\u0027ll need to exclude the powermax_storage_protocol puppet parameter from the expected list of cinder parameters.\n\nOr, maybe move the powermax_storage_protocol entry from :params to :default_params.","commit_id":"1f463eaa5cb493ce11af289a8dab246937ac4d61"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"cd1332c8d1dbb865a928c6c52a09d10a94ba5e62","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  shared_examples \u0027dellemc_powermax volume driver\u0027 do"},{"line_number":33,"context_line":"    let :params_hash do"},{"line_number":34,"context_line":"      default_params.merge(params)"},{"line_number":35,"context_line":"    end"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    it { is_expected.to contain_cinder__backend__dellemc_powermax(config_group_name) }"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"df33271e_dbb8c677","line":34,"in_reply_to":"df33271e_463d24ba","updated":"2020-03-25 20:32:25.000000000","message":"Fixed","commit_id":"1f463eaa5cb493ce11af289a8dab246937ac4d61"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a25ba427559f6eb7e4544f93bda5ac321c96967f","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  let :custom_params do"},{"line_number":28,"context_line":"    {"},{"line_number":29,"context_line":"      :backend_availability_zone \u003d\u003e \u0027my_zone\u0027,"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"df33271e_e6d34a37","line":29,"updated":"2020-03-27 16:04:14.000000000","message":"-1: I don\u0027t see where this value is ever checked. There are no is_expected tests for this in the cinder config.","commit_id":"9fa54568b49862657be9429b7ca81891134e4a05"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"12be554ebc5034d26df86434082de5618ed7eb25","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  let :custom_params do"},{"line_number":28,"context_line":"    {"},{"line_number":29,"context_line":"      :backend_availability_zone \u003d\u003e \u0027my_zone\u0027,"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"df33271e_6f038610","line":29,"in_reply_to":"df33271e_e6d34a37","updated":"2020-03-27 23:40:01.000000000","message":"Done","commit_id":"9fa54568b49862657be9429b7ca81891134e4a05"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a25ba427559f6eb7e4544f93bda5ac321c96967f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  end"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":" shared_examples \u0027dellemc_powermax fc volume driver\u0027 do"},{"line_number":51,"context_line":"    let :params_hash do"},{"line_number":52,"context_line":"      default_params.merge(params)"},{"line_number":53,"context_line":"      default_params.merge({\u0027powermax_storage_protocol\u0027 \u003d\u003e \u0027FC\u0027})"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"df33271e_86febeab","line":50,"updated":"2020-03-27 16:04:14.000000000","message":"-1: this shared example is never referenced, and so the FC protocol is never tested. Would also be good to test an invalid value.","commit_id":"9fa54568b49862657be9429b7ca81891134e4a05"}]}