)]}'
{"manifests/backend/dellemc_vxflexos.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5d0a6dc435bfb80eb872725dbcb534c326275bd0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*volume_backend_name*]"},{"line_number":9,"context_line":"#   (optional) The name of the cinder::backend::vxflexos_ ressource"},{"line_number":10,"context_line":"#   Defaults to $name."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*backend_availability_zone*]"},{"line_number":13,"context_line":"#   (Optional) Availability zone for this volume backend."},{"line_number":14,"context_line":"#   If not set, the storage_availability_zone option value"},{"line_number":15,"context_line":"#   is used as the default for all backends."},{"line_number":16,"context_line":"#   Defaults to $::os_service_default."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*san_login*]"},{"line_number":19,"context_line":"#   (required) Administrative user account name used to access the storage"},{"line_number":20,"context_line":"#   system or proxy server."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f493fa4_26d37c3a","line":17,"range":{"start_line":8,"start_character":0,"end_line":17,"end_character":1},"updated":"2020-05-07 18:23:02.000000000","message":"Required parameters should appear first, and order they are documented should match the order starting at L89.","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"ce5423cc9e3b05b68458df39820d08cdecc4b9f9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*volume_backend_name*]"},{"line_number":9,"context_line":"#   (optional) The name of the cinder::backend::vxflexos_ ressource"},{"line_number":10,"context_line":"#   Defaults to $name."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*backend_availability_zone*]"},{"line_number":13,"context_line":"#   (Optional) Availability zone for this volume backend."},{"line_number":14,"context_line":"#   If not set, the storage_availability_zone option value"},{"line_number":15,"context_line":"#   is used as the default for all backends."},{"line_number":16,"context_line":"#   Defaults to $::os_service_default."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*san_login*]"},{"line_number":19,"context_line":"#   (required) Administrative user account name used to access the storage"},{"line_number":20,"context_line":"#   system or proxy server."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ff570b3c_20ed8e25","line":17,"range":{"start_line":8,"start_character":0,"end_line":17,"end_character":1},"in_reply_to":"1f493fa4_26d37c3a","updated":"2020-05-08 21:10:38.000000000","message":"Done","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5d0a6dc435bfb80eb872725dbcb534c326275bd0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#  volume creation will fail for volumes not sized properly"},{"line_number":53,"context_line":"#  Defaults to $::os_service_default"},{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# [*vxflexos_storage_pools*]"},{"line_number":56,"context_line":"#   (String) (required)  Storage Pools. Comma separated list of storage pools used to provide volumes."},{"line_number":57,"context_line":"#   Each pool should be specified as a protection_domain_name:storage_pool_name value"},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# [*vxflexos_unmap_volume_before_deletion*]"},{"line_number":60,"context_line":"#   (Boolean) Unmap volumes before deletion."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f493fa4_a6e66c15","line":57,"range":{"start_line":55,"start_character":1,"end_line":57,"end_character":85},"updated":"2020-05-07 18:23:02.000000000","message":"Should appear with the other required parameters","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"ce5423cc9e3b05b68458df39820d08cdecc4b9f9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#  volume creation will fail for volumes not sized properly"},{"line_number":53,"context_line":"#  Defaults to $::os_service_default"},{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# [*vxflexos_storage_pools*]"},{"line_number":56,"context_line":"#   (String) (required)  Storage Pools. Comma separated list of storage pools used to provide volumes."},{"line_number":57,"context_line":"#   Each pool should be specified as a protection_domain_name:storage_pool_name value"},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# [*vxflexos_unmap_volume_before_deletion*]"},{"line_number":60,"context_line":"#   (Boolean) Unmap volumes before deletion."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ff570b3c_80f29a05","line":57,"range":{"start_line":55,"start_character":1,"end_line":57,"end_character":85},"in_reply_to":"1f493fa4_a6e66c15","updated":"2020-05-08 21:10:38.000000000","message":"Done","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5d0a6dc435bfb80eb872725dbcb534c326275bd0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#   Each pool should be specified as a protection_domain_name:storage_pool_name value"},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# [*vxflexos_unmap_volume_before_deletion*]"},{"line_number":60,"context_line":"#   (Boolean) Unmap volumes before deletion."},{"line_number":61,"context_line":"#   Defaults to $::os_service_default"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*san_thin_provision*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f493fa4_e6f074cc","line":60,"updated":"2020-05-07 18:23:02.000000000","message":"needs optional","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"ce5423cc9e3b05b68458df39820d08cdecc4b9f9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#   Each pool should be specified as a protection_domain_name:storage_pool_name value"},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# [*vxflexos_unmap_volume_before_deletion*]"},{"line_number":60,"context_line":"#   (Boolean) Unmap volumes before deletion."},{"line_number":61,"context_line":"#   Defaults to $::os_service_default"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*san_thin_provision*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ff570b3c_00bfaafb","line":60,"in_reply_to":"1f493fa4_e6f074cc","updated":"2020-05-08 21:10:38.000000000","message":"Done","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55e9bed14aef279f7f0e462343af947d8dedaece","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  include cinder::deps"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  cinder_config {"},{"line_number":109,"context_line":"    \"${name}/volume_backend_name\":                     value \u003d\u003e $volume_backend_name;"},{"line_number":110,"context_line":"    \"${name}/backend_availability_zone\":               value \u003d\u003e $backend_availability_zone;"},{"line_number":111,"context_line":"    \"${name}/volume_driver\":                           value \u003d\u003e \u0027cinder.volume.drivers.dell_emc.vxflexos.driver.VxFlexOSDriver\u0027;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f493fa4_6eec4d8f","line":108,"updated":"2020-05-07 00:31:09.000000000","message":"It seems like vxflexos_server_api_version is missing.\n\nAlso there are some options not implemented in this patch, but was implemented in deprecated version\n - driver_ssl_cert_verify\n - driver_ssl_cert_path\n\nDo you want to add these options, too ?","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"4cce83e1b8637ca43032b7de591bd97ca2860cfa","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  include cinder::deps"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  cinder_config {"},{"line_number":109,"context_line":"    \"${name}/volume_backend_name\":                     value \u003d\u003e $volume_backend_name;"},{"line_number":110,"context_line":"    \"${name}/backend_availability_zone\":               value \u003d\u003e $backend_availability_zone;"},{"line_number":111,"context_line":"    \"${name}/volume_driver\":                           value \u003d\u003e \u0027cinder.volume.drivers.dell_emc.vxflexos.driver.VxFlexOSDriver\u0027;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f493fa4_3d738bb3","line":108,"in_reply_to":"1f493fa4_6eec4d8f","updated":"2020-05-07 15:51:25.000000000","message":"Added the new options","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55e9bed14aef279f7f0e462343af947d8dedaece","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    \"${name}/san_ip\":                                  value \u003d\u003e $san_ip;"},{"line_number":115,"context_line":"    \"${name}/vxflexos_allow_migration_during_rebuild\": value \u003d\u003e $vxflexos_allow_migration_during_rebuild;"},{"line_number":116,"context_line":"    \"${name}/vxflexos_allow_non_padded_volumes\":       value \u003d\u003e $vxflexos_allow_non_padded_volumes;"},{"line_number":117,"context_line":"    \"${name}/vxflexos_max_over_subscription_ratio\":    value \u003d\u003e $$vxflexos_max_over_subscription_ratio;"},{"line_number":118,"context_line":"    \"${name}/vxflexos_rest_server_port\":               value \u003d\u003e $vxflexos_rest_server_port;"},{"line_number":119,"context_line":"    \"${name}/vxflexos_round_volume_capacity\":          value \u003d\u003e $vxflexos_round_volume_capacity;"},{"line_number":120,"context_line":"    \"${name}/vxflexos_storage_pools\":                  value \u003d\u003e $vxflexos_storage_pools;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f493fa4_4eefd186","line":117,"range":{"start_line":117,"start_character":64,"end_line":117,"end_character":65},"updated":"2020-05-07 00:31:09.000000000","message":"This should be removed.","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"4cce83e1b8637ca43032b7de591bd97ca2860cfa","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    \"${name}/san_ip\":                                  value \u003d\u003e $san_ip;"},{"line_number":115,"context_line":"    \"${name}/vxflexos_allow_migration_during_rebuild\": value \u003d\u003e $vxflexos_allow_migration_during_rebuild;"},{"line_number":116,"context_line":"    \"${name}/vxflexos_allow_non_padded_volumes\":       value \u003d\u003e $vxflexos_allow_non_padded_volumes;"},{"line_number":117,"context_line":"    \"${name}/vxflexos_max_over_subscription_ratio\":    value \u003d\u003e $$vxflexos_max_over_subscription_ratio;"},{"line_number":118,"context_line":"    \"${name}/vxflexos_rest_server_port\":               value \u003d\u003e $vxflexos_rest_server_port;"},{"line_number":119,"context_line":"    \"${name}/vxflexos_round_volume_capacity\":          value \u003d\u003e $vxflexos_round_volume_capacity;"},{"line_number":120,"context_line":"    \"${name}/vxflexos_storage_pools\":                  value \u003d\u003e $vxflexos_storage_pools;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f493fa4_9d69ffbf","line":117,"range":{"start_line":117,"start_character":64,"end_line":117,"end_character":65},"in_reply_to":"1f493fa4_4eefd186","updated":"2020-05-07 15:51:25.000000000","message":"Done","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5d0a6dc435bfb80eb872725dbcb534c326275bd0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  $vxflexos_server_api_version             \u003d $::os_service_default,"},{"line_number":113,"context_line":"  $vxflexos_unmap_volume_before_deletion   \u003d $::os_service_default,"},{"line_number":114,"context_line":"  $san_thin_provision                      \u003d $::os_service_default,"},{"line_number":115,"context_line":"  $driver_ssl_cert_verify                  \u003d $::os_service_default, "},{"line_number":116,"context_line":"  $driver_ssl_cert_path                    \u003d $::os_service_default,"},{"line_number":117,"context_line":"  $manage_volume_type                      \u003d false,"},{"line_number":118,"context_line":"  $extra_options                           \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1f493fa4_e66d1499","line":115,"updated":"2020-05-07 18:23:02.000000000","message":"linter is flagging the trailing whitespace","commit_id":"12d40b63b5970b3de0837d4a76690deb43a821e2"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"ce5423cc9e3b05b68458df39820d08cdecc4b9f9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  $vxflexos_server_api_version             \u003d $::os_service_default,"},{"line_number":113,"context_line":"  $vxflexos_unmap_volume_before_deletion   \u003d $::os_service_default,"},{"line_number":114,"context_line":"  $san_thin_provision                      \u003d $::os_service_default,"},{"line_number":115,"context_line":"  $driver_ssl_cert_verify                  \u003d $::os_service_default, "},{"line_number":116,"context_line":"  $driver_ssl_cert_path                    \u003d $::os_service_default,"},{"line_number":117,"context_line":"  $manage_volume_type                      \u003d false,"},{"line_number":118,"context_line":"  $extra_options                           \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ff570b3c_40e88215","line":115,"in_reply_to":"1f493fa4_e66d1499","updated":"2020-05-08 21:10:38.000000000","message":"Done","commit_id":"12d40b63b5970b3de0837d4a76690deb43a821e2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1979c3740d70358238760e4b6826032d26a49b2","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    \"${name}/driver_ssl_cert_verify\":                  value \u003d\u003e $driver_ssl_cert_verify;"},{"line_number":140,"context_line":"    \"${name}/driver_ssl_cert_path\":                    value \u003d\u003e $driver_ssl_cert_path;"},{"line_number":141,"context_line":"  }"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  if $manage_volume_type {"},{"line_number":145,"context_line":"    cinder_type { $name:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ff570b3c_359e6763","line":142,"range":{"start_line":142,"start_character":0,"end_line":142,"end_character":0},"updated":"2020-05-10 15:23:46.000000000","message":"These 2 blank lines can be reduced to 1.","commit_id":"74a3bf5bba7f87d02daa6910fa2bdf9a7a30b094"}],"spec/defines/cinder_backend_dellemc_vxflexos.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5d0a6dc435bfb80eb872725dbcb534c326275bd0","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  let :params2 do"},{"line_number":18,"context_line":"    {"},{"line_number":19,"context_line":"      :backend_availability_zone        \u003d\u003e \u0027my_zone\u0027,"},{"line_number":20,"context_line":"      :vxflexos_allow_migration_during_rebuild \u003d\u003e \u0027true\u0027,"},{"line_number":21,"context_line":"      :vxflexos_allow_non_padded_volumes       \u003d\u003e \u0027false\u0027,"},{"line_number":22,"context_line":"      :vxflexos_max_over_subscription_ratio  \u003d\u003e \u00276.0\u0027,"},{"line_number":23,"context_line":"      :vxflexos_round_volume_capacity        \u003d\u003e true,"},{"line_number":24,"context_line":"      :vxflexos_storage_pools                \u003d\u003e \u0027domain1:pool1,domain2:pool2\u0027,"},{"line_number":25,"context_line":"      :vxflexos_unmap_volume_before_deletion \u003d\u003e false,"},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"  end"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1f493fa4_c6fd78b2","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":54},"updated":"2020-05-07 18:23:02.000000000","message":"\u003d\u003e not aligned","commit_id":"91eab914e8f9525d8a3cee208687fea9c540b651"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1979c3740d70358238760e4b6826032d26a49b2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      :vxflexos_unmap_volume_before_deletion   \u003d\u003e false,"},{"line_number":27,"context_line":"      :driver_ssl_cert_path                    \u003d\u003e \u0027/path/cert.pem\u0027,"},{"line_number":28,"context_line":"      :driver_ssl_cert_verify                  \u003d\u003e true,"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ff570b3c_f5934f5b","line":29,"updated":"2020-05-10 15:23:46.000000000","message":"This blank line can be removed.","commit_id":"74a3bf5bba7f87d02daa6910fa2bdf9a7a30b094"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"b55454057c45ce6d78acea3fa3db5924250846f6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      :vxflexos_unmap_volume_before_deletion   \u003d\u003e false,"},{"line_number":27,"context_line":"      :driver_ssl_cert_path                    \u003d\u003e \u0027/path/cert.pem\u0027,"},{"line_number":28,"context_line":"      :driver_ssl_cert_verify                  \u003d\u003e true,"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ff570b3c_e59eef05","line":29,"in_reply_to":"ff570b3c_f5934f5b","updated":"2020-05-11 15:48:53.000000000","message":"Done","commit_id":"74a3bf5bba7f87d02daa6910fa2bdf9a7a30b094"}]}