)]}'
{"manifests/backend/iscsi.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"44fe346f38de7f98ea2ab895204d1159ae63749a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        tag    \u003d\u003e \u0027cinder-support-package\u0027,"},{"line_number":105,"context_line":"      }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      if($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":108,"context_line":"        file_line { \u0027cinder include\u0027:"},{"line_number":109,"context_line":"          path    \u003d\u003e \u0027/etc/tgt/targets.conf\u0027,"},{"line_number":110,"context_line":"          line    \u003d\u003e \"include ${volumes_dir}/*\","},{"line_number":111,"context_line":"          match   \u003d\u003e \u0027#?include /\u0027,"},{"line_number":112,"context_line":"          require \u003d\u003e Anchor[\u0027cinder::install::end\u0027],"},{"line_number":113,"context_line":"          notify  \u003d\u003e Anchor[\u0027cinder::service::begin\u0027],"},{"line_number":114,"context_line":"        }"},{"line_number":115,"context_line":"      }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"      service { \u0027tgtd\u0027:"},{"line_number":118,"context_line":"        ensure \u003d\u003e running,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ff570b3c_7bd3e201","side":"PARENT","line":115,"range":{"start_line":107,"start_character":0,"end_line":115,"end_character":7},"updated":"2020-06-04 15:04:54.000000000","message":"Why is this CentOS 6 specific? We should probably notify about this change if somebody relies on it.","commit_id":"37e6d74314f941d05405df335a82150cd9df2329"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2ac979a54fcf854b5727f7aaae202c584f0c6892","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        tag    \u003d\u003e \u0027cinder-support-package\u0027,"},{"line_number":105,"context_line":"      }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      if($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":108,"context_line":"        file_line { \u0027cinder include\u0027:"},{"line_number":109,"context_line":"          path    \u003d\u003e \u0027/etc/tgt/targets.conf\u0027,"},{"line_number":110,"context_line":"          line    \u003d\u003e \"include ${volumes_dir}/*\","},{"line_number":111,"context_line":"          match   \u003d\u003e \u0027#?include /\u0027,"},{"line_number":112,"context_line":"          require \u003d\u003e Anchor[\u0027cinder::install::end\u0027],"},{"line_number":113,"context_line":"          notify  \u003d\u003e Anchor[\u0027cinder::service::begin\u0027],"},{"line_number":114,"context_line":"        }"},{"line_number":115,"context_line":"      }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"      service { \u0027tgtd\u0027:"},{"line_number":118,"context_line":"        ensure \u003d\u003e running,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ff570b3c_96616bd6","side":"PARENT","line":115,"range":{"start_line":107,"start_character":0,"end_line":115,"end_character":7},"in_reply_to":"ff570b3c_7bd3e201","updated":"2020-06-04 15:33:09.000000000","message":"I missed the fact that target_helper can be overridden by the parameter. Fixed this.\n\nOn the other hand, I guess that tgt package is no longer available in CentOS7/8, and these logic might be useless.\nI\u0027ll check that later and submit another patch if needed.","commit_id":"37e6d74314f941d05405df335a82150cd9df2329"}]}