)]}'
{"manifests/backend/dellemc_powerstore.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31adb81eeff6fac7c8d84db932350a125ccb574e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $san_login,"},{"line_number":51,"context_line":"  $san_password,"},{"line_number":52,"context_line":"  $powerstore_appliances,"},{"line_number":53,"context_line":"  $powerstore_ports            \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $storage_protocol            \u003d \u0027iSCSI\u0027,"},{"line_number":55,"context_line":"  $volume_backend_name         \u003d $name,"},{"line_number":56,"context_line":"  $backend_availability_zone   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f560f44_83bd746a","line":53,"range":{"start_line":53,"start_character":29,"end_line":53,"end_character":31},"updated":"2020-07-27 12:40:01.000000000","message":"(nit) 2 redundant spaces can be removed","commit_id":"e13e0985807a4bfed1bc9d28410d7dd0a88674a1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"31adb81eeff6fac7c8d84db932350a125ccb574e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    \"${name}/powerstore_appliances\":     value \u003d\u003e $powerstore_appliances;"},{"line_number":81,"context_line":"    \"${name}/powerstore_ports\":          value \u003d\u003e $powerstore_ports;"},{"line_number":82,"context_line":"    \"${name}/storage_protocol\":          value \u003d\u003e $storage_protocol;"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  }"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  if $manage_volume_type {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f560f44_c3b76c86","line":83,"updated":"2020-07-27 12:40:01.000000000","message":"(nit) Redundant blank line","commit_id":"e13e0985807a4bfed1bc9d28410d7dd0a88674a1"}],"spec/defines/cinder_backend_dellemc_powerstore_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1d5d1b49f19db0775295d651ee4722268f8bd449","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  end"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"   context \u0027with storage_protocol set to FC\u0027 do"},{"line_number":51,"context_line":"      before do"},{"line_number":52,"context_line":"        params.merge!(:storage_protocol \u003d\u003e \u0027FC\u0027,)"},{"line_number":53,"context_line":"      end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      it \u0027should configure the FC driver\u0027 do"},{"line_number":56,"context_line":"        is_expected.to contain_cinder_config(\"#{title}/volume_driver\").with_value("},{"line_number":57,"context_line":"          \u0027cinder.volume.drivers.dell_emc.powerstore.driver.PowerStoreDriver\u0027"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"      end"},{"line_number":60,"context_line":"    end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    context \u0027with an invalid storage_protocol\u0027 do"},{"line_number":63,"context_line":"      before do"},{"line_number":64,"context_line":"        params.merge!(:storage_protocol \u003d\u003e \u0027BAD\u0027,)"},{"line_number":65,"context_line":"      end"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"      it \u0027should raise an error\u0027 do"},{"line_number":68,"context_line":"        is_expected.to compile.and_raise_error("},{"line_number":69,"context_line":"          /The cinder::backend::dellemc_powerstore storage_protocol specified is not valid. It should be iSCSI or FC/"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"      end"},{"line_number":72,"context_line":"    end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  shared_examples \u0027cinder::backend::dellemc_powerstore\u0027 do"},{"line_number":75,"context_line":"    context \u0027with default parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"bf51134e_056e71c8","line":72,"range":{"start_line":50,"start_character":0,"end_line":72,"end_character":7},"updated":"2020-07-21 03:33:47.000000000","message":"Any reason why is this block appears outside the shared_examples? I would expect the block to be included in the shared_examples at L74.","commit_id":"61eec11c9705b411dbf4d1a75dc8238c90f49433"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"02cc7735e93b4602bbdece68b07193ded96e3e00","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"  end"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"   context \u0027with storage_protocol set to FC\u0027 do"},{"line_number":51,"context_line":"      before do"},{"line_number":52,"context_line":"        params.merge!(:storage_protocol \u003d\u003e \u0027FC\u0027,)"},{"line_number":53,"context_line":"      end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      it \u0027should configure the FC driver\u0027 do"},{"line_number":56,"context_line":"        is_expected.to contain_cinder_config(\"#{title}/volume_driver\").with_value("},{"line_number":57,"context_line":"          \u0027cinder.volume.drivers.dell_emc.powerstore.driver.PowerStoreDriver\u0027"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"      end"},{"line_number":60,"context_line":"    end"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    context \u0027with an invalid storage_protocol\u0027 do"},{"line_number":63,"context_line":"      before do"},{"line_number":64,"context_line":"        params.merge!(:storage_protocol \u003d\u003e \u0027BAD\u0027,)"},{"line_number":65,"context_line":"      end"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"      it \u0027should raise an error\u0027 do"},{"line_number":68,"context_line":"        is_expected.to compile.and_raise_error("},{"line_number":69,"context_line":"          /The cinder::backend::dellemc_powerstore storage_protocol specified is not valid. It should be iSCSI or FC/"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"      end"},{"line_number":72,"context_line":"    end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  shared_examples \u0027cinder::backend::dellemc_powerstore\u0027 do"},{"line_number":75,"context_line":"    context \u0027with default parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"bf51134e_ed717879","line":72,"range":{"start_line":50,"start_character":0,"end_line":72,"end_character":7},"in_reply_to":"bf51134e_056e71c8","updated":"2020-07-22 21:34:05.000000000","message":"Done","commit_id":"61eec11c9705b411dbf4d1a75dc8238c90f49433"}]}