)]}'
{"id":"openstack%2Fpuppet-cinder~751266","triplet_id":"openstack%2Fpuppet-cinder~master~I779dfd416da6fe8bb713105ed246172ebf0aae85","project":"openstack/puppet-cinder","branch":"master","topic":"fix-doubled-fined-services-and-package","hashtags":[],"change_id":"I779dfd416da6fe8bb713105ed246172ebf0aae85","subject":"Avoid defining resources twice in iscsi backend","status":"MERGED","created":"2020-09-11 12:39:39.000000000","updated":"2020-09-14 03:11:09.000000000","submitted":"2020-09-14 03:11:09.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"751266-1600053069259-06ebbb73","meta_rev_id":"9ddab61f3e23654e07031770d040042c4812a4e4","_number":751266,"virtual_id_number":751266,"owner":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2020-09-11 12:44:41.000000000","_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2020-09-11 14:16:12.000000000","_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-14 03:11:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2020-09-14 01:26:21.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2020-09-11 19:39:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2020-09-14 01:26:21.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-11 12:44:41.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2020-09-11 19:39:03.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-09-14 01:26:21.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-09-14 03:11:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2fb16a4a39bd345be8a2d7e09a3f367f78c14716","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2020-09-11 12:39:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5a4a50ec304b1f0f4a55a101feb9ce54363e7dea","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-09-11 12:44:41.000000000","message":"Patch Set 1:\n\nWhat about using ensure_packages() instead of all if statements, much cleaner and will solve your issue.","accounts_in_message":[],"_revision_number":1},{"id":"4caeb27842bb4d3bf851648e2f7635e0cc3eacd2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-11 14:14:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c674db9c3eaa4543b03aa1650a070ec1 : SUCCESS in 4m 03s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/32d74d70207341b59a479a2ac6255393 : SUCCESS in 3m 54s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/40170982551347dba640b0312a9bcd99 : SUCCESS in 15m 18s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a91997a4c6384c0b9607bd125f81ce15 : SUCCESS in 12m 05s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b6e02f936b844686a32b5870de5df2d4 : SUCCESS in 14m 36s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/0fe2d956cb0946d4ab679621cccfeeb6 : SUCCESS in 45m 56s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/75bcf45665804fa6ac9b96e99698363a : SUCCESS in 51m 10s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2b351c7b309e4dcf9e5881e1cafa5185 : SUCCESS in 47m 46s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/18da80ca254d49eabf6b09b570c95f59 : SUCCESS in 48m 14s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/9bf31d3476a3432f8cf979258de7264b : SUCCESS in 1h 10m 07s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/1d6841e3d8f54bb8822ea041b6cd8a0c : SUCCESS in 1h 27m 00s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/87a5dacad3124d85ae2f6fb8227e984a : SUCCESS in 1h 24m 10s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/d23f0fd1cea044e49989554a9ca85433 : SUCCESS in 54m 06s\n- puppet-openstack-litmus-centos-8 https://zuul.opendev.org/t/openstack/build/1287dfe062d643ed822edefddaf3c0c9 : SUCCESS in 25m 01s\n- puppet-openstack-litmus-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ee5e0d26cdfa40f099214d8de5138a6c : SUCCESS in 14m 14s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/c19c29cfcfb842ee97a46b41e9883f35 : SUCCESS in 1h 25m 00s","accounts_in_message":[],"_revision_number":1},{"id":"893a4762e5c90a47e3ba12a5cedc31b07f3cb16f","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2020-09-11 14:16:12.000000000","message":"Patch Set 1:\n\nHi Tobias,\n\nI thought about it, and I\u0027m ok with ensure_package, however, this wasn\u0027t done like this prior to this patch, and I don\u0027t see a reason why to move to that, this will basically be the same thing.","accounts_in_message":[],"_revision_number":1},{"id":"c30cf4063acbdee6aaf115d0c72830f4113dfa0e","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-09-11 19:39:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0049b89882e15ad97994592be9d6504403859f44","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-09-14 01:26:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d2f33aa3fafdf66b62fff53d8e0224ccc1899f9a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 01:26:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b96d0a7864c62596822c6fa02318d70e8550d6e1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 03:11:09.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"d6b03dea294900fa2b47b1522a3ef0679065dd38","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 03:11:09.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1f3fceb3d8d141beac86289146849362 : SUCCESS in 3m 46s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f32240d700594200ac8368538b622483 : SUCCESS in 3m 28s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/818de9c4e1be4d4cb78d6eef68e01dbb : SUCCESS in 14m 05s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6af1120952f94eca93b235400762683f : SUCCESS in 12m 17s\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/c58bb580cc04497fb51b1cfcb16e25e6 : SUCCESS in 1h 06m 46s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/6b55394b124d4934985cf7470f9f0f03 : SUCCESS in 1h 26m 06s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/78128bf8798c4eb3ad61667c47741e1e : SUCCESS in 1h 26m 12s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/7f2926647ca3489881e98e036b910cb7 : SUCCESS in 52m 02s\n- puppet-openstack-litmus-centos-8 https://zuul.opendev.org/t/openstack/build/1c2ea4c6b66a4c21abe600e80cf4725e : SUCCESS in 14m 07s\n- puppet-openstack-litmus-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/886d7e57c5b94642811bdfcc57634784 : SUCCESS in 14m 18s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/4f4d3ab8452f44579014a016792ea632 : SUCCESS in 1h 39m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"715263c21c49493c7d4dcac96163e6c153e65ca4","revisions":{"715263c21c49493c7d4dcac96163e6c153e65ca4":{"kind":"REWORK","_number":1,"created":"2020-09-11 12:39:39.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/66/751266/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/66/751266/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/66/751266/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/66/751266/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/66/751266/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/66/751266/1"}}},"commit":{"parents":[{"commit":"f22af86550fc1d5d9d780905d79df6cdf7f35262","subject":"Merge \"Add Puppet Litmus\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/f22af86550fc1d5d9d780905d79df6cdf7f35262"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2020-09-11 12:37:33.000000000","tz":120},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2020-09-11 12:37:33.000000000","tz":120},"subject":"Avoid defining resources twice in iscsi backend","message":"Avoid defining resources twice in iscsi backend\n\nIn its current form, cinder::backend::iscsi is a define, allowing to call\nit multiple times, which is desirable (if a server has multiple backends).\nHowever, some resources are defined twice if the class is called twice.\nTo avoid this, this patch decorates the resource definition for packages\nand services with if !defined.\n\nChange-Id: I779dfd416da6fe8bb713105ed246172ebf0aae85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/715263c21c49493c7d4dcac96163e6c153e65ca4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/715263c21c49493c7d4dcac96163e6c153e65ca4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}