)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"adb8347623e97cf0a4acd36ae15869e5431d7c70","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  if $configure_endpoint_v2 {"},{"line_number":209,"context_line":"    warning(\u0027The support for v2 API has been deprecated\u0027)"},{"line_number":210,"context_line":"    Keystone_endpoint[\"${region}/${service_name_v2}::${service_type_v2}\"] -\u003e Anchor[\u0027cinder::service::end\u0027]"},{"line_number":211,"context_line":"  }"},{"line_number":212,"context_line":"  if $configure_user_v2 {"},{"line_number":213,"context_line":"    warning(\u0027The support for v2 API has been deprecated\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f621f24_d142da0e","line":210,"updated":"2020-11-13 13:41:15.000000000","message":"We know API v2 has been deprecated in cinder for quite a while, and the community has proposed removing support in Wallaby. If they do remove it this cycle, will another patch be required to remove L210?","commit_id":"18557bcdc2fa3500d0a3a6929cd58252072e7de0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"def4081efa0dd798d9fd21927b876f86c5f11005","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  if $configure_endpoint_v2 {"},{"line_number":209,"context_line":"    warning(\u0027The support for v2 API has been deprecated\u0027)"},{"line_number":210,"context_line":"    Keystone_endpoint[\"${region}/${service_name_v2}::${service_type_v2}\"] -\u003e Anchor[\u0027cinder::service::end\u0027]"},{"line_number":211,"context_line":"  }"},{"line_number":212,"context_line":"  if $configure_user_v2 {"},{"line_number":213,"context_line":"    warning(\u0027The support for v2 API has been deprecated\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f621f24_44443847","line":210,"in_reply_to":"1f621f24_d142da0e","updated":"2020-11-16 13:48:24.000000000","message":"I thought to make 2 steps (deprecate then remove support).\n\nHowever if cinder removes v2 api completely during this cycle, I think it\u0027s better to remove support in puppet-cinder at the same time.\n\nMy current plan is;\n\n- submit another patch to make all parameters for v2 api ineffective if cinder drops v2 api in this cycle.\n\n- if cinder keeps v2 api for some reasons then I\u0027ll leave these parameters functional, with making v2 api disabled by default","commit_id":"18557bcdc2fa3500d0a3a6929cd58252072e7de0"}],"spec/classes/cinder_keystone_auth_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"adb8347623e97cf0a4acd36ae15869e5431d7c70","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        params.merge!({"},{"line_number":65,"context_line":"          :roles                 \u003d\u003e [\u0027admin\u0027, \u0027service\u0027],"},{"line_number":66,"context_line":"          :region                \u003d\u003e \u0027RegionThree\u0027,"},{"line_number":67,"context_line":"          :configure_endpoint_v2 \u003d\u003e true"},{"line_number":68,"context_line":"          :public_url_v2         \u003d\u003e \u0027https://10.0.42.1:4242/v42/%(tenant_id)s\u0027,"},{"line_number":69,"context_line":"          :admin_url_v2          \u003d\u003e \u0027https://10.0.42.2:4242/v42/%(tenant_id)s\u0027,"},{"line_number":70,"context_line":"          :internal_url_v2       \u003d\u003e \u0027https://10.0.42.3:4242/v42/%(tenant_id)s\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1f621f24_31fb4ec1","line":67,"updated":"2020-11-13 13:41:15.000000000","message":"missing comma at end of line","commit_id":"18557bcdc2fa3500d0a3a6929cd58252072e7de0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"def4081efa0dd798d9fd21927b876f86c5f11005","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        params.merge!({"},{"line_number":65,"context_line":"          :roles                 \u003d\u003e [\u0027admin\u0027, \u0027service\u0027],"},{"line_number":66,"context_line":"          :region                \u003d\u003e \u0027RegionThree\u0027,"},{"line_number":67,"context_line":"          :configure_endpoint_v2 \u003d\u003e true"},{"line_number":68,"context_line":"          :public_url_v2         \u003d\u003e \u0027https://10.0.42.1:4242/v42/%(tenant_id)s\u0027,"},{"line_number":69,"context_line":"          :admin_url_v2          \u003d\u003e \u0027https://10.0.42.2:4242/v42/%(tenant_id)s\u0027,"},{"line_number":70,"context_line":"          :internal_url_v2       \u003d\u003e \u0027https://10.0.42.3:4242/v42/%(tenant_id)s\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1f621f24_a49d4cbd","line":67,"in_reply_to":"1f621f24_31fb4ec1","updated":"2020-11-16 13:48:24.000000000","message":"thanks! will fix.","commit_id":"18557bcdc2fa3500d0a3a6929cd58252072e7de0"}]}