)]}'
{"manifests/backup/s3.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"46ff4e3c89dc6696d712fea6c59675ac1dda83af","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# [*backup_s3_store_secret_key*]"},{"line_number":14,"context_line":"#   (required) The S3 query token secret key."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*backup_driver*]"},{"line_number":17,"context_line":"#   (Optional) The backup driver for S3 backend."},{"line_number":18,"context_line":"#   Defaults to \u0027cinder.backup.drivers.s3.S3BackupDriver\u0027."},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"4ae9c74f_b50a26e9","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":17},"updated":"2021-02-04 11:56:11.000000000","message":"This is not specific for this change and should be discussed in the follow up, but I feel it is not very useful but just confusing to have backup driver options overridable.\n\nWe don\u0027t really expect our users to override driver path, thus it makes sense to deprecate the driver parameters and make them hard-coded.","commit_id":"b810f33fd9d1a8983972619e7adf5643a13f667d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"66008685028f1a86935ae974feccfbf884a62b53","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# [*backup_s3_store_secret_key*]"},{"line_number":14,"context_line":"#   (required) The S3 query token secret key."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*backup_driver*]"},{"line_number":17,"context_line":"#   (Optional) The backup driver for S3 backend."},{"line_number":18,"context_line":"#   Defaults to \u0027cinder.backup.drivers.s3.S3BackupDriver\u0027."},{"line_number":19,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"a11d55f0_dbaeec7f","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":17},"in_reply_to":"4ae9c74f_b50a26e9","updated":"2021-02-04 16:15:44.000000000","message":"I agree we \"don\u0027t expect\" users to override the driver path, but the pattern of providing that ability has been present in the code for a long time, and I don\u0027t see a lot of value in removing flexibility.\n\nIn fact, I know of one situation where the capability was useful for a Red Hat customer. The situation was unusual, but my point is simply that the feature has proven useful in addressing unexpected corner cases.","commit_id":"b810f33fd9d1a8983972619e7adf5643a13f667d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"46ff4e3c89dc6696d712fea6c59675ac1dda83af","unresolved":true,"context_lines":[{"line_number":134,"context_line":"  include cinder::deps"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  cinder_config {"},{"line_number":137,"context_line":"    \u0027DEFAULT/backup_s3_endpoint_url\u0027:           value \u003d\u003e $backup_s3_endpoint_url;"},{"line_number":138,"context_line":"    \u0027DEFAULT/backup_s3_store_access_key\u0027:       value \u003d\u003e $backup_s3_store_access_key, secret \u003d\u003e true;"},{"line_number":139,"context_line":"    \u0027DEFAULT/backup_s3_store_secret_key\u0027:       value \u003d\u003e $backup_s3_store_secret_key, secret \u003d\u003e true;"},{"line_number":140,"context_line":"    \u0027DEFAULT/backup_driver\u0027:                    value \u003d\u003e $backup_driver;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1f3cc751_351f3424","line":137,"range":{"start_line":137,"start_character":5,"end_line":137,"end_character":35},"updated":"2021-02-04 11:56:11.000000000","message":"off-topic:\nI think this indicates some rationale to introduce the new \"backup\" section in cinder.conf .","commit_id":"b810f33fd9d1a8983972619e7adf5643a13f667d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"66008685028f1a86935ae974feccfbf884a62b53","unresolved":true,"context_lines":[{"line_number":134,"context_line":"  include cinder::deps"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  cinder_config {"},{"line_number":137,"context_line":"    \u0027DEFAULT/backup_s3_endpoint_url\u0027:           value \u003d\u003e $backup_s3_endpoint_url;"},{"line_number":138,"context_line":"    \u0027DEFAULT/backup_s3_store_access_key\u0027:       value \u003d\u003e $backup_s3_store_access_key, secret \u003d\u003e true;"},{"line_number":139,"context_line":"    \u0027DEFAULT/backup_s3_store_secret_key\u0027:       value \u003d\u003e $backup_s3_store_secret_key, secret \u003d\u003e true;"},{"line_number":140,"context_line":"    \u0027DEFAULT/backup_driver\u0027:                    value \u003d\u003e $backup_driver;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"54584d47_51e89afa","line":137,"range":{"start_line":137,"start_character":5,"end_line":137,"end_character":35},"in_reply_to":"1f3cc751_351f3424","updated":"2021-02-04 16:15:44.000000000","message":"Well, bear in mind there\u0027s a larger issue at stack. There have been occasional requests for cinder to support multiple backup backends (similar to the volume service). That would certainly require overhauling the way backup options are currently handled. But that sort of architectural change would be extensive.","commit_id":"b810f33fd9d1a8983972619e7adf5643a13f667d"}]}