)]}'
{"id":"openstack%2Fpuppet-cinder~772653","triplet_id":"openstack%2Fpuppet-cinder~master~Ia8792cd35ab7cf015e19b1156fe7294c7629a5d5","project":"openstack/puppet-cinder","branch":"master","topic":"keymgr-opts","hashtags":[],"change_id":"Ia8792cd35ab7cf015e19b1156fe7294c7629a5d5","subject":"Create an indepent class for Barbican options","status":"ABANDONED","created":"2021-01-27 11:32:19.000000000","updated":"2021-05-12 23:52:25.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"aeb159843e4ee9f71972d0a686c274462568593e","_number":772653,"virtual_id_number":772653,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-01-27 13:40:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":-1,"date":"2021-01-27 11:55:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-27 11:36:15.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"state":"REVIEWER"},{"updated":"2021-01-27 13:40:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"950004946013be731f070db45312ea45586aaf00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-01-27 11:32:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d8b4b6e130c4f440225930e251846713f9a58bee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-01-27 11:34:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d9b839304ea296d80decb0559bf00e2428ef1741","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-01-27 11:36:15.000000000","message":"Patch Set 2:\n\n@Alan How does this one look to you ?","accounts_in_message":[],"_revision_number":2},{"id":"044635cf4d656523f352228dca97675af85bc37d","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-01-27 11:55:09.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"ecbb44ab169e9928f895eb44241773b5f39e510e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-27 13:40:48.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/18a1d1dd3b6f4614939ec6c7bc0a5048 : SUCCESS in 3m 16s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c1ccd2e5fffd4fcbb199dd45d2b4cd69 : SUCCESS in 3m 09s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/e9b5685bdc51451ea9316aa042176804 : SUCCESS in 11m 58s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9a68cdc63643439a81e225f341cb7c5c : SUCCESS in 11m 53s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6805938b8b7e40829be58f5e37ce2c65 : SUCCESS in 10m 00s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a9dc8fb2cb104795adf843889154422a : SUCCESS in 54m 35s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a256f901051041c883ee66b16526585f : SUCCESS in 57m 46s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8feea5549b584f938e42097536b0ceb8 : SUCCESS in 47m 06s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f171f707fb024f52b5389bae1537720e : SUCCESS in 46m 38s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/9f5731b667114ff9bca8d2c0b10fe7c6 : SUCCESS in 1h 34m 52s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/18c54f0b12b14603bc19b420851d45ce : SUCCESS in 1h 58m 11s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/4f781c3b38674d7988afc3e31c3bc16a : SUCCESS in 1h 28m 50s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/2fb2c97c863b40339a2cb4d8cb5a071e : SUCCESS in 1h 07m 30s\n- puppet-openstack-litmus-centos-8 https://zuul.opendev.org/t/openstack/build/59ea4dcceb0244f9843efd24af969da1 : SUCCESS in 17m 26s\n- puppet-openstack-litmus-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/dd8141e0c8144449880b64ebb58d9a9d : SUCCESS in 13m 03s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0c0d0d7bb0c54469b58649de6d31ffaa : SUCCESS in 4m 01s\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/3429dd6b24924f30986d228c82d68b3d : FAILURE in 1h 36m 06s","accounts_in_message":[],"_revision_number":2},{"id":"37de261eb15efd39a67a54a151fa22c0d85ae479","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-01-28 00:47:04.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e @Alan How does this one look to you ?\n\nThank you for considering the feedback I left in the original patch, https://review.opendev.org/c/openstack/puppet-cinder/+/772139 !!!\n\nI still don\u0027t see a huge value this sort of change offers to an individual project, but I accept the point you made in the other review about having cinder, glance and nova all use a common approach for configuring the key manager. Plus, the new \u0027barbican\u0027 class you\u0027re proposing adds the ability to configure more of the barbican options, which is good.\n\nWith this in mind, I\u0027ll do a more thorough review of the other patch. If we\u0027re going to make some changes that deprecate existing settings, then we may as well go \"all in\" and make the new interface(s) as clean as possible. For this reason, I see how having a separate \u0027key_manager\u0027 class would be better, which is why I\u0027ll take a closer look at the other patch.","accounts_in_message":[],"_revision_number":2},{"id":"aeb159843e4ee9f71972d0a686c274462568593e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-05-12 23:52:25.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"64bdac4b7b950360a8cfbd59baba327172285115","revisions":{"135b1fb2cb7f51dedcdcf384dd280e2c72b71a2f":{"kind":"REWORK","_number":1,"created":"2021-01-27 11:32:19.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/53/772653/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/53/772653/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/772653/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/772653/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/772653/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/53/772653/1"}}},"commit":{"parents":[{"commit":"49d5ef14707104ef9751e9fcc10067708129dbd8","subject":"Remove the deprecated keymgr_* parameters of cinder::api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/49d5ef14707104ef9751e9fcc10067708129dbd8"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-01-23 01:34:52.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-01-27 11:31:52.000000000","tz":540},"subject":"Create an indepent class for Barbican options","message":"Create an indepent class for Barbican options\n\nThis change introduces the new independent classes to manage options\nunder the [barbican] section, which are implemented in the castellan\nlibrary.\n\nChange-Id: Ia8792cd35ab7cf015e19b1156fe7294c7629a5d5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/135b1fb2cb7f51dedcdcf384dd280e2c72b71a2f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/135b1fb2cb7f51dedcdcf384dd280e2c72b71a2f"}]},"branch":"refs/heads/master"},"64bdac4b7b950360a8cfbd59baba327172285115":{"kind":"REWORK","_number":2,"created":"2021-01-27 11:34:34.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/53/772653/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/53/772653/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/772653/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/772653/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/772653/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/53/772653/2"}}},"commit":{"parents":[{"commit":"49d5ef14707104ef9751e9fcc10067708129dbd8","subject":"Remove the deprecated keymgr_* parameters of cinder::api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/49d5ef14707104ef9751e9fcc10067708129dbd8"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-01-23 01:34:52.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-01-27 11:34:21.000000000","tz":540},"subject":"Create an indepent class for Barbican options","message":"Create an indepent class for Barbican options\n\nThis change introduces the new independent classes to manage options\nunder the [barbican] section, which are implemented in the castellan\nlibrary.\n\nChange-Id: Ia8792cd35ab7cf015e19b1156fe7294c7629a5d5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/64bdac4b7b950360a8cfbd59baba327172285115"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/64bdac4b7b950360a8cfbd59baba327172285115"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}