)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1f9a5c3e41aa102370da2062e32563eff2efd24b","unresolved":true,"context_lines":[{"line_number":13,"context_line":"filtering."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/775798"},{"line_number":16,"context_line":"Closes-Bug: #1915800"},{"line_number":17,"context_line":"Change-Id: I5d4934549de9350b8816d688ce8526dbc5d0f603"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fdf4ce38_d7bc7930","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":6},"updated":"2021-02-18 12:18:31.000000000","message":"(nit) Related might be more appropriate for patches in puppet and tripleo.","commit_id":"2e889e3dd326ede6383a2e25a1c607b9de7aa141"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"dd263b3e8837656d002a89e2df77579f8b8e32a9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"filtering."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/775798"},{"line_number":16,"context_line":"Closes-Bug: #1915800"},{"line_number":17,"context_line":"Change-Id: I5d4934549de9350b8816d688ce8526dbc5d0f603"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6da17b0e_ed7c00c8","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":6},"in_reply_to":"fdf4ce38_d7bc7930","updated":"2021-02-18 12:48:50.000000000","message":"Done","commit_id":"2e889e3dd326ede6383a2e25a1c607b9de7aa141"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"1fe40f1de19e476ac9fcff5712197b0194b74240","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ports filtering support to XtremIO Cinder driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there are some iSCSI or FC targets (ESXi for example) that"},{"line_number":10,"context_line":"are not connected to the OpenStack host,"},{"line_number":11,"context_line":"attach volume operation waits until timeout."},{"line_number":12,"context_line":"The XtremIO Cinder driver needs a new option to support ports"},{"line_number":13,"context_line":"filtering."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/775798"},{"line_number":16,"context_line":"Related-Bug: #1915800"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5dacba1f_36bef973","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":10},"updated":"2021-02-18 17:02:09.000000000","message":"again something more specific to puppet-cinder","commit_id":"cc8665d4738064e7e25466526d01c14903c6b505"}],"manifests/backend/dellemc_xtremio.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1f9a5c3e41aa102370da2062e32563eff2efd24b","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    \"${name}/xtremio_array_busy_retry_count\":    value \u003d\u003e $xtremio_array_busy_retry_count;"},{"line_number":101,"context_line":"    \"${name}/xtremio_array_busy_retry_interval\": value \u003d\u003e $xtremio_array_busy_retry_interval;"},{"line_number":102,"context_line":"    \"${name}/xtremio_volumes_per_glance_cache\":  value \u003d\u003e $xtremio_volumes_per_glance_cache;"},{"line_number":103,"context_line":"    \"${name}/xtremio_ports\":                     value \u003d\u003e $xtremio_ports;"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"02b2686f_a1bc2b5b","line":103,"range":{"start_line":103,"start_character":59,"end_line":103,"end_character":72},"updated":"2021-02-18 12:18:31.000000000","message":"If this expects comma-separated list then how about implementing something like\n\n join(any2array($xtremio_ports), \u0027,\u0027)\n\nThis allows us to use list in addition to a single string and would be helpful when a user wants to put multiple items.","commit_id":"2e889e3dd326ede6383a2e25a1c607b9de7aa141"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"dd263b3e8837656d002a89e2df77579f8b8e32a9","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    \"${name}/xtremio_array_busy_retry_count\":    value \u003d\u003e $xtremio_array_busy_retry_count;"},{"line_number":101,"context_line":"    \"${name}/xtremio_array_busy_retry_interval\": value \u003d\u003e $xtremio_array_busy_retry_interval;"},{"line_number":102,"context_line":"    \"${name}/xtremio_volumes_per_glance_cache\":  value \u003d\u003e $xtremio_volumes_per_glance_cache;"},{"line_number":103,"context_line":"    \"${name}/xtremio_ports\":                     value \u003d\u003e $xtremio_ports;"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"891409ae_b77595ca","line":103,"range":{"start_line":103,"start_character":59,"end_line":103,"end_character":72},"in_reply_to":"02b2686f_a1bc2b5b","updated":"2021-02-18 12:48:50.000000000","message":"I wanted this to look similar to other Dell EMC manifests.","commit_id":"2e889e3dd326ede6383a2e25a1c607b9de7aa141"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de0a34d438788a47217fc1955a28cf5a3594bb31","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    \"${name}/xtremio_array_busy_retry_count\":    value \u003d\u003e $xtremio_array_busy_retry_count;"},{"line_number":101,"context_line":"    \"${name}/xtremio_array_busy_retry_interval\": value \u003d\u003e $xtremio_array_busy_retry_interval;"},{"line_number":102,"context_line":"    \"${name}/xtremio_volumes_per_glance_cache\":  value \u003d\u003e $xtremio_volumes_per_glance_cache;"},{"line_number":103,"context_line":"    \"${name}/xtremio_ports\":                     value \u003d\u003e $xtremio_ports;"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fc91a832_82f9d1e7","line":103,"range":{"start_line":103,"start_character":59,"end_line":103,"end_character":72},"in_reply_to":"891409ae_b77595ca","updated":"2021-02-18 13:07:22.000000000","message":"The implementation I proposed uses the raw value if a string like \u0027192.168.0.1\u0027 or \u0027192.168.0.1,192.168.0.2\u0027 is passed while it converts a array value like [\u0027192.168.0.1\u0027, \u0027192.168.0.2\u0027] to a string like \u0027192.168.0.1,192.168.0.2\u0027.\nSo it is still compatible with the existing implementation but accepts more flexible definition by array. \n\nI see that we don\u0027t have this implementation in many other drivers so maybe we can leave it now. However I still think this is a valid improvement and something worth implementing later.","commit_id":"2e889e3dd326ede6383a2e25a1c607b9de7aa141"}]}