)]}'
{"id":"openstack%2Fpuppet-cinder~787532","triplet_id":"openstack%2Fpuppet-cinder~master~I86a4e6e14f39a5bdb70d5443764f946b3f26130e","project":"openstack/puppet-cinder","branch":"master","topic":"hpelefthand","hashtags":[],"change_id":"I86a4e6e14f39a5bdb70d5443764f946b3f26130e","subject":"Remove support for HPE Lefthand driver","status":"MERGED","created":"2021-04-22 11:14:12.000000000","updated":"2021-04-23 18:39:58.000000000","submitted":"2021-04-23 18:38:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"787532-hpelefthand","meta_rev_id":"ceaa25141a34e31028d94f11b9c1a6e496de13d6","_number":787532,"virtual_id_number":787532,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-23 18:38:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"all":[{"value":2,"date":"2021-04-22 15:23:50.000000000","_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":2,"date":"2021-04-23 13:48:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":1,"date":"2021-04-23 13:48:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-22 14:59:19.000000000","updated_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"reviewer":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"state":"CC"},{"updated":"2021-04-22 15:23:50.000000000","updated_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"reviewer":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"state":"REVIEWER"},{"updated":"2021-04-22 17:42:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-23 13:48:16.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"}],"messages":[{"id":"13fb9be8e6223f3447657b6e31dc10b14a25e0a9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-04-22 11:14:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"965844a781713520688ec11d798e12cb549fa8c9","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-04-22 11:16:37.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"6b51eb6d4a56eeccc76f2e47d2dcb45cab978063","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-04-22 14:59:19.000000000","message":"Patch Set 1:\n\nThis patch lgtm, so I\u0027m not sure why you abandoned it. The driver was removed from cinder back in ussuri by Ibdd79282777b705c04b33073112f7280f45c2b2f","accounts_in_message":[],"_revision_number":1},{"id":"a93c14652356f4f7bb9d73a41cc718a45ff8464d","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-04-22 15:01:06.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e This patch lgtm, so I\u0027m not sure why you abandoned it. The driver was removed from cinder back in ussuri by Ibdd79282777b705c04b33073112f7280f45c2b2f\n\nThat is because I decided to clean up multiple drivers in a single commit rather than making multiple small commits.\n https://review.opendev.org/c/openstack/puppet-cinder/+/787534\n\nNote that above change doesn\u0027t clean up deprecated dell emc drivers since these are still used by tripleo.","accounts_in_message":[],"_revision_number":1},{"id":"14ca0e58c86a6fcc2f0534b1ac4492d67f691b8b","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-04-22 15:08:23.000000000","message":"Patch Set 1:\n\nOK, that\u0027s reasonable, as long as the drivers that were removed from cinder aren\u0027t likely to return in a later release (which often happens in cinder, when the vendor decides they want to resume support for their driver). If it\u0027s unclear whether a driver might possibly return, then it would be better to isolate the corresponding puppet-XXX patches related to that driver. This would make it easier to revert the puppet patch(es) should the driver be restored in cinder.","accounts_in_message":[],"_revision_number":1},{"id":"46d819976cebdeb29b85b3c8f2732ef3f88f4c3e","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-04-22 15:10:56.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e OK, that\u0027s reasonable, as long as the drivers that were removed from cinder aren\u0027t likely to return in a later release (which often happens in cinder, when the vendor decides they want to resume support for their driver). If it\u0027s unclear whether a driver might possibly return, then it would be better to isolate the corresponding puppet-XXX patches related to that driver. This would make it easier to revert the puppet patch(es) should the driver be restored in cinder.\n\nThank you for your thoughts. That\u0027s a fair point. Let me restore this and make separate commits.","accounts_in_message":[],"_revision_number":1},{"id":"39db7df7a47356b8f75ae47c45e4b6f8310cf4d7","tag":"autogenerated:gerrit:restore","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-04-22 15:11:00.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"173b9df117db2c5095f439d0a6fe3ea60b60d880","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-04-22 15:23:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6936dd925e9718925b08341fa1d0558496704df4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-22 17:42:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ea10b8eb682047d7a804ffebf147356e : SUCCESS in 4m 28s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f07b06471b5a43aeaf4ff1e6fd5574e2 : SUCCESS in 4m 34s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/a6e1af53b2ba490cb97836ffb46b5640 : SUCCESS in 12m 29s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/902628c0e4fc48af8773c33713f0b1b5 : SUCCESS in 11m 00s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/64936611e451478db97fab4cab3164c2 : SUCCESS in 9m 30s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f1b641339f4742c7916a31c621208a42 : FAILURE in 15m 40s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b917f8c09f7346d2a7203ce833e47074 : SUCCESS in 52m 52s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c601d3b2b9994c9cb1b621911860a42e : FAILURE in 28m 31s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c814cf049a96456c8e4678c0f69825ef : SUCCESS in 40m 39s (non-voting)\n- puppet-openstack-integration-6-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/e4db94102d654ba28ba49f31fff6e85a : SUCCESS in 20m 57s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/0e9d99dcc3e14cf187f5a18685ecbf68 : SUCCESS in 1h 13m 00s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/f6d959467ee145ed9868b9367f575ebd : SUCCESS in 1h 20m 54s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/780c2031f18c4a70bdc4cb2771025d12 : SUCCESS in 1h 26m 07s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/eda1865b253e49f7afe7fc1fde9ce97d : SUCCESS in 56m 18s\n- puppet-openstack-litmus-centos-8-stream https://zuul.opendev.org/t/openstack/build/3a3f62ad50fb4fc7b6e522e3bd3d87de : SUCCESS in 24m 25s\n- puppet-openstack-litmus-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a370b08facdf446ebefe1893942227e0 : SUCCESS in 19m 02s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/709c19bf78cc4e9a8ffd2c67f038fb31 : SUCCESS in 4m 29s\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/215127fcc8254929a3a85392d3c0a538 : SUCCESS in 2h 22m 37s","accounts_in_message":[],"_revision_number":1},{"id":"9290bcdde9ed4d00d8555b6ab14a40038ac9d2bf","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-04-23 13:48:16.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"adb69d6b7bc00823eb1ff14477ade8d5b42944a0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-23 13:48:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0fd2745720e5f17827f0252ca6a924bb28abcecc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-23 16:16:23.000000000","message":"Patch Set 1:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c43c6e8755354126cc8c7612811d4ff1868d881e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-23 18:38:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7ce4b77441294c95b7eadaba4517f2f0 : SUCCESS in 3m 49s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/624e129c54a744c9bf23cbe00f238c09 : SUCCESS in 3m 45s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/c7eb5d6b262246fcbd212ae779387222 : SUCCESS in 11m 58s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6e4864ce0f044ab290456b29552750ab : SUCCESS in 12m 10s\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/6f6aaf51755a47b0938691919b79c812 : SUCCESS in 52m 36s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/a8974260648e43c39a04540adfce0f74 : SUCCESS in 1h 14m 59s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/dd748c24454a4dd3b7c2155947d3c8b7 : SUCCESS in 1h 19m 48s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/7c84226419e042cea105708720c9dd96 : SUCCESS in 1h 01m 48s\n- puppet-openstack-litmus-centos-8-stream https://zuul.opendev.org/t/openstack/build/d3e029a6368b4438806e55f68dd8e918 : SUCCESS in 19m 04s\n- puppet-openstack-litmus-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d038bbc0b72048e783a6b1e8d8909a90 : SUCCESS in 15m 49s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4a547cfc891e409b87a2551449759e52 : SUCCESS in 6m 25s\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/1e9bafb1d74b4256a0d20c7169cf8fb4 : SUCCESS in 2h 18m 59s","accounts_in_message":[],"_revision_number":1},{"id":"1846fd240713b38a45fc90126741ec5f2a67d5f8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-23 18:38:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ceaa25141a34e31028d94f11b9c1a6e496de13d6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-23 18:39:58.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ce94161e346046b181e03aad57007d50 : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"51ef949abf7fcdb71b9c9f4ccc92a079f8732938","revisions":{"51ef949abf7fcdb71b9c9f4ccc92a079f8732938":{"kind":"REWORK","_number":1,"created":"2021-04-22 11:14:12.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/32/787532/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/32/787532/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/32/787532/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/32/787532/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/32/787532/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/32/787532/1"}}},"commit":{"parents":[{"commit":"a56906687eeb0a6d9cf1f6ab92f43673650e70b8","subject":"Merge \"Remove the deprecated keymgr_* parameters of cinder::api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/a56906687eeb0a6d9cf1f6ab92f43673650e70b8"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-04-22 11:13:15.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-04-22 11:13:57.000000000","tz":540},"subject":"Remove support for HPE Lefthand driver","message":"Remove support for HPE Lefthand driver\n\n... because it was deprecated during the previous cycle[1], and\nthe driver implementation has been removed from cinder.\n\n[1] c5927c42afa8f73bcd7890a28446c1308901cfbc\n\nChange-Id: I86a4e6e14f39a5bdb70d5443764f946b3f26130e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/51ef949abf7fcdb71b9c9f4ccc92a079f8732938"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/51ef949abf7fcdb71b9c9f4ccc92a079f8732938"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}