)]}'
{"manifests/backends.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"27003728bf69f94c7f2a21a08088cbe8396b40e2","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  include cinder::deps"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  $backend_host_real \u003d pick($::cinder::backend_host, $backend_host)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  if $enabled_backends \u003d\u003d undef {"},{"line_number":28,"context_line":"    warning(\"Configurations that are setting backend config in ``[DEFAULT]`` \\"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"00fb37d6_a621aa03","line":25,"updated":"2021-05-03 13:20:12.000000000","message":"I\u0027m not sure, but you may have swapped one problem for another. I understand the issue you\u0027re trying to resolve is the old code is relying on hiera, and it won\u0027t work if cinder::backend_host is defined in a manifest file.\n\nBut if I remember correctly, I tried a pick() but found this found was not working if cinder::backend_host *is* defined using hiera.\n\nDo we need a 3-way pick to ensure cinder::backend_host is selected if it\u0027s set in either a manifest or via hiera?","commit_id":"63d43e4ed5c52979bdcc58c2f3bdbe8e6a11f5c9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90a8cf1839812710425770bb697423646b98e573","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  include cinder::deps"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  $backend_host_real \u003d pick($::cinder::backend_host, $backend_host)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  if $enabled_backends \u003d\u003d undef {"},{"line_number":28,"context_line":"    warning(\"Configurations that are setting backend config in ``[DEFAULT]`` \\"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"37ccfb23_616def22","line":25,"in_reply_to":"00fb37d6_a621aa03","updated":"2021-05-03 14:09:32.000000000","message":"Hmm... That is strange and the pick function is supposed to work even if hieradata is used. \n\nIn fact in tripleo standalone job cinder::backend_host is defined as part of hieradata\n https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0f8/789087/3/check/puppet-cinder-tripleo-standalone/0f85340/logs/undercloud/etc/puppet/hieradata/service_configs.json\n\nbut it is applied in cinder.conf as expected.\n https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0f8/789087/3/check/puppet-cinder-tripleo-standalone/0f85340/logs/undercloud/var/lib/config-data/puppet-generated/cinder/etc/cinder/cinder.conf","commit_id":"63d43e4ed5c52979bdcc58c2f3bdbe8e6a11f5c9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f58b7855425bbad20d7ceaec22e607918dbdde5d","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  include cinder::deps"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  $backend_host_real \u003d pick($::cinder::backend_host, $backend_host)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  if $enabled_backends \u003d\u003d undef {"},{"line_number":28,"context_line":"    warning(\"Configurations that are setting backend config in ``[DEFAULT]`` \\"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7f74f1e5_28f88542","line":25,"in_reply_to":"37ccfb23_616def22","updated":"2021-05-03 14:59:18.000000000","message":"Hmm, you\u0027re right! Maybe my memory is faulty, or I misinterpreted the results of the tests I performed when I last worked on this. I agree the results indicate this patch functions correctly.","commit_id":"63d43e4ed5c52979bdcc58c2f3bdbe8e6a11f5c9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"71f7ef94a2f11c153acd08ed8f5f162a46dc7550","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  include cinder::deps"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  if pick($::cinder::backend_host, false) {"},{"line_number":26,"context_line":"    $backend_host_real \u003d pick($::cinder::backend_host)"},{"line_number":27,"context_line":"  } else {"},{"line_number":28,"context_line":"    $backend_host_real \u003d $backend_host"},{"line_number":29,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"142a2ed8_d836a94e","line":26,"updated":"2021-05-05 19:58:30.000000000","message":"Is this pick() necessary? Maybe to handle both situations where the value is defined (hiera or manifest)?","commit_id":"971b0ba3945f5ca044323ee150708b031a06186a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7054c1c5294041578555d480cc81081d208d3d8c","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  include cinder::deps"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  if pick($::cinder::backend_host, false) {"},{"line_number":26,"context_line":"    $backend_host_real \u003d pick($::cinder::backend_host)"},{"line_number":27,"context_line":"  } else {"},{"line_number":28,"context_line":"    $backend_host_real \u003d $backend_host"},{"line_number":29,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7c7c0a62_c993f173","line":26,"in_reply_to":"142a2ed8_d836a94e","updated":"2021-05-05 23:21:18.000000000","message":"You are right and we don\u0027t need pick here since we have already confirmed that the parameter exists.\nOne change this is making is that we refer the parameter not directly from hiera but from class, thus it is required to have the cinder class before the cinder::backends class even if we use hiera.\n\nI have updated the patch a bit to re-introduce enforcement about class order. This doesn\u0027t break tripleo (unless there is something unexpected).","commit_id":"971b0ba3945f5ca044323ee150708b031a06186a"}],"manifests/init.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"71f7ef94a2f11c153acd08ed8f5f162a46dc7550","unresolved":true,"context_lines":[{"line_number":471,"context_line":"  }"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"  if $backend_host !\u003d undef {"},{"line_number":474,"context_line":"    warning(\u0027The backend_host parameter has no effect unless cinder::backends is included later\u0027)"},{"line_number":475,"context_line":"  }"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"  # V3 APIs"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"c755be93_fe2aebca","line":474,"updated":"2021-05-05 19:58:30.000000000","message":"The logs (I\u0027m looking at the puppet-cinder-tripleo-standalone job) don\u0027t make it clear that \"The backend_host parameter\" referred to in this warning message is cinder::backend_host, which is handled quite differently than the similarly named cinder::backends::backend_host parameter.\n\nI think the warning message will be clearer if it specifically mentions cinder::backend_host.","commit_id":"971b0ba3945f5ca044323ee150708b031a06186a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7054c1c5294041578555d480cc81081d208d3d8c","unresolved":true,"context_lines":[{"line_number":471,"context_line":"  }"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"  if $backend_host !\u003d undef {"},{"line_number":474,"context_line":"    warning(\u0027The backend_host parameter has no effect unless cinder::backends is included later\u0027)"},{"line_number":475,"context_line":"  }"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"  # V3 APIs"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1474ec06_89ce9a53","line":474,"in_reply_to":"c755be93_fe2aebca","updated":"2021-05-05 23:21:18.000000000","message":"That\u0027s very fair point. I have updated the message accordingly.","commit_id":"971b0ba3945f5ca044323ee150708b031a06186a"}]}