)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"61dd47175bedd0374043e94adcb52f8084ab87d3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Deprecate the redundant cinder::backend_host parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The cinder::backend_host parameter is not used in the cinder class"},{"line_number":10,"context_line":"itselfu but is used to only override the cinder::backends::backend_host"},{"line_number":11,"context_line":"parameter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ife5f8bdcfd4e982b7ffa5532b2a23d48c65d501f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b206a529_1be61eee","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"updated":"2021-05-03 13:19:31.000000000","message":"nit: typo","commit_id":"cfa892523f1a4cf23cb72d40215dd4969e3422ea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"658842f25ee7cedd1a614f2f60fad06d784009ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate the redundant cinder::backend_host parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The cinder::backend_host parameter is not used in the cinder class"},{"line_number":10,"context_line":"itselfu but is used to only override the cinder::backends::backend_host"},{"line_number":11,"context_line":"parameter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ife5f8bdcfd4e982b7ffa5532b2a23d48c65d501f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"cad0c41c_39d5ffbd","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":7},"in_reply_to":"b206a529_1be61eee","updated":"2021-05-03 14:13:56.000000000","message":"Done. Thank you for the catch !","commit_id":"cfa892523f1a4cf23cb72d40215dd4969e3422ea"}],"manifests/backends.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6dcf32c1c7300995404e3fe936007f7eeb01448e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  } else {"},{"line_number":28,"context_line":"    $backend_host_real \u003d $backend_host"},{"line_number":29,"context_line":"    if ! $backend_host_real {"},{"line_number":30,"context_line":"      warning(\u0027Using a false value for backend_host is deprecated. \\"},{"line_number":31,"context_line":"Use $::os_service_default instead\u0027)"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"95efbe29_978a4982","line":30,"updated":"2021-05-05 20:11:00.000000000","message":"What\u0027s the purpose of this message? I\u0027m not familiar with setting backend_host to false, unless it\u0027s somehow associated with the legacy code in cinder::backend::rbd [1].\n\n[1] https://opendev.org/openstack/puppet-cinder/src/branch/master/manifests/backend/rbd.pp#L134","commit_id":"2799f7619339cb627bdc3ccc0c4378d40958ad51"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a40d7b682174efd51f452e4f7441ed8ea0b7090b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  } else {"},{"line_number":28,"context_line":"    $backend_host_real \u003d $backend_host"},{"line_number":29,"context_line":"    if ! $backend_host_real {"},{"line_number":30,"context_line":"      warning(\u0027Using a false value for backend_host is deprecated. \\"},{"line_number":31,"context_line":"Use $::os_service_default instead\u0027)"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ef588f18_2fd89aa8","line":30,"in_reply_to":"75949614_8f10455c","updated":"2021-05-06 03:24:21.000000000","message":"I\u0027m not familiar with the pattern of setting a parameter False to indicate it should be unmanaged, but your explanation makes sense.","commit_id":"2799f7619339cb627bdc3ccc0c4378d40958ad51"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c55ffd16697183bceb3c4b4725672a875b2eb8fb","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  } else {"},{"line_number":28,"context_line":"    $backend_host_real \u003d $backend_host"},{"line_number":29,"context_line":"    if ! $backend_host_real {"},{"line_number":30,"context_line":"      warning(\u0027Using a false value for backend_host is deprecated. \\"},{"line_number":31,"context_line":"Use $::os_service_default instead\u0027)"},{"line_number":32,"context_line":"    }"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"75949614_8f10455c","line":30,"in_reply_to":"95efbe29_978a4982","updated":"2021-05-05 23:42:35.000000000","message":"The reason why I mentioned \"a false value\" is that we haven\u0027t enforce its type but just checked whether it is true/false.\nThis is not very expected usage but it is still valid to set backend_host \u003d\u003e false to make the parameter unmanaged.\n\nSince the aim is to update the default and then get rid of the if statement in L44 we want to ensure ANY value which results in unmanaging the parameter is replaced by $::os_service_default","commit_id":"2799f7619339cb627bdc3ccc0c4378d40958ad51"}],"manifests/init.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6dcf32c1c7300995404e3fe936007f7eeb01448e","unresolved":true,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"  if $backend_host !\u003d undef {"},{"line_number":471,"context_line":"    warning(\u0027The backend_host parameter has no effect unless cinder::backends is included later\u0027)"},{"line_number":472,"context_line":"    warning(\u0027The backend_host parameter is deprecated. \\"},{"line_number":473,"context_line":"Use the cinder::backends::backend_host parameter instead\u0027)"},{"line_number":474,"context_line":"  }"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7188d539_f1054ea7","line":472,"updated":"2021-05-05 20:11:00.000000000","message":"As I noted in the other review, this is another instance where it will be clearer if the message states it\u0027s referring to cinder::backend_host. Hopefully that will avoid confusion because the similarly named cinder::backends::backend_host is *not* deprecated.","commit_id":"2799f7619339cb627bdc3ccc0c4378d40958ad51"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c55ffd16697183bceb3c4b4725672a875b2eb8fb","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"  if $backend_host !\u003d undef {"},{"line_number":471,"context_line":"    warning(\u0027The backend_host parameter has no effect unless cinder::backends is included later\u0027)"},{"line_number":472,"context_line":"    warning(\u0027The backend_host parameter is deprecated. \\"},{"line_number":473,"context_line":"Use the cinder::backends::backend_host parameter instead\u0027)"},{"line_number":474,"context_line":"  }"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"9f29086a_14a9d550","line":472,"in_reply_to":"7188d539_f1054ea7","updated":"2021-05-05 23:42:35.000000000","message":"Done","commit_id":"2799f7619339cb627bdc3ccc0c4378d40958ad51"}]}