)]}'
{"id":"openstack%2Fpuppet-cinder~799753","triplet_id":"openstack%2Fpuppet-cinder~master~Ib622c1a04e3e40db4f37fc6bbc57ee91d7f9dd88","project":"openstack/puppet-cinder","branch":"master","hashtags":[],"change_id":"Ib622c1a04e3e40db4f37fc6bbc57ee91d7f9dd88","subject":"Restore support for enable_v2_api","status":"ABANDONED","created":"2021-07-07 08:18:38.000000000","updated":"2021-08-18 14:16:36.000000000","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"2a70590ca2c3dcf3f1435ff2207586b9152eb253","_number":799753,"virtual_id_number":799753,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-07-07 10:17:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2021-07-07 20:01:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":-1,"date":"2021-07-08 09:38:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-07 10:17:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-07 13:37:11.000000000","updated_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"reviewer":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"state":"CC"},{"updated":"2021-07-07 20:01:40.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2021-07-07 20:13:27.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"CC"}],"messages":[{"id":"7e537a8b05dcde0b67d6926c1dbcdb590677b5b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-07-07 08:18:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f36713707b4e31ef1253b3986841bf3a1d8b2721","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-07-07 08:26:05.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2a84cd641e94e2f56ec8e63e115e02ef1cb368aa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-07 10:17:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9a3540b601fd48279acc30b72d245ec6 : SUCCESS in 4m 19s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/573aedd6962349d1b71508254aca9f3a : SUCCESS in 4m 11s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b7d345484f744ecfa502eed942d43e8a : SUCCESS in 4m 01s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/1d50f4e2d81a4f77bbbfe14830df0f86 : SUCCESS in 13m 47s\n- puppet-openstack-unit-7.5-centos-8-stream https://zuul.opendev.org/t/openstack/build/c6ae54f072234b3692c9ab86f6bc2eaa : SUCCESS in 14m 22s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5ef234762c5b4da2814b45e174650794 : SUCCESS in 10m 25s\n- puppet-openstack-unit-7.5-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5eb444a53f594e2d8ab17725aa1ff7d2 : SUCCESS in 10m 39s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7002be8cfebf4d2bbc73a9c4f79ac2c6 : SUCCESS in 11m 08s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/11340d218c3042faabd06bfe54061b97 : FAILURE in 37m 20s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/99fa0f46118f4854bd2327c885f2ba16 : FAILURE in 44m 08s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/dc057f6cf9044b6a83c0c7dcc0502622 : FAILURE in 33m 08s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/33a2ec7b17a64b449add875628f0cfc0 : FAILURE in 26m 54s (non-voting)\n- puppet-openstack-integration-6-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/dfaf95a78c384e27b8cc714a9e67a992 : SUCCESS in 25m 39s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/b8d24b139b1149238e503157a219de43 : SUCCESS in 1h 18m 29s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/cc76555eb6304285a49bab61df531e09 : SUCCESS in 1h 49m 12s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/252d9559663047199c25d439718126e1 : SUCCESS in 1h 36m 57s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/4a3fe83355b2480fbfde6cb128bdc6c1 : SUCCESS in 1h 12m 48s\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/088162bb7cf5443d8d03d771cde24e2c : SUCCESS in 24m 35s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/4eb461d20e764896bccd2bdf91aba6ce : SUCCESS in 1h 28m 00s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/ecb3da26e892486ab33c206486d72606 : SUCCESS in 1h 30m 23s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/73d2bfd868c0491c92f97635c63497d2 : SUCCESS in 1h 31m 26s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/b22979c1729343e9b629e75b9e9e868b : SUCCESS in 1h 05m 22s\n- puppet-openstack-litmus-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/88ee7950008040f3af4f6516325c8c9a : SUCCESS in 21m 28s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b5acf0bb7f7340e187b2a4c6176c9b6f : FAILURE in 14m 25s (non-voting)\n- puppet-openstack-litmus-7.5-centos-8-stream https://zuul.opendev.org/t/openstack/build/b6e434119f8c4c11a2fac8aacb9608da : SUCCESS in 21m 24s\n- puppet-openstack-litmus-7.5-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ab4cd38558554983a5b901057424e951 : FAILURE in 13m 53s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/bc3432313fe7405583f40a3795683daa : FAILURE in 14m 42s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2331a714d55342aeb72496d5dc8bc0b3 : SUCCESS in 5m 18s\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/edddd9e45c7345158ac2163b7ee8962d : SUCCESS in 1h 55m 08s","accounts_in_message":[],"_revision_number":1},{"id":"96fcfa7075c1cf6f0341752234d16ef6716499b2","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-07-07 13:37:11.000000000","message":"Patch Set 1:\n\nThe cinder community is pretty dedicated to removing API v2 in Xena [1]. I suggest holding this for now, and reconsider later in the cycle in case cinder doesn\u0027t complete the work.\n\n[1] https://review.opendev.org/q/topic:%22drop-v2%22+(status:open%20OR%20status:merged)","accounts_in_message":[],"_revision_number":1},{"id":"3d389cbde2a78965f33da34be051812ff329db6c","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-07-07 20:01:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"98f10564b28929b69f423cd7e23e7e0ae1f92a5f","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-07-07 20:13:27.000000000","message":"Patch Set 1:\n\nI agree with Alan.","accounts_in_message":[],"_revision_number":1},{"id":"6a28cff4fc777f588a90ee99f5495b4400fc52a5","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-07-07 20:23:00.000000000","message":"Patch Set 1:\n\nthere\u0027s not really any harm in leaving this if it was supported in W as we used to try and make sure that modules were at least N-1 compatible to assist with upgrades. But i\u0027d be ok with not landing this if the cinder folks don\u0027t want it","accounts_in_message":[],"_revision_number":1},{"id":"35c78ce1f4bc826b206b02b42b019220963fa20d","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-07-08 09:38:35.000000000","message":"Patch Set 1: Workflow-1\n\nAdding WIP to avoid merging this before we come to clear agreement.\n\nA question would be what is \"recommended\" configuration from cinder\u0027s perspective. TBH it shows a bit confusing warning about the parameter\n\n- Without enable_v2_api setting to False, cinder shows deprecation warning that it should be disabled[1]. \n\n- On the other hand, if enable_v2_api set to to False, cinder shows a different deprecation warning that the parameter is deprecated and should not be used.\n\n[1] https://github.com/openstack/cinder/blob/a7e98dba5b0bc84a2642952b66962d2e645c64f3/cinder/api/__init__.py#L38-L40\n\n\nIf unsetting enable_v2_api is recommended in master and older releases, then I\u0027ll abandon this.\n\nIf enable_v2_api\u003dFalse is recommended then IMO we need this parameter implemented. I understand v2 API is likely to be removed soon but we can\u0027t directly implement this in stable branches. We should merge this first in master, backport to older branches and deprecated the parameter in master. That\u0027s why I started implementing this parameter in master first.\n\nTBH the current implementation in cinder to show warning for both cases is a bit \"faulty\" but that\u0027s not what we should(or can) fix nowadays.","accounts_in_message":[],"_revision_number":1},{"id":"6f6e9d08d030bd2defe210a6041009fa0eed92a0","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-07-08 17:53:51.000000000","message":"Patch Set 1:\n\nCinder\u0027s history is definitely convoluted. The v2 API was originally deprecated back in pike, and the deprecation warning about leaving the v2 api enabled was added in queens. Also strange is the \"enable_v2_api\" option defaults to True. Unfortunately all of this leads to an unfortunately situation:\n\n- If you don\u0027t override enable_v2_api then you get a deprecation warning for the v2 API being enabled\n- But if you set enable_v2_api \u003d False then you get a different warning for setting a deprecated option\n\nAlso, note the puppet-cinder code removed support for setting enable_v2_api back in queens [1]\n\n[1] https://review.opendev.org/c/openstack/puppet-cinder/+/541587\n\nWith this in mind I don\u0027t see the value in backporting anything to a stable branch, especially if we\u0027re reintroducing a parameter that was removed from puppet-cinder six cycles ago. Clearly there\u0027s been no harm in leaving the v2 API enabled in cinder, and it\u0027s probably just not been used in any recent deployments. Also bear in mind that allowing cinder to support the v2 API doesn\u0027t necessarily mean there\u0027s a keystone service and endpoint associated with v2.\n\nMy inclination is to leave things alone, and live with cinder\u0027s deprecation warning until cinder actually removes the v2 code.","accounts_in_message":[],"_revision_number":1},{"id":"2a70590ca2c3dcf3f1435ff2207586b9152eb253","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-18 14:16:36.000000000","message":"Abandoned\n\nv2 api was removed. Adding this parameter doesn\u0027t get rid of all warnings so it\u0027s not very much useful to have this parameter in older releases.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a04f8ad5c0d014bd208449bb372fc5039a8163de","revisions":{"a04f8ad5c0d014bd208449bb372fc5039a8163de":{"kind":"REWORK","_number":1,"created":"2021-07-07 08:18:38.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/53/799753/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/53/799753/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/799753/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/799753/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/53/799753/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/53/799753/1"}}},"commit":{"parents":[{"commit":"e42724cc89493685934e9f99ef5f2061866b4280","subject":"Merge \"Add support for [cors] options\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/e42724cc89493685934e9f99ef5f2061866b4280"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-07-07 08:15:46.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-07-07 08:17:51.000000000","tz":540},"subject":"Restore support for enable_v2_api","message":"Restore support for enable_v2_api\n\nThe enable_v2_api parameter was deprecated a while ago but the default\ndefined in cinder is still `True` which means v2 api is still enabled\nin cinder-api.\n\nThis change re-introduces the enable_v2_api parameter so that users\ncan set enable_v2_api\u003dFalse to disable v2 api support in cinder-api.\n\nChange-Id: Ib622c1a04e3e40db4f37fc6bbc57ee91d7f9dd88\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/a04f8ad5c0d014bd208449bb372fc5039a8163de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/a04f8ad5c0d014bd208449bb372fc5039a8163de"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}