)]}'
{"id":"openstack%2Fpuppet-cinder~806333","triplet_id":"openstack%2Fpuppet-cinder~master~I97d14585ebb28166c95755169df0ea5433adb3e8","project":"openstack/puppet-cinder","branch":"master","topic":"bug/1941860","hashtags":[],"change_id":"I97d14585ebb28166c95755169df0ea5433adb3e8","subject":"Fix the default of cinder::api::ratelimits_factory","status":"MERGED","created":"2021-08-27 09:07:24.000000000","updated":"2021-09-03 03:09:31.000000000","submitted":"2021-09-03 03:09:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"806333-bug/1941860","meta_rev_id":"ddc0d34b0ce413d29e35f3fbbe982a6e3d1df4c2","_number":806333,"virtual_id_number":806333,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-03 03:09:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"all":[{"value":2,"date":"2021-09-02 15:16:53.000000000","_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":2,"date":"2021-09-02 15:00:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"all":[{"value":1,"date":"2021-09-02 15:16:53.000000000","_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-27 11:25:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-28 19:40:33.000000000","updated_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"reviewer":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"state":"REVIEWER"},{"updated":"2021-09-02 15:00:48.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"}],"messages":[{"id":"9b03d4d62f44659b6e44f5a20a904ab46cde700e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-27 09:07:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"072bf983fb3ba7ebf704e6ecb85a2084f97f743f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-27 09:09:42.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"727666defadb1e470b845c67b85ca8d9d72238ed","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-27 11:25:40.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0ee06dc5342c4b1fbdf745b982678c82 : SUCCESS in 4m 37s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/73875e759bf2434dba96b433fda8cca2 : SUCCESS in 5m 44s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/04e0c2a72b044babba3629fc32fd0703 : SUCCESS in 3m 52s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/a6a09f3d28d648059eebe061b5b06f45 : FAILURE in 17m 27s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/fd830e8812964437bc1ccaef5fc91425 : FAILURE in 18m 04s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/15bd949da74149589af78655912d3999 : FAILURE in 14m 16s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/542f6bc9282c41d7a4ea9b144f48915c : FAILURE in 16m 07s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e51ed522a9924f6ebf078e50fc43943b : FAILURE in 18m 01s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a14c241ffe884de6a2ded37476d42351 : SUCCESS in 1h 07m 46s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8bdfb1bd93c44232a5dd9af226eaebb0 : SUCCESS in 50m 18s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/558f0f9b657f409d8d6a39e686cfdefe : FAILURE in 33m 14s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1efa5ecf064047408fc6ecafe7edb44e : SUCCESS in 51m 53s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/4d46ea0a70f6431bb2a3aea551ad3faf : FAILURE in 31m 45s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/be8f1ffa7cb449728cc5ab864623ae8f : SUCCESS in 1h 31m 26s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/a98cebd5090247ad83b8228e54a0ca1a : FAILURE in 18m 46s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/2e1a6f4301384ff8a98fe21756f7161b : FAILURE in 17m 38s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/aeafe689e3194d309df577a3b86372a1 : SUCCESS in 1h 16m 26s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/23509888e2a64755a045b4d52ffd17cb : FAILURE in 14m 26s (non-voting)\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/fb28fd478f8543f2a5c8644c9da61ccf : FAILURE in 17m 00s\n- puppet-openstack-litmus-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/63e142a7e54147fbba7a316ef35f30cf : SUCCESS in 18m 35s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/30012a7cb3a548d193aac38d0f645e55 : SUCCESS in 16m 34s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/6099fe17c8934f9cba33a69b4e33d1f0 : SUCCESS in 2h 09m 55s","accounts_in_message":[],"_revision_number":2},{"id":"0ec400f36546bb0a1404cbd456748ad4f244a97e","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-27 11:33:05.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"067fe2b3dd29dccf2dbd418edb1f89389debc0e9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-27 13:45:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5f269a1e898d4b769b03b0eec90c6ee4 : SUCCESS in 6m 12s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9f2d161d157f4972a0e0f352e07b6ec8 : SUCCESS in 3m 56s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0c75a40bd6aa4352a644ad66bbbb8a81 : SUCCESS in 5m 35s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/dc5f3e70e1564979af4388465d47ea26 : SUCCESS in 18m 50s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/5f93b41853c446958bcf5694aa6ca6a4 : SUCCESS in 15m 56s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a2d7c5c29e85400a80b7d7ee0fc6ac5f : SUCCESS in 18m 18s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c4bf7cbccf704527bc538c8d7dfc5ef4 : SUCCESS in 13m 10s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/731a2a9d0fda4f71a9d6d9c283cb97de : SUCCESS in 14m 31s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7ab7667694b1404ab0ac7c4f465ecc77 : SUCCESS in 53m 43s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e91f1a2acba04f2b9251ef36efaed0fb : SUCCESS in 55m 09s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/dba76582134448f391ab08cdafd6e916 : FAILURE in 34m 23s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2aba720bd1f24fc98b98860699e0a6e3 : SUCCESS in 1h 08m 24s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/22f847ecfd6246b7be0ead3579e31d4d : SUCCESS in 32m 10s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/d64297b5c870455ca96456008c8545a7 : SUCCESS in 1h 11m 02s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/bb049b78ba9240f6becad98158b5c448 : SUCCESS in 1h 30m 34s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/08dfd3ea251d4565ac4456d30daca8a7 : SUCCESS in 1h 09m 47s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/8a5a370e0f2a4a0e8656e49edb4249a0 : SUCCESS in 1h 09m 28s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/54c2ab42938e4caf838d805ca17f9a82 : SUCCESS in 16m 40s (non-voting)\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/d555ca6755a94c4f80db719a31fd3652 : SUCCESS in 24m 02s\n- puppet-openstack-litmus-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c79f39fbde61465faf40f5992a91abb8 : SUCCESS in 20m 13s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/cee0d7847636407f825c18f2046d73e1 : SUCCESS in 16m 40s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/cea235a524504bb9ad56de72af9574a3 : SUCCESS in 2h 06m 28s","accounts_in_message":[],"_revision_number":2},{"id":"7382b72848b1bc1302206332d5997638d5246a53","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-28 01:30:24.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"eeec61320c4d2c177b0ed6e315109ecaf754e5a2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-28 03:25:45.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e8cc837c46e648d3994fc3971d375891 : SUCCESS in 4m 00s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b02231856c304a27a8d12cde7e437d2b : SUCCESS in 5m 08s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5d5edbb4e25f4381a62b0b59da665024 : SUCCESS in 3m 53s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/ba6632bf381149ed9a4de3f496923392 : SUCCESS in 14m 46s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/5afc1fe50bd5459a80b2366d659643cd : SUCCESS in 14m 04s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5e78ec81de4e4f2b890453864073e40c : SUCCESS in 12m 34s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ac49c8d710ed464fbb3351cdde18772c : SUCCESS in 10m 45s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8fe71e97484f46b080cac48c5ea02ca9 : SUCCESS in 12m 46s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/98c7d314887144f684c75e2d70f8176c : SUCCESS in 55m 28s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/cd9f67397ffc49f9a99889eaeb6c241a : SUCCESS in 58m 53s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/56f4e822f9c54e3bbbb7ba6462fde65d : FAILURE in 30m 51s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/558fe5dbe0564a42a4b5e810915b6bda : SUCCESS in 36m 30s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/c8dc0b1ad28f4e13bb631db56c887c4b : SUCCESS in 23m 25s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/f54d748659ce491390338742be15d49b : SUCCESS in 1h 17m 08s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/9d72a8c28e524dc3966f0076337e538b : SUCCESS in 1h 31m 15s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/63d75e159b724321adb1b15920033a6c : SUCCESS in 1h 07m 00s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/6454459072774ebcb5622274e4164e0e : SUCCESS in 55m 35s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8853e32896584a1cafcafa3d57f8e997 : SUCCESS in 14m 53s (non-voting)\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/34e8959fedac4713aeefc7f8fb84ae3d : SUCCESS in 23m 04s\n- puppet-openstack-litmus-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/145d0598b9e44614bcdd15721e0ab8e8 : SUCCESS in 20m 58s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/23e37484fcc54657a277dbd926f65719 : SUCCESS in 17m 03s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f3a11204f56947298eafde907c303643 : SUCCESS in 4m 35s\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/380793ff0b1c4196a90601c1367f11d0 : SUCCESS in 1h 52m 12s","accounts_in_message":[],"_revision_number":3},{"id":"e420c577bcd7fe9b126e8d8813d9e65096fc65ff","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-08-28 19:40:33.000000000","message":"Patch Set 3: Code-Review+1\n\nThe code changes certainly look fine, but I\u0027m not familiar with RateLimitingMiddleware and so I\u0027m curious to learn why it was available for API v1 and v2, but not v3.","accounts_in_message":[],"_revision_number":3},{"id":"2484b6c01df3c0005c9b8937ba15d4b7f624cc21","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-28 23:35:47.000000000","message":"Patch Set 3:\n\nI\u0027m not able to explain the actual decision behind this unfortunately... but looking at the old, old git logs I found nova first removed that when API micro versions were added.\n https://review.opendev.org/c/openstack/nova/+/115893\n\nSo my guess is cinder folks followed the same decision when they started implementing v3 API which has been supporting micro versions from the beginning.","accounts_in_message":[],"_revision_number":3},{"id":"cdddd97df672bb832e4db17594fcc22df1488215","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-08-31 19:00:30.000000000","message":"Patch Set 3: Code-Review-1\n\nIt\u0027s true that cinder has no RateLimitingMiddleware in its api/v3/limits.py. However, I\u0027ve gone over the history of that file, and it still relies on the api/v2/limits.py content. From what I can tell, much of the content is actually unrelated to the API version, especially the RateLimitingMiddleware portion. And the api/v2/limits.py still exists in the tree, even with the actual API v2 code removed.\n\nDigging further, much of the rate limiting seems to date back to the early days (2012-2013), and I have no idea if anyone uses the feature these days (tripleo doesn\u0027t configure it). But before we deprecate support in puppet, the feature would need to be deprecated in cinder. And from what I can see, it\u0027s OK to use the RateLimitingMiddleware in api/v2/limits.py, even for the API v3.\n\nThe one problem I _do_ see with the puppet code is it defaults ratelimits_factory to \u0027cinder.api.v1.limits:RateLimitingMiddleware.factory\u0027, which definitely won\u0027t work because the api/v1/limits.py file was removed a long time ago.\n\nI suspect nobody is really using the rate limiting feature. I think we can go two ways with this:\n\n1. Abandon this patch, and ask the cinder community if they really want to deprecate rate limiting (if they do, then maybe confirm the intent is to continue using the RateLimitingMiddleware in api/v2/limits.py).\n\n2. Submit a different patch (or reuse this one) to update the ratelimits_factory default value to use the v2 factory, \u0027cinder.api.v2.limits:RateLimitingMiddleware.factory\u0027","accounts_in_message":[],"_revision_number":3},{"id":"3183eb4c154f185b9bb58e8e7c0a13bd893fa4a9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-31 23:46:15.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d6e1feab8bc915b7d3064d72d66c0e8749c1e4a8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-31 23:47:45.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"442574c9f18bed3ceafdb0c63e829d9c485da481","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-08-31 23:53:08.000000000","message":"Patch Set 5:\n\nHi Alan,\n\nThank you for your nice insight as always. I was confused with my observation for two projects about the same topic. It\u0027s true that the implementation is still left in cinder. As long as the implementation is left, we should not deprecated the parameter, so I\u0027ve updated this change to only fix the wrong default.\n\nIMHO the middleware is not really popular. It is not enabled in pipeline by default nowadays, nova dropped the same implementation, So it would make sense to deprecate the middleware from cinder as well. I\u0027ll look into that when I have time ( in case you are interested, please feel free to take it over :-) ).","accounts_in_message":[],"_revision_number":5},{"id":"fb7d784a3308caaf1528c28b084525ef2bcef0e7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-01 01:41:19.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3b556288608f48338a31069c1d1757cf : SUCCESS in 4m 35s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/af4dc2b2051e470ba6ca033f9eb052fc : SUCCESS in 5m 06s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fa4616aa422e4dd5bea32ae2a2da50da : SUCCESS in 4m 45s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/c96567d67db74a4cb560b4751c9afaf4 : SUCCESS in 15m 23s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/528a66b815164f548fc2981e2ac53397 : SUCCESS in 14m 30s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/467e81b0d6e9414abb1bf7b6a6de2788 : SUCCESS in 12m 01s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7c5cbf7691524d1888bccd7b06afcae2 : SUCCESS in 11m 01s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/af7f84a097694087a2d9edc61aaa26e1 : SUCCESS in 11m 21s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/21ce96edb2f54bebb48172876637e628 : SUCCESS in 55m 46s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ffd9a8bd020743488ea7e2e96b6b9ba2 : SUCCESS in 52m 04s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d7080f75c6db4a2e8d1c70632b1ff512 : FAILURE in 29m 06s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c996c0eee7644a35856c2f65b4ee0075 : SUCCESS in 38m 25s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/248114db3124437eb03bc34fbb917c9b : SUCCESS in 23m 38s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/c9ee97007ebf4a64a214bdf7f1a2d23c : SUCCESS in 1h 34m 34s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/d67ba28fb1b94c0bae74c5fcde693144 : SUCCESS in 1h 29m 56s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/0ab1dbca2e18446fadaaa639b6fd86b7 : SUCCESS in 1h 09m 01s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/b8fd130df8b84f0dbf60dfc7aa572fe5 : SUCCESS in 1h 04m 10s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/64fafd3436854256ab7a7f8b72ebf516 : SUCCESS in 15m 33s (non-voting)\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/578cc05c838142b19d30d354c237d1e6 : SUCCESS in 20m 49s\n- puppet-openstack-litmus-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3da19912180349058096450058f0d94d : SUCCESS in 14m 56s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e0ad0e2a07e048eaadf0e48703b6cc11 : SUCCESS in 14m 16s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/67d0974913284e48992261d12a6697d5 : SUCCESS in 1h 51m 39s","accounts_in_message":[],"_revision_number":5},{"id":"ddcdc6adf57fad3ce92eee9c8494662b824b76ad","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-09-02 15:00:48.000000000","message":"Patch Set 5: Code-Review+2\n\nAgree that nobody is probably using it, but until it\u0027s removed from Cinder it makes sense to not have anything broken by default.","accounts_in_message":[],"_revision_number":5},{"id":"f41116768359a486f7bd618cf32f355ed0a8d68d","author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"date":"2021-09-02 15:16:53.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nYeah, this is a good fix. The cinder community is pretty overloaded (especially at the moment, with xena-m3 looming), so I don\u0027t expect cinder will have bandwidth to consider deprecating support for this in their code any time soon.","accounts_in_message":[],"_revision_number":5},{"id":"478ab895d17ef3d64fbe10f5fcb5888b38050019","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 15:18:52.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"f16f61a9ec6af1daf4a077d330e9da5582c7141b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 17:45:31.000000000","message":"Patch Set 5: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/02f0ab389b55470a9271e7113f88be86 : SUCCESS in 4m 51s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3ab4d0cd2fdf4908b421e388d8ee5fac : SUCCESS in 4m 03s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/05d0918c7b774b9e97171e2d3b41a045 : SUCCESS in 4m 48s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/26455a05232a4104bc2fd2f8638ad93a : SUCCESS in 16m 32s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/f11d39082cae457980292f93bc8bad76 : SUCCESS in 17m 26s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/45d42d47519840bb9e3f672e50fe4d0d : SUCCESS in 13m 32s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/62a102159cbb49c6919a9c00ca7f59b8 : SUCCESS in 15m 01s\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/4994bf914525435b9689a3654793f9d2 : SUCCESS in 1h 14m 16s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/37190f0ba2b9441992a537aff895df61 : SUCCESS in 1h 22m 36s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/8a5116409e2648a28d9a1d67539e3d76 : FAILURE in 1h 38m 11s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/c807ebf770964b77a38c120c5fa8c7f0 : SUCCESS in 1h 05m 04s\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/f1f0db735bf742839f727db406b98854 : SUCCESS in 25m 39s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/930cb60afb9441499ff5ba95fcaddf0a : SUCCESS in 15m 18s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/35f3e45966de467aa55cddddb5b8a62d : SUCCESS in 2h 21m 13s","accounts_in_message":[],"_revision_number":5},{"id":"51307a3970136cb7da7d954280fa8cddbbeb66c5","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-09-02 23:07:49.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"85d7c30c569268d59312c4228771bd6f980c57de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-03 00:56:48.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0f11427a264e4810b08406d82bbedcc6 : SUCCESS in 4m 21s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/928b9d4d5c914c4f94c55632696b6d60 : SUCCESS in 3m 55s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f333796637c9416d964305287f7fb3ed : SUCCESS in 4m 25s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/be644b13c2204f078904c955da07149a : SUCCESS in 16m 01s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/d6e04a80f7fe40fca6c557a7c9810199 : SUCCESS in 16m 00s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/634e26bc2b954a7fa3e6b1ac0fa3ba0a : SUCCESS in 11m 17s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/54e0cae6092c4a69929b1eb343e974ac : SUCCESS in 16m 01s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/38dc888cc06e41b092799b982e900e92 : SUCCESS in 11m 55s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/82a819e380a64b028568403c27edbb38 : SUCCESS in 48m 32s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8b5e8d9a80a245b287527cd61301303e : SUCCESS in 52m 20s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/45b426555af34ba288e378f372b1532a : FAILURE in 31m 10s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2af518a6de594995ba5766194ce07fe4 : SUCCESS in 41m 02s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/8b06e6368b0a4a55858f40c1c2f3d2a0 : SUCCESS in 25m 46s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/33bd1be21fe549b09e1ad3b05f74c39a : SUCCESS in 1h 07m 13s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/a686acb22e3d4907854df9a8e9418676 : SUCCESS in 1h 16m 14s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/ac22946cd8c346a7a5b013437de96de4 : SUCCESS in 1h 11m 12s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/36f2b15e75da46b79fd20b8b6d021189 : SUCCESS in 55m 14s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/dcfc638cee374974b0ad4aa798fb3922 : SUCCESS in 14m 45s (non-voting)\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/95085b2f85bf4908acae253685ad6b40 : SUCCESS in 22m 34s\n- puppet-openstack-litmus-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/25ae563da8b5407fb14f0fc255d67592 : SUCCESS in 17m 37s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7d208f0f65e94ec7893dc556b433b7e5 : SUCCESS in 15m 54s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/0f83cd3c74a04af1a2573f5d8d8fb262 : SUCCESS in 1h 46m 00s","accounts_in_message":[],"_revision_number":5},{"id":"29d28d19bc3cd4675b190e5fda6ccad982340a03","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-03 00:57:55.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"fff1cd38cb21ddfa549e4571f053ac4a2d93430e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-03 03:09:30.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/223518362de44741954cb477cdb53268 : SUCCESS in 4m 03s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/19e8c2d03c1147c4b1e573850a25dd6e : SUCCESS in 4m 00s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1f9ec23379b8414b804b7f68d69fed42 : SUCCESS in 4m 06s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/97cb6ce27c7e4d11bef669473f1752a0 : SUCCESS in 13m 43s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/923edfa2a6dd4eb99ccb3f78554d15d1 : SUCCESS in 13m 48s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/44683e7d8e944189bef0aa8f7e4f69ff : SUCCESS in 10m 15s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/73560043df6b41f5a96870d6fece1ceb : SUCCESS in 11m 01s\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/143405a439a243ed83982bfd07615c7d : SUCCESS in 1h 20m 22s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/9696e691cfc84735947c23348aae1323 : SUCCESS in 1h 24m 07s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/2c5390bf71f6475ca9bcc931b907ccca : SUCCESS in 1h 16m 29s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/246692efa13a4a10a8829a3e9a62bf05 : SUCCESS in 57m 08s\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/7e620e8abbaa46d3b8383f72d71a8c68 : SUCCESS in 20m 59s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c233520cfd96424799b7819356787517 : SUCCESS in 30m 04s (non-voting)\n- puppet-cinder-tripleo-standalone https://zuul.opendev.org/t/openstack/build/36fbb42a8e3d424ebd4d93371f9dbe13 : SUCCESS in 2h 05m 50s","accounts_in_message":[],"_revision_number":5},{"id":"ddc0d34b0ce413d29e35f3fbbe982a6e3d1df4c2","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-03 03:09:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"3111f64dd222a71c5039a8b6a8d18296f5beef1d","revisions":{"93a9433566c107951016b6a8ae9f5a229f1a81ee":{"kind":"REWORK","_number":1,"created":"2021-08-27 09:07:24.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/33/806333/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/33/806333/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/1"}}},"commit":{"parents":[{"commit":"d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d","subject":"Merge \"Support Puppet 7\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-27 09:05:27.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-27 09:07:07.000000000","tz":540},"subject":"Deprecate parameters for RateLimitingMiddleware","message":"Deprecate parameters for RateLimitingMiddleware\n\nRateLimitingMiddleware was available for only v1/v2 API and is not\nprovided for v3 API. Since v1 API and v2 API were both removed let\u0027s\ndeprecated the parameter for the middleware currently unavailable.\n\nCloses-Bug: #1941860\nChange-Id: I97d14585ebb28166c95755169df0ea5433adb3e8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/93a9433566c107951016b6a8ae9f5a229f1a81ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/93a9433566c107951016b6a8ae9f5a229f1a81ee"}]},"branch":"refs/heads/master"},"10586547f3441f4f9cde33b1da5eb033e1b6ab62":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-08-27 09:09:42.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/33/806333/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/33/806333/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/2"}}},"commit":{"parents":[{"commit":"d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d","subject":"Merge \"Support Puppet 7\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-27 09:05:27.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-27 09:08:57.000000000","tz":540},"subject":"Deprecate parameters for RateLimitingMiddleware","message":"Deprecate parameters for RateLimitingMiddleware\n\nRateLimitingMiddleware was available for only v1/v2 API and is not\nprovided for v3 API. Because both v1 API and v2 API have been removed,\nthis change deprecates the parameters for the middleware.\n\nCloses-Bug: #1941860\nChange-Id: I97d14585ebb28166c95755169df0ea5433adb3e8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/10586547f3441f4f9cde33b1da5eb033e1b6ab62"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/10586547f3441f4f9cde33b1da5eb033e1b6ab62"}]},"branch":"refs/heads/master"},"c0f44245a9dcc6d82bc800270d3f6b6f2e48ddd0":{"kind":"REWORK","_number":3,"created":"2021-08-28 01:30:24.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/33/806333/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/33/806333/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/3"}}},"commit":{"parents":[{"commit":"d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d","subject":"Merge \"Support Puppet 7\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-27 09:05:27.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-28 01:30:15.000000000","tz":540},"subject":"Deprecate parameters for RateLimitingMiddleware","message":"Deprecate parameters for RateLimitingMiddleware\n\nRateLimitingMiddleware was available for only v1/v2 API and is not\nprovided for v3 API. Because both v1 API and v2 API have been removed,\nthis change deprecates the parameters for the middleware.\n\nCloses-Bug: #1941860\nChange-Id: I97d14585ebb28166c95755169df0ea5433adb3e8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/c0f44245a9dcc6d82bc800270d3f6b6f2e48ddd0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/c0f44245a9dcc6d82bc800270d3f6b6f2e48ddd0"}]},"branch":"refs/heads/master"},"8345ca89b6b85a3faed4b0c5f9d91913d171a713":{"kind":"REWORK","_number":4,"created":"2021-08-31 23:46:15.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/33/806333/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/33/806333/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/4"}}},"commit":{"parents":[{"commit":"d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d","subject":"Merge \"Support Puppet 7\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-31 23:42:56.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-31 23:42:56.000000000","tz":540},"subject":"Fix the default of cinder::api::ratelimits_factory","message":"Fix the default of cinder::api::ratelimits_factory\n\nThe cinder::api class introduces RateLimitingMiddleware when\nthe ratelimits parameter is true. However current default of\nratelimits_factory still points to v1 API code which was already\nremoved.\nThis change ensures that it points to v2 API code which still exists.\n\nCloses-Bug: #1941860\nChange-Id: I97d14585ebb28166c95755169df0ea5433adb3e8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/8345ca89b6b85a3faed4b0c5f9d91913d171a713"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/8345ca89b6b85a3faed4b0c5f9d91913d171a713"}]},"branch":"refs/heads/master"},"3111f64dd222a71c5039a8b6a8d18296f5beef1d":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2021-08-31 23:47:45.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/33/806333/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cinder","ref":"refs/changes/33/806333/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cinder refs/changes/33/806333/5"}}},"commit":{"parents":[{"commit":"d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d","subject":"Merge \"Support Puppet 7\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/d0c1bfd14e26617c2066ea99063fa4ce1f5a0f9d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-31 23:42:56.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-08-31 23:46:35.000000000","tz":540},"subject":"Fix the default of cinder::api::ratelimits_factory","message":"Fix the default of cinder::api::ratelimits_factory\n\nThe cinder::api class introduces RateLimitingMiddleware when\nthe ratelimits parameter is true. However the current default of\nratelimits_factory still points to v1 API code which was already\nremoved, and this results in an invalid definition.\n\nThis change ensures that it points to v2 API code which still exists.\n\nCloses-Bug: #1941860\nChange-Id: I97d14585ebb28166c95755169df0ea5433adb3e8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/3111f64dd222a71c5039a8b6a8d18296f5beef1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cinder/commit/3111f64dd222a71c5039a8b6a8d18296f5beef1d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}