)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"28e381953a80e9f2455f85a86d2fbc34b14b5b81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05296a32_4a0879af","updated":"2021-12-02 14:48:17.000000000","message":"Cinder needs to provide the service default","commit_id":"904ff8cee905bd061d2a84a85d132d644cc00289"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5f906535ef5b7df7716d5c5c285f3aaf7bce009f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47087977_8136b394","updated":"2021-12-02 14:57:34.000000000","message":"Clearly this issue affects a number of services, and it would be good to identify a generic solution. For example, I found neutron uses its service name [1], which seems like a clever approach.\n\nAnd if \"openstack\" is too generic, then be aware that manila needs to be fixed [2].\n\n[1] https://opendev.org/openstack/puppet-neutron/src/branch/master/manifests/init.pp#L351\n[2] https://opendev.org/openstack/puppet-manila/src/branch/master/manifests/init.pp#L228","commit_id":"904ff8cee905bd061d2a84a85d132d644cc00289"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"aceab552b82e8de9a2644ebf0b455ee2e6a06ac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b916b0ff_6a89c7ae","updated":"2021-12-02 15:34:53.000000000","message":"Yes, thanks Alan, I will submit a patch for cinder to catch up with bp scope-config-opts and to address bug 1953050","commit_id":"904ff8cee905bd061d2a84a85d132d644cc00289"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0a1c4ec87193d7fa7344980006753a93b78aaa7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fa4266d_8e6fc668","in_reply_to":"99fc2f49_9732cdf3","updated":"2021-12-02 16:32:02.000000000","message":"makes sense","commit_id":"904ff8cee905bd061d2a84a85d132d644cc00289"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f59497faae8600c637c3b26a778a6136cf27ba66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99fc2f49_9732cdf3","in_reply_to":"b916b0ff_6a89c7ae","updated":"2021-12-02 15:50:56.000000000","message":"It may take extra work to push a change through cinder. Would it work if puppet-cinder were to switch the setting from \"openstack\" to \"cinder\" (just like puppet-neutron does)?","commit_id":"904ff8cee905bd061d2a84a85d132d644cc00289"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"e4c8ced08ae398aa8b864e1a58a36ef3d6843dde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"20df35af_44fae2ec","updated":"2021-12-08 14:06:26.000000000","message":"IMO the correct thing here is to warn about it being set to service default in next release, it\u0027s up to deployment to continue setting it to something else one release after.","commit_id":"5273be1180bb858b13b0a8c1a7680bc9706329c9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"50f3efdb719a56bba92d4cb6ba2857ed4fd8db7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da6bbcb4_0ae66d7b","updated":"2021-12-08 10:21:37.000000000","message":"Not sure about upgrade impact. Perhaps updating this parameter should happen consistently, otherwise two sides of RPC wouldn\u0027t be able to communicate, until restarted with a new config? Also, it might affect custom ha-policies set by operators for rabbitmq, expecting \u0027openstack\u0027 and not \u0027cinder\u0027. Given that said, I look forward for the experts\u0027 feedback on that and how to move this forward (including the related changes needed in cinder).\n\nMeanwhile, the status quo remains as that - one cannot use amqp durable queues with such control_exchange defaults, and the feature remains (and will remain) effectively blocked for years.","commit_id":"5273be1180bb858b13b0a8c1a7680bc9706329c9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5ab9762f7dc30eda3b2f66ec3bca88d7e72f38e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"56dc1530_73765d07","updated":"2021-12-08 14:07:12.000000000","message":"Or really, just setting it to os_service_default and it\u0027s up to the deployments (or TripleO etc) to set it to something else. It shouldn\u0027t be opinionated more than that.","commit_id":"5273be1180bb858b13b0a8c1a7680bc9706329c9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6fb6992b508d80f89fc740917bf26dc55f871bd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d723568_43a9195d","updated":"2021-12-08 09:06:13.000000000","message":"PTAL","commit_id":"5273be1180bb858b13b0a8c1a7680bc9706329c9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"91bb544271ec22b7e6503429fc404ed1527aa66f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4fe105cd_fc970caa","updated":"2021-12-03 00:33:44.000000000","message":"The situation with puppet-neutron is different. Neutron already overrides the default  control_exchange by neutron and current default in puppet-neutron is just re-defining the same\n(I\u0027m now removing that redundant default by https://review.opendev.org/c/openstack/puppet-neutron/+/820279 )\n\nBasically we keep puppet modules as transparent as possible and avoid implementing our own thing. I tend to use service default instead, to prepare for any future change in cinder/manila side instead of hardcoding our own defaults.","commit_id":"5273be1180bb858b13b0a8c1a7680bc9706329c9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c4f39acd2c22370825ed9340e30e0bc30c846177","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"757dd28b_3145caec","updated":"2021-12-03 12:30:40.000000000","message":"agreed. I put fixme to address that once we have the service default in the main code","commit_id":"5273be1180bb858b13b0a8c1a7680bc9706329c9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aef444e10cbd42751eadc5e2aed95310bd7551b9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f757f0dc_ceb80a1a","in_reply_to":"757dd28b_3145caec","updated":"2021-12-06 14:43:48.000000000","message":"IMO, we should avoid defining our own default and basically rely on the default in services. I agree it doesn\u0027t make sense to define redundant \u0027openstack\u0027 but IMO we should use $::os_service_default, until we hear feedback to your proposals to cinder/manila.\n\nAlso, updating control_exchange requires some caution. For example updating this parameter should happen consistently otherwise some services can\u0027t communicate each other. Also, it might affect ha-policy in rabbitmq. That\u0027s another reason I hesitate to go with this change now.","commit_id":"5273be1180bb858b13b0a8c1a7680bc9706329c9"}]}