)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d40c150663a4f4781927679c1fea766f5331582e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0dd9454_320e0e21","updated":"2022-03-04 07:43:02.000000000","message":"recheck","commit_id":"7f8f98d6adba6697f70148dfc8bf2bef2c3bb1dd"}],"manifests/backends.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"76e6ce8632b0736cc8f6d691d2a3202ff62593fc","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      \u0027DEFAULT/enabled_backends\u0027: value \u003d\u003e join($enabled_backends, \u0027,\u0027);"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    $enabled_backends.each |$backend| {"},{"line_number":36,"context_line":"      # Avoid colliding with code in backend/rbd.pp"},{"line_number":37,"context_line":"      unless defined(Cinder_config[\"${backend}/backend_host\"]) {"},{"line_number":38,"context_line":"        cinder_config {"},{"line_number":39,"context_line":"          \"${backend}/backend_host\": value \u003d\u003e $backend_host;"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"      }"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"db83d213_29d16d11","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":60},"updated":"2022-03-04 14:52:32.000000000","message":"Should this entire block be conditional on $backend_host being any value other than $::os_service_default? Or is it OK to configure each ${backend}/backend_host with $::os_service_default?","commit_id":"7f8f98d6adba6697f70148dfc8bf2bef2c3bb1dd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"db97cdabf3ea9deb075914669ddf674cca2bc7af","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      \u0027DEFAULT/enabled_backends\u0027: value \u003d\u003e join($enabled_backends, \u0027,\u0027);"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    $enabled_backends.each |$backend| {"},{"line_number":36,"context_line":"      # Avoid colliding with code in backend/rbd.pp"},{"line_number":37,"context_line":"      unless defined(Cinder_config[\"${backend}/backend_host\"]) {"},{"line_number":38,"context_line":"        cinder_config {"},{"line_number":39,"context_line":"          \"${backend}/backend_host\": value \u003d\u003e $backend_host;"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"      }"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"b51d539f_578a5c4b","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":60},"in_reply_to":"64e39530_d3a4a280","updated":"2022-04-18 15:24:31.000000000","message":"Ack","commit_id":"7f8f98d6adba6697f70148dfc8bf2bef2c3bb1dd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"689dcea3252707c5ab861dfe031d5f5b3f50abd0","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      \u0027DEFAULT/enabled_backends\u0027: value \u003d\u003e join($enabled_backends, \u0027,\u0027);"},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    $enabled_backends.each |$backend| {"},{"line_number":36,"context_line":"      # Avoid colliding with code in backend/rbd.pp"},{"line_number":37,"context_line":"      unless defined(Cinder_config[\"${backend}/backend_host\"]) {"},{"line_number":38,"context_line":"        cinder_config {"},{"line_number":39,"context_line":"          \"${backend}/backend_host\": value \u003d\u003e $backend_host;"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"      }"},{"line_number":42,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"64e39530_d3a4a280","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":60},"in_reply_to":"db83d213_29d16d11","updated":"2022-04-18 13:01:51.000000000","message":"$::os_service_default is preferred option to ensure the value is removed. The current implementation can leave unmanaged values in cinder.conf if the parameter is removed from manifest after initial deployment.","commit_id":"7f8f98d6adba6697f70148dfc8bf2bef2c3bb1dd"}]}