)]}'
{"manifests/api.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"46155b43345f76a7fc50d247d424f634dea1428f","unresolved":true,"context_lines":[{"line_number":113,"context_line":"#   requests. For example, boot-from-volume."},{"line_number":114,"context_line":"#   Defaults to undef"},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"# [*validate*]"},{"line_number":117,"context_line":"#   (optional) Whether to validate the service is working after any service"},{"line_number":118,"context_line":"#   refreshes"},{"line_number":119,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d501bddb_c4d27fea","side":"PARENT","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":12},"updated":"2022-05-03 15:02:38.000000000","message":"This one was deprecated in yoga, so that makes it a candidate for deletion now that we\u0027re in zed. Unless you want to leave this for another cycle, you could include its removal in this patch. For that matter, there are deprecated parameters in other files that seem to be ready for removal. I\u0027m not sure we need separate patches for each one, so would it be cleaner to do a general cleanup patch?","commit_id":"40028359ce95a655cf0ea92932d2e336d05bd73e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1f865f9e44f583bfa27b16ef7b3da1df676e85b9","unresolved":true,"context_lines":[{"line_number":113,"context_line":"#   requests. For example, boot-from-volume."},{"line_number":114,"context_line":"#   Defaults to undef"},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"# [*validate*]"},{"line_number":117,"context_line":"#   (optional) Whether to validate the service is working after any service"},{"line_number":118,"context_line":"#   refreshes"},{"line_number":119,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6e65283d_671fd69f","side":"PARENT","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":12},"in_reply_to":"82a826e6_d73fb419","updated":"2022-05-18 14:40:32.000000000","message":"This is as much of a style issue than a technical one, so I\u0027m OK with letting the patch author(s) take the lead on how they want to manage the patches. In other words, I\u0027m OK with handling the removal of the \u0027validate\u0027 parameter separately.","commit_id":"40028359ce95a655cf0ea92932d2e336d05bd73e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f2d5dceeac7c0402809d14e5c68e966e90929fc1","unresolved":true,"context_lines":[{"line_number":113,"context_line":"#   requests. For example, boot-from-volume."},{"line_number":114,"context_line":"#   Defaults to undef"},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"# [*validate*]"},{"line_number":117,"context_line":"#   (optional) Whether to validate the service is working after any service"},{"line_number":118,"context_line":"#   refreshes"},{"line_number":119,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"82a826e6_d73fb419","side":"PARENT","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":12},"in_reply_to":"d501bddb_c4d27fea","updated":"2022-05-18 00:24:19.000000000","message":"I\u0027ll remove the validate parameter as well but this is a global change(I mean, we removed validation in the other modules as well) so am thinking of creating a separate commit with the common topic name .\n\nI personally prefer removing set of the parameters, which were deprecated in a single commit, because that would help us look up and revert a change.\n\nHowever this is not quite technical one so if that strategy sounds redundant then I can go with a single cleanup commit instead.","commit_id":"40028359ce95a655cf0ea92932d2e336d05bd73e"}]}