)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4e4993188b3bf8490475fddd42f9b89c89414761","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-14 16:06:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable use_multipath_for_image_xfer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces a new Class cinder::backend::defaults, that"},{"line_number":10,"context_line":"provides a way to enable use_multipath_for_image_xfer for all cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"712c2163_4597e809","line":7,"updated":"2022-06-15 17:24:35.000000000","message":"Two things: First, that setting isn\u0027t actually enabled unless you override the puppet parameter (it\u0027s $::os_service_default).\n\nBut I think a better subject line would focus on the new ability to configure backend_defaults. In my mind, that is the \"big feature,\" and using it to configure use_multipath_for_image_xfer is just the initial use case.","commit_id":"c16aeb222eafade6339812f61d178054383a607d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"69d3f312374d07924476b0a862e750e01ca9913e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-14 16:06:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable use_multipath_for_image_xfer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces a new Class cinder::backend::defaults, that"},{"line_number":10,"context_line":"provides a way to enable use_multipath_for_image_xfer for all cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f45ae643_e4e803f6","line":7,"in_reply_to":"712c2163_4597e809","updated":"2022-06-16 05:03:19.000000000","message":"+1 for both good points.","commit_id":"c16aeb222eafade6339812f61d178054383a607d"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"99149925959bbd930f326c66de3551e9f39f8b26","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     katarimanoj \u003cmkatari@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-14 16:06:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable use_multipath_for_image_xfer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces a new Class cinder::backend::defaults, that"},{"line_number":10,"context_line":"provides a way to enable use_multipath_for_image_xfer for all cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1b45ae33_742cdeba","line":7,"in_reply_to":"f45ae643_e4e803f6","updated":"2022-06-16 09:58:58.000000000","message":"Done!","commit_id":"c16aeb222eafade6339812f61d178054383a607d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a55a1a15546066192e524ac8e7d4eb1496cd5cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"228fad2e_0be7b965","updated":"2022-06-14 01:06:15.000000000","message":"Just leaving a few additional nodes. It\u0027d be nice if you can address these.\n\n- A release note should be added to explain the new class.\n- We might want to implement support for enforce_multipath_for_image_xfer as well.","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4e4993188b3bf8490475fddd42f9b89c89414761","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e46d825e_0e740634","in_reply_to":"228fad2e_0be7b965","updated":"2022-06-15 17:24:35.000000000","message":"enforce_multipath_for_image_xfer is an odd one, and cinder people typically recommend it *not* be enabled. Nova may choose to use it in its os-brick connections, but mainly to ensure there\u0027s no data loss if a vm\u0027s only volume connection goes down. With cinder, the connections tend to be ephemeral (only used when downloading an image), so having only a single connection is OK.","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"69d3f312374d07924476b0a862e750e01ca9913e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa90e51a_d3429647","in_reply_to":"e46d825e_0e740634","updated":"2022-06-16 05:03:19.000000000","message":"I agree with your observation. Let\u0027s leave it now.","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a8617eb577993cb508ab4c7dbb8921808bdc533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"14a03a9b_b53b3e07","updated":"2022-06-14 02:01:21.000000000","message":"Leaving -1 to highlight my previous comment. Also, there are a few formatting problems which should be addressed.","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cac76f641abfe05d67849e2de85ffb2a1e9d604f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a76f075d_7237bb98","updated":"2022-06-14 01:46:43.000000000","message":"Thanks Takashi for your comments!","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cf345458b3eb7ee253d2bb502c178c8258a8c4ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d295f427_2d869a17","updated":"2022-06-14 10:32:23.000000000","message":"Thanks Takashi, i have addressed your comments.\nI would like to keep this patch in WIP to check if any other parameters can be enabled.","commit_id":"0a23f8d516058c0cfe443de93f86c7e780a9787c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"69d3f312374d07924476b0a862e750e01ca9913e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dfb6bc7d_9c24e55b","in_reply_to":"00f2cdc5_047a0411","updated":"2022-06-16 05:03:19.000000000","message":"Yeah I agree. The idea behind my previous proposal is to implement the all parameters related to multipath, but I agree with you 2nd comment and we can start with this minimum implementation, which provides the most popular parameter.","commit_id":"0a23f8d516058c0cfe443de93f86c7e780a9787c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4e4993188b3bf8490475fddd42f9b89c89414761","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"00f2cdc5_047a0411","in_reply_to":"d295f427_2d869a17","updated":"2022-06-15 17:24:35.000000000","message":"I looked over [1] in cinder, and there are certainly lots of parameters to choose from. However, it would not make sense to try and implement them all, and many are extremely obscure or unique to specific backends.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/opts.py#L313\n\nThe use_multipath_for_image_xfer config is the only one that I believe is \"most requested,\" so I\u0027m fine with this initial implementation.","commit_id":"0a23f8d516058c0cfe443de93f86c7e780a9787c"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8f809d4adeaac6409501948732501d73e4a80593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f940820d_ab75e33c","updated":"2022-06-16 13:51:35.000000000","message":"Right now, tripleo ci is causing problems for a lot of patches, but code lgtm.","commit_id":"3a9a21fc0938f5c5a7afb99cecf407c7754c2b90"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d5cec6b3da746aacfc10ebedd57b8172a1bda0fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"93311a66_ebbd6855","updated":"2022-06-17 05:02:25.000000000","message":"recheck\n\nlet me recheck the job once again to see the issue with tripleo job is consistent or not.","commit_id":"3a9a21fc0938f5c5a7afb99cecf407c7754c2b90"}],"manifests/backend/defaults.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a8617eb577993cb508ab4c7dbb8921808bdc533","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Cinder backend defaults"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"# [*use_multipath_for_image_xfer*]"},{"line_number":7,"context_line":"#   (Optional) Whether to use multipath during create-volume-from-image and"},{"line_number":8,"context_line":"#   copy-volume-to-image operations."},{"line_number":9,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ee1a8b1d_4b470792","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":34},"updated":"2022-06-14 02:01:21.000000000","message":"please insert one line after the head\n\n# \u003d\u003d\u003d Parameters\n#\n# [*use_multipath_for_image_xfer*]","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cf345458b3eb7ee253d2bb502c178c8258a8c4ea","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Cinder backend defaults"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"# [*use_multipath_for_image_xfer*]"},{"line_number":7,"context_line":"#   (Optional) Whether to use multipath during create-volume-from-image and"},{"line_number":8,"context_line":"#   copy-volume-to-image operations."},{"line_number":9,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bae5118a_aabf3eb6","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":34},"in_reply_to":"ee1a8b1d_4b470792","updated":"2022-06-14 10:32:23.000000000","message":"Done","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a8617eb577993cb508ab4c7dbb8921808bdc533","unresolved":true,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class cinder::backend::defaults ("},{"line_number":12,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  cinder_config {"},{"line_number":15,"context_line":"    \u0027backend_defaults/use_multipath_for_image_xfer\u0027:  value \u003d\u003e $use_multipath_for_image_xfer;"},{"line_number":16,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8cc6e7eb_e2ae6deb","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":3},"updated":"2022-06-14 02:01:21.000000000","message":"Please include cinder::deps to enforce resource ordering.","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cf345458b3eb7ee253d2bb502c178c8258a8c4ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class cinder::backend::defaults ("},{"line_number":12,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  cinder_config {"},{"line_number":15,"context_line":"    \u0027backend_defaults/use_multipath_for_image_xfer\u0027:  value \u003d\u003e $use_multipath_for_image_xfer;"},{"line_number":16,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"83a09f74_e2bbd22b","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":3},"in_reply_to":"8cc6e7eb_e2ae6deb","updated":"2022-06-14 10:32:23.000000000","message":"Done","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a8617eb577993cb508ab4c7dbb8921808bdc533","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  cinder_config {"},{"line_number":15,"context_line":"    \u0027backend_defaults/use_multipath_for_image_xfer\u0027:  value \u003d\u003e $use_multipath_for_image_xfer;"},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"033c7a0b_e25c328c","line":15,"range":{"start_line":15,"start_character":53,"end_line":15,"end_character":54},"updated":"2022-06-14 02:01:21.000000000","message":"one space can be removed.","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cf345458b3eb7ee253d2bb502c178c8258a8c4ea","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  cinder_config {"},{"line_number":15,"context_line":"    \u0027backend_defaults/use_multipath_for_image_xfer\u0027:  value \u003d\u003e $use_multipath_for_image_xfer;"},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"133fcef8_44d82313","line":15,"range":{"start_line":15,"start_character":53,"end_line":15,"end_character":54},"in_reply_to":"033c7a0b_e25c328c","updated":"2022-06-14 10:32:23.000000000","message":"Done","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4e4993188b3bf8490475fddd42f9b89c89414761","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class cinder::backend::defaults ("},{"line_number":13,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  include cinder::deps"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ed9c91a3_614c53a3","line":14,"updated":"2022-06-15 17:24:35.000000000","message":"I think it would be nice addition if this class supported an $extra_options parameter, similar to some (many? maybe all) backends. See [1] for an example. This would create a nice hook that would let you assign any arbitrary backend_default setting by defining it using cinder::backend::defaults::extra_options.\n\n[1] https://opendev.org/openstack/puppet-cinder/src/branch/master/manifests/backend/rbd.pp#L104","commit_id":"c16aeb222eafade6339812f61d178054383a607d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"8f809d4adeaac6409501948732501d73e4a80593","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class cinder::backend::defaults ("},{"line_number":13,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  include cinder::deps"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"0305e5f5_797330cb","line":14,"in_reply_to":"0da20f67_c0ce03f5","updated":"2022-06-16 13:51:35.000000000","message":"Good point, Takashi! While it would really only add a single line of actual code, there\u0027s no reason to add something that basically duplicates an existing feature. I agree that cinder::config::cinder_config is adequate.","commit_id":"c16aeb222eafade6339812f61d178054383a607d"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"99149925959bbd930f326c66de3551e9f39f8b26","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class cinder::backend::defaults ("},{"line_number":13,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  include cinder::deps"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"0da20f67_c0ce03f5","line":14,"in_reply_to":"5c976146_cfdab815","updated":"2022-06-16 09:58:58.000000000","message":"Thanks Alan and Takashi for your insight, i will wait for the discussion to complete.","commit_id":"c16aeb222eafade6339812f61d178054383a607d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"69d3f312374d07924476b0a862e750e01ca9913e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class cinder::backend::defaults ("},{"line_number":13,"context_line":"  $use_multipath_for_image_xfer \u003d $::os_service_default,"},{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  include cinder::deps"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5c976146_cfdab815","line":14,"in_reply_to":"ed9c91a3_614c53a3","updated":"2022-06-16 05:03:19.000000000","message":"I\u0027d disagree with that. We already have cinder::config::cinder_config interface to inject parameters and adding that option to this class does not provide much benefit while it introduces additional complexity.","commit_id":"c16aeb222eafade6339812f61d178054383a607d"}],"releasenotes/notes/introduce_new_class_for_cinder_backend_defaults-f1f63f755dfdef47.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"4e4993188b3bf8490475fddd42f9b89c89414761","unresolved":true,"context_lines":[{"line_number":4,"context_line":"      Introduce a new Class cinder::backend::defaults, that provides a"},{"line_number":5,"context_line":"      way to enable parameters for all cinder backends in [backend_defaults]"},{"line_number":6,"context_line":"      section of cinder configuration file."},{"line_number":7,"context_line":"      This parameter ``use_multipath_for_image_xfer`` is enabled currently."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dc5c064c_a1642997","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":74},"updated":"2022-06-15 17:24:35.000000000","message":"It\u0027s a good idea to mention this is the parameter currently supported, but remember it\u0027s not enabled by default (it\u0027s $::os_service_default).","commit_id":"c16aeb222eafade6339812f61d178054383a607d"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"99149925959bbd930f326c66de3551e9f39f8b26","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      Introduce a new Class cinder::backend::defaults, that provides a"},{"line_number":5,"context_line":"      way to enable parameters for all cinder backends in [backend_defaults]"},{"line_number":6,"context_line":"      section of cinder configuration file."},{"line_number":7,"context_line":"      This parameter ``use_multipath_for_image_xfer`` is enabled currently."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"165e6491_ed652401","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":74},"in_reply_to":"317097f4_5306ffa2","updated":"2022-06-16 09:58:58.000000000","message":"Done","commit_id":"c16aeb222eafade6339812f61d178054383a607d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"69d3f312374d07924476b0a862e750e01ca9913e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"      Introduce a new Class cinder::backend::defaults, that provides a"},{"line_number":5,"context_line":"      way to enable parameters for all cinder backends in [backend_defaults]"},{"line_number":6,"context_line":"      section of cinder configuration file."},{"line_number":7,"context_line":"      This parameter ``use_multipath_for_image_xfer`` is enabled currently."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"317097f4_5306ffa2","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":74},"in_reply_to":"dc5c064c_a1642997","updated":"2022-06-16 05:03:19.000000000","message":"+1","commit_id":"c16aeb222eafade6339812f61d178054383a607d"}],"spec/classes/cinder_backend_defaults_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ded662315729629e34d68c12f5d393f4142581c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":"describe \u0027cinder::backend::defaults\u0027 do"},{"line_number":3,"context_line":"  shared_examples \u0027cinder::backend::defaults\u0027 do"},{"line_number":4,"context_line":"    context \u0027configure cinder with default backend_defaults parameters\u0027 do"},{"line_number":5,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(nil) }"},{"line_number":6,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"77af2525_b55e6897","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":17},"updated":"2022-06-14 01:01:48.000000000","message":"so you define test cases here but there is not definition to execute these cases.\n\nSee https://github.com/openstack/puppet-cinder/blob/master/spec/classes/cinder_backends_spec.rb#L73-L83","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cac76f641abfe05d67849e2de85ffb2a1e9d604f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":"describe \u0027cinder::backend::defaults\u0027 do"},{"line_number":3,"context_line":"  shared_examples \u0027cinder::backend::defaults\u0027 do"},{"line_number":4,"context_line":"    context \u0027configure cinder with default backend_defaults parameters\u0027 do"},{"line_number":5,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(nil) }"},{"line_number":6,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bb4dc98d_31aaa2be","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":17},"in_reply_to":"77af2525_b55e6897","updated":"2022-06-14 01:46:43.000000000","message":"Done","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ded662315729629e34d68c12f5d393f4142581c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"describe \u0027cinder::backend::defaults\u0027 do"},{"line_number":3,"context_line":"  shared_examples \u0027cinder::backend::defaults\u0027 do"},{"line_number":4,"context_line":"    context \u0027configure cinder with default backend_defaults parameters\u0027 do"},{"line_number":5,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(nil) }"},{"line_number":6,"context_line":"    end"},{"line_number":7,"context_line":"    context \u0027configure cinder with user defined backend_defaults parameters\u0027 do"},{"line_number":8,"context_line":"      let(:params) { {"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"31cf4fdf_a3b427dc","line":5,"range":{"start_line":5,"start_character":108,"end_line":5,"end_character":111},"updated":"2022-06-14 01:01:48.000000000","message":"\u0027\u003cSERVICE DEFAULT\u003e\u0027","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cac76f641abfe05d67849e2de85ffb2a1e9d604f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"describe \u0027cinder::backend::defaults\u0027 do"},{"line_number":3,"context_line":"  shared_examples \u0027cinder::backend::defaults\u0027 do"},{"line_number":4,"context_line":"    context \u0027configure cinder with default backend_defaults parameters\u0027 do"},{"line_number":5,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(nil) }"},{"line_number":6,"context_line":"    end"},{"line_number":7,"context_line":"    context \u0027configure cinder with user defined backend_defaults parameters\u0027 do"},{"line_number":8,"context_line":"      let(:params) { {"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7300f374_29c7076e","line":5,"range":{"start_line":5,"start_character":108,"end_line":5,"end_character":111},"in_reply_to":"31cf4fdf_a3b427dc","updated":"2022-06-14 01:46:43.000000000","message":"Done","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ded662315729629e34d68c12f5d393f4142581c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(nil) }"},{"line_number":6,"context_line":"    end"},{"line_number":7,"context_line":"    context \u0027configure cinder with user defined backend_defaults parameters\u0027 do"},{"line_number":8,"context_line":"      let(:params) { {"},{"line_number":9,"context_line":"        :use_multipath_for_image_xfer \u003d\u003e true,"},{"line_number":10,"context_line":"                            } }"},{"line_number":11,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(true) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"f182ae97_ad5c435b","line":8,"range":{"start_line":8,"start_character":19,"end_line":8,"end_character":22},"updated":"2022-06-14 01:01:48.000000000","message":"we usually use do - end instead of {} in puppet openstack modules , so I \u0027d prefer\n\nlet (:params) do\n  { :use_multipath_for_image_xfer \u003d\u003e true }\nend","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cac76f641abfe05d67849e2de85ffb2a1e9d604f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(nil) }"},{"line_number":6,"context_line":"    end"},{"line_number":7,"context_line":"    context \u0027configure cinder with user defined backend_defaults parameters\u0027 do"},{"line_number":8,"context_line":"      let(:params) { {"},{"line_number":9,"context_line":"        :use_multipath_for_image_xfer \u003d\u003e true,"},{"line_number":10,"context_line":"                            } }"},{"line_number":11,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(true) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"0d8c75f5_1511b43c","line":8,"range":{"start_line":8,"start_character":19,"end_line":8,"end_character":22},"in_reply_to":"f182ae97_ad5c435b","updated":"2022-06-14 01:46:43.000000000","message":"Done","commit_id":"a7d9dc876dc6c8f46fa61ad2b3efba32ba4dfde4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a8617eb577993cb508ab4c7dbb8921808bdc533","unresolved":true,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":"describe \u0027cinder::backend::defaults\u0027 do"},{"line_number":3,"context_line":"  shared_examples \u0027cinder backend defaults\u0027 do"},{"line_number":4,"context_line":"    context \u0027configure cinder with default backend_defaults parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"18cd960c_9fecc883","line":1,"range":{"start_line":1,"start_character":20,"end_line":1,"end_character":21},"updated":"2022-06-14 02:01:21.000000000","message":"let\u0027s insert one blank line after this.","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cf345458b3eb7ee253d2bb502c178c8258a8c4ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":"describe \u0027cinder::backend::defaults\u0027 do"},{"line_number":3,"context_line":"  shared_examples \u0027cinder backend defaults\u0027 do"},{"line_number":4,"context_line":"    context \u0027configure cinder with default backend_defaults parameters\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ed547af4_d57bb3e4","line":1,"range":{"start_line":1,"start_character":20,"end_line":1,"end_character":21},"in_reply_to":"18cd960c_9fecc883","updated":"2022-06-14 10:32:23.000000000","message":"Done","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a8617eb577993cb508ab4c7dbb8921808bdc533","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  shared_examples \u0027cinder backend defaults\u0027 do"},{"line_number":4,"context_line":"    context \u0027configure cinder with default backend_defaults parameters\u0027 do"},{"line_number":5,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":6,"context_line":"    end"},{"line_number":7,"context_line":"    context \u0027configure cinder with user defined backend_defaults parameters\u0027 do"},{"line_number":8,"context_line":"      let(:params) do"},{"line_number":9,"context_line":"        { :use_multipath_for_image_xfer \u003d\u003e true, }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"858babdb_00ea11b4","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":7},"updated":"2022-06-14 02:01:21.000000000","message":"please consider adding one blank line below for better readability.","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cf345458b3eb7ee253d2bb502c178c8258a8c4ea","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  shared_examples \u0027cinder backend defaults\u0027 do"},{"line_number":4,"context_line":"    context \u0027configure cinder with default backend_defaults parameters\u0027 do"},{"line_number":5,"context_line":"      it { is_expected.to contain_cinder_config(\u0027backend_defaults/use_multipath_for_image_xfer\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"},{"line_number":6,"context_line":"    end"},{"line_number":7,"context_line":"    context \u0027configure cinder with user defined backend_defaults parameters\u0027 do"},{"line_number":8,"context_line":"      let(:params) do"},{"line_number":9,"context_line":"        { :use_multipath_for_image_xfer \u003d\u003e true, }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"55bdfdd3_73220e6c","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":7},"in_reply_to":"858babdb_00ea11b4","updated":"2022-06-14 10:32:23.000000000","message":"Done","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a8617eb577993cb508ab4c7dbb8921808bdc533","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  end"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  on_supported_os({"},{"line_number":16,"context_line":"    :supported_os   \u003d\u003e OSDefaults.get_supported_os"},{"line_number":17,"context_line":"  }).each do |os,facts|"},{"line_number":18,"context_line":"    context \"on #{os}\" do"},{"line_number":19,"context_line":"      let (:facts) do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"a15525b9_26794ffb","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":19},"updated":"2022-06-14 02:01:21.000000000","message":"you can remove these redundant spaces.","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cf345458b3eb7ee253d2bb502c178c8258a8c4ea","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  end"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  on_supported_os({"},{"line_number":16,"context_line":"    :supported_os   \u003d\u003e OSDefaults.get_supported_os"},{"line_number":17,"context_line":"  }).each do |os,facts|"},{"line_number":18,"context_line":"    context \"on #{os}\" do"},{"line_number":19,"context_line":"      let (:facts) do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"4350497a_77fda659","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":19},"in_reply_to":"a15525b9_26794ffb","updated":"2022-06-14 10:32:23.000000000","message":"Done","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a8617eb577993cb508ab4c7dbb8921808bdc533","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"      it_behaves_like \u0027cinder backend defaults\u0027"},{"line_number":24,"context_line":"    end"},{"line_number":25,"context_line":"  end  "},{"line_number":26,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"34102f7c_889a6f69","line":25,"range":{"start_line":25,"start_character":5,"end_line":25,"end_character":7},"updated":"2022-06-14 02:01:21.000000000","message":"please remove this.","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"cf345458b3eb7ee253d2bb502c178c8258a8c4ea","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"      it_behaves_like \u0027cinder backend defaults\u0027"},{"line_number":24,"context_line":"    end"},{"line_number":25,"context_line":"  end  "},{"line_number":26,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"63b9a7ba_1ec356f8","line":25,"range":{"start_line":25,"start_character":5,"end_line":25,"end_character":7},"in_reply_to":"34102f7c_889a6f69","updated":"2022-06-14 10:32:23.000000000","message":"Done","commit_id":"eb39b8a3a20b978969eb32a303ed35699dfc7772"}]}