)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1276c3719e8ce2f753874817381154ae475d6af6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"line nature matching the existing examples."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"```"},{"line_number":16,"context_line":"extra_options: { \u0027section_header/example_var\u0027: { \u0027value\u0027: somevalue }, }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"extra_options:"},{"line_number":19,"context_line":"  section_header/example_var:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9345809d_82ef867e","line":16,"updated":"2022-08-10 01:44:34.000000000","message":"I think this is a difference in yaml vs puppet hashes. The examples were done assuming puppet hash syntax https://puppet.com/docs/puppet/7/lang_data_hash.html#lang_data_hash-hashes-syntax and not yaml.","commit_id":"e76a3ab9b424383919cc9bda1fa413f6c83248aa"},{"author":{"_account_id":35182,"name":"Karl Goetz","email":"karl@kgoetz.id.au","username":"kgoetz"},"change_message_id":"c4c6dbe1ce22794fe374dce9b33feaac43e93bc5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"line nature matching the existing examples."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"```"},{"line_number":16,"context_line":"extra_options: { \u0027section_header/example_var\u0027: { \u0027value\u0027: somevalue }, }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"extra_options:"},{"line_number":19,"context_line":"  section_header/example_var:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"072c816c_2a1a1439","line":16,"in_reply_to":"81b4b393_bf166729","updated":"2022-08-25 06:37:11.000000000","message":"Really sorry about how long it took to reply :s\nI see what you\u0027re saying - I had assumed the examples were meant to be used differently and got caught up in it.\n\nthanks for your clarification.","commit_id":"e76a3ab9b424383919cc9bda1fa413f6c83248aa"},{"author":{"_account_id":35182,"name":"Karl Goetz","email":"karl@kgoetz.id.au","username":"kgoetz"},"change_message_id":"8fa4967de50220954689f8cdaedfb1096656cc14","unresolved":false,"context_lines":[{"line_number":13,"context_line":"line nature matching the existing examples."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"```"},{"line_number":16,"context_line":"extra_options: { \u0027section_header/example_var\u0027: { \u0027value\u0027: somevalue }, }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"extra_options:"},{"line_number":19,"context_line":"  section_header/example_var:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"beac6e09_ce163f7d","line":16,"in_reply_to":"9345809d_82ef867e","updated":"2022-08-10 03:42:04.000000000","message":"I couldn\u0027t get the hash syntax to parse\n```\n 24       extra_options: {\n 25         \u0027deferred_deletion_delay\u0027  \u003d\u003e { \u0027value\u0027 \u003d\u003e 18144, },\n 26         \u0027enable_deferred_deletion\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e True, },\n 27       }\n```\n\nresulting in\n```\nError: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Unable to parse (/etc/puppetlabs/code/dev_environments/kgoetz_tas_syntax_test/data/nodes/cinder.yaml): expected \u0027,\u0027 or \u0027}\u0027, but got \u003cscalar\u003e while parsing a flow mapping at line 25 column 36 on node cinder\nWarning: Not using cache on failed catalog\nError: Could not retrieve catalog; skipping run\n```\n\nChanging to the yaml syntax has resulted in successful puppet runs so I proposed it here.","commit_id":"e76a3ab9b424383919cc9bda1fa413f6c83248aa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d1aaafe2ae84d6be8fce06be95465f2298638ccb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"line nature matching the existing examples."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"```"},{"line_number":16,"context_line":"extra_options: { \u0027section_header/example_var\u0027: { \u0027value\u0027: somevalue }, }"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"extra_options:"},{"line_number":19,"context_line":"  section_header/example_var:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"81b4b393_bf166729","line":16,"in_reply_to":"beac6e09_ce163f7d","updated":"2022-08-10 14:27:51.000000000","message":"Right because that\u0027s a yaml file. The comments in the .pp files are using puppet syntax. In your cinder.yaml, you\u0027d use the yaml hash syntax but if defining a hash in a .pp file like we do https://opendev.org/openstack/puppet-openstack-integration/src/branch/master/manifests/cinder.pp#L70-L76, then you\u0027d use the existing syntax that is documented.","commit_id":"e76a3ab9b424383919cc9bda1fa413f6c83248aa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d1aaafe2ae84d6be8fce06be95465f2298638ccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"40249e7f_f1638464","updated":"2022-08-10 14:27:51.000000000","message":"The values we document in the puppet parameters are always in puppet syntax.","commit_id":"e76a3ab9b424383919cc9bda1fa413f6c83248aa"},{"author":{"_account_id":35182,"name":"Karl Goetz","email":"karl@kgoetz.id.au","username":"kgoetz"},"change_message_id":"7e965d472fad047bc40b22a9d69143f626c24788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2065392d_89ebc0b1","updated":"2022-08-09 23:36:24.000000000","message":"recheck","commit_id":"e76a3ab9b424383919cc9bda1fa413f6c83248aa"}]}