)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ac2219c67165a1afcae350943e2e2ee9658189d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83e7862d_b6808db4","updated":"2022-09-01 03:55:03.000000000","message":"Has a problem been reported with the existing code?","commit_id":"9fea76ab0de1a08c12cf76b1b9f9a49c893fbad6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"205265261e6ffeff14e217aab578eec358e70dfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"347d6baf_0e172903","updated":"2022-09-05 15:58:18.000000000","message":"recheck\n\nthe issue with ovn-metadata-agent was fixed.","commit_id":"9fea76ab0de1a08c12cf76b1b9f9a49c893fbad6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"93b22676b8833c31b55080dba58c64906694e786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"94f20db0_4a468d5d","in_reply_to":"1d61a5a7_c0e12053","updated":"2022-09-01 11:03:49.000000000","message":"I ended up creating an ugly patch to force the problematic order to start services then create pv/vg.\nAdding this hacky dependency does not cause circular dependency, which means we don\u0027t have any order constraint to make sure pv/vg is created AFTER services are started. (if there is any then puppet should complain circular dependencies)\n\nhttps://review.opendev.org/c/openstack/puppet-openstack-integration/+/855446\n\n\nHere we see c-vol failed to initialize backend and the backend is reported as down.\n\nhttps://zuul.opendev.org/t/openstack/build/f8b4684e3bec4be998a0a9b1bd2692f5\nhttps://0793b39e56ef753a822c-5061d1dd61c75bd0e8246a27130264c7.ssl.cf1.rackcdn.com/855446/2/check/puppet-openstack-integration-7-scenario002-tempest-centos-9-stream/a8efa37/logs/cinder/volume.txt","commit_id":"9fea76ab0de1a08c12cf76b1b9f9a49c893fbad6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7dabc29fed12fdc4a529d4f9faff3f058f46fa60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d61a5a7_c0e12053","in_reply_to":"83e7862d_b6808db4","updated":"2022-09-01 04:02:28.000000000","message":"I\u0027m not aware of any actual bug report. Let me try whether I can reproduce the issue.","commit_id":"9fea76ab0de1a08c12cf76b1b9f9a49c893fbad6"}],"manifests/setup_test_volume.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bdfe2026c9489c114c864e7cada7965190f05231","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  ~\u003e file { \"${volume_path}/${volume_name}\":"},{"line_number":41,"context_line":"    mode   \u003d\u003e \u00270640\u0027,"},{"line_number":42,"context_line":"    before \u003d\u003e Anchor[\u0027cinder::service::begin\u0027],"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  ~\u003e exec { \"losetup ${loopback_device} ${volume_path}/${volume_name}\":"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"988ef6a3_0549af05","line":42,"updated":"2022-08-31 14:37:45.000000000","message":"I think this should be redundant if you put this after the last exec in this chain since they are already a series of -\u003e statements","commit_id":"a00efab2be613750b54f987e30949c5bafd74b71"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ce50b375b61d27e6d82e0c2e7e7503906e6849bb","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  ~\u003e file { \"${volume_path}/${volume_name}\":"},{"line_number":41,"context_line":"    mode   \u003d\u003e \u00270640\u0027,"},{"line_number":42,"context_line":"    before \u003d\u003e Anchor[\u0027cinder::service::begin\u0027],"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  ~\u003e exec { \"losetup ${loopback_device} ${volume_path}/${volume_name}\":"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"102d896c_35162294","line":42,"in_reply_to":"988ef6a3_0549af05","updated":"2022-08-31 16:14:10.000000000","message":"Done. Yeah that is true.","commit_id":"a00efab2be613750b54f987e30949c5bafd74b71"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bdfe2026c9489c114c864e7cada7965190f05231","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    tag         \u003d\u003e \u0027cinder-test-volume-exec\u0027,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  Exec\u003c| tag \u003d\u003d \u0027cinder-test-volume-exec\u0027 |\u003e -\u003e Anchor[\u0027cinder::service::begin\u0027]"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"396bc25c_dc716ec5","line":67,"updated":"2022-08-31 14:37:45.000000000","message":"Don\u0027t really need the tag since all these already have an ordering. You could just tack the anchor after the last exect.","commit_id":"a00efab2be613750b54f987e30949c5bafd74b71"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ce50b375b61d27e6d82e0c2e7e7503906e6849bb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    tag         \u003d\u003e \u0027cinder-test-volume-exec\u0027,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  Exec\u003c| tag \u003d\u003d \u0027cinder-test-volume-exec\u0027 |\u003e -\u003e Anchor[\u0027cinder::service::begin\u0027]"},{"line_number":68,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"335f8173_46e406db","line":67,"in_reply_to":"396bc25c_dc716ec5","updated":"2022-08-31 16:14:10.000000000","message":"I agree. Fixed accordingly. This would help our future maintenance.","commit_id":"a00efab2be613750b54f987e30949c5bafd74b71"}]}