)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"89a79afbff4e60617f6a172b71f9a468e7a1052c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for Cinder IBM Svf driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds tripleo deployment support in puppet-cinder"},{"line_number":10,"context_line":"for Cinder IBM Spectrum virtualize family (Svf) driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I43f954879de6ce70237cb468e7ef1fbc2649edcd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"05bad044_77dc3228","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":59},"updated":"2022-10-28 04:06:14.000000000","message":"I would avoid referring to tripleo, as this puppet feature supports any deployment tooling that uses openstack puppet. I think the commit message reads fine if you remove most the highlighted text:\n\n\"This patch adds support for Cinder IBM Spectrum virtualize family (Svf) driver.\"","commit_id":"da289813c1f912200ae04f735f2f1e966e3cddef"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6a4a6b0df1f4db41d08ecbad3fd2e1275c51cfac","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for Cinder IBM Svf driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds tripleo deployment support in puppet-cinder"},{"line_number":10,"context_line":"for Cinder IBM Spectrum virtualize family (Svf) driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I43f954879de6ce70237cb468e7ef1fbc2649edcd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a235ee3b_8b549e83","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":59},"in_reply_to":"05bad044_77dc3228","updated":"2022-10-28 10:32:32.000000000","message":"Done","commit_id":"da289813c1f912200ae04f735f2f1e966e3cddef"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ecdae0d4d4d2b65a88a618b24647fb7564691186","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a71a4bd_52dd5bbd","updated":"2022-10-27 00:20:22.000000000","message":"Thanks for proposing this. Please find my inline comments.\n\nAlso, this adds the new feature so we need a release note.","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"8403796c576442e1431cf9b58aa6d7240bb5a3f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"22062e4a_682851ca","in_reply_to":"2a71a4bd_52dd5bbd","updated":"2022-10-27 17:08:09.000000000","message":"Done!","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"89a79afbff4e60617f6a172b71f9a468e7a1052c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ecd3a5ed_93200b51","updated":"2022-10-28 04:06:14.000000000","message":"A few minor items, but generally looks good.","commit_id":"da289813c1f912200ae04f735f2f1e966e3cddef"}],"manifests/backend/ibm_svf.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ecdae0d4d4d2b65a88a618b24647fb7564691186","unresolved":true,"context_lines":[{"line_number":60,"context_line":"#   Example :"},{"line_number":61,"context_line":"#     { \u0027ibm_svf_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }#"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"define cinder::backend::ibm_svf ("},{"line_number":64,"context_line":"  $san_ip,"},{"line_number":65,"context_line":"  $san_login,"},{"line_number":66,"context_line":"  $san_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fc0636e8_5e000597","line":63,"range":{"start_line":63,"start_character":24,"end_line":63,"end_character":31},"updated":"2022-10-27 00:20:22.000000000","message":"I think ibm_storwise_svc is more consistent with the driver name ?","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1a469be4b3af96dcd781102b4a35ccf2a783e13f","unresolved":true,"context_lines":[{"line_number":60,"context_line":"#   Example :"},{"line_number":61,"context_line":"#     { \u0027ibm_svf_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }#"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"define cinder::backend::ibm_svf ("},{"line_number":64,"context_line":"  $san_ip,"},{"line_number":65,"context_line":"  $san_login,"},{"line_number":66,"context_line":"  $san_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c5d5ee59_753956c0","line":63,"range":{"start_line":63,"start_character":24,"end_line":63,"end_character":31},"in_reply_to":"713b06af_2084d716","updated":"2022-10-31 03:26:31.000000000","message":"I 100% agree that renaming drivers is irritating, but it absolutely does happen. In fact, cinder has a specific mechanism to support renaming drivers in a way that provides backward compatibility [1]. Luckily this does not involve renaming the driver config options.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L177","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c6e5a4852a1d15876f5165f59366be561f234cc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"#   Example :"},{"line_number":61,"context_line":"#     { \u0027ibm_svf_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }#"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"define cinder::backend::ibm_svf ("},{"line_number":64,"context_line":"  $san_ip,"},{"line_number":65,"context_line":"  $san_login,"},{"line_number":66,"context_line":"  $san_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e055ac74_62c03a2f","line":63,"range":{"start_line":63,"start_character":24,"end_line":63,"end_character":31},"in_reply_to":"713b06af_2084d716","updated":"2022-10-31 03:21:54.000000000","message":"I\u0027m afraid I opened the wrong documentation.\nSo the cinder documentation was updated a while ago to replace storwise svc by svf[1], then we\u0027d better use svf here. I still hope they consider renaming the code and not renaming their product again but I don\u0027t know they really want to do that now and in the future.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/753429","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ad085c33391fc83f347d3c2d19f4f14b71d9147","unresolved":true,"context_lines":[{"line_number":60,"context_line":"#   Example :"},{"line_number":61,"context_line":"#     { \u0027ibm_svf_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }#"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"define cinder::backend::ibm_svf ("},{"line_number":64,"context_line":"  $san_ip,"},{"line_number":65,"context_line":"  $san_login,"},{"line_number":66,"context_line":"  $san_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"713b06af_2084d716","line":63,"range":{"start_line":63,"start_character":24,"end_line":63,"end_character":31},"in_reply_to":"f433497b_43335d71","updated":"2022-10-31 03:05:41.000000000","message":"I hate rebranding which has been causing multiple confusions.\n\nI still think the old naming is better. Cinder has never renamed the driver and the parameter names. We better avoid using our own naming but follow what cinder has.\n\nAlso, the documentation and the change you are referring still mention \"Storwize (Cinder) driver\" instead of \"Spectrum virtualize family (Cinder) driver\".","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"8403796c576442e1431cf9b58aa6d7240bb5a3f2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"#   Example :"},{"line_number":61,"context_line":"#     { \u0027ibm_svf_backend/param1\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e value1 } }#"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"define cinder::backend::ibm_svf ("},{"line_number":64,"context_line":"  $san_ip,"},{"line_number":65,"context_line":"  $san_login,"},{"line_number":66,"context_line":"  $san_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f433497b_43335d71","line":63,"range":{"start_line":63,"start_character":24,"end_line":63,"end_character":31},"in_reply_to":"fc0636e8_5e000597","updated":"2022-10-27 17:08:09.000000000","message":"storwize_svc is the older name, after rebranding, it is called as svf (spectrum virtualize family).\nsvf includes svc/storwize, flashsystem storages.\nDriver documentation [1] and a patch [2] for your reference.\n\n[1] https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/ibm-storwize-svc-driver.html\n[2] https://review.opendev.org/c/openstack/cinder/+/830787","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ecdae0d4d4d2b65a88a618b24647fb7564691186","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  $san_login,"},{"line_number":66,"context_line":"  $san_password,"},{"line_number":67,"context_line":"  $storwize_svc_volpool_name,"},{"line_number":68,"context_line":"  $storwize_svc_allow_tenant_qos     \u003d false,"},{"line_number":69,"context_line":"  $storwize_svc_connection_protocol  \u003d \u0027iSCSI\u0027,"},{"line_number":70,"context_line":"  $storwize_svc_iscsi_chap_enabled   \u003d false,"},{"line_number":71,"context_line":"  $storwize_svc_retain_aux_volume    \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9c14f64a_655879a2","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":44},"updated":"2022-10-27 00:20:22.000000000","message":"Please do not hard-code the default value. This requires us to maintain these by our own. I\u0027d strongly recommend $::os_service_default .","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"8403796c576442e1431cf9b58aa6d7240bb5a3f2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $san_login,"},{"line_number":66,"context_line":"  $san_password,"},{"line_number":67,"context_line":"  $storwize_svc_volpool_name,"},{"line_number":68,"context_line":"  $storwize_svc_allow_tenant_qos     \u003d false,"},{"line_number":69,"context_line":"  $storwize_svc_connection_protocol  \u003d \u0027iSCSI\u0027,"},{"line_number":70,"context_line":"  $storwize_svc_iscsi_chap_enabled   \u003d false,"},{"line_number":71,"context_line":"  $storwize_svc_retain_aux_volume    \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c56fb496_36561a1f","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":44},"in_reply_to":"9c14f64a_655879a2","updated":"2022-10-27 17:08:09.000000000","message":"Thanks for identifying this. \nupdated it at all the required places.","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ecdae0d4d4d2b65a88a618b24647fb7564691186","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    \"${name}/san_ip\":                          value \u003d\u003e $san_ip;"},{"line_number":96,"context_line":"    \"${name}/san_login\":                       value \u003d\u003e $san_login;"},{"line_number":97,"context_line":"    \"${name}/san_password\":                    value \u003d\u003e $san_password, secret \u003d\u003e true;"},{"line_number":98,"context_line":"    \"${name}/storwize_svc_volpool_name\":       value \u003d\u003e $storwize_svc_volpool_name;"},{"line_number":99,"context_line":"    \"${name}/storwize_svc_allow_tenant_qos\":   value \u003d\u003e $storwize_svc_allow_tenant_qos;"},{"line_number":100,"context_line":"    \"${name}/storwize_svc_iscsi_chap_enabled\": value \u003d\u003e $storwize_svc_iscsi_chap_enabled;"},{"line_number":101,"context_line":"    \"${name}/storwize_svc_retain_aux_volume\":  value \u003d\u003e $storwize_svc_retain_aux_volume;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7defa57c_6b6bb926","line":98,"range":{"start_line":98,"start_character":57,"end_line":98,"end_character":82},"updated":"2022-10-27 00:20:22.000000000","message":"We can improve this logic to support an array value as well.\n\n```\njoin(any2array($storwize_svc_volpool_name), \u0027,\u0027)\n```","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"8403796c576442e1431cf9b58aa6d7240bb5a3f2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    \"${name}/san_ip\":                          value \u003d\u003e $san_ip;"},{"line_number":96,"context_line":"    \"${name}/san_login\":                       value \u003d\u003e $san_login;"},{"line_number":97,"context_line":"    \"${name}/san_password\":                    value \u003d\u003e $san_password, secret \u003d\u003e true;"},{"line_number":98,"context_line":"    \"${name}/storwize_svc_volpool_name\":       value \u003d\u003e $storwize_svc_volpool_name;"},{"line_number":99,"context_line":"    \"${name}/storwize_svc_allow_tenant_qos\":   value \u003d\u003e $storwize_svc_allow_tenant_qos;"},{"line_number":100,"context_line":"    \"${name}/storwize_svc_iscsi_chap_enabled\": value \u003d\u003e $storwize_svc_iscsi_chap_enabled;"},{"line_number":101,"context_line":"    \"${name}/storwize_svc_retain_aux_volume\":  value \u003d\u003e $storwize_svc_retain_aux_volume;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"a961a65a_12075434","line":98,"range":{"start_line":98,"start_character":57,"end_line":98,"end_character":82},"in_reply_to":"7defa57c_6b6bb926","updated":"2022-10-27 17:08:09.000000000","message":"Done","commit_id":"e2a773cf07fbcaee44cda8d5633945d567479ec6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"89a79afbff4e60617f6a172b71f9a468e7a1052c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*storwize_svc_allow_tenant_qos*]"},{"line_number":22,"context_line":"#   (optional) Allow tenants to specify QoS on create."},{"line_number":23,"context_line":"#   Defaults to false."},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*storwize_svc_connection_protocol*]"},{"line_number":26,"context_line":"#   (optional) The Storage protocol, iSCSI or FC."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5742b047_d4b957a4","line":23,"updated":"2022-10-28 04:06:14.000000000","message":"Several comments need to be updated where the actual default is $::os_service_default.","commit_id":"da289813c1f912200ae04f735f2f1e966e3cddef"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6a4a6b0df1f4db41d08ecbad3fd2e1275c51cfac","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*storwize_svc_allow_tenant_qos*]"},{"line_number":22,"context_line":"#   (optional) Allow tenants to specify QoS on create."},{"line_number":23,"context_line":"#   Defaults to false."},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*storwize_svc_connection_protocol*]"},{"line_number":26,"context_line":"#   (optional) The Storage protocol, iSCSI or FC."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"d3bb552d_1ad90bea","line":23,"in_reply_to":"5742b047_d4b957a4","updated":"2022-10-28 10:32:32.000000000","message":"Done","commit_id":"da289813c1f912200ae04f735f2f1e966e3cddef"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ad085c33391fc83f347d3c2d19f4f14b71d9147","unresolved":true,"context_lines":[{"line_number":16,"context_line":"#   (required) Password for IBM Svf SAN controller."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*storwize_svc_volpool_name*]"},{"line_number":19,"context_line":"#   (required) Comma separated list of storage pools for volumes."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*storwize_svc_allow_tenant_qos*]"},{"line_number":22,"context_line":"#   (optional) Allow tenants to specify QoS on create."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"83cdc85e_2b65cefa","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":35},"updated":"2022-10-31 03:05:41.000000000","message":"(nit) We probably want to use \"List\" instead because an array value is also accepted.","commit_id":"fa671e8ed6dfb80aee18d2ea1fdf7420f4f68371"}],"releasenotes/notes/Add_support_for_ibm_svf_driver-803e3cbfc82e39d9.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"89a79afbff4e60617f6a172b71f9a468e7a1052c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add tripleo deployment support in puppet-cinder for Cinder"},{"line_number":5,"context_line":"    IBM Spectrum virtualize family (Svf) driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"602eab0a_f26fde3d","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":15},"updated":"2022-10-28 04:06:14.000000000","message":"As I mentioned in another comment, I think references to tripleo should be eliminated.","commit_id":"da289813c1f912200ae04f735f2f1e966e3cddef"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6a4a6b0df1f4db41d08ecbad3fd2e1275c51cfac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add tripleo deployment support in puppet-cinder for Cinder"},{"line_number":5,"context_line":"    IBM Spectrum virtualize family (Svf) driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a05f17e1_a2edb517","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":15},"in_reply_to":"602eab0a_f26fde3d","updated":"2022-10-28 10:32:32.000000000","message":"Done","commit_id":"da289813c1f912200ae04f735f2f1e966e3cddef"}]}