)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bd37e0dfb0b94a4acdf74cb611add3c357510e74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c83e9e01_6aa0eeee","updated":"2023-01-03 15:11:32.000000000","message":"This patch seems to pertain more to adding Pure driver support for NVMe in general (in fact, the pure_nvme_transport parameter only supports a single value!).\n\nI see there are pure_nvme_cidr and pure_nvme_cidr_list parameters that mirror their iscsi counterparts. Should they be included this patch?","commit_id":"af4f23ff0eb36befff5f2091f4914004abe26511"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5dc816778bb627a7531d2acf7da0ef91caa78ba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"405c3f95_24251de8","updated":"2022-12-30 16:09:45.000000000","message":"recheck","commit_id":"af4f23ff0eb36befff5f2091f4914004abe26511"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f4c8ac707db47fc0dfa30f2eedb3bb72e8729619","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a0aa71f5_ca0a9c42","updated":"2022-12-30 17:53:28.000000000","message":"recheck","commit_id":"af4f23ff0eb36befff5f2091f4914004abe26511"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6bf095f96133f794b6101ac5f53725a501c20c3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"67fa94d2_8a1517e2","in_reply_to":"c83e9e01_6aa0eeee","updated":"2023-01-03 15:28:08.000000000","message":"Yes - you are correct. Fixing all of this.\nWe have the nvme_protocol parameter to enable the support of mote than RoCE in the future. There are plans for both NVMe-FC and NVMe-TCP very soon.","commit_id":"af4f23ff0eb36befff5f2091f4914004abe26511"}],"manifests/backend/pure.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bd37e0dfb0b94a4acdf74cb611add3c357510e74","unresolved":true,"context_lines":[{"line_number":22,"context_line":"#   Defaults to $::os_service_default."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*pure_storage_protocol*]"},{"line_number":25,"context_line":"#   (optional) Must be either \u0027iSCSI\u0027 or \u0027FC\u0027. This will determine"},{"line_number":26,"context_line":"#   which Volume Driver will be configured; PureISCSIDriver or PureFCDriver."},{"line_number":27,"context_line":"#   Defaults to \u0027iSCSI\u0027"},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"346f8f98_7cdc9860","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":45},"updated":"2023-01-03 15:11:32.000000000","message":"L105 suggests this is no longer true, and \u0027NVMe\u0027 is also valid.","commit_id":"af4f23ff0eb36befff5f2091f4914004abe26511"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6bf095f96133f794b6101ac5f53725a501c20c3d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   Defaults to $::os_service_default."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*pure_storage_protocol*]"},{"line_number":25,"context_line":"#   (optional) Must be either \u0027iSCSI\u0027 or \u0027FC\u0027. This will determine"},{"line_number":26,"context_line":"#   which Volume Driver will be configured; PureISCSIDriver or PureFCDriver."},{"line_number":27,"context_line":"#   Defaults to \u0027iSCSI\u0027"},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"789c4f29_2bc9276f","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":45},"in_reply_to":"346f8f98_7cdc9860","updated":"2023-01-03 15:28:08.000000000","message":"Done","commit_id":"af4f23ff0eb36befff5f2091f4914004abe26511"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bcd7659ee6644ab0d55773e8e94e4d473d65eb3f","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    \"${name}/pure_eradicate_on_delete\":      value \u003d\u003e $pure_eradicate_on_delete;"},{"line_number":127,"context_line":"    \"${name}/pure_nvme_transport\":           value \u003d\u003e $pure_nvme_transport;"},{"line_number":128,"context_line":"    \"${name}/pure_nvme_cidr\":                value \u003d\u003e $pure_nvme_cidr;"},{"line_number":129,"context_line":"    \"${name}/pure_nvme_cidr_list\":           value \u003d\u003e $pure_nvme_cidr_list;"},{"line_number":130,"context_line":"    \"${name}/pure_iscsi_cidr\":               value \u003d\u003e $pure_iscsi_cidr;"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"0ff058de_5ce026d3","line":129,"range":{"start_line":129,"start_character":55,"end_line":129,"end_character":74},"updated":"2023-01-05 14:49:33.000000000","message":"we probably want to accept a native list\n\n```\njoin(any2array($pure_nvme_cidr_list), \u0027,\u0027)\n```\n\nBecause this is being merged now, I\u0027ll submit a follow-up to make that change.","commit_id":"8f598b0f7d22662c307bd8624c7d829941e49363"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"75eff910018c988a65228ee5df0d089f02716a0f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \"${name}/pure_eradicate_on_delete\":      value \u003d\u003e $pure_eradicate_on_delete;"},{"line_number":127,"context_line":"    \"${name}/pure_nvme_transport\":           value \u003d\u003e $pure_nvme_transport;"},{"line_number":128,"context_line":"    \"${name}/pure_nvme_cidr\":                value \u003d\u003e $pure_nvme_cidr;"},{"line_number":129,"context_line":"    \"${name}/pure_nvme_cidr_list\":           value \u003d\u003e $pure_nvme_cidr_list;"},{"line_number":130,"context_line":"    \"${name}/pure_iscsi_cidr\":               value \u003d\u003e $pure_iscsi_cidr;"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"c58595b1_186dc32e","line":129,"range":{"start_line":129,"start_character":55,"end_line":129,"end_character":74},"in_reply_to":"0ff058de_5ce026d3","updated":"2023-01-05 15:38:08.000000000","message":"I\u0027ve amended the code to take this into account as I found a couple of other things not correct","commit_id":"8f598b0f7d22662c307bd8624c7d829941e49363"}],"releasenotes/notes/pure_nvme-b471de69aba7dbe7.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bd37e0dfb0b94a4acdf74cb611add3c357510e74","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new parameter ``cinder::backend::pure::pure_nvme_transport``"},{"line_number":5,"context_line":"    which defines the NVMe transport layer used when the NVMe"},{"line_number":6,"context_line":"    driver is selected. This only supports ``roce`` at this time."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f59d291c_cf253d90","line":4,"updated":"2023-01-03 15:11:32.000000000","message":"You should also mention cinder::backend::pure::pure_storage_protocol supports \u0027NVMe\u0027","commit_id":"af4f23ff0eb36befff5f2091f4914004abe26511"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6bf095f96133f794b6101ac5f53725a501c20c3d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add new parameter ``cinder::backend::pure::pure_nvme_transport``"},{"line_number":5,"context_line":"    which defines the NVMe transport layer used when the NVMe"},{"line_number":6,"context_line":"    driver is selected. This only supports ``roce`` at this time."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"434dff2f_4cbebe94","line":4,"in_reply_to":"f59d291c_cf253d90","updated":"2023-01-03 15:28:08.000000000","message":"Done","commit_id":"af4f23ff0eb36befff5f2091f4914004abe26511"}],"spec/defines/cinder_backend_pure_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6fa914781ba410f4882483aaf9b022334155cc75","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    context \u0027pure volume driver with pure_nvme_cidr_list set to an array\u0027 do"},{"line_number":122,"context_line":"      let :params do"},{"line_number":123,"context_line":"        req_params.merge({\u0027pure_nvme_cidr_list\u0027 \u003d\u003e [\u0027192.0.3.1/24\u0027, \u0027192.0.3.2/24\u0027]})"},{"line_number":124,"context_line":"      end"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      it {"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"00f24d30_497e4a59","line":123,"range":{"start_line":123,"start_character":53,"end_line":123,"end_character":62},"updated":"2023-01-06 08:13:07.000000000","message":"I usually prefer 192.0.2.0/24 range because it is reserved for documentation but that\u0027s just trivial.","commit_id":"2519bd4f8173a6b016d0a901205470d731b8903d"}]}