)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de0caac7966c584b06d8bf53afea622b4eb7b44e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88a56147_87fd2e75","updated":"2023-03-16 01:45:41.000000000","message":"Thanks for submitting this ! Let me leave some comments inline.","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b8e71ac255d72f9d11421337a874a5c62913b6d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"427ad32c_3f429822","updated":"2023-03-16 09:08:45.000000000","message":"Thanks for the suggestions.","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88cd1a43d553d574f49d7b77150c7717fe795967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61b0dd08_7549bdc1","updated":"2023-03-16 11:02:08.000000000","message":"Thanks ! Just leaving one minor suggestion which I\u0027ll fix by my side. The other parts looks good to me !","commit_id":"52c433bf845e855d3594dfa6e4db73429fb6b1bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6606ab204dbe8105c7b9dcf3ed8417fa01ab72eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be0254b6_133755ee","updated":"2023-03-17 05:50:43.000000000","message":"recheck 504 errors in tempest","commit_id":"d55f88c1dea50c27e5408be3dc33f0cb57da8957"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7f90484b57a12c142efb700bc0d8be1d024cbab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44bbc1cb_d280cc4e","updated":"2023-03-16 13:37:49.000000000","message":"recheck tempest","commit_id":"d55f88c1dea50c27e5408be3dc33f0cb57da8957"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"629bf767109baf0602c2ef3bc1c9ca269b87558f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"501d9c2c_84c51864","updated":"2023-03-18 06:51:01.000000000","message":"recheck tempest","commit_id":"d55f88c1dea50c27e5408be3dc33f0cb57da8957"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0f7588dc074ece4806776a3ccfaa5822c5336a9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"56465689_84bce6c8","updated":"2023-03-19 16:02:36.000000000","message":"recheck tempest","commit_id":"d55f88c1dea50c27e5408be3dc33f0cb57da8957"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a49ca2541b3f55bd4ad6286baecfa2430d32200","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9418c97a_141cb595","updated":"2023-03-18 03:04:01.000000000","message":"recheck tempest","commit_id":"d55f88c1dea50c27e5408be3dc33f0cb57da8957"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"256f895e918548fa7b72df38103c35756e059f9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f385fc3_c6c4365b","updated":"2023-03-17 23:27:21.000000000","message":"recheck tempest","commit_id":"d55f88c1dea50c27e5408be3dc33f0cb57da8957"}],"manifests/backend/nvmeof.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de0caac7966c584b06d8bf53afea622b4eb7b44e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"# [*target_helper*]"},{"line_number":10,"context_line":"#   (Required) Target user-land tool to use."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*target_port*]"},{"line_number":13,"context_line":"#   (Optional) Port that NVMe target is listening on."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*target_protocol*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"03b23214_b811cd7d","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":15},"updated":"2023-03-16 01:45:41.000000000","message":"let\u0027s put this after target_protocl. Also add the line to explain its default.","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b8e71ac255d72f9d11421337a874a5c62913b6d3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# [*target_helper*]"},{"line_number":10,"context_line":"#   (Required) Target user-land tool to use."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*target_port*]"},{"line_number":13,"context_line":"#   (Optional) Port that NVMe target is listening on."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*target_protocol*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e443d7c0_c2355c51","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":15},"in_reply_to":"03b23214_b811cd7d","updated":"2023-03-16 09:08:45.000000000","message":"LOL\nI did move it initially, but somehow I reverted the change. (/me facepalms)","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de0caac7966c584b06d8bf53afea622b4eb7b44e","unresolved":true,"context_lines":[{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*nvmeof_conn_info_version*]"},{"line_number":49,"context_line":"#   (Optional) NVMe-oF Connection Information version"},{"line_number":50,"context_line":"#   Defaults to \u00271\u0027"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*lvm_share_target*]"},{"line_number":53,"context_line":"#   (Optional) Use shared targets or per-volume targets"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa187509_aa8f7c25","line":50,"range":{"start_line":50,"start_character":16,"end_line":50,"end_character":19},"updated":"2023-03-16 01:45:41.000000000","message":"let\u0027s use $facts[\u0027os_service_default\u0027] to all the new parameters instead, to avoid hard-coding our own defaults.\nI\u0027ll submit a follow-up to change default of nvmet_port_id and nvmet_ns_id.","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b8e71ac255d72f9d11421337a874a5c62913b6d3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*nvmeof_conn_info_version*]"},{"line_number":49,"context_line":"#   (Optional) NVMe-oF Connection Information version"},{"line_number":50,"context_line":"#   Defaults to \u00271\u0027"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*lvm_share_target*]"},{"line_number":53,"context_line":"#   (Optional) Use shared targets or per-volume targets"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"795ff979_2dcf18bf","line":50,"range":{"start_line":50,"start_character":16,"end_line":50,"end_character":19},"in_reply_to":"fa187509_aa8f7c25","updated":"2023-03-16 09:08:45.000000000","message":"Done","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de0caac7966c584b06d8bf53afea622b4eb7b44e","unresolved":true,"context_lines":[{"line_number":53,"context_line":"#   (Optional) Use shared targets or per-volume targets"},{"line_number":54,"context_line":"#   Defaults to false"},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"# [*target_seoncdary_ip_addresses*]"},{"line_number":57,"context_line":"#   (Optional) Additional ip addresses to map the NVMe-oF volume"},{"line_number":58,"context_line":"#   Defaults to []"},{"line_number":59,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1b46550a_7d801e35","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":16},"updated":"2023-03-16 01:45:41.000000000","message":"typo secondary","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b8e71ac255d72f9d11421337a874a5c62913b6d3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#   (Optional) Use shared targets or per-volume targets"},{"line_number":54,"context_line":"#   Defaults to false"},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"# [*target_seoncdary_ip_addresses*]"},{"line_number":57,"context_line":"#   (Optional) Additional ip addresses to map the NVMe-oF volume"},{"line_number":58,"context_line":"#   Defaults to []"},{"line_number":59,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"0a1a5fff_1031a285","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":16},"in_reply_to":"1b46550a_7d801e35","updated":"2023-03-16 09:08:45.000000000","message":"Done","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de0caac7966c584b06d8bf53afea622b4eb7b44e","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    \"${name}/volume_group\":                  value \u003d\u003e $volume_group;"},{"line_number":92,"context_line":"    \"${name}/nvmeof_conn_info_version\":      value \u003d\u003e $nvmeof_conn_info_version;"},{"line_number":93,"context_line":"    \"${name}/lvm_share_target\":              value \u003d\u003e $lvm_share_target;"},{"line_number":94,"context_line":"    \"${name}/target_secondary_ip_addresses\": value \u003d\u003e $target_secondary_ip_addresses;"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  package { \u0027nvmetcli\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6c2c1619_6f9d715a","line":94,"range":{"start_line":94,"start_character":54,"end_line":94,"end_character":84},"updated":"2023-03-16 01:45:41.000000000","message":"The below logic allows you to use both string and array\n```\njoin(any2array($target_secondary_ip_addresses), \u0027,\u0027)\n```","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b8e71ac255d72f9d11421337a874a5c62913b6d3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"${name}/volume_group\":                  value \u003d\u003e $volume_group;"},{"line_number":92,"context_line":"    \"${name}/nvmeof_conn_info_version\":      value \u003d\u003e $nvmeof_conn_info_version;"},{"line_number":93,"context_line":"    \"${name}/lvm_share_target\":              value \u003d\u003e $lvm_share_target;"},{"line_number":94,"context_line":"    \"${name}/target_secondary_ip_addresses\": value \u003d\u003e $target_secondary_ip_addresses;"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  package { \u0027nvmetcli\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"af67da41_7c845743","line":94,"range":{"start_line":94,"start_character":54,"end_line":94,"end_character":84},"in_reply_to":"6c2c1619_6f9d715a","updated":"2023-03-16 09:08:45.000000000","message":"Done","commit_id":"d639c047768e7fb69aa475cd42420bd500f647b5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88cd1a43d553d574f49d7b77150c7717fe795967","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#"},{"line_number":49,"context_line":"# [*nvmeof_conn_info_version*]"},{"line_number":50,"context_line":"#   (Optional) NVMe-oF Connection Information version"},{"line_number":51,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027] (\u00271\u0027)"},{"line_number":52,"context_line":"#"},{"line_number":53,"context_line":"# [*lvm_share_target*]"},{"line_number":54,"context_line":"#   (Optional) Use shared targets or per-volume targets"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"961fcb66_1f77b553","line":51,"range":{"start_line":51,"start_character":45,"end_line":51,"end_character":50},"updated":"2023-03-16 11:02:08.000000000","message":"let\u0027s avoid documenting actual defaults here. We have had some challenges with updating the descriptions consistently and timely after any of the defaults has been updated in service side.","commit_id":"52c433bf845e855d3594dfa6e4db73429fb6b1bb"}]}