)]}'
{"manifests/backend/dellemc_powerflex.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0c88246a1684f581d2d7c9b303af1a785a0a7cd","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  $driver_ssl_cert_verify                   \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":116,"context_line":"  $driver_ssl_cert_path                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":117,"context_line":"  Boolean $manage_volume_type               \u003d false,"},{"line_number":118,"context_line":"  Hash $extra_options                       \u003d {},"},{"line_number":119,"context_line":") {"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  include cinder::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f8aca02_f75fade3","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":6},"updated":"2023-06-15 17:33:51.000000000","message":"This hasn\u0027t been validated. However adding this validation would make sense because we do the similar validation in cinder::config.","commit_id":"4d1bb7c07c02131f1d34ceb866bb203762b1982a"}],"manifests/backend/netapp.pp":[{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"1f1b676052e55dd13338e26849298fbf1b4ffdcc","unresolved":true,"context_lines":[{"line_number":181,"context_line":"  $expiry_thres_minutes               \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":182,"context_line":"  $thres_avl_size_perc_start          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":183,"context_line":"  $thres_avl_size_perc_stop           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":184,"context_line":"  Optional[Array[String]] $nfs_shares \u003d undef,"},{"line_number":185,"context_line":"  $nfs_shares_config                  \u003d \u0027/etc/cinder/shares.conf\u0027,"},{"line_number":186,"context_line":"  $nfs_mount_options                  \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":187,"context_line":"  $netapp_host_type                   \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"a29ca148_90c12813","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":23},"updated":"2023-06-15 20:36:09.000000000","message":"I think we should use String[1], since an empty string is useless.","commit_id":"4d1bb7c07c02131f1d34ceb866bb203762b1982a"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"c53c16ecfd0414a50770c6b6f78965b29a5baaf0","unresolved":true,"context_lines":[{"line_number":181,"context_line":"  $expiry_thres_minutes               \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":182,"context_line":"  $thres_avl_size_perc_start          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":183,"context_line":"  $thres_avl_size_perc_stop           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":184,"context_line":"  Optional[Array[String]] $nfs_shares \u003d undef,"},{"line_number":185,"context_line":"  $nfs_shares_config                  \u003d \u0027/etc/cinder/shares.conf\u0027,"},{"line_number":186,"context_line":"  $nfs_mount_options                  \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":187,"context_line":"  $netapp_host_type                   \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ab6537a9_fe6e4fb0","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":23},"in_reply_to":"8dd980fd_2c2e5485","updated":"2023-06-19 14:05:30.000000000","message":"In that case you need to change to Optional[Array], since checking for an Array of Strings is new ! (but I still think Optiona[Array[String[1]]] is best choice)","commit_id":"4d1bb7c07c02131f1d34ceb866bb203762b1982a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3874111c7f3743941a9ecb94252f236a6e522804","unresolved":true,"context_lines":[{"line_number":181,"context_line":"  $expiry_thres_minutes               \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":182,"context_line":"  $thres_avl_size_perc_start          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":183,"context_line":"  $thres_avl_size_perc_stop           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":184,"context_line":"  Optional[Array[String]] $nfs_shares \u003d undef,"},{"line_number":185,"context_line":"  $nfs_shares_config                  \u003d \u0027/etc/cinder/shares.conf\u0027,"},{"line_number":186,"context_line":"  $nfs_mount_options                  \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":187,"context_line":"  $netapp_host_type                   \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"8dd980fd_2c2e5485","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":23},"in_reply_to":"a29ca148_90c12813","updated":"2023-06-19 13:52:26.000000000","message":"I agree an empty string isn\u0027t a valid nfs share, but the goal of this patch (and similar ones in other puppet-openstack projects) is to remove uses of the validate_legacy function. It\u0027s not feasible to validate every aspect of the $nfs_shares parameter (do we test for special characters? what about \u0027 \u0027?).","commit_id":"4d1bb7c07c02131f1d34ceb866bb203762b1982a"}],"manifests/backend/nfs.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d0c88246a1684f581d2d7c9b303af1a785a0a7cd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"define cinder::backend::nfs ("},{"line_number":93,"context_line":"  $volume_backend_name         \u003d $name,"},{"line_number":94,"context_line":"  $backend_availability_zone   \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":95,"context_line":"  Array[String] $nfs_servers   \u003d [],"},{"line_number":96,"context_line":"  $nfs_mount_attempts          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":97,"context_line":"  $nfs_mount_options           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":98,"context_line":"  $nfs_sparsed_volumes         \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"64ec1332_be57d682","line":95,"range":{"start_line":95,"start_character":2,"end_line":95,"end_character":15},"updated":"2023-06-15 17:33:51.000000000","message":"this was added following `cinder::backend::netapp`","commit_id":"4d1bb7c07c02131f1d34ceb866bb203762b1982a"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"1f1b676052e55dd13338e26849298fbf1b4ffdcc","unresolved":true,"context_lines":[{"line_number":92,"context_line":"define cinder::backend::nfs ("},{"line_number":93,"context_line":"  $volume_backend_name         \u003d $name,"},{"line_number":94,"context_line":"  $backend_availability_zone   \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":95,"context_line":"  Array[String] $nfs_servers   \u003d [],"},{"line_number":96,"context_line":"  $nfs_mount_attempts          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":97,"context_line":"  $nfs_mount_options           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":98,"context_line":"  $nfs_sparsed_volumes         \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5be9d89b_2a0caf79","line":95,"updated":"2023-06-15 20:36:09.000000000","message":"use String[1] seems better.","commit_id":"4d1bb7c07c02131f1d34ceb866bb203762b1982a"}]}