)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"1d31a0e5756219239725d335d3c796bf7bc68625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"90e018fd_e281f48d","updated":"2024-10-10 11:42:26.000000000","message":"nice, thanks Takashi! I\u0027ll just +2 and not +w so that Alex can give any feedback on the final approach.","commit_id":"b0957ff6a689c6cd7b000659adadb56f27ea958b"}],"manifests/keystone/auth.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6b1e5b1122236d6bad81245cb1b7f18c6b3e62fa","unresolved":true,"context_lines":[{"line_number":155,"context_line":"  Keystone::PublicEndpointUrl $public_url_v3 \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":156,"context_line":"  Keystone::EndpointUrl $internal_url_v3     \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":157,"context_line":"  Keystone::EndpointUrl $admin_url_v3        \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":158,"context_line":"  Boolean $configure_endpoint_current        \u003d true,"},{"line_number":159,"context_line":"  Boolean $configure_endpoint_v3             \u003d true,"},{"line_number":160,"context_line":"  Boolean $configure_user                    \u003d true,"},{"line_number":161,"context_line":"  Boolean $configure_user_role               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e77da09c_1013c5e9","line":158,"updated":"2024-10-09 14:23:55.000000000","message":"I feel the \"_current\" suffix is somewhat confusing, meaning it may create confusion rather than helping prevent it. \"_latest\" is slightly better, but what if we drop it entirely? I think that would be consistent with openstack-discuss thread.","commit_id":"ee30b3a03ec3308d682cfdd03a81caa620d35fe0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a3dfc0e4a8fec6d4a571164ca1e639c850560fcd","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  Keystone::PublicEndpointUrl $public_url_v3 \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":156,"context_line":"  Keystone::EndpointUrl $internal_url_v3     \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":157,"context_line":"  Keystone::EndpointUrl $admin_url_v3        \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":158,"context_line":"  Boolean $configure_endpoint_current        \u003d true,"},{"line_number":159,"context_line":"  Boolean $configure_endpoint_v3             \u003d true,"},{"line_number":160,"context_line":"  Boolean $configure_user                    \u003d true,"},{"line_number":161,"context_line":"  Boolean $configure_user_role               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"b6af7006_981ec0f6","line":158,"in_reply_to":"e5e626ee_c8eeed52","updated":"2024-10-09 14:38:10.000000000","message":"I dropped the _current suffix and used the plain configure_endpoint. Let\u0027s see how this works.","commit_id":"ee30b3a03ec3308d682cfdd03a81caa620d35fe0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1512311f6c0ab59c7ae238eb5bab4fd06d4875bc","unresolved":true,"context_lines":[{"line_number":155,"context_line":"  Keystone::PublicEndpointUrl $public_url_v3 \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":156,"context_line":"  Keystone::EndpointUrl $internal_url_v3     \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":157,"context_line":"  Keystone::EndpointUrl $admin_url_v3        \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":158,"context_line":"  Boolean $configure_endpoint_current        \u003d true,"},{"line_number":159,"context_line":"  Boolean $configure_endpoint_v3             \u003d true,"},{"line_number":160,"context_line":"  Boolean $configure_user                    \u003d true,"},{"line_number":161,"context_line":"  Boolean $configure_user_role               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1c39ffe3_eed8c548","line":158,"in_reply_to":"e77da09c_1013c5e9","updated":"2024-10-09 14:30:21.000000000","message":"I first drafted the change without version suffix but decided to add _current becaise the same approach does not work for puppet-manila. However now I got an idea about the thing we can do for puppet-manila so maybe we don\u0027t have to be bothered by it.\n\nLet me update the change.","commit_id":"ee30b3a03ec3308d682cfdd03a81caa620d35fe0"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"63816a7d8b430037f2a422fe931b70d416fa8142","unresolved":true,"context_lines":[{"line_number":155,"context_line":"  Keystone::PublicEndpointUrl $public_url_v3 \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":156,"context_line":"  Keystone::EndpointUrl $internal_url_v3     \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":157,"context_line":"  Keystone::EndpointUrl $admin_url_v3        \u003d \u0027http://127.0.0.1:8776/v3\u0027,"},{"line_number":158,"context_line":"  Boolean $configure_endpoint_current        \u003d true,"},{"line_number":159,"context_line":"  Boolean $configure_endpoint_v3             \u003d true,"},{"line_number":160,"context_line":"  Boolean $configure_user                    \u003d true,"},{"line_number":161,"context_line":"  Boolean $configure_user_role               \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e5e626ee_c8eeed52","line":158,"in_reply_to":"e77da09c_1013c5e9","updated":"2024-10-09 14:30:49.000000000","message":"or just drop _current entirely and use configure_endpoint etc again, must have been a long time since we had configure_endpoint that supported cinder v1 (or v2?) and we could reintroduce that again?\n\nwould spare us deprecating configure_endpoint_(current|latest) if we ever want to consolidate in the future\n\njust my 2cents, im fine with either approach+naming","commit_id":"ee30b3a03ec3308d682cfdd03a81caa620d35fe0"}]}