)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"47d305a6b50c78854fb93fb7ec8d681980e47d2c","unresolved":true,"context_lines":[{"line_number":213,"context_line":"    internal_url        \u003d\u003e $internal_url_v3,"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  keystone::resource::service_identity { \u0027cinderv3\u0027:"},{"line_number":217,"context_line":"    configure_user      \u003d\u003e $configure_user_v3,"},{"line_number":218,"context_line":"    configure_user_role \u003d\u003e $configure_user_role_v3,"},{"line_number":219,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint_v3,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4abbeff4_8d3f3182","side":"PARENT","line":216,"updated":"2025-04-17 19:49:04.000000000","message":"Based on the earlier commit message [1] I expected L216..L235 to be eliminated. Was my initial understanding incorrect?\n\n[1] https://review.opendev.org/c/openstack/puppet-cinder/+/929545/2//COMMIT_MSG","commit_id":"0dd0973d44b8b1beb00fceb57c82e4c0d34b319b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"00d0288d0aa895a9d6a7aafe5846aa98c818f4eb","unresolved":true,"context_lines":[{"line_number":213,"context_line":"    internal_url        \u003d\u003e $internal_url_v3,"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  keystone::resource::service_identity { \u0027cinderv3\u0027:"},{"line_number":217,"context_line":"    configure_user      \u003d\u003e $configure_user_v3,"},{"line_number":218,"context_line":"    configure_user_role \u003d\u003e $configure_user_role_v3,"},{"line_number":219,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint_v3,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"d38e53cf_951e83b3","side":"PARENT","line":216,"in_reply_to":"4abbeff4_8d3f3182","updated":"2025-04-18 01:25:30.000000000","message":"This should still be kept to create an endpoint with the volumev3 service type. What I intended to deprecate at that time is only management of the cinderv3 keystone user and its project and roles.\n\nWe can probably deprecate/remove the volumev3 service type assuming block-storage service type is enough (we were unsure about that when we added the block-storage service type) but that should be done separately, I think.","commit_id":"0dd0973d44b8b1beb00fceb57c82e4c0d34b319b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2b8df984d9e9b36e5db86be44359cc11063fd909","unresolved":true,"context_lines":[{"line_number":213,"context_line":"    internal_url        \u003d\u003e $internal_url_v3,"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  keystone::resource::service_identity { \u0027cinderv3\u0027:"},{"line_number":217,"context_line":"    configure_user      \u003d\u003e $configure_user_v3,"},{"line_number":218,"context_line":"    configure_user_role \u003d\u003e $configure_user_role_v3,"},{"line_number":219,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint_v3,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"d8ad4049_9a728337","side":"PARENT","line":216,"in_reply_to":"d38e53cf_951e83b3","updated":"2025-04-20 19:24:02.000000000","message":"OK, that makes sense now. Thank you for the explanation!","commit_id":"0dd0973d44b8b1beb00fceb57c82e4c0d34b319b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9e035888b28f75475fa786766d4f79ff73f52100","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    internal_url        \u003d\u003e $internal_url_v3,"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  keystone::resource::service_identity { \u0027cinderv3\u0027:"},{"line_number":217,"context_line":"    configure_user      \u003d\u003e $configure_user_v3,"},{"line_number":218,"context_line":"    configure_user_role \u003d\u003e $configure_user_role_v3,"},{"line_number":219,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint_v3,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"0d361895_8e437166","side":"PARENT","line":216,"in_reply_to":"d8ad4049_9a728337","updated":"2025-04-21 02:57:44.000000000","message":"Done","commit_id":"0dd0973d44b8b1beb00fceb57c82e4c0d34b319b"}]}