)]}'
{"manifests/params.pp":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"348ccb69013027ac4016d02cc411735b01d9e31d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  case $::osfamily {"},{"line_number":8,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":9,"context_line":"    # package names"},{"line_number":10,"context_line":"    $api_package_name \u003d \u0027openstack-cloudkitty-api\u0027"},{"line_number":11,"context_line":"    $processor_package_name \u003d \u0027openstack-cloudkitty-processor\u0027"},{"line_number":12,"context_line":"    $ui_package_name \u003d \u0027openstack-cloudkitty-ui\u0027"},{"line_number":13,"context_line":"    $common_package_name \u003d \u0027openstack-cloudkitty-common\u0027"},{"line_number":14,"context_line":"    $client_package_name \u003d \u0027python-cloudkittyclient\u0027"},{"line_number":15,"context_line":"    # service names"},{"line_number":16,"context_line":"    $api_service_name \u003d \u0027cloudkitty-api\u0027"},{"line_number":17,"context_line":"    $processor_service_name \u003d \u0027cloudkitty-processor\u0027"},{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":"    \u0027Debian\u0027: {"},{"line_number":20,"context_line":"    # package names"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5da102_f17bf8bb","line":17,"range":{"start_line":10,"start_character":3,"end_line":17,"end_character":52},"updated":"2016-11-03 09:21:20.000000000","message":"Alignment is better :)","commit_id":"8ea62034f672a2fdbf58945c6ac223a2110cdaf6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d4819869fc04008405769679119959ac9c9b57c2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    $client_package_name \u003d \u0027python-cloudkittyclient\u0027"},{"line_number":15,"context_line":"    # service names"},{"line_number":16,"context_line":"    $api_service_name \u003d \u0027cloudkitty-api\u0027"},{"line_number":17,"context_line":"    $processor_service_name \u003d \u0027cloudkitty-processor\u0027"},{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":"    \u0027Debian\u0027: {"},{"line_number":20,"context_line":"    # package names"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5da102_56572557","line":17,"updated":"2016-11-03 15:48:52.000000000","message":"While it\u0027s  not exactly a hard fast rule, it is something that we do for consistency and readability within the openstack modules. please consider aligning these to match the other modules. For example,\nhttps://github.com/openstack/puppet-nova/blob/master/manifests/params.pp\nhttps://github.com/openstack/puppet-glance/blob/master/manifests/params.pp\nhttps://github.com/openstack/puppet-barbican/blob/master/manifests/params.pp\nhttps://github.com/openstack/puppet-swift/blob/master/manifests/params.pp","commit_id":"8ea62034f672a2fdbf58945c6ac223a2110cdaf6"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"0b051522ff7f82e1175efcfd7173662e5a74071b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    $client_package_name \u003d \u0027python-cloudkittyclient\u0027"},{"line_number":15,"context_line":"    # service names"},{"line_number":16,"context_line":"    $api_service_name \u003d \u0027cloudkitty-api\u0027"},{"line_number":17,"context_line":"    $processor_service_name \u003d \u0027cloudkitty-processor\u0027"},{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":"    \u0027Debian\u0027: {"},{"line_number":20,"context_line":"    # package names"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5da102_a7accd8c","line":17,"in_reply_to":"ba5da102_56572557","updated":"2016-11-03 16:47:51.000000000","message":"OK，I will update this fortmat. \nbtw,when I write this manifest, I take https://github.com/openstack/puppet-heat/blob/master/manifests/params.pp for refer.\nReally a bad example :)","commit_id":"8ea62034f672a2fdbf58945c6ac223a2110cdaf6"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"a9382414ba95b74dd836b204bd45f140ccb446e3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  case $::osfamily {"},{"line_number":8,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":9,"context_line":"    # package names"},{"line_number":10,"context_line":"    $api_package_name \u003d \u0027openstack-cloudkitty-api\u0027"},{"line_number":11,"context_line":"    $processor_package_name \u003d \u0027openstack-cloudkitty-processor\u0027"},{"line_number":12,"context_line":"    $ui_package_name \u003d \u0027openstack-cloudkitty-ui\u0027"},{"line_number":13,"context_line":"    $common_package_name \u003d \u0027openstack-cloudkitty-common\u0027"},{"line_number":14,"context_line":"    $client_package_name \u003d \u0027python-cloudkittyclient\u0027"},{"line_number":15,"context_line":"    # service names"},{"line_number":16,"context_line":"    $api_service_name \u003d \u0027cloudkitty-api\u0027"},{"line_number":17,"context_line":"    $processor_service_name \u003d \u0027cloudkitty-processor\u0027"},{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":"    \u0027Debian\u0027: {"},{"line_number":20,"context_line":"    # package names"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5da102_1c66c329","line":17,"range":{"start_line":10,"start_character":3,"end_line":17,"end_character":52},"in_reply_to":"ba5da102_f17bf8bb","updated":"2016-11-03 10:00:04.000000000","message":"according to http://puppet-lint.com/checks and https://docs.puppet.com/guides/style_guide.html, puppet only suggest about arrow alignment, not equal alignment.\n\nPlease let me know if I miss some other puppet style.","commit_id":"8ea62034f672a2fdbf58945c6ac223a2110cdaf6"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"348ccb69013027ac4016d02cc411735b01d9e31d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    }"},{"line_number":19,"context_line":"    \u0027Debian\u0027: {"},{"line_number":20,"context_line":"    # package names"},{"line_number":21,"context_line":"    $api_package_name \u003d \u0027cloudkitty-api\u0027"},{"line_number":22,"context_line":"    $processor_package_name \u003d \u0027cloudkitty-processor\u0027"},{"line_number":23,"context_line":"    $ui_package_name \u003d \u0027cloudkitty-dashboard\u0027"},{"line_number":24,"context_line":"    $common_package_name \u003d \u0027cloudkitty-common\u0027"},{"line_number":25,"context_line":"    $client_package_name \u003d \u0027python-cloudkittyclient\u0027"},{"line_number":26,"context_line":"    # service names"},{"line_number":27,"context_line":"    $api_service_name \u003d \u0027cloudkitty-api\u0027"},{"line_number":28,"context_line":"    $processor_service_name \u003d \u0027cloudkitty-processor\u0027"},{"line_number":29,"context_line":"    }"},{"line_number":30,"context_line":"    default: {"},{"line_number":31,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba5da102_9161dc07","line":28,"range":{"start_line":21,"start_character":2,"end_line":28,"end_character":52},"updated":"2016-11-03 09:21:20.000000000","message":"same","commit_id":"8ea62034f672a2fdbf58945c6ac223a2110cdaf6"}]}
