)]}'
{"manifests/api.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b6ee56fa8754494475402dbb37a28b52db06aefe","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # we need to make sure cloudkitty-api/eventlet is stopped before trying to start apache"},{"line_number":88,"context_line":"    Service[\u0027cloudkitty-api\u0027] -\u003e Service[$service_name]"},{"line_number":89,"context_line":"  } elsif $service_name \u003d\u003d $::cloudkitty::params::api_service_name {"},{"line_number":90,"context_line":"    service { \u0027cloudkitty-api\u0027:"},{"line_number":91,"context_line":"      enable     \u003d\u003e $enabled,"},{"line_number":92,"context_line":"      name       \u003d\u003e \u0027cloudkitty-api\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f493fa4_33e65cea","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":66},"updated":"2020-05-05 03:49:23.000000000","message":"Can you move this before \u0027$service_name \u003d\u003d \u0027httpd\u0027\u0027 so that the order is consistent with the other modules ?\n\nhttps://github.com/openstack/puppet-cinder/blob/master/manifests/api.pp#L204-L228\nhttps://github.com/openstack/puppet-heat/blob/master/manifests/api.pp#L99-L123","commit_id":"eeb5b4f76422c064f5c727fb6093df001f6bf19b"}],"spec/classes/cloudkitty_api_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a84f3417ac60b20bf03550b8094afa3853215c76","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        params.merge!({ :service_name \u003d\u003e \u0027httpd\u0027 })"},{"line_number":45,"context_line":"      end"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      let :pre_condition do"},{"line_number":48,"context_line":"        \"include apache"},{"line_number":49,"context_line":"         class { \u0027cloudkitty\u0027: }"},{"line_number":50,"context_line":"         class { \u0027cloudkitty::keystone::authtoken\u0027:"},{"line_number":51,"context_line":"           password \u003d\u003e \u0027foo\u0027,"},{"line_number":52,"context_line":"         }\""},{"line_number":53,"context_line":"      end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      it \u0027configures cloudkitty-api service with Apache\u0027 do"},{"line_number":56,"context_line":"        is_expected.to contain_service(\u0027cloudkitty-api\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ff570b3c_da7c7a22","line":53,"range":{"start_line":47,"start_character":0,"end_line":53,"end_character":9},"updated":"2020-05-10 12:13:53.000000000","message":"We don\u0027t need this because we already have the same in bese (L13-20)","commit_id":"09cd7cad88d84d8f325440e3db8307add55fc3bd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f1070a5e150b16e2b7261f3a6fd44a967c539307","unresolved":false,"context_lines":[{"line_number":52,"context_line":"         }\""},{"line_number":53,"context_line":"      end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"      it \u0027configures cloudkitty-api service with Apache\u0027 do"},{"line_number":56,"context_line":"        is_expected.to contain_service(\u0027cloudkitty-api\u0027).with("},{"line_number":57,"context_line":"          :ensure \u003d\u003e \u0027stopped\u0027,"},{"line_number":58,"context_line":"          :name   \u003d\u003e platform_params[:api_service_name],"},{"line_number":59,"context_line":"          :enable \u003d\u003e false,"},{"line_number":60,"context_line":"          :tag    \u003d\u003e \u0027cloudkitty-service\u0027,"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"      end"},{"line_number":63,"context_line":"    end"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    context \u0027when service_name is not valid\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"ff570b3c_ba9ee651","line":62,"range":{"start_line":55,"start_character":0,"end_line":62,"end_character":9},"updated":"2020-05-10 12:23:40.000000000","message":"Also, the test case for standalone service pattern is not added.","commit_id":"09cd7cad88d84d8f325440e3db8307add55fc3bd"}]}
