)]}'
{"manifests/init.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"675f7c00a3ab1dae9acc1b7bc2476a5bc9f8c54e","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    password               \u003d\u003e $amqp_password,"},{"line_number":357,"context_line":"  }"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"  oslo::middleware {\u0027cloudkitty_config\u0027:"},{"line_number":360,"context_line":"    enable_proxy_headers_parsing \u003d\u003e $enable_proxy_headers_parsing,"},{"line_number":361,"context_line":"  }"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf51134e_601fa6b6","line":359,"updated":"2020-07-15 15:06:30.000000000","message":"nit: spacing","commit_id":"10c8efa756d8cceeedf72cc0090cfbf5f28faf80"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ef1f6d19ae108e131589a90594b1154fcf481d61","unresolved":false,"context_lines":[{"line_number":289,"context_line":"  $rpc_response_timeout               \u003d $::os_service_default,"},{"line_number":290,"context_line":"  $control_exchange                   \u003d $::os_service_default,"},{"line_number":291,"context_line":"  $notification_transport_url         \u003d $::os_service_default,"},{"line_number":292,"context_line":"  $enable_proxy_headers_parsing       \u003d $::os_service_default,"},{"line_number":293,"context_line":"  $purge_config                       \u003d false,"},{"line_number":294,"context_line":"  $auth_strategy                      \u003d \u0027keystone\u0027,"},{"line_number":295,"context_line":"  $api_paste_config                   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f560f44_136a24b2","line":292,"range":{"start_line":292,"start_character":2,"end_line":292,"end_character":62},"updated":"2020-07-29 13:09:27.000000000","message":"Also, I think it makes more sense to implement this in  cloudkitty::api class instead of cloudkitty class, because this parameter is used only in api, IIUC.","commit_id":"387833868ee5f512e1442d870ba15263eca0c354"}],"spec/classes/cloudkitty_init_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1b40265ed7c842fa641903db99ddf50378858d52","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      end"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"      it \u0027configures enable_proxy_headers_parsing\u0027 do"},{"line_number":39,"context_line":"        is_expected.to contain_cloudkitty_config(\u0027oslo_middleware/enable_proxy_headers_parsing\u0027).with_value(\u0027absent\u0027)"},{"line_number":40,"context_line":"      end"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"      it \u0027passes purge to resource\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f560f44_33180874","line":39,"range":{"start_line":39,"start_character":97,"end_line":39,"end_character":107},"updated":"2020-07-29 13:07:09.000000000","message":"This should be with_ensure, and this seems to be the reason why unit tests are failing.\n\nAlso, I prefer testing parameters passed to oslo:middleware class, rather than testing actual parameters, like [1]\n[1] https://github.com/openstack/puppet-nova/blob/master/spec/classes/nova_api_spec.rb#L57-L60\nThis helps us avoid unexpected test failures caused by change in puppet-oslo.","commit_id":"387833868ee5f512e1442d870ba15263eca0c354"}]}