)]}'
{"id":"openstack%2Fpuppet-cloudkitty~755084","triplet_id":"openstack%2Fpuppet-cloudkitty~master~I54ed638d868541affe8f29551f52f7b09d13a090","project":"openstack/puppet-cloudkitty","branch":"master","topic":"fix_wsgi_source_path","hashtags":[],"change_id":"I54ed638d868541affe8f29551f52f7b09d13a090","subject":"add parameter to specify wsgi script source and path","status":"ABANDONED","created":"2020-09-29 16:31:20.000000000","updated":"2022-05-15 23:27:39.000000000","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"66977794932ed039d05727b503dd2f9e02e3ab1b","_number":755084,"virtual_id_number":755084,"owner":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-10-14 10:09:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"date":"2020-10-23 17:47:02.000000000","_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-10-14 09:45:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":-1,"date":"2020-10-14 09:45:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-03 13:32:07.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-10-03 13:32:21.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-10-03 13:32:25.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2020-10-03 15:04:04.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2020-10-04 15:39:02.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2020-10-14 10:09:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5f71620be05b42f34c08dfb5b5fe88aa1560928a","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-09-29 16:31:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"15703d30c5a774f658c1a5cb267f654e4c03c984","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-29 17:30:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9d1150b1582d40bfab34d317bc4ff9b2 : SUCCESS in 3m 49s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/18001d3f9d7a43b0b5226e3886f6bcf3 : SUCCESS in 3m 46s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/1009dc86d7c9475397e1561d4866b263 : SUCCESS in 12m 03s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9f2e1ea03d9349f6946fa1e7cd15cfb3 : SUCCESS in 8m 31s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/fcbd8d713ebc41f2a82f4f1fda338dff : SUCCESS in 8m 26s (non-voting)\n- puppet-openstack-litmus-centos-8 https://zuul.opendev.org/t/openstack/build/925fc6b3cb0a4fc386280f23673385e3 : SUCCESS in 17m 33s\n- puppet-openstack-litmus-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bf149b7e63f341618a85a6a323a601b2 : SUCCESS in 12m 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"23fdefd3968b7bf3525a871a8220394fc4b006d5","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-09-29 23:44:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nPlease find my comment inline.\nAlso, could you add a release note about the new parameter ?","accounts_in_message":[],"_revision_number":1},{"id":"095a5b76e52a2ca5cb1821d864d938f88b18ccc8","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-09-29 23:59:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1f4996097b4590604089f06617d7513551db2756","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-09-30 00:09:20.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nwill add release notes ....","accounts_in_message":[],"_revision_number":1},{"id":"2c2a6b1e74df469efad5ac2ee4035e45ff9b5b43","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-09-30 00:27:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ddb6e035bc89ac95e2884a3da3964c293dd6a7bb","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-09-30 07:52:45.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"24c219149100ed8e184fb921142ffe7939c0f029","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-10-02 14:36:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"614db5c409b7cc54dd5897a325c64f0a78ca68a0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-02 15:01:00.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d9c287c43df24b10a04105ffcd8b3645 : SUCCESS in 3m 09s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/46e30348261241c28654b9707d6049a7 : SUCCESS in 3m 33s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/d5649d90ec484956ac22c80e6f5d03dc : FAILURE in 17m 10s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9f9178ec3ae24909bdcfcf0b4fc61d9b : FAILURE in 8m 08s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4bc77cd5c5f94e00afa56cf3de96695e : FAILURE in 10m 30s (non-voting)\n- puppet-openstack-litmus-centos-8 https://zuul.opendev.org/t/openstack/build/130335ceeab2464d9318aeb1584f0d20 : SUCCESS in 20m 41s\n- puppet-openstack-litmus-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e67577719bac4082ad286c88d7fdcafd : SUCCESS in 14m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e312b2610ccc29b659aa6bf9841b2218b7623653","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-10-02 15:47:34.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5d728911cbe8e27d31d2516864b795d39779643d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-02 16:17:08.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/48dabe7aa48f416aaa17805c75042b52 : SUCCESS in 3m 14s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2d2ddfbcd8f5442d9e758f32a72ae726 : SUCCESS in 5m 54s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/cc504c79a7de41fcb1ee90587720fb0d : SUCCESS in 12m 55s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/27bc1f062c36418ab7dda39608a531ec : SUCCESS in 7m 56s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8b98ba1d0bcb4e6c9cd4192496b04567 : SUCCESS in 9m 34s (non-voting)\n- puppet-openstack-litmus-centos-8 https://zuul.opendev.org/t/openstack/build/91910159e41f46fdbd6648359c0a42db : SUCCESS in 18m 34s\n- puppet-openstack-litmus-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5cb2a6b1d8a94978a321c97bf0035919 : SUCCESS in 20m 29s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"25688d3163bf6d8b81e3dda5960b746a6d310adb","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-10-03 11:29:39.000000000","message":"Patch Set 3: Code-Review+2\n\nI do agree that it\u0027s always better to follow the latest style. However the reality here is that we still have plenty of old style codes in puppet-openstack, and we have a lot remaining works to switch to \"modern\" style. For example you see that most of the module doesn\u0027t implement class validation. \n\nWe can get rid of all inheritances (and also re-implement them by bindings), but that switch should happen at the same time in all modules, otherwise inconsistent implementations among multiple modules can cause difficulties in the maintenance of each modules.\n\nLet\u0027s move this patch in the current status, but we definitely need to look into the other modules to make their implementation consistent with the modern implementation implemented only in a single module.","accounts_in_message":[],"_revision_number":3},{"id":"34010d259fc7ed32945457a5024998a2a5bec318","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-10-03 11:30:12.000000000","message":"Patch Set 3:\n\ns/class validation/type validation/\n\nsorry for the noise...","accounts_in_message":[],"_revision_number":3},{"id":"a14b98db69d66892529d821e1995ef800d349609","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-10-03 12:51:31.000000000","message":"Patch Set 3:\n\nWell, I disagree, that the changes towards a \u0027modern\u0027 style have to be done all in the same time. I strongly think we should start even if we cannot change everything at once. If I have a look at the puppet modules used in my installation, I have old modules (used in puppet 2.6 ...) and modern ones using hiera, type validation etc. and even modules, that have several styles in the same module. \n\nI think we do not have the power to do all modules at once. So just start in the right direction would make it. Which means I would have preferred to implement this patch using hiera although other defaults are defined in params.pp.\nThis would have been a fist step to go on.\n\nBut anyway, let\u0027s merge the patch now as it is and see if we switch the modules in the far or short future ;)\n\nAnd btw. I used typed parameters in the new classes just added in the last days (some already merged, some awaiting to be merged) ;)","accounts_in_message":[],"_revision_number":3},{"id":"628f5ab33cfebf7f8ea55cd1ba7d6c428dced559","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-10-03 13:29:26.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)\n\nI know what you say, but I\u0027d like to let you know that I personally experienced some problems caused by inconsistencies between modules, especially when dealing with the change which required common fix in all modules. I agree that we should make any progress to go beyond current status, but we still need careful consideration to make \"proper\" direction which we can follow in the other modules.\n\nBy the way after considering the way how we can implement this in hieradata later, I noticed one concerns possibly caused by current implementation. Please find my comment inline. I\u0027ll reduce my review score for the moment to attract some attention from you as well as the other reviewers. Since this might unexpectedly affect the next proper step we will take in short or long term","accounts_in_message":[],"_revision_number":3},{"id":"99975efbed5b669d9f0788d2a5d96df37106af85","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-10-03 14:34:49.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nI strongly do not agree with class inheritance like you did in the mentioned patch (since it\u0027s already merged I cannot -1;().\n\nIf there is a common sense to go towards hiera for default values and type specified parameters, I\u0027m happy to do so.","accounts_in_message":[],"_revision_number":3},{"id":"ff31096e3f7222b1a6229c7d429e4921de5305ad","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-10-03 15:04:04.000000000","message":"Patch Set 3: -Code-Review\n\nLet me summarize current thought about this change.\n\n- The default value for wsgi_script_source and wsgi_script_dir should be implemented as a defaults depending on platform, as we implement these 2 in params.pp in other modules like puppet-aodh.\n\n- If we use params.pp, IMO we can use class inheritance, to avoid undesireble usage of \"undef\". I know class inheritance has been discouraged for a long, but it is still \"consistent\" usage regarding the fact we still use params.pp .\n\n- To implement this in \"modern\" way, we should use hieradata. It is really nice and cool, however we shouldn\u0027t merge that change in V cycle, which will be released soon. The change can be merged in W in the earliest.\n\n- I prefer to replace all usage of params.pp by hieradata at least in puppet-cloudkilly if we start switching to hieradata, otherwise we should look at two places to maintain values depending on platforms.","accounts_in_message":[],"_revision_number":3},{"id":"85134bb2399b5b1f6e91f5b0c230a17da447bedb","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-10-04 15:39:02.000000000","message":"Patch Set 3: Code-Review-1\n\nMoving to hieradata is definitely something we\u0027d like to do in Wallaby or later just somebody needs to take charge on the effort and make sure all modules is converted in the long term.\n\nApart from that, I\u0027d rather see that we use the old params behavior than sticking pick() calls everywhere since I\u0027d ease the transition and is much cleaner.\n\nAnother problem I see is that we are renaming variables in the params class with this change, unfortunately the params class should be seen as something that is exposed to the end-user since we never finished the assert_private() enforcement in the params classes which were suppose to be a step to make sure it\u0027s isn\u0027t used by end users so that the change to hieradata would have been smoother.\n\nSo we\u0027d need a release note for anything that affects the end user consuming this module.","accounts_in_message":[],"_revision_number":3},{"id":"4a410b77494d33ef7e15bdf01f635fd70ef328bd","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-10-04 16:33:21.000000000","message":"Patch Set 3:\n\n@Tobias: \"Apart from that ...\"\nDoes this mean you better like to have a class inheritance than the pick statement ?","accounts_in_message":[],"_revision_number":3},{"id":"88857e4476a975982b620462f8f2b239adf5958f","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-10-14 09:45:21.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"ba087134736d21f87cb94ec2b43defa648ca8f5d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-14 10:09:58.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/50a923117ac14f1b99bbc69a5d612184 : SUCCESS in 3m 48s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c4fc3ee6c05e4ba7baf5b50e93fc87b9 : SUCCESS in 3m 44s\n- puppet-openstack-unit-6.14-centos-8 https://zuul.opendev.org/t/openstack/build/efa53187923f4a52ac98d02c9dcf8acd : SUCCESS in 14m 17s\n- puppet-openstack-unit-6.14-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b9f915548d9340d39704868b0d481fd8 : SUCCESS in 9m 07s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3892814e52814b538d5c2727121f90c3 : SUCCESS in 8m 47s (non-voting)\n- puppet-openstack-litmus-centos-8 https://zuul.opendev.org/t/openstack/build/c0403868995c4f4a98a3395e0369720d : SUCCESS in 18m 14s\n- puppet-openstack-litmus-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4ef5fa54cfd34058afafaa3b14527eac : SUCCESS in 12m 19s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"e903bd7a3a0ac487eba9f57628bd229cdef0780c","author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"date":"2020-10-23 17:47:02.000000000","message":"Patch Set 4:\n\nJust pushed a commit with a similar goal but using hiera: https://review.opendev.org/#/c/759496\nIt\u0027s up to you to decide which approach you like better !","accounts_in_message":[],"_revision_number":4},{"id":"66977794932ed039d05727b503dd2f9e02e3ab1b","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-05-15 23:27:39.000000000","message":"Abandoned\n\nI\u0027ll abandon this patch because it has been inactive for \u003e1 year. Please feel free to reopen it if you resume your work.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e7dba7070f89a7908541f8252152c9c244d260a6","revisions":{"2b3acda88a680296a705a3536bb0e7de6687f778":{"kind":"REWORK","_number":1,"created":"2020-09-29 16:31:20.000000000","uploader":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"ref":"refs/changes/84/755084/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cloudkitty","ref":"refs/changes/84/755084/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/1"}}},"commit":{"parents":[{"commit":"cde689da6e32573ac70ea702f5060d2ee4c6e0d8","subject":"Prepare Victoria RC1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/cde689da6e32573ac70ea702f5060d2ee4c6e0d8"}]}],"author":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2020-09-29 16:30:30.000000000","tz":120},"committer":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2020-09-29 16:30:30.000000000","tz":120},"subject":"add parameter to specify wsgi script source","message":"add parameter to specify wsgi script source\n\nChange-Id: I54ed638d868541affe8f29551f52f7b09d13a090\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/2b3acda88a680296a705a3536bb0e7de6687f778"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/2b3acda88a680296a705a3536bb0e7de6687f778"}]},"branch":"refs/heads/master"},"2a4a2a7bf4d14446ee443c5f7ba111da89b45b54":{"kind":"REWORK","_number":2,"created":"2020-10-02 14:36:34.000000000","uploader":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"ref":"refs/changes/84/755084/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cloudkitty","ref":"refs/changes/84/755084/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/2"}}},"commit":{"parents":[{"commit":"8556da0c4d24d1b0fedfd91b430593b7006eb816","subject":"add class to configure influxdb storage configuration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/8556da0c4d24d1b0fedfd91b430593b7006eb816"}]}],"author":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2020-09-29 16:30:30.000000000","tz":120},"committer":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2020-10-02 14:35:51.000000000","tz":120},"subject":"add parameter to specify wsgi script source and path","message":"add parameter to specify wsgi script source and path\n\nChange-Id: I54ed638d868541affe8f29551f52f7b09d13a090\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/2a4a2a7bf4d14446ee443c5f7ba111da89b45b54"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/2a4a2a7bf4d14446ee443c5f7ba111da89b45b54"}]},"branch":"refs/heads/master"},"e06c3b590faf2479e8f863940a24b923964dce5a":{"kind":"REWORK","_number":3,"created":"2020-10-02 15:47:34.000000000","uploader":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"ref":"refs/changes/84/755084/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cloudkitty","ref":"refs/changes/84/755084/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/3"}}},"commit":{"parents":[{"commit":"8556da0c4d24d1b0fedfd91b430593b7006eb816","subject":"add class to configure influxdb storage configuration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/8556da0c4d24d1b0fedfd91b430593b7006eb816"}]}],"author":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2020-09-29 16:30:30.000000000","tz":120},"committer":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2020-10-02 15:46:54.000000000","tz":120},"subject":"add parameter to specify wsgi script source and path","message":"add parameter to specify wsgi script source and path\n\nChange-Id: I54ed638d868541affe8f29551f52f7b09d13a090\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/e06c3b590faf2479e8f863940a24b923964dce5a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/e06c3b590faf2479e8f863940a24b923964dce5a"}]},"branch":"refs/heads/master"},"e7dba7070f89a7908541f8252152c9c244d260a6":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2020-10-14 09:45:21.000000000","uploader":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"ref":"refs/changes/84/755084/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-cloudkitty","ref":"refs/changes/84/755084/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-cloudkitty refs/changes/84/755084/4"}}},"commit":{"parents":[{"commit":"e62b7159912619eadc9c270410b008165efe39d0","subject":"Merge \"Add parameter to configure metrics.yml file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/e62b7159912619eadc9c270410b008165efe39d0"}]}],"author":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2020-09-29 16:30:30.000000000","tz":120},"committer":{"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","date":"2020-10-14 09:42:50.000000000","tz":120},"subject":"add parameter to specify wsgi script source and path","message":"add parameter to specify wsgi script source and path\n\nChange-Id: I54ed638d868541affe8f29551f52f7b09d13a090\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/e7dba7070f89a7908541f8252152c9c244d260a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-cloudkitty/commit/e7dba7070f89a7908541f8252152c9c244d260a6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}