)]}'
{"manifests/processor.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b7f0d67a2ae658cb606f92ba4d7cc1f9377f032a","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    \u0027collect/collector\u0027:              value \u003d\u003e $collector;"},{"line_number":105,"context_line":"    \u0027collector_gnocchi/auth_type\u0027:    value \u003d\u003e $auth_type;"},{"line_number":106,"context_line":"    \u0027collector_gnocchi/auth_section\u0027: value \u003d\u003e $auth_section;"},{"line_number":107,"context_line":"    \u0027collector_gnocchi/region_name\u0027:  value \u003d\u003e $region_name;"},{"line_number":108,"context_line":"  }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e2257abf_8ec268c7","line":107,"range":{"start_line":107,"start_character":5,"end_line":107,"end_character":59},"updated":"2021-08-03 00:50:42.000000000","message":"I don\u0027t disagree with adding this parameter but this sounds like a bug in cloudkitty. It should pick up the region_name parameter from auth_section and should not override region_name by this parameter.\n\nI\u0027d suggest you consider filing a bug to cloudkitty to address that point.","commit_id":"1464a6898a5da1ff5c97e47fcc48a7855c995943"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"022e4216f6a7ddfc9dbfe63dd5c0acb7c438aaed","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    \u0027collect/collector\u0027:              value \u003d\u003e $collector;"},{"line_number":105,"context_line":"    \u0027collector_gnocchi/auth_type\u0027:    value \u003d\u003e $auth_type;"},{"line_number":106,"context_line":"    \u0027collector_gnocchi/auth_section\u0027: value \u003d\u003e $auth_section;"},{"line_number":107,"context_line":"    \u0027collector_gnocchi/region_name\u0027:  value \u003d\u003e $region_name;"},{"line_number":108,"context_line":"  }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"885b859b_30f513a7","line":107,"range":{"start_line":107,"start_character":5,"end_line":107,"end_character":59},"in_reply_to":"53dda663_8f58fc95","updated":"2021-08-17 11:13:04.000000000","message":"Adding this parameter in puppet-cloudkitty is valid, based on the current implementation in cloudkitty.\n\nWhat I\u0027m complaining is the current design in cludkitty. I\u0027d expect cloudkillty can pick up region_name from [keystone_authtoken] rather than requiring redundant definition of region_name and in both [collector_gnocchi], but it is not possible because the default regionOne is defined only for [collector_gnocchi].","commit_id":"1464a6898a5da1ff5c97e47fcc48a7855c995943"},{"author":{"_account_id":26721,"name":"Rocky","display_name":"Shi Yan","email":"yanshi.403@gmail.com","username":"Rocky"},"change_message_id":"d8022a1d4b675ea15d654e60af43487a8525d9ad","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    \u0027collect/collector\u0027:              value \u003d\u003e $collector;"},{"line_number":105,"context_line":"    \u0027collector_gnocchi/auth_type\u0027:    value \u003d\u003e $auth_type;"},{"line_number":106,"context_line":"    \u0027collector_gnocchi/auth_section\u0027: value \u003d\u003e $auth_section;"},{"line_number":107,"context_line":"    \u0027collector_gnocchi/region_name\u0027:  value \u003d\u003e $region_name;"},{"line_number":108,"context_line":"  }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"53dda663_8f58fc95","line":107,"range":{"start_line":107,"start_character":5,"end_line":107,"end_character":59},"in_reply_to":"e2257abf_8ec268c7","updated":"2021-08-17 04:37:21.000000000","message":"Sorry for the late reply I\u0027d overlooked this comment.\n\nI think the region_name here is still valid, as we can collect data from gnocchi endpoints in a different region, right?","commit_id":"1464a6898a5da1ff5c97e47fcc48a7855c995943"}],"spec/classes/cloudkitty_processor_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55fa4481ae3f71f1716fe279d85bd920928edb9d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"      :period         \u003d\u003e \u002760\u0027,"},{"line_number":10,"context_line":"      :wait_periods   \u003d\u003e \u00271\u0027,"},{"line_number":11,"context_line":"      :window         \u003d\u003e \u00273600\u0027,"},{"line_number":12,"context_line":"      :region_name    \u003d\u003e \u0027Other\u0027,}"},{"line_number":13,"context_line":"  end"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  shared_examples_for \u0027cloudkitty-processor\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bcc89a70_edbbe9ab","line":12,"range":{"start_line":12,"start_character":26,"end_line":12,"end_character":31},"updated":"2021-08-03 00:54:27.000000000","message":"Please consider using RegionOne instead, which looks more realistic region name.","commit_id":"1464a6898a5da1ff5c97e47fcc48a7855c995943"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55fa4481ae3f71f1716fe279d85bd920928edb9d","unresolved":true,"context_lines":[{"line_number":24,"context_line":"      it { is_expected.to contain_cloudkitty_config(\u0027collect/wait_periods\u0027).with_value( params[:wait_periods] ) }"},{"line_number":25,"context_line":"      it { is_expected.to contain_cloudkitty_config(\u0027collector_gnocchi/auth_type\u0027).with_value(\u0027password\u0027) }"},{"line_number":26,"context_line":"      it { is_expected.to contain_cloudkitty_config(\u0027collector_gnocchi/auth_section\u0027).with_value(\u0027keystone_authtoken\u0027) }"},{"line_number":27,"context_line":"      it { is_expected.to contain_cloudkitty_config(\u0027collector_gnocchi/region_name\u0027).with_value(\u0027Other\u0027) }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"      it \u0027installs cloudkitty-processor package\u0027 do"},{"line_number":30,"context_line":"        is_expected.to contain_package(\u0027cloudkitty-processor\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":1,"id":"676d0bb9_69192b1c","line":27,"range":{"start_line":27,"start_character":96,"end_line":27,"end_character":103},"updated":"2021-08-03 00:54:27.000000000","message":"Let\u0027s use params[:region_name] instead to follow the other test cases.","commit_id":"1464a6898a5da1ff5c97e47fcc48a7855c995943"}]}