)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11bfcc4b7562efd2eb73316ecab0500f2e12c109","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Populating init.pp and parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- skipping accepence test for now, packages arn\u0027t quite ready"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieefebfcb9529065a520b95f06e4524d7784fe109"},{"line_number":12,"context_line":"Signed-off-by: Dan Radez \u003cdradez@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1aa78d24_e362e83c","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":49},"updated":"2016-07-14 00:44:17.000000000","message":"aren\u0027t","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"}],"manifests/init.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"f6adc6fdb01ca1becbf8d21067c39fcf0a0671ec","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $database_max_overflow              \u003d undef,"},{"line_number":220,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":221,"context_line":"  $control_exchange                   \u003d \u0027congress\u0027,"},{"line_number":222,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"},{"line_number":223,"context_line":"  $rabbit_port                        \u003d 5672,"},{"line_number":224,"context_line":"  $rabbit_hosts                       \u003d false,"},{"line_number":225,"context_line":"  $rabbit_virtual_host                \u003d \u0027/\u0027,"},{"line_number":226,"context_line":"  $rabbit_heartbeat_timeout_threshold \u003d 0,"},{"line_number":227,"context_line":"  $rabbit_heartbeat_rate              \u003d 2,"},{"line_number":228,"context_line":"  $rabbit_userid                      \u003d \u0027guest\u0027,"},{"line_number":229,"context_line":"  $rabbit_password                    \u003d false,"},{"line_number":230,"context_line":"  $rabbit_use_ssl                     \u003d false,"},{"line_number":231,"context_line":"  $kombu_ssl_ca_certs                 \u003d $::os_service_default,"},{"line_number":232,"context_line":"  $kombu_ssl_certfile                 \u003d $::os_service_default,"},{"line_number":233,"context_line":"  $kombu_ssl_keyfile                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_6ce7da46","line":230,"range":{"start_line":222,"start_character":2,"end_line":230,"end_character":46},"updated":"2016-06-16 08:36:01.000000000","message":"is it possible to use os_service_default for these options?","commit_id":"9839b7511fb5088dad861ed01f0511181a5ad2c2"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f525fe0a79ea40b560ac710f313ad3ca9b15cf8e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $database_max_overflow              \u003d undef,"},{"line_number":220,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":221,"context_line":"  $control_exchange                   \u003d \u0027congress\u0027,"},{"line_number":222,"context_line":"  $rabbit_host                        \u003d \u0027127.0.0.1\u0027,"},{"line_number":223,"context_line":"  $rabbit_port                        \u003d 5672,"},{"line_number":224,"context_line":"  $rabbit_hosts                       \u003d false,"},{"line_number":225,"context_line":"  $rabbit_virtual_host                \u003d \u0027/\u0027,"},{"line_number":226,"context_line":"  $rabbit_heartbeat_timeout_threshold \u003d 0,"},{"line_number":227,"context_line":"  $rabbit_heartbeat_rate              \u003d 2,"},{"line_number":228,"context_line":"  $rabbit_userid                      \u003d \u0027guest\u0027,"},{"line_number":229,"context_line":"  $rabbit_password                    \u003d false,"},{"line_number":230,"context_line":"  $rabbit_use_ssl                     \u003d false,"},{"line_number":231,"context_line":"  $kombu_ssl_ca_certs                 \u003d $::os_service_default,"},{"line_number":232,"context_line":"  $kombu_ssl_certfile                 \u003d $::os_service_default,"},{"line_number":233,"context_line":"  $kombu_ssl_keyfile                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_72792293","line":230,"range":{"start_line":222,"start_character":2,"end_line":230,"end_character":46},"in_reply_to":"7aa08908_6ce7da46","updated":"2016-06-17 14:40:25.000000000","message":"Done","commit_id":"9839b7511fb5088dad861ed01f0511181a5ad2c2"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"f6adc6fdb01ca1becbf8d21067c39fcf0a0671ec","unresolved":false,"context_lines":[{"line_number":264,"context_line":"      fail(\u0027Please specify a rabbit_password parameter.\u0027)"},{"line_number":265,"context_line":"    }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    congress_config {"},{"line_number":268,"context_line":"      \u0027DEFAULT/rabbit_password\u0027:              value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"},{"line_number":269,"context_line":"      \u0027DEFAULT/rabbit_userid\u0027:                value \u003d\u003e $rabbit_userid;"},{"line_number":270,"context_line":"      \u0027DEFAULT/rabbit_virtual_host\u0027:          value \u003d\u003e $rabbit_virtual_host;"},{"line_number":271,"context_line":"      \u0027DEFAULT/control_exchange\u0027:             value \u003d\u003e $control_exchange;"},{"line_number":272,"context_line":"      #\u0027DEFAULT/rabbit_use_ssl\u0027:               value \u003d\u003e $rabbit_use_ssl;"},{"line_number":273,"context_line":"      #\u0027DEFAULT/kombu_reconnect_delay\u0027:        value \u003d\u003e $kombu_reconnect_delay;"},{"line_number":274,"context_line":"      #\u0027DEFAULT/heartbeat_timeout_threshold\u0027:  value \u003d\u003e $rabbit_heartbeat_timeout_threshold;"},{"line_number":275,"context_line":"      #\u0027DEFAULT/heartbeat_rate\u0027:               value \u003d\u003e $rabbit_heartbeat_rate;"},{"line_number":276,"context_line":"      #\u0027DEFAULT/amqp_durable_queues\u0027:          value \u003d\u003e $amqp_durable_queues;"},{"line_number":277,"context_line":"    }"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    if $rabbit_use_ssl {"},{"line_number":280,"context_line":"      congress_config {"},{"line_number":281,"context_line":"        \u0027DEFAULT/kombu_ssl_version\u0027  : value \u003d\u003e $kombu_ssl_version;"},{"line_number":282,"context_line":"        \u0027DEFAULT/kombu_ssl_ca_certs\u0027 : value \u003d\u003e $kombu_ssl_ca_certs;"},{"line_number":283,"context_line":"        \u0027DEFAULT/kombu_ssl_certfile\u0027 : value \u003d\u003e $kombu_ssl_certfile;"},{"line_number":284,"context_line":"        \u0027DEFAULT/kombu_ssl_keyfile\u0027  : value \u003d\u003e $kombu_ssl_keyfile;"},{"line_number":285,"context_line":"      }"},{"line_number":286,"context_line":"    }"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    if $rabbit_hosts {"},{"line_number":289,"context_line":"      congress_config { \u0027DEFAULT/rabbit_hosts\u0027:     value \u003d\u003e join($rabbit_hosts, \u0027,\u0027) }"},{"line_number":290,"context_line":"      congress_config { \u0027DEFAULT/rabbit_ha_queues\u0027: value \u003d\u003e true }"},{"line_number":291,"context_line":"      congress_config { \u0027DEFAULT/rabbit_host\u0027:      ensure \u003d\u003e absent }"},{"line_number":292,"context_line":"      congress_config { \u0027DEFAULT/rabbit_port\u0027:      ensure \u003d\u003e absent }"},{"line_number":293,"context_line":"    } else {"},{"line_number":294,"context_line":"      congress_config { \u0027DEFAULT/rabbit_host\u0027:      value \u003d\u003e $rabbit_host }"},{"line_number":295,"context_line":"      congress_config { \u0027DEFAULT/rabbit_port\u0027:      value \u003d\u003e $rabbit_port }"},{"line_number":296,"context_line":"      congress_config { \u0027DEFAULT/rabbit_hosts\u0027:     value \u003d\u003e \"${rabbit_host}:${rabbit_port}\" }"},{"line_number":297,"context_line":"      congress_config { \u0027DEFAULT/rabbit_ha_queues\u0027: value \u003d\u003e false }"},{"line_number":298,"context_line":"    }"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_2c3312f8","line":297,"range":{"start_line":267,"start_character":0,"end_line":297,"end_character":68},"updated":"2016-06-16 08:36:01.000000000","message":"we should use puppet-oslo module to configure this, please look for example into puppet-nova module","commit_id":"9839b7511fb5088dad861ed01f0511181a5ad2c2"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f525fe0a79ea40b560ac710f313ad3ca9b15cf8e","unresolved":false,"context_lines":[{"line_number":264,"context_line":"      fail(\u0027Please specify a rabbit_password parameter.\u0027)"},{"line_number":265,"context_line":"    }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    congress_config {"},{"line_number":268,"context_line":"      \u0027DEFAULT/rabbit_password\u0027:              value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"},{"line_number":269,"context_line":"      \u0027DEFAULT/rabbit_userid\u0027:                value \u003d\u003e $rabbit_userid;"},{"line_number":270,"context_line":"      \u0027DEFAULT/rabbit_virtual_host\u0027:          value \u003d\u003e $rabbit_virtual_host;"},{"line_number":271,"context_line":"      \u0027DEFAULT/control_exchange\u0027:             value \u003d\u003e $control_exchange;"},{"line_number":272,"context_line":"      #\u0027DEFAULT/rabbit_use_ssl\u0027:               value \u003d\u003e $rabbit_use_ssl;"},{"line_number":273,"context_line":"      #\u0027DEFAULT/kombu_reconnect_delay\u0027:        value \u003d\u003e $kombu_reconnect_delay;"},{"line_number":274,"context_line":"      #\u0027DEFAULT/heartbeat_timeout_threshold\u0027:  value \u003d\u003e $rabbit_heartbeat_timeout_threshold;"},{"line_number":275,"context_line":"      #\u0027DEFAULT/heartbeat_rate\u0027:               value \u003d\u003e $rabbit_heartbeat_rate;"},{"line_number":276,"context_line":"      #\u0027DEFAULT/amqp_durable_queues\u0027:          value \u003d\u003e $amqp_durable_queues;"},{"line_number":277,"context_line":"    }"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    if $rabbit_use_ssl {"},{"line_number":280,"context_line":"      congress_config {"},{"line_number":281,"context_line":"        \u0027DEFAULT/kombu_ssl_version\u0027  : value \u003d\u003e $kombu_ssl_version;"},{"line_number":282,"context_line":"        \u0027DEFAULT/kombu_ssl_ca_certs\u0027 : value \u003d\u003e $kombu_ssl_ca_certs;"},{"line_number":283,"context_line":"        \u0027DEFAULT/kombu_ssl_certfile\u0027 : value \u003d\u003e $kombu_ssl_certfile;"},{"line_number":284,"context_line":"        \u0027DEFAULT/kombu_ssl_keyfile\u0027  : value \u003d\u003e $kombu_ssl_keyfile;"},{"line_number":285,"context_line":"      }"},{"line_number":286,"context_line":"    }"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    if $rabbit_hosts {"},{"line_number":289,"context_line":"      congress_config { \u0027DEFAULT/rabbit_hosts\u0027:     value \u003d\u003e join($rabbit_hosts, \u0027,\u0027) }"},{"line_number":290,"context_line":"      congress_config { \u0027DEFAULT/rabbit_ha_queues\u0027: value \u003d\u003e true }"},{"line_number":291,"context_line":"      congress_config { \u0027DEFAULT/rabbit_host\u0027:      ensure \u003d\u003e absent }"},{"line_number":292,"context_line":"      congress_config { \u0027DEFAULT/rabbit_port\u0027:      ensure \u003d\u003e absent }"},{"line_number":293,"context_line":"    } else {"},{"line_number":294,"context_line":"      congress_config { \u0027DEFAULT/rabbit_host\u0027:      value \u003d\u003e $rabbit_host }"},{"line_number":295,"context_line":"      congress_config { \u0027DEFAULT/rabbit_port\u0027:      value \u003d\u003e $rabbit_port }"},{"line_number":296,"context_line":"      congress_config { \u0027DEFAULT/rabbit_hosts\u0027:     value \u003d\u003e \"${rabbit_host}:${rabbit_port}\" }"},{"line_number":297,"context_line":"      congress_config { \u0027DEFAULT/rabbit_ha_queues\u0027: value \u003d\u003e false }"},{"line_number":298,"context_line":"    }"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_d26a96b4","line":297,"range":{"start_line":267,"start_character":0,"end_line":297,"end_character":68},"in_reply_to":"7aa08908_2c3312f8","updated":"2016-06-17 14:40:25.000000000","message":"Done","commit_id":"9839b7511fb5088dad861ed01f0511181a5ad2c2"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"441160832642892435106e2ecd4692393d4772f1","unresolved":false,"context_lines":[{"line_number":141,"context_line":"#"},{"line_number":142,"context_line":"# [*rabbit_use_ssl*]"},{"line_number":143,"context_line":"#   (optional) Connect over SSL for RabbitMQ"},{"line_number":144,"context_line":"#   Defaults to false"},{"line_number":145,"context_line":"#"},{"line_number":146,"context_line":"# [*kombu_ssl_ca_certs*]"},{"line_number":147,"context_line":"#   (optional) SSL certification authority file (valid only if SSL enabled)."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_12553e4f","line":144,"updated":"2016-06-17 14:47:08.000000000","message":"please fix all documentation defaults, so they are the same as you define in the class","commit_id":"d78dbb8a028bae5f058f4b746ef2328f7bc48ab0"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"07c44bf057ae8123b3689ed790149a062b569edd","unresolved":false,"context_lines":[{"line_number":141,"context_line":"#"},{"line_number":142,"context_line":"# [*rabbit_use_ssl*]"},{"line_number":143,"context_line":"#   (optional) Connect over SSL for RabbitMQ"},{"line_number":144,"context_line":"#   Defaults to false"},{"line_number":145,"context_line":"#"},{"line_number":146,"context_line":"# [*kombu_ssl_ca_certs*]"},{"line_number":147,"context_line":"#   (optional) SSL certification authority file (valid only if SSL enabled)."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_950598c3","line":144,"in_reply_to":"7aa08908_12553e4f","updated":"2016-06-17 14:57:15.000000000","message":"Done","commit_id":"d78dbb8a028bae5f058f4b746ef2328f7bc48ab0"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"441160832642892435106e2ecd4692393d4772f1","unresolved":false,"context_lines":[{"line_number":210,"context_line":"  $keystone_user                      \u003d \u0027congress\u0027,"},{"line_number":211,"context_line":"  $manage_service                     \u003d true,"},{"line_number":212,"context_line":"  $enabled                            \u003d true,"},{"line_number":213,"context_line":"  $database_connection                \u003d undef,"},{"line_number":214,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":215,"context_line":"  $database_max_retries               \u003d undef,"},{"line_number":216,"context_line":"  $database_retry_interval            \u003d undef,"},{"line_number":217,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":218,"context_line":"  $database_max_pool_size             \u003d undef,"},{"line_number":219,"context_line":"  $database_max_overflow              \u003d undef,"},{"line_number":220,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":221,"context_line":"  $control_exchange                   \u003d \u0027congress\u0027,"},{"line_number":222,"context_line":"  $rabbit_host                        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_32ecbaba","line":219,"range":{"start_line":213,"start_character":2,"end_line":219,"end_character":46},"updated":"2016-06-17 14:47:08.000000000","message":"these parameters should be in db class","commit_id":"d78dbb8a028bae5f058f4b746ef2328f7bc48ab0"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"07c44bf057ae8123b3689ed790149a062b569edd","unresolved":false,"context_lines":[{"line_number":210,"context_line":"  $keystone_user                      \u003d \u0027congress\u0027,"},{"line_number":211,"context_line":"  $manage_service                     \u003d true,"},{"line_number":212,"context_line":"  $enabled                            \u003d true,"},{"line_number":213,"context_line":"  $database_connection                \u003d undef,"},{"line_number":214,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":215,"context_line":"  $database_max_retries               \u003d undef,"},{"line_number":216,"context_line":"  $database_retry_interval            \u003d undef,"},{"line_number":217,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":218,"context_line":"  $database_max_pool_size             \u003d undef,"},{"line_number":219,"context_line":"  $database_max_overflow              \u003d undef,"},{"line_number":220,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":221,"context_line":"  $control_exchange                   \u003d \u0027congress\u0027,"},{"line_number":222,"context_line":"  $rabbit_host                        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_356664bb","line":219,"range":{"start_line":213,"start_character":2,"end_line":219,"end_character":46},"in_reply_to":"7aa08908_32ecbaba","updated":"2016-06-17 14:57:15.000000000","message":"Done","commit_id":"d78dbb8a028bae5f058f4b746ef2328f7bc48ab0"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"441160832642892435106e2ecd4692393d4772f1","unresolved":false,"context_lines":[{"line_number":233,"context_line":"  $kombu_ssl_keyfile                  \u003d $::os_service_default,"},{"line_number":234,"context_line":"  $kombu_ssl_version                  \u003d $::os_service_default,"},{"line_number":235,"context_line":"  $kombu_reconnect_delay              \u003d $::os_service_default,"},{"line_number":236,"context_line":"  $amqp_durable_queues                \u003d false,"},{"line_number":237,"context_line":"  $service_provider                   \u003d $::congress::params::service_provider,"},{"line_number":238,"context_line":"  $service_name                       \u003d $::congress::params::service_name,"},{"line_number":239,"context_line":"  $sync_db                            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_b20d4a91","line":236,"range":{"start_line":236,"start_character":2,"end_line":236,"end_character":46},"updated":"2016-06-17 14:47:08.000000000","message":"can this be os service default?","commit_id":"d78dbb8a028bae5f058f4b746ef2328f7bc48ab0"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"07c44bf057ae8123b3689ed790149a062b569edd","unresolved":false,"context_lines":[{"line_number":233,"context_line":"  $kombu_ssl_keyfile                  \u003d $::os_service_default,"},{"line_number":234,"context_line":"  $kombu_ssl_version                  \u003d $::os_service_default,"},{"line_number":235,"context_line":"  $kombu_reconnect_delay              \u003d $::os_service_default,"},{"line_number":236,"context_line":"  $amqp_durable_queues                \u003d false,"},{"line_number":237,"context_line":"  $service_provider                   \u003d $::congress::params::service_provider,"},{"line_number":238,"context_line":"  $service_name                       \u003d $::congress::params::service_name,"},{"line_number":239,"context_line":"  $sync_db                            \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_5569708b","line":236,"range":{"start_line":236,"start_character":2,"end_line":236,"end_character":46},"in_reply_to":"7aa08908_b20d4a91","updated":"2016-06-17 14:57:15.000000000","message":"Done","commit_id":"d78dbb8a028bae5f058f4b746ef2328f7bc48ab0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"784c6e3f15bacdb53a244954cb4c4d546d26d5ab","unresolved":false,"context_lines":[{"line_number":315,"context_line":"      heartbeat_rate              \u003d\u003e $rabbit_heartbeat_rate,"},{"line_number":316,"context_line":"      kombu_reconnect_delay       \u003d\u003e $kombu_reconnect_delay,"},{"line_number":317,"context_line":"      amqp_durable_queues         \u003d\u003e $amqp_durable_queues,"},{"line_number":318,"context_line":"      kombu_compression           \u003d\u003e $kombu_compression,"},{"line_number":319,"context_line":"      kombu_ssl_ca_certs          \u003d\u003e $kombu_ssl_ca_certs,"},{"line_number":320,"context_line":"      kombu_ssl_certfile          \u003d\u003e $kombu_ssl_certfile,"},{"line_number":321,"context_line":"      kombu_ssl_keyfile           \u003d\u003e $kombu_ssl_keyfile,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_e1937aa1","line":318,"range":{"start_line":318,"start_character":37,"end_line":318,"end_character":55},"updated":"2016-06-17 16:03:07.000000000","message":"you don\u0027t have this variable","commit_id":"1efc9105930122068ceac8f71580328e51db1a4d"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"d48eb83ec751ae387132a7e5b99036dab4edd891","unresolved":false,"context_lines":[{"line_number":315,"context_line":"      heartbeat_rate              \u003d\u003e $rabbit_heartbeat_rate,"},{"line_number":316,"context_line":"      kombu_reconnect_delay       \u003d\u003e $kombu_reconnect_delay,"},{"line_number":317,"context_line":"      amqp_durable_queues         \u003d\u003e $amqp_durable_queues,"},{"line_number":318,"context_line":"      kombu_compression           \u003d\u003e $kombu_compression,"},{"line_number":319,"context_line":"      kombu_ssl_ca_certs          \u003d\u003e $kombu_ssl_ca_certs,"},{"line_number":320,"context_line":"      kombu_ssl_certfile          \u003d\u003e $kombu_ssl_certfile,"},{"line_number":321,"context_line":"      kombu_ssl_keyfile           \u003d\u003e $kombu_ssl_keyfile,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_0c1eba0b","line":318,"range":{"start_line":318,"start_character":37,"end_line":318,"end_character":55},"in_reply_to":"7aa08908_e1937aa1","updated":"2016-06-17 17:58:21.000000000","message":"Done","commit_id":"1efc9105930122068ceac8f71580328e51db1a4d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"784c6e3f15bacdb53a244954cb4c4d546d26d5ab","unresolved":false,"context_lines":[{"line_number":323,"context_line":"      rabbit_hosts                \u003d\u003e $rabbit_hosts,"},{"line_number":324,"context_line":"      rabbit_host                 \u003d\u003e $rabbit_host,"},{"line_number":325,"context_line":"      rabbit_port                 \u003d\u003e $rabbit_port,"},{"line_number":326,"context_line":"      rabbit_ha_queues            \u003d\u003e $rabbit_ha_queues,"},{"line_number":327,"context_line":"    }"},{"line_number":328,"context_line":"  } elsif $rpc_backend \u003d\u003d \u0027amqp\u0027 {"},{"line_number":329,"context_line":"    oslo::messaging::amqp { \u0027congress_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_819b96c8","line":326,"range":{"start_line":326,"start_character":37,"end_line":326,"end_character":54},"updated":"2016-06-17 16:03:07.000000000","message":"you don\u0027t have this variable","commit_id":"1efc9105930122068ceac8f71580328e51db1a4d"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"d48eb83ec751ae387132a7e5b99036dab4edd891","unresolved":false,"context_lines":[{"line_number":323,"context_line":"      rabbit_hosts                \u003d\u003e $rabbit_hosts,"},{"line_number":324,"context_line":"      rabbit_host                 \u003d\u003e $rabbit_host,"},{"line_number":325,"context_line":"      rabbit_port                 \u003d\u003e $rabbit_port,"},{"line_number":326,"context_line":"      rabbit_ha_queues            \u003d\u003e $rabbit_ha_queues,"},{"line_number":327,"context_line":"    }"},{"line_number":328,"context_line":"  } elsif $rpc_backend \u003d\u003d \u0027amqp\u0027 {"},{"line_number":329,"context_line":"    oslo::messaging::amqp { \u0027congress_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_6c177eee","line":326,"range":{"start_line":326,"start_character":37,"end_line":326,"end_character":54},"in_reply_to":"7aa08908_819b96c8","updated":"2016-06-17 17:58:21.000000000","message":"Done","commit_id":"1efc9105930122068ceac8f71580328e51db1a4d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"305b5f57d0fc0a8be49a7d53b5d22abd2bead784","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   (optional) Port that congress binds to."},{"line_number":26,"context_line":"#   Defaults to \u00271789\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*verbose*]"},{"line_number":29,"context_line":"#   (optional) Rather congress should log at verbose level."},{"line_number":30,"context_line":"#   Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*debug*]"},{"line_number":33,"context_line":"#   (optional) Rather congress should log at debug level."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_745fc272","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"updated":"2016-06-20 13:42:51.000000000","message":"please remove, verbose deprecated \n\nhttps://github.com/openstack/puppet-keystone/blob/dbde71b85510d5076bfdd968e56033ce1b76c4b5/releasenotes/notes/verbose-deprecation-38d9b7667fcf381d.yaml","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   (optional) Port that congress binds to."},{"line_number":26,"context_line":"#   Defaults to \u00271789\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*verbose*]"},{"line_number":29,"context_line":"#   (optional) Rather congress should log at verbose level."},{"line_number":30,"context_line":"#   Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*debug*]"},{"line_number":33,"context_line":"#   (optional) Rather congress should log at debug level."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_45364c04","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":21},"in_reply_to":"5a9d85d2_745fc272","updated":"2016-06-22 09:40:18.000000000","message":"Done","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"305b5f57d0fc0a8be49a7d53b5d22abd2bead784","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (optional) Rather congress should log at verbose level."},{"line_number":30,"context_line":"#   Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*debug*]"},{"line_number":33,"context_line":"#   (optional) Rather congress should log at debug level."},{"line_number":34,"context_line":"#   Defaults to undef"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*auth_type*]"},{"line_number":37,"context_line":"#   (optional) Type is authorization being used."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_74d6a2c6","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":21},"updated":"2016-06-20 13:42:51.000000000","message":"since we have logging class why not let logging parameters only there?","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   (optional) Rather congress should log at verbose level."},{"line_number":30,"context_line":"#   Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*debug*]"},{"line_number":33,"context_line":"#   (optional) Rather congress should log at debug level."},{"line_number":34,"context_line":"#   Defaults to undef"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*auth_type*]"},{"line_number":37,"context_line":"#   (optional) Type is authorization being used."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_eadbc7eb","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":21},"in_reply_to":"5a9d85d2_74d6a2c6","updated":"2016-06-22 09:40:18.000000000","message":"I think you\u0027re suggesting to remove this and rely on the logging param?","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"305b5f57d0fc0a8be49a7d53b5d22abd2bead784","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*auth_uri*]"},{"line_number":41,"context_line":"#   (optional) Complete public Identity API endpoint."},{"line_number":42,"context_line":"#   Defaults to false"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*identity_uri*]"},{"line_number":45,"context_line":"#   (optional) Complete admin Identity API endpoint."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_5404467d","line":42,"range":{"start_line":42,"start_character":16,"end_line":42,"end_character":21},"updated":"2016-06-20 13:42:51.000000000","message":"false? this should be a url","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*auth_uri*]"},{"line_number":41,"context_line":"#   (optional) Complete public Identity API endpoint."},{"line_number":42,"context_line":"#   Defaults to false"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*identity_uri*]"},{"line_number":45,"context_line":"#   (optional) Complete admin Identity API endpoint."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_6a31970b","line":42,"range":{"start_line":42,"start_character":16,"end_line":42,"end_character":21},"in_reply_to":"5a9d85d2_5404467d","updated":"2016-06-22 09:40:18.000000000","message":"this was a duplicate of identity, removed it.","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecbf4df1728c1ad80f4201b056da3c51a034fea2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*identity_uri*]"},{"line_number":45,"context_line":"#   (optional) Complete admin Identity API endpoint."},{"line_number":46,"context_line":"#   Defaults to: false"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*keystone_tenant*]"},{"line_number":49,"context_line":"#   (optional) Tenant to authenticate to."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_c7524fdd","line":46,"updated":"2016-06-20 10:57:57.000000000","message":"Defaults to false","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"305b5f57d0fc0a8be49a7d53b5d22abd2bead784","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*identity_uri*]"},{"line_number":45,"context_line":"#   (optional) Complete admin Identity API endpoint."},{"line_number":46,"context_line":"#   Defaults to: false"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*keystone_tenant*]"},{"line_number":49,"context_line":"#   (optional) Tenant to authenticate to."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_b4ce4a58","line":46,"in_reply_to":"5a9d85d2_c7524fdd","updated":"2016-06-20 13:42:51.000000000","message":"false? this should be a url not?","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*identity_uri*]"},{"line_number":45,"context_line":"#   (optional) Complete admin Identity API endpoint."},{"line_number":46,"context_line":"#   Defaults to: false"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*keystone_tenant*]"},{"line_number":49,"context_line":"#   (optional) Tenant to authenticate to."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_2a302f01","line":46,"in_reply_to":"5a9d85d2_c7524fdd","updated":"2016-06-22 09:40:18.000000000","message":"it\u0027s optional, changing this to undef instead","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecbf4df1728c1ad80f4201b056da3c51a034fea2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*keystone_tenant*]"},{"line_number":49,"context_line":"#   (optional) Tenant to authenticate to."},{"line_number":50,"context_line":"#   Defaults to services"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*keystone_user*]"},{"line_number":53,"context_line":"#   (optional) User to authenticate as with keystone."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_275eb3e9","line":50,"updated":"2016-06-20 10:57:57.000000000","message":"\u0027services\u0027","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*keystone_tenant*]"},{"line_number":49,"context_line":"#   (optional) Tenant to authenticate to."},{"line_number":50,"context_line":"#   Defaults to services"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*keystone_user*]"},{"line_number":53,"context_line":"#   (optional) User to authenticate as with keystone."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_452bec82","line":50,"in_reply_to":"5a9d85d2_275eb3e9","updated":"2016-06-22 09:40:18.000000000","message":"Done","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecbf4df1728c1ad80f4201b056da3c51a034fea2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*control_exchange*]"},{"line_number":69,"context_line":"#   (Optional)"},{"line_number":70,"context_line":"#   Defaults to \u0027openstack\u0027"},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*rabbit_host*]"},{"line_number":73,"context_line":"#   (Optional) IP or hostname of the rabbit server."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_a720e34a","line":70,"updated":"2016-06-20 10:57:57.000000000","message":"\u0027congress\u0027 or \u0027openstack\u0027 as 258 lines says?","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*control_exchange*]"},{"line_number":69,"context_line":"#   (Optional)"},{"line_number":70,"context_line":"#   Defaults to \u0027openstack\u0027"},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*rabbit_host*]"},{"line_number":73,"context_line":"#   (Optional) IP or hostname of the rabbit server."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_e56818bd","line":70,"in_reply_to":"5a9d85d2_a720e34a","updated":"2016-06-22 09:40:18.000000000","message":"not sure this is being used, removing for now","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecbf4df1728c1ad80f4201b056da3c51a034fea2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*rabbit_host*]"},{"line_number":73,"context_line":"#   (Optional) IP or hostname of the rabbit server."},{"line_number":74,"context_line":"#   Defaults to \u0027127.0.0.1\u0027"},{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"# [*rabbit_port*]"},{"line_number":77,"context_line":"#   (Optional) Port of the rabbit server."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_c769af8d","line":74,"updated":"2016-06-20 10:57:57.000000000","message":"$::os_service_default","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"# [*rabbit_host*]"},{"line_number":73,"context_line":"#   (Optional) IP or hostname of the rabbit server."},{"line_number":74,"context_line":"#   Defaults to \u0027127.0.0.1\u0027"},{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"# [*rabbit_port*]"},{"line_number":77,"context_line":"#   (Optional) Port of the rabbit server."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_25306001","line":74,"in_reply_to":"5a9d85d2_c769af8d","updated":"2016-06-22 09:40:18.000000000","message":"Done","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecbf4df1728c1ad80f4201b056da3c51a034fea2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"# [*rabbit_port*]"},{"line_number":77,"context_line":"#   (Optional) Port of the rabbit server."},{"line_number":78,"context_line":"#   Defaults to 5672"},{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":"# [*rabbit_hosts*]"},{"line_number":81,"context_line":"#   (Optional) Array of host:port (used with HA queues)."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_070a97d2","line":78,"updated":"2016-06-20 10:57:57.000000000","message":"$::os_service_default","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":75,"context_line":"#"},{"line_number":76,"context_line":"# [*rabbit_port*]"},{"line_number":77,"context_line":"#   (Optional) Port of the rabbit server."},{"line_number":78,"context_line":"#   Defaults to 5672"},{"line_number":79,"context_line":"#"},{"line_number":80,"context_line":"# [*rabbit_hosts*]"},{"line_number":81,"context_line":"#   (Optional) Array of host:port (used with HA queues)."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_6518a885","line":78,"in_reply_to":"5a9d85d2_070a97d2","updated":"2016-06-22 09:40:18.000000000","message":"Done","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecbf4df1728c1ad80f4201b056da3c51a034fea2","unresolved":false,"context_lines":[{"line_number":219,"context_line":"#   Default value defined in congress::params for given operation system."},{"line_number":220,"context_line":"#   If you use Pacemaker or another Cluster Resource Manager, you can make"},{"line_number":221,"context_line":"#   custom service provider for changing start/stop/status behavior of service,"},{"line_number":222,"context_line":"#   and set it here."},{"line_number":223,"context_line":"#"},{"line_number":224,"context_line":"# [*service_name*]"},{"line_number":225,"context_line":"#   (optional) Name of the service that will be providing the"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_c7eecfeb","line":222,"updated":"2016-06-20 10:57:57.000000000","message":"Defaults to $::congress::params::service_provider","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":219,"context_line":"#   Default value defined in congress::params for given operation system."},{"line_number":220,"context_line":"#   If you use Pacemaker or another Cluster Resource Manager, you can make"},{"line_number":221,"context_line":"#   custom service provider for changing start/stop/status behavior of service,"},{"line_number":222,"context_line":"#   and set it here."},{"line_number":223,"context_line":"#"},{"line_number":224,"context_line":"# [*service_name*]"},{"line_number":225,"context_line":"#   (optional) Name of the service that will be providing the"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_451dac72","line":222,"in_reply_to":"5a9d85d2_c7eecfeb","updated":"2016-06-22 09:40:18.000000000","message":"Done","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecbf4df1728c1ad80f4201b056da3c51a034fea2","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    \u0027DEFAULT/drivers\u0027     : value \u003d\u003e \u0027congress.datasources.neutronv2_driver.NeutronV2Driver,congress.datasources.glancev2_driver.GlanceV2Driver,congress.datasources.nova_driver.NovaDriver,congress.datasources.keystone_driver.KeystoneDriver,congress.datasources.ceilometer_driver.CeilometerDriver,congress.datasources.cinder_driver.CinderDriver\u0027;"},{"line_number":298,"context_line":"    \u0027DEFAULT/policy_path\u0027 : value \u003d\u003e \u0027/etc/congress/snapshot/\u0027;"},{"line_number":299,"context_line":"    \u0027DEFAULT/log_file\u0027    : value \u003d\u003e \u0027congress.log\u0027;"},{"line_number":300,"context_line":"    \u0027DEFAULT/log_dir\u0027     : value \u003d\u003e \u0027/var/log/congress/\u0027;"},{"line_number":301,"context_line":"  }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  if $identity_uri {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_27a193aa","line":300,"updated":"2016-06-20 10:57:57.000000000","message":"why do you hard-code these values?","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    \u0027DEFAULT/drivers\u0027     : value \u003d\u003e \u0027congress.datasources.neutronv2_driver.NeutronV2Driver,congress.datasources.glancev2_driver.GlanceV2Driver,congress.datasources.nova_driver.NovaDriver,congress.datasources.keystone_driver.KeystoneDriver,congress.datasources.ceilometer_driver.CeilometerDriver,congress.datasources.cinder_driver.CinderDriver\u0027;"},{"line_number":298,"context_line":"    \u0027DEFAULT/policy_path\u0027 : value \u003d\u003e \u0027/etc/congress/snapshot/\u0027;"},{"line_number":299,"context_line":"    \u0027DEFAULT/log_file\u0027    : value \u003d\u003e \u0027congress.log\u0027;"},{"line_number":300,"context_line":"    \u0027DEFAULT/log_dir\u0027     : value \u003d\u003e \u0027/var/log/congress/\u0027;"},{"line_number":301,"context_line":"  }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  if $identity_uri {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_e55e5844","line":300,"in_reply_to":"5a9d85d2_27a193aa","updated":"2016-06-22 09:40:18.000000000","message":"moved these values to params","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecbf4df1728c1ad80f4201b056da3c51a034fea2","unresolved":false,"context_lines":[{"line_number":315,"context_line":"  }"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  if $rpc_backend \u003d\u003d \u0027rabbit\u0027 {"},{"line_number":318,"context_line":"    if ! $rabbit_password {"},{"line_number":319,"context_line":"      fail(\u0027Please specify a rabbit_password parameter.\u0027)"},{"line_number":320,"context_line":"    }"},{"line_number":321,"context_line":"    oslo::messaging::rabbit {\u0027congress_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a9d85d2_078d7731","line":318,"updated":"2016-06-20 10:57:57.000000000","message":"if is_service_default($rabbit_password) then do fail","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"5e9c62d3c7c93e66d8cdcbedef6db22e7ba4d416","unresolved":false,"context_lines":[{"line_number":315,"context_line":"  }"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  if $rpc_backend \u003d\u003d \u0027rabbit\u0027 {"},{"line_number":318,"context_line":"    if ! $rabbit_password {"},{"line_number":319,"context_line":"      fail(\u0027Please specify a rabbit_password parameter.\u0027)"},{"line_number":320,"context_line":"    }"},{"line_number":321,"context_line":"    oslo::messaging::rabbit {\u0027congress_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3aaa91ec_c5099c33","line":318,"in_reply_to":"5a9d85d2_078d7731","updated":"2016-06-22 09:40:18.000000000","message":"Done","commit_id":"856c0e6b7d5b4db64b1197c7a2e21afb6d07e7f7"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"1badfc70a7ec543208bccddc2fc25338684df1a4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*keystone_password*]"},{"line_number":8,"context_line":"#   (required) Password used to authentication."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*package_ensure*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_7041810b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":23},"updated":"2016-06-22 09:15:19.000000000","message":"just a nit, but parameters could be sorted alphabetically, or grouped by functionality, so is easier to consume them","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"62e275148361196e01d061773179aa1c4d150363","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*keystone_password*]"},{"line_number":8,"context_line":"#   (required) Password used to authentication."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*package_ensure*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_9cda4677","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":23},"in_reply_to":"3aaa91ec_7041810b","updated":"2016-06-23 10:07:12.000000000","message":"I think they are arranged by groups now.\nRequired, packages, service configuration, messaging configuration and congress specific last.","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"1badfc70a7ec543208bccddc2fc25338684df1a4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   (optional) Port that congress binds to."},{"line_number":26,"context_line":"#   Defaults to \u00271789\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*auth_type*]"},{"line_number":29,"context_line":"#   (optional) Type is authorization being used."},{"line_number":30,"context_line":"#   Defaults to \u0027keystone\u0027"},{"line_number":31,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_50ed658a","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":13},"updated":"2016-06-22 09:15:19.000000000","message":"auth_type is documented here, but not exposed as a parameter in the class","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"62e275148361196e01d061773179aa1c4d150363","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#   (optional) Port that congress binds to."},{"line_number":26,"context_line":"#   Defaults to \u00271789\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*auth_type*]"},{"line_number":29,"context_line":"#   (optional) Type is authorization being used."},{"line_number":30,"context_line":"#   Defaults to \u0027keystone\u0027"},{"line_number":31,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_3c37d2b1","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":13},"in_reply_to":"3aaa91ec_50ed658a","updated":"2016-06-23 10:07:12.000000000","message":"removed","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"1badfc70a7ec543208bccddc2fc25338684df1a4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#   (Optional) Port of the rabbit server."},{"line_number":62,"context_line":"#   Defaults to $::os_service_default"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*rabbit_hosts*]"},{"line_number":65,"context_line":"#   (Optional) Array of host:port (used with HA queues)."},{"line_number":66,"context_line":"#   If defined, will remove rabbit_host \u0026 rabbit_port parameters from config"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_70dd0142","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":16},"updated":"2016-06-22 09:15:19.000000000","message":"i wonder if you could merge rabit_host and rabbit_hosts parameter. If rabbit_hosts is array, use as HA, and if it\u0027s just a single string use with non HA config","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"62e275148361196e01d061773179aa1c4d150363","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#   (Optional) Port of the rabbit server."},{"line_number":62,"context_line":"#   Defaults to $::os_service_default"},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*rabbit_hosts*]"},{"line_number":65,"context_line":"#   (Optional) Array of host:port (used with HA queues)."},{"line_number":66,"context_line":"#   If defined, will remove rabbit_host \u0026 rabbit_port parameters from config"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_fc90aa97","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":16},"in_reply_to":"3aaa91ec_70dd0142","updated":"2016-06-23 10:07:12.000000000","message":"This is how other puppet modules have done this, more so keeping consistent with other modules by doing it this way.","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"1badfc70a7ec543208bccddc2fc25338684df1a4","unresolved":false,"context_lines":[{"line_number":238,"context_line":"#   Dan Radez \u003cdradez@redhat.com\u003e"},{"line_number":239,"context_line":"#"},{"line_number":240,"context_line":"# \u003d\u003d Copyright"},{"line_number":241,"context_line":"#"},{"line_number":242,"context_line":"# Copyright 2015 Red Hat Inc, unless otherwise noted."},{"line_number":243,"context_line":"#"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_d0c5d55b","line":241,"range":{"start_line":241,"start_character":0,"end_line":241,"end_character":1},"updated":"2016-06-22 09:15:19.000000000","message":"nit, 2016","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"62e275148361196e01d061773179aa1c4d150363","unresolved":false,"context_lines":[{"line_number":238,"context_line":"#   Dan Radez \u003cdradez@redhat.com\u003e"},{"line_number":239,"context_line":"#"},{"line_number":240,"context_line":"# \u003d\u003d Copyright"},{"line_number":241,"context_line":"#"},{"line_number":242,"context_line":"# Copyright 2015 Red Hat Inc, unless otherwise noted."},{"line_number":243,"context_line":"#"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_5c461e24","line":241,"range":{"start_line":241,"start_character":0,"end_line":241,"end_character":1},"in_reply_to":"3aaa91ec_d0c5d55b","updated":"2016-06-23 10:07:12.000000000","message":"Done","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5fc2e0bed12965ec809a5b695f696633a4e2ba84","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: congress"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Full description of class congress here."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_5d528e14","line":3,"updated":"2016-06-22 13:31:15.000000000","message":"change it","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"710eb440b4c4d50b1172613e0c1d9fed683bed14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: congress"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Full description of class congress here."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_ec3e60d9","line":3,"in_reply_to":"3aaa91ec_5d528e14","updated":"2016-06-27 17:48:18.000000000","message":"Done","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5fc2e0bed12965ec809a5b695f696633a4e2ba84","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   accepts latest or specific versions."},{"line_number":18,"context_line":"#   Defaults to present"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*bind_host*]"},{"line_number":21,"context_line":"#   (optional) The IP address that congress binds to."},{"line_number":22,"context_line":"#   Default to \u00270.0.0.0\u0027"},{"line_number":23,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_bd573201","line":20,"updated":"2016-06-22 13:31:15.000000000","message":"I think process name is congress-server, isn\u0027t? If yes, maybe we can set server options in a server.pp?","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"710eb440b4c4d50b1172613e0c1d9fed683bed14","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   accepts latest or specific versions."},{"line_number":18,"context_line":"#   Defaults to present"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*bind_host*]"},{"line_number":21,"context_line":"#   (optional) The IP address that congress binds to."},{"line_number":22,"context_line":"#   Default to \u00270.0.0.0\u0027"},{"line_number":23,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_982b8b94","line":20,"in_reply_to":"3aaa91ec_bd573201","updated":"2016-06-27 17:48:18.000000000","message":"Took ther service resource out of init, will add it to service.pp\n\nFrom other modules it looks like init still takes the params and the service class does the config correct?","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5fc2e0bed12965ec809a5b695f696633a4e2ba84","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*bind_port*]"},{"line_number":25,"context_line":"#   (optional) Port that congress binds to."},{"line_number":26,"context_line":"#   Defaults to \u00271789\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*auth_type*]"},{"line_number":29,"context_line":"#   (optional) Type is authorization being used."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_9d5cf626","line":26,"updated":"2016-06-22 13:31:15.000000000","message":"same","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"710eb440b4c4d50b1172613e0c1d9fed683bed14","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*bind_port*]"},{"line_number":25,"context_line":"#   (optional) Port that congress binds to."},{"line_number":26,"context_line":"#   Defaults to \u00271789\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*auth_type*]"},{"line_number":29,"context_line":"#   (optional) Type is authorization being used."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_f8160f57","line":26,"in_reply_to":"3aaa91ec_9d5cf626","updated":"2016-06-27 17:48:18.000000000","message":"Done","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5fc2e0bed12965ec809a5b695f696633a4e2ba84","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*manage_service*]"},{"line_number":45,"context_line":"#   (Optional) If Puppet should manage service startup / shutdown."},{"line_number":46,"context_line":"#   Defaults to true"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*enabled*]"},{"line_number":49,"context_line":"#  (optional) If the congress services should be enabled."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_fd41ba3a","line":46,"updated":"2016-06-22 13:31:15.000000000","message":"same","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"710eb440b4c4d50b1172613e0c1d9fed683bed14","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*manage_service*]"},{"line_number":45,"context_line":"#   (Optional) If Puppet should manage service startup / shutdown."},{"line_number":46,"context_line":"#   Defaults to true"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*enabled*]"},{"line_number":49,"context_line":"#  (optional) If the congress services should be enabled."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_3811b75e","line":46,"in_reply_to":"3aaa91ec_fd41ba3a","updated":"2016-06-27 17:48:18.000000000","message":"Done","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5fc2e0bed12965ec809a5b695f696633a4e2ba84","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*enabled*]"},{"line_number":49,"context_line":"#  (optional) If the congress services should be enabled."},{"line_number":50,"context_line":"#   Default to true"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*rpc_backend*]"},{"line_number":53,"context_line":"#   (Optional) Use these options to configure the RabbitMQ message system."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_dd3e7eb7","line":50,"updated":"2016-06-22 13:31:15.000000000","message":"same","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"710eb440b4c4d50b1172613e0c1d9fed683bed14","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*enabled*]"},{"line_number":49,"context_line":"#  (optional) If the congress services should be enabled."},{"line_number":50,"context_line":"#   Default to true"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*rpc_backend*]"},{"line_number":53,"context_line":"#   (Optional) Use these options to configure the RabbitMQ message system."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_780b3f2c","line":50,"in_reply_to":"3aaa91ec_dd3e7eb7","updated":"2016-06-27 17:48:18.000000000","message":"Done","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5fc2e0bed12965ec809a5b695f696633a4e2ba84","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    \u0027DEFAULT/drivers\u0027     : value \u003d\u003e $drivers;"},{"line_number":300,"context_line":"    \u0027DEFAULT/policy_path\u0027 : value \u003d\u003e $policy_path;"},{"line_number":301,"context_line":"    \u0027DEFAULT/log_file\u0027    : value \u003d\u003e $log_file;"},{"line_number":302,"context_line":"    \u0027DEFAULT/log_dir\u0027     : value \u003d\u003e $log_dir;"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  if $identity_uri {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_3d4ce26f","line":302,"updated":"2016-06-22 13:31:15.000000000","message":"no, we shoud use logging.pp for log_*, see other modules","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"710eb440b4c4d50b1172613e0c1d9fed683bed14","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    \u0027DEFAULT/drivers\u0027     : value \u003d\u003e $drivers;"},{"line_number":300,"context_line":"    \u0027DEFAULT/policy_path\u0027 : value \u003d\u003e $policy_path;"},{"line_number":301,"context_line":"    \u0027DEFAULT/log_file\u0027    : value \u003d\u003e $log_file;"},{"line_number":302,"context_line":"    \u0027DEFAULT/log_dir\u0027     : value \u003d\u003e $log_dir;"},{"line_number":303,"context_line":"  }"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"  if $identity_uri {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3aaa91ec_ed03f3bc","line":302,"in_reply_to":"3aaa91ec_3d4ce26f","updated":"2016-06-27 17:48:18.000000000","message":"Done","commit_id":"0499eb0b09e008a01ef6f0c797621ef5717fcaa6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"350eee261379cb09338fa30aad9e62aedaeb456f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*identity_uri*]"},{"line_number":29,"context_line":"#   (optional) Complete admin Identity API endpoint."},{"line_number":30,"context_line":"#   Defaults to: undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*keystone_tenant*]"},{"line_number":33,"context_line":"#   (optional) Tenant to authenticate to."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_4f13bbb8","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":22},"updated":"2016-06-23 12:52:15.000000000","message":"why undef? take a look at other modules we set to http://127.0.0.1:35357/","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"dee0fef7a62d38bfffe62f3138e46c02e840b133","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*identity_uri*]"},{"line_number":29,"context_line":"#   (optional) Complete admin Identity API endpoint."},{"line_number":30,"context_line":"#   Defaults to: undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*keystone_tenant*]"},{"line_number":33,"context_line":"#   (optional) Tenant to authenticate to."}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_6ce1d09a","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":22},"in_reply_to":"3aaa91ec_4f13bbb8","updated":"2020-11-23 14:58:42.000000000","message":"Done","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"350eee261379cb09338fa30aad9e62aedaeb456f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"  $log_dir                            \u003d $::congress::params::log_dir,"},{"line_number":292,"context_line":"  $sync_db                            \u003d true,"},{"line_number":293,"context_line":") inherits congress::params {"},{"line_number":294,"context_line":"  congress_config {"},{"line_number":295,"context_line":"    \u0027DEFAULT/drivers\u0027     : value \u003d\u003e $drivers;"},{"line_number":296,"context_line":"    \u0027DEFAULT/policy_path\u0027 : value \u003d\u003e $policy_path;"},{"line_number":297,"context_line":"    \u0027DEFAULT/log_file\u0027    : value \u003d\u003e $log_file;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_4f7a9bf2","line":294,"updated":"2016-06-23 12:52:15.000000000","message":"can you skip a line? just to make more readable.","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"dee0fef7a62d38bfffe62f3138e46c02e840b133","unresolved":false,"context_lines":[{"line_number":291,"context_line":"  $log_dir                            \u003d $::congress::params::log_dir,"},{"line_number":292,"context_line":"  $sync_db                            \u003d true,"},{"line_number":293,"context_line":") inherits congress::params {"},{"line_number":294,"context_line":"  congress_config {"},{"line_number":295,"context_line":"    \u0027DEFAULT/drivers\u0027     : value \u003d\u003e $drivers;"},{"line_number":296,"context_line":"    \u0027DEFAULT/policy_path\u0027 : value \u003d\u003e $policy_path;"},{"line_number":297,"context_line":"    \u0027DEFAULT/log_file\u0027    : value \u003d\u003e $log_file;"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_cc61e413","line":294,"in_reply_to":"3aaa91ec_4f7a9bf2","updated":"2020-11-23 14:58:42.000000000","message":"Done","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"07b5858f85b97d3b0cd97008f202545772ebdbf3","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  $service_name                       \u003d $::congress::params::service_name,"},{"line_number":289,"context_line":"  $drivers                            \u003d $::congress::params::drivers,"},{"line_number":290,"context_line":"  $policy_path                        \u003d $::congress::params::policy_path,"},{"line_number":291,"context_line":"  $log_file                           \u003d $::congress::params::log_file,"},{"line_number":292,"context_line":"  $log_dir                            \u003d $::congress::params::log_dir,"},{"line_number":293,"context_line":"  $sync_db                            \u003d true,"},{"line_number":294,"context_line":") inherits congress::params {"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3aaa91ec_489dd258","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":69},"updated":"2016-06-27 18:31:07.000000000","message":"You don\u0027t need this here since will be in logging.pp","commit_id":"19b47aa6ace7bb59e1bff529c020c8fc1a6393f2"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"fce1a776f37004dd5b26e41b12d7618fd6577afc","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  $service_name                       \u003d $::congress::params::service_name,"},{"line_number":289,"context_line":"  $drivers                            \u003d $::congress::params::drivers,"},{"line_number":290,"context_line":"  $policy_path                        \u003d $::congress::params::policy_path,"},{"line_number":291,"context_line":"  $log_file                           \u003d $::congress::params::log_file,"},{"line_number":292,"context_line":"  $log_dir                            \u003d $::congress::params::log_dir,"},{"line_number":293,"context_line":"  $sync_db                            \u003d true,"},{"line_number":294,"context_line":") inherits congress::params {"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3aaa91ec_842f7e87","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":69},"in_reply_to":"3aaa91ec_489dd258","updated":"2016-06-28 11:38:42.000000000","message":"ah yea missed these, thx","commit_id":"19b47aa6ace7bb59e1bff529c020c8fc1a6393f2"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11bfcc4b7562efd2eb73316ecab0500f2e12c109","unresolved":false,"context_lines":[{"line_number":216,"context_line":"#   (optional) Directory that congress with use for policy storage."},{"line_number":217,"context_line":"#   Defaults to \u0027$::congress::params::policy_path\u0027"},{"line_number":218,"context_line":"#"},{"line_number":219,"context_line":"# [*log_file*]"},{"line_number":220,"context_line":"#   (optional) Name of the main log file that congress will"},{"line_number":221,"context_line":"#   log to."},{"line_number":222,"context_line":"#   Defaults to \u0027$::congress::params::log_file\u0027"},{"line_number":223,"context_line":"#"},{"line_number":224,"context_line":"# [*log_dir*]"},{"line_number":225,"context_line":"#   (optional) Directory set in congress config file that congress"},{"line_number":226,"context_line":"#   will keep logs in."},{"line_number":227,"context_line":"#   Defaults to \u0027$::congress::params::log_dir\u0027"},{"line_number":228,"context_line":"#"},{"line_number":229,"context_line":"# [*sync_db*]"},{"line_number":230,"context_line":"#   (Optional) Run db sync on the node."},{"line_number":231,"context_line":"#   Defaults to true"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"1aa78d24_46802af8","line":228,"range":{"start_line":219,"start_character":0,"end_line":228,"end_character":1},"updated":"2016-07-14 00:44:17.000000000","message":"this really should be here?\nyou dont\u0027t have $::congress::params::log_dir/log_file in params.pp\n\nThis should be in congress::logging","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f2b1ccc3292ce5869c4e4b56ffa4e0a07aaf78d7","unresolved":false,"context_lines":[{"line_number":216,"context_line":"#   (optional) Directory that congress with use for policy storage."},{"line_number":217,"context_line":"#   Defaults to \u0027$::congress::params::policy_path\u0027"},{"line_number":218,"context_line":"#"},{"line_number":219,"context_line":"# [*log_file*]"},{"line_number":220,"context_line":"#   (optional) Name of the main log file that congress will"},{"line_number":221,"context_line":"#   log to."},{"line_number":222,"context_line":"#   Defaults to \u0027$::congress::params::log_file\u0027"},{"line_number":223,"context_line":"#"},{"line_number":224,"context_line":"# [*log_dir*]"},{"line_number":225,"context_line":"#   (optional) Directory set in congress config file that congress"},{"line_number":226,"context_line":"#   will keep logs in."},{"line_number":227,"context_line":"#   Defaults to \u0027$::congress::params::log_dir\u0027"},{"line_number":228,"context_line":"#"},{"line_number":229,"context_line":"# [*sync_db*]"},{"line_number":230,"context_line":"#   (Optional) Run db sync on the node."},{"line_number":231,"context_line":"#   Defaults to true"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"9ad45d7e_41f87f49","line":228,"range":{"start_line":219,"start_character":0,"end_line":228,"end_character":1},"in_reply_to":"1aa78d24_46802af8","updated":"2016-08-10 18:24:12.000000000","message":"removed","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11bfcc4b7562efd2eb73316ecab0500f2e12c109","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  $service_name                       \u003d $::congress::params::service_name,"},{"line_number":289,"context_line":"  $drivers                            \u003d $::congress::params::drivers,"},{"line_number":290,"context_line":"  $policy_path                        \u003d $::congress::params::policy_path,"},{"line_number":291,"context_line":"  $log_file                           \u003d $::congress::params::log_file,"},{"line_number":292,"context_line":"  $log_dir                            \u003d $::congress::params::log_dir,"},{"line_number":293,"context_line":"  $sync_db                            \u003d true,"},{"line_number":294,"context_line":") inherits congress::params {"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":19,"id":"1aa78d24_6677263c","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":69},"updated":"2016-07-14 00:44:17.000000000","message":"same from above for this parameters","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f2b1ccc3292ce5869c4e4b56ffa4e0a07aaf78d7","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  $service_name                       \u003d $::congress::params::service_name,"},{"line_number":289,"context_line":"  $drivers                            \u003d $::congress::params::drivers,"},{"line_number":290,"context_line":"  $policy_path                        \u003d $::congress::params::policy_path,"},{"line_number":291,"context_line":"  $log_file                           \u003d $::congress::params::log_file,"},{"line_number":292,"context_line":"  $log_dir                            \u003d $::congress::params::log_dir,"},{"line_number":293,"context_line":"  $sync_db                            \u003d true,"},{"line_number":294,"context_line":") inherits congress::params {"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":19,"id":"9ad45d7e_a197bbea","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":69},"in_reply_to":"1aa78d24_6677263c","updated":"2016-08-10 18:24:12.000000000","message":"Done","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11bfcc4b7562efd2eb73316ecab0500f2e12c109","unresolved":false,"context_lines":[{"line_number":301,"context_line":"  }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  if $identity_uri {"},{"line_number":304,"context_line":"    congress_config { \u0027keystone_authtoken/identity_uri\u0027: value \u003d\u003e $identity_uri; }"},{"line_number":305,"context_line":"    congress_config { \u0027keystone_authtoken/auth_url\u0027    : value \u003d\u003e $identity_uri; }"},{"line_number":306,"context_line":"  } else {"},{"line_number":307,"context_line":"    congress_config { \u0027keystone_authtoken/identity_uri\u0027: ensure \u003d\u003e absent; }"},{"line_number":308,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"1aa78d24_26299e38","line":305,"range":{"start_line":304,"start_character":4,"end_line":305,"end_character":82},"updated":"2016-07-14 00:44:17.000000000","message":"you don\u0027t need two congress_config for this\n\nwhy not have $auth_url?\n\nDo you know what services from congress (api,..) uses the the keystone_authtoken section in congress.conf?\nBecause this class is for common configuration if only congress::api use keystone_authtoken you should not use here","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f2b1ccc3292ce5869c4e4b56ffa4e0a07aaf78d7","unresolved":false,"context_lines":[{"line_number":301,"context_line":"  }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  if $identity_uri {"},{"line_number":304,"context_line":"    congress_config { \u0027keystone_authtoken/identity_uri\u0027: value \u003d\u003e $identity_uri; }"},{"line_number":305,"context_line":"    congress_config { \u0027keystone_authtoken/auth_url\u0027    : value \u003d\u003e $identity_uri; }"},{"line_number":306,"context_line":"  } else {"},{"line_number":307,"context_line":"    congress_config { \u0027keystone_authtoken/identity_uri\u0027: ensure \u003d\u003e absent; }"},{"line_number":308,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"9ad45d7e_0177a7d3","line":305,"range":{"start_line":304,"start_character":4,"end_line":305,"end_character":82},"in_reply_to":"1aa78d24_26299e38","updated":"2016-08-10 18:24:12.000000000","message":"I\u0027m not sure why this is configured this way, I\u0027m mostly following the docs given to me to configure it.\n\nI think only api uses it, so I\u0027ll just pull it out here","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11bfcc4b7562efd2eb73316ecab0500f2e12c109","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    congress_config { \u0027keystone_authtoken/identity_uri\u0027: ensure \u003d\u003e absent; }"},{"line_number":308,"context_line":"  }"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  include ::congress::params"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  if $sync_db {"},{"line_number":313,"context_line":"    include ::congress::db::sync"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"1aa78d24_a6158ee6","line":310,"range":{"start_line":310,"start_character":1,"end_line":310,"end_character":28},"updated":"2016-07-14 00:44:17.000000000","message":"why include ::congress::params if you are using inherits in line 294?","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f2b1ccc3292ce5869c4e4b56ffa4e0a07aaf78d7","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    congress_config { \u0027keystone_authtoken/identity_uri\u0027: ensure \u003d\u003e absent; }"},{"line_number":308,"context_line":"  }"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"  include ::congress::params"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  if $sync_db {"},{"line_number":313,"context_line":"    include ::congress::db::sync"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"9ad45d7e_c1b90f7b","line":310,"range":{"start_line":310,"start_character":1,"end_line":310,"end_character":28},"in_reply_to":"1aa78d24_a6158ee6","updated":"2016-08-10 18:24:12.000000000","message":"removed","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5a9088a80bfb748f675c9a9f9ed45d49f17a1c99","unresolved":false,"context_lines":[{"line_number":230,"context_line":"#"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class congress("},{"line_number":233,"context_line":"  $keystone_password,"},{"line_number":234,"context_line":"  $package_ensure                     \u003d \u0027present\u0027,"},{"line_number":235,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":236,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9ad45d7e_1cea6adb","line":233,"range":{"start_line":233,"start_character":1,"end_line":233,"end_character":21},"updated":"2016-08-10 18:24:01.000000000","message":"you don\u0027t use anywhere.","commit_id":"78269f879c264e9cea49b49fc7ab2ee330999584"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"a9cedc5740ed3c2fc69ed98a6292302dcdcd91aa","unresolved":false,"context_lines":[{"line_number":230,"context_line":"#"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class congress("},{"line_number":233,"context_line":"  $keystone_password,"},{"line_number":234,"context_line":"  $package_ensure                     \u003d \u0027present\u0027,"},{"line_number":235,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":236,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9ad45d7e_052de094","line":233,"range":{"start_line":233,"start_character":1,"end_line":233,"end_character":21},"in_reply_to":"9ad45d7e_1cea6adb","updated":"2016-08-11 02:32:06.000000000","message":"removed","commit_id":"78269f879c264e9cea49b49fc7ab2ee330999584"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5a9088a80bfb748f675c9a9f9ed45d49f17a1c99","unresolved":false,"context_lines":[{"line_number":235,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":236,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"},{"line_number":237,"context_line":"  $bind_port                          \u003d \u00271789\u0027,"},{"line_number":238,"context_line":"  $identity_uri                       \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":239,"context_line":"  $keystone_tenant                    \u003d \u0027services\u0027,"},{"line_number":240,"context_line":"  $keystone_user                      \u003d \u0027congress\u0027,"},{"line_number":241,"context_line":"  $manage_service                     \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9ad45d7e_3cc48e5d","line":238,"range":{"start_line":238,"start_character":2,"end_line":238,"end_character":16},"updated":"2016-08-10 18:24:01.000000000","message":"this is deprecated. auth_url and auth_uri, all keystone_authtoken parameters are going to be in congress::keystone::authtoken class see https://review.openstack.org/#/c/351778/","commit_id":"78269f879c264e9cea49b49fc7ab2ee330999584"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"a9cedc5740ed3c2fc69ed98a6292302dcdcd91aa","unresolved":false,"context_lines":[{"line_number":235,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":236,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"},{"line_number":237,"context_line":"  $bind_port                          \u003d \u00271789\u0027,"},{"line_number":238,"context_line":"  $identity_uri                       \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":239,"context_line":"  $keystone_tenant                    \u003d \u0027services\u0027,"},{"line_number":240,"context_line":"  $keystone_user                      \u003d \u0027congress\u0027,"},{"line_number":241,"context_line":"  $manage_service                     \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"9ad45d7e_452358a7","line":238,"range":{"start_line":238,"start_character":2,"end_line":238,"end_character":16},"in_reply_to":"9ad45d7e_3cc48e5d","updated":"2016-08-11 02:32:06.000000000","message":"removed","commit_id":"78269f879c264e9cea49b49fc7ab2ee330999584"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8931d2cffee2cc604093fe2ddd79fe839fe8017","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   (optional) Port that congress binds to."},{"line_number":24,"context_line":"#   Defaults to \u00271789\u0027"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*keystone_tenant*]"},{"line_number":27,"context_line":"#   (optional) Tenant to authenticate to."},{"line_number":28,"context_line":"#   Defaults to \u0027services\u0027"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*keystone_user*]"},{"line_number":31,"context_line":"#   (optional) User to authenticate as with keystone."},{"line_number":32,"context_line":"#   Defaults to \u0027congress\u0027"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*manage_service*]"},{"line_number":35,"context_line":"#   (Optional) If Puppet should manage service startup / shutdown."}],"source_content_type":"text/x-puppet","patch_set":21,"id":"9ad45d7e_e5e52c38","line":32,"range":{"start_line":26,"start_character":0,"end_line":32,"end_character":26},"updated":"2016-08-11 02:40:45.000000000","message":"remove","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"b44f331bcb841afc5d935c7e80f7d66f937719c5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   (optional) Port that congress binds to."},{"line_number":24,"context_line":"#   Defaults to \u00271789\u0027"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*keystone_tenant*]"},{"line_number":27,"context_line":"#   (optional) Tenant to authenticate to."},{"line_number":28,"context_line":"#   Defaults to \u0027services\u0027"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*keystone_user*]"},{"line_number":31,"context_line":"#   (optional) User to authenticate as with keystone."},{"line_number":32,"context_line":"#   Defaults to \u0027congress\u0027"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*manage_service*]"},{"line_number":35,"context_line":"#   (Optional) If Puppet should manage service startup / shutdown."}],"source_content_type":"text/x-puppet","patch_set":21,"id":"9ad45d7e_252d84fe","line":32,"range":{"start_line":26,"start_character":0,"end_line":32,"end_character":26},"in_reply_to":"9ad45d7e_e5e52c38","updated":"2016-08-11 02:55:47.000000000","message":"Done","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8931d2cffee2cc604093fe2ddd79fe839fe8017","unresolved":false,"context_lines":[{"line_number":221,"context_line":"#"},{"line_number":222,"context_line":"# Copyright 2016 Red Hat Inc, unless otherwise noted."},{"line_number":223,"context_line":"#"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"class congress("},{"line_number":226,"context_line":"  $package_ensure                     \u003d \u0027present\u0027,"},{"line_number":227,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"9ad45d7e_25ebc414","line":224,"updated":"2016-08-11 02:40:45.000000000","message":"you can remove this line","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"b44f331bcb841afc5d935c7e80f7d66f937719c5","unresolved":false,"context_lines":[{"line_number":221,"context_line":"#"},{"line_number":222,"context_line":"# Copyright 2016 Red Hat Inc, unless otherwise noted."},{"line_number":223,"context_line":"#"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"class congress("},{"line_number":226,"context_line":"  $package_ensure                     \u003d \u0027present\u0027,"},{"line_number":227,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"9ad45d7e_a5fa1473","line":224,"in_reply_to":"9ad45d7e_25ebc414","updated":"2016-08-11 02:55:47.000000000","message":"Done","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8931d2cffee2cc604093fe2ddd79fe839fe8017","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":228,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"},{"line_number":229,"context_line":"  $bind_port                          \u003d \u00271789\u0027,"},{"line_number":230,"context_line":"  $keystone_tenant                    \u003d \u0027services\u0027,"},{"line_number":231,"context_line":"  $keystone_user                      \u003d \u0027congress\u0027,"},{"line_number":232,"context_line":"  $manage_service                     \u003d true,"},{"line_number":233,"context_line":"  $enabled                            \u003d true,"},{"line_number":234,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"9ad45d7e_657adc78","line":231,"range":{"start_line":230,"start_character":0,"end_line":231,"end_character":51},"updated":"2016-08-11 02:40:45.000000000","message":"you\u0027re not using this too ;)","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"b44f331bcb841afc5d935c7e80f7d66f937719c5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  $client_package_ensure              \u003d \u0027present\u0027,"},{"line_number":228,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"},{"line_number":229,"context_line":"  $bind_port                          \u003d \u00271789\u0027,"},{"line_number":230,"context_line":"  $keystone_tenant                    \u003d \u0027services\u0027,"},{"line_number":231,"context_line":"  $keystone_user                      \u003d \u0027congress\u0027,"},{"line_number":232,"context_line":"  $manage_service                     \u003d true,"},{"line_number":233,"context_line":"  $enabled                            \u003d true,"},{"line_number":234,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"9ad45d7e_e5f08c93","line":231,"range":{"start_line":230,"start_character":0,"end_line":231,"end_character":51},"in_reply_to":"9ad45d7e_657adc78","updated":"2016-08-11 02:55:47.000000000","message":"Done","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b3b7a6e92f815bb47fe3ac557015f291a14de08f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"  $amqp_sasl_config_name              \u003d $::os_service_default,"},{"line_number":255,"context_line":"  $amqp_username                      \u003d $::os_service_default,"},{"line_number":256,"context_line":"  $amqp_password                      \u003d $::os_service_default,"},{"line_number":257,"context_line":"  $service_provider                   \u003d $::congress::params::service_provider,"},{"line_number":258,"context_line":"  $service_name                       \u003d $::congress::params::service_name,"},{"line_number":259,"context_line":"  $drivers                            \u003d $::congress::params::drivers,"},{"line_number":260,"context_line":"  $policy_path                        \u003d $::congress::params::policy_path,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"9ad45d7e_056297ad","line":257,"updated":"2016-08-12 15:20:20.000000000","message":"you don\u0027t need that.","commit_id":"2dcfc95f88b42ae91c13eeee2c972ea979b51b62"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"c69ae46cd02ad0d468898534596ef966073a8620","unresolved":false,"context_lines":[{"line_number":254,"context_line":"  $amqp_sasl_config_name              \u003d $::os_service_default,"},{"line_number":255,"context_line":"  $amqp_username                      \u003d $::os_service_default,"},{"line_number":256,"context_line":"  $amqp_password                      \u003d $::os_service_default,"},{"line_number":257,"context_line":"  $service_provider                   \u003d $::congress::params::service_provider,"},{"line_number":258,"context_line":"  $service_name                       \u003d $::congress::params::service_name,"},{"line_number":259,"context_line":"  $drivers                            \u003d $::congress::params::drivers,"},{"line_number":260,"context_line":"  $policy_path                        \u003d $::congress::params::policy_path,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"7a8ec9b2_4824d0c5","line":257,"in_reply_to":"9ad45d7e_056297ad","updated":"2016-09-19 14:35:34.000000000","message":"Done","commit_id":"2dcfc95f88b42ae91c13eeee2c972ea979b51b62"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3163bffb5032e1db786b2b30030f075f66a7dbbe","unresolved":false,"context_lines":[{"line_number":255,"context_line":"  include ::congress::logging"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"  congress_config {"},{"line_number":258,"context_line":"    \u0027DEFAULT/drivers\u0027     : value \u003d\u003e $drivers;"},{"line_number":259,"context_line":"    \u0027DEFAULT/policy_path\u0027 : value \u003d\u003e $policy_path;"},{"line_number":260,"context_line":"  }"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":26,"id":"fa7ab95a_c0ccacbd","line":258,"updated":"2016-09-01 21:59:07.000000000","message":"If you switch drivers to support an array you could just do join(any2array($drivers), \u0027,\u0027) here instead to support both array and a string value input","commit_id":"31b86c67ef8b8983c2c7b5eb65a7d86ad780adbc"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"576e57d1fd8b1cb8bb11751900ee19adf1ec119c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"  include ::congress::logging"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"  congress_config {"},{"line_number":258,"context_line":"    \u0027DEFAULT/drivers\u0027     : value \u003d\u003e $drivers;"},{"line_number":259,"context_line":"    \u0027DEFAULT/policy_path\u0027 : value \u003d\u003e $policy_path;"},{"line_number":260,"context_line":"  }"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":26,"id":"7a8ec9b2_fb5568fa","line":258,"in_reply_to":"fa7ab95a_c0ccacbd","updated":"2016-09-19 14:35:09.000000000","message":"Done","commit_id":"31b86c67ef8b8983c2c7b5eb65a7d86ad780adbc"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0f30f377f21c89286d64b351927ebbe9aafd3e7c","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"},{"line_number":207,"context_line":"  $bind_port                          \u003d \u00271789\u0027,"},{"line_number":208,"context_line":"  $manage_service                     \u003d true,"},{"line_number":209,"context_line":"  $enabled                            \u003d true,"},{"line_number":210,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":211,"context_line":"  $rabbit_host                        \u003d $::os_service_default,"},{"line_number":212,"context_line":"  $rabbit_port                        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"7a8ec9b2_96942b45","line":209,"updated":"2016-09-19 18:36:57.000000000","message":"from 204 to here, maybe move it into a server.pp to manage congress server service. it will help to not have a huge init.pp. Though, you can keep messaging parameters here.","commit_id":"08399e3c5339426874ceb9b483c655e84e52721e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"53acd8d32b776cd964b18d65943801e762a7c5e6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  $bind_host                          \u003d \u00270.0.0.0\u0027,"},{"line_number":207,"context_line":"  $bind_port                          \u003d \u00271789\u0027,"},{"line_number":208,"context_line":"  $manage_service                     \u003d true,"},{"line_number":209,"context_line":"  $enabled                            \u003d true,"},{"line_number":210,"context_line":"  $rpc_backend                        \u003d \u0027rabbit\u0027,"},{"line_number":211,"context_line":"  $rabbit_host                        \u003d $::os_service_default,"},{"line_number":212,"context_line":"  $rabbit_port                        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"5a8bc5a2_4a645d21","line":209,"in_reply_to":"7a8ec9b2_96942b45","updated":"2016-09-23 20:23:03.000000000","message":"pulled that out, focusing on the init.pp for now\nI\u0027ll include it into the server.pp when I get there","commit_id":"08399e3c5339426874ceb9b483c655e84e52721e"}],"manifests/params.pp":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"cb6db5a4af171e4a262c1cb76bf5d408daf04c0a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      $package_name                 \u003d \u0027openstack-congress\u0027"},{"line_number":12,"context_line":"      $service_name                 \u003d \u0027openstack-congress\u0027"},{"line_number":13,"context_line":"      $sqlite_package_name          \u003d undef"},{"line_number":14,"context_line":"      $service_provider             \u003d undef"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    \u0027Debian\u0027: {"},{"line_number":17,"context_line":"      $package_name                 \u003d \u0027congress\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_6b0eb635","line":14,"range":{"start_line":14,"start_character":7,"end_line":14,"end_character":23},"updated":"2016-06-22 09:16:12.000000000","message":"why paste_config is not defined on redhat case, but on debian only?","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"213a2afa8985f8c231e8362be95391e0319a766e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      $package_name                 \u003d \u0027openstack-congress\u0027"},{"line_number":12,"context_line":"      $service_name                 \u003d \u0027openstack-congress\u0027"},{"line_number":13,"context_line":"      $sqlite_package_name          \u003d undef"},{"line_number":14,"context_line":"      $service_provider             \u003d undef"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    \u0027Debian\u0027: {"},{"line_number":17,"context_line":"      $package_name                 \u003d \u0027congress\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3aaa91ec_46bacfe2","line":14,"range":{"start_line":14,"start_character":7,"end_line":14,"end_character":23},"in_reply_to":"3aaa91ec_6b0eb635","updated":"2016-06-22 09:40:31.000000000","message":"no reason, I don\u0027t think paste_config ended up being used, I\u0027ll remove it","commit_id":"be84be06f8ea39e26f8d346f579d330ff109213e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"350eee261379cb09338fa30aad9e62aedaeb456f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  $client_package_name \u003d \u0027python-congressclient\u0027"},{"line_number":5,"context_line":"  $drivers \u003d \u0027congress.datasources.neutronv2_driver.NeutronV2Driver,congress.datasources.glancev2_driver.GlanceV2Driver,congress.datasources.nova_driver.NovaDriver,congress.datasources.keystone_driver.KeystoneDriver,congress.datasources.ceilometer_driver.CeilometerDriver,congress.datasources.cinder_driver.CinderDriver\u0027;"},{"line_number":6,"context_line":"  $policy_path \u003d \u0027/etc/congress/snapshot/\u0027"},{"line_number":7,"context_line":"  $log_file \u003d \u0027congress.log\u0027"},{"line_number":8,"context_line":"  $log_dir \u003d \u0027/var/log/congress/\u0027"},{"line_number":9,"context_line":"  case $::osfamily {"},{"line_number":10,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":11,"context_line":"      $package_name                 \u003d \u0027openstack-congress\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_af085f2e","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":32},"updated":"2016-06-23 12:52:15.000000000","message":"you already have this parameters in logging.pp not?","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"dee0fef7a62d38bfffe62f3138e46c02e840b133","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  $client_package_name \u003d \u0027python-congressclient\u0027"},{"line_number":5,"context_line":"  $drivers \u003d \u0027congress.datasources.neutronv2_driver.NeutronV2Driver,congress.datasources.glancev2_driver.GlanceV2Driver,congress.datasources.nova_driver.NovaDriver,congress.datasources.keystone_driver.KeystoneDriver,congress.datasources.ceilometer_driver.CeilometerDriver,congress.datasources.cinder_driver.CinderDriver\u0027;"},{"line_number":6,"context_line":"  $policy_path \u003d \u0027/etc/congress/snapshot/\u0027"},{"line_number":7,"context_line":"  $log_file \u003d \u0027congress.log\u0027"},{"line_number":8,"context_line":"  $log_dir \u003d \u0027/var/log/congress/\u0027"},{"line_number":9,"context_line":"  case $::osfamily {"},{"line_number":10,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":11,"context_line":"      $package_name                 \u003d \u0027openstack-congress\u0027"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_cc5e0479","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":32},"in_reply_to":"3aaa91ec_af085f2e","updated":"2020-11-23 14:58:42.000000000","message":"Done","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"350eee261379cb09338fa30aad9e62aedaeb456f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":11,"context_line":"      $package_name                 \u003d \u0027openstack-congress\u0027"},{"line_number":12,"context_line":"      $service_name                 \u003d \u0027openstack-congress\u0027"},{"line_number":13,"context_line":"      $sqlite_package_name          \u003d undef"},{"line_number":14,"context_line":"      $service_provider             \u003d undef"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    \u0027Debian\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_2151230f","line":13,"range":{"start_line":13,"start_character":6,"end_line":13,"end_character":26},"updated":"2016-06-23 12:52:15.000000000","message":"you don\u0027t need this because oslo::db will do this work \u003d)","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"dee0fef7a62d38bfffe62f3138e46c02e840b133","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":11,"context_line":"      $package_name                 \u003d \u0027openstack-congress\u0027"},{"line_number":12,"context_line":"      $service_name                 \u003d \u0027openstack-congress\u0027"},{"line_number":13,"context_line":"      $sqlite_package_name          \u003d undef"},{"line_number":14,"context_line":"      $service_provider             \u003d undef"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    \u0027Debian\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_4c6cd436","line":13,"range":{"start_line":13,"start_character":6,"end_line":13,"end_character":26},"in_reply_to":"3aaa91ec_2151230f","updated":"2020-11-23 14:58:42.000000000","message":"Done","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"350eee261379cb09338fa30aad9e62aedaeb456f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0027Debian\u0027: {"},{"line_number":17,"context_line":"      $package_name                 \u003d \u0027congress\u0027"},{"line_number":18,"context_line":"      $service_name                 \u003d \u0027congress\u0027"},{"line_number":19,"context_line":"      $sqlite_package_name          \u003d \u0027python-pysqlite2\u0027"},{"line_number":20,"context_line":"      case $::operatingsystem {"},{"line_number":21,"context_line":"        \u0027Debian\u0027: {"},{"line_number":22,"context_line":"          $service_provider         \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_0136a7e5","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":26},"updated":"2016-06-23 12:52:15.000000000","message":"same","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"dee0fef7a62d38bfffe62f3138e46c02e840b133","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0027Debian\u0027: {"},{"line_number":17,"context_line":"      $package_name                 \u003d \u0027congress\u0027"},{"line_number":18,"context_line":"      $service_name                 \u003d \u0027congress\u0027"},{"line_number":19,"context_line":"      $sqlite_package_name          \u003d \u0027python-pysqlite2\u0027"},{"line_number":20,"context_line":"      case $::operatingsystem {"},{"line_number":21,"context_line":"        \u0027Debian\u0027: {"},{"line_number":22,"context_line":"          $service_provider         \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3aaa91ec_ec8660da","line":19,"range":{"start_line":19,"start_character":6,"end_line":19,"end_character":26},"in_reply_to":"3aaa91ec_0136a7e5","updated":"2020-11-23 14:58:42.000000000","message":"Done","commit_id":"8e1dddbf46cee298890d2d71ddb6050cb7ce44a7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3163bffb5032e1db786b2b30030f075f66a7dbbe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  include ::openstacklib::defaults"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  $client_package_name \u003d \u0027python-congressclient\u0027"},{"line_number":7,"context_line":"  $drivers \u003d \u0027congress.datasources.neutronv2_driver.NeutronV2Driver,congress.datasources.glancev2_driver.GlanceV2Driver,congress.datasources.nova_driver.NovaDriver,congress.datasources.keystone_driver.KeystoneDriver,congress.datasources.ceilometer_driver.CeilometerDriver,congress.datasources.cinder_driver.CinderDriver\u0027"},{"line_number":8,"context_line":"  $policy_path \u003d \u0027/etc/congress/snapshot/\u0027"},{"line_number":9,"context_line":"  case $::osfamily {"},{"line_number":10,"context_line":"    \u0027RedHat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":26,"id":"fa7ab95a_a0c7a896","line":7,"updated":"2016-09-01 21:59:07.000000000","message":"This seems like it would be better as an array and to just join them where this is used.","commit_id":"31b86c67ef8b8983c2c7b5eb65a7d86ad780adbc"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"576e57d1fd8b1cb8bb11751900ee19adf1ec119c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  include ::openstacklib::defaults"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  $client_package_name \u003d \u0027python-congressclient\u0027"},{"line_number":7,"context_line":"  $drivers \u003d \u0027congress.datasources.neutronv2_driver.NeutronV2Driver,congress.datasources.glancev2_driver.GlanceV2Driver,congress.datasources.nova_driver.NovaDriver,congress.datasources.keystone_driver.KeystoneDriver,congress.datasources.ceilometer_driver.CeilometerDriver,congress.datasources.cinder_driver.CinderDriver\u0027"},{"line_number":8,"context_line":"  $policy_path \u003d \u0027/etc/congress/snapshot/\u0027"},{"line_number":9,"context_line":"  case $::osfamily {"},{"line_number":10,"context_line":"    \u0027RedHat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":26,"id":"7a8ec9b2_7be6b845","line":7,"in_reply_to":"fa7ab95a_a0c7a896","updated":"2016-09-19 14:35:09.000000000","message":"Done","commit_id":"31b86c67ef8b8983c2c7b5eb65a7d86ad780adbc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e61703f78f1369e664064226c9ed243cda6323cd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          $service_provider         \u003d undef"},{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":"        default: {"},{"line_number":27,"context_line":"          $service_provider         \u003d \u0027upstart\u0027"},{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"      }"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"5a8bc5a2_84536316","line":27,"updated":"2016-09-26 21:38:50.000000000","message":"Pretty sure this isn\u0027t correct since we\u0027re on xenial now. You could check the $operatingsystemrelease but I\u0027m not sure we even need to support trusty for this module.  Also is this even used?","commit_id":"45a780632a3b7441742dd47fde83dbd48173f673"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fd331c1ef39b349b689a10fcb6f5b41d74671198","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          $service_provider         \u003d undef"},{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":"        default: {"},{"line_number":27,"context_line":"          $service_provider         \u003d \u0027upstart\u0027"},{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"      }"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"5a8bc5a2_47bf9da9","line":27,"in_reply_to":"5a8bc5a2_47187d75","updated":"2016-09-26 22:14:19.000000000","message":"I\u0027d rather just remove it now or fix it. Since this is the only commit out there it doesn\u0027t make sense to have it right now.  I\u0027m not against it existing if it serves a purpose but it doesn\u0027t at the moment and there don\u0027t appear to be any follow on commits requiring it at the moment.","commit_id":"45a780632a3b7441742dd47fde83dbd48173f673"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"ece0b22afdcc219b53bf3d627391cdee550f9d0f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          $service_provider         \u003d undef"},{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":"        default: {"},{"line_number":27,"context_line":"          $service_provider         \u003d \u0027upstart\u0027"},{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"      }"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"5a8bc5a2_0c5e5f76","line":27,"in_reply_to":"5a8bc5a2_472a3d91","updated":"2016-09-27 19:32:26.000000000","message":"Done","commit_id":"45a780632a3b7441742dd47fde83dbd48173f673"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ddba4df0bd91f69b05c43992a2c382eb4f95117a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          $service_provider         \u003d undef"},{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":"        default: {"},{"line_number":27,"context_line":"          $service_provider         \u003d \u0027upstart\u0027"},{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"      }"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"5a8bc5a2_472a3d91","line":27,"in_reply_to":"5a8bc5a2_47bf9da9","updated":"2016-09-26 22:27:09.000000000","message":"yeah this can be added in other commit \u003d)","commit_id":"45a780632a3b7441742dd47fde83dbd48173f673"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"90bfb9b5e94fd9af74be335dad40685744cb80ed","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          $service_provider         \u003d undef"},{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":"        default: {"},{"line_number":27,"context_line":"          $service_provider         \u003d \u0027upstart\u0027"},{"line_number":28,"context_line":"        }"},{"line_number":29,"context_line":"      }"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"5a8bc5a2_47187d75","line":27,"in_reply_to":"5a8bc5a2_84536316","updated":"2016-09-26 22:04:51.000000000","message":"Since the puppet-congress module was moved to the openstack domain we asked Dan to move all code from the old repo in separated commits..\nIn the old repo we have the support https://github.com/radez/puppet-congress/blob/stable/mitaka/manifests/params.pp","commit_id":"45a780632a3b7441742dd47fde83dbd48173f673"}],"spec/acceptance/basic_congress_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"05aa4bab12e6dbbec9919abefaf6ce6c058c5691","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        rabbit_password     \u003d\u003e \u0027an_even_bigger_secret\u0027,"},{"line_number":37,"context_line":"        rabbit_host         \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":38,"context_line":"        rpc_backend         \u003d\u003e \u0027rabbit\u0027,"},{"line_number":39,"context_line":"        database_connection \u003d\u003e \u0027mysql+pymysql://congress:a_big_secret@127.0.0.1/congress?charset\u003dutf8\u0027,"},{"line_number":40,"context_line":"        admin_password      \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":41,"context_line":"      }"},{"line_number":42,"context_line":"      class { \u0027::congress::keystone::auth\u0027:"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1aa78d24_515e0b77","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":26},"updated":"2016-07-08 15:11:39.000000000","message":"Tests are failling because you dont have this parameter in init.pp, the connection is in congress::db class.","commit_id":"80cc21ac0a973bfdb5e5d76d39403d5006e69a25"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9f3302eab37ad4a86d50aa9576555715a5958cff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        rabbit_password     \u003d\u003e \u0027an_even_bigger_secret\u0027,"},{"line_number":37,"context_line":"        rabbit_host         \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":38,"context_line":"        rpc_backend         \u003d\u003e \u0027rabbit\u0027,"},{"line_number":39,"context_line":"        database_connection \u003d\u003e \u0027mysql+pymysql://congress:a_big_secret@127.0.0.1/congress?charset\u003dutf8\u0027,"},{"line_number":40,"context_line":"        admin_password      \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":41,"context_line":"      }"},{"line_number":42,"context_line":"      class { \u0027::congress::keystone::auth\u0027:"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1aa78d24_2c0966de","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":26},"in_reply_to":"1aa78d24_515e0b77","updated":"2016-07-08 15:19:13.000000000","message":"Take a look at: https://github.com/openstack/puppet-octavia/blob/master/spec/acceptance/octavia_spec.rb it can be useful","commit_id":"80cc21ac0a973bfdb5e5d76d39403d5006e69a25"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f53ed6624720156bf50975b4f8d581df2de6db5f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        rabbit_password     \u003d\u003e \u0027an_even_bigger_secret\u0027,"},{"line_number":37,"context_line":"        rabbit_host         \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":38,"context_line":"        rpc_backend         \u003d\u003e \u0027rabbit\u0027,"},{"line_number":39,"context_line":"        database_connection \u003d\u003e \u0027mysql+pymysql://congress:a_big_secret@127.0.0.1/congress?charset\u003dutf8\u0027,"},{"line_number":40,"context_line":"        admin_password      \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":41,"context_line":"      }"},{"line_number":42,"context_line":"      class { \u0027::congress::keystone::auth\u0027:"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1aa78d24_f0c0c87e","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":26},"in_reply_to":"1aa78d24_515e0b77","updated":"2016-07-08 17:44:42.000000000","message":"thanks, I tried to clean that up now.","commit_id":"80cc21ac0a973bfdb5e5d76d39403d5006e69a25"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"baa128db26890313a5ef1a31af71a9d1d216fbde","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      class { \u0027::congress::db::mysql\u0027:"},{"line_number":32,"context_line":"        password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":33,"context_line":"      }"},{"line_number":34,"context_line":"      class { \u0027::congress\u0027:"},{"line_number":35,"context_line":"        rabbit_userid       \u003d\u003e \u0027congress\u0027,"},{"line_number":36,"context_line":"        rabbit_password     \u003d\u003e \u0027an_even_bigger_secret\u0027,"},{"line_number":37,"context_line":"        rabbit_host         \u003d\u003e \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"1aa78d24_5dcc4361","line":34,"updated":"2016-07-09 04:07:27.000000000","message":"before call congress i think you need to create the endpoint, you need to call class \u0027::congress::keystone::auth\u0027:\u0027\nconfigure the db and logging i.e:\n\n\nclass { \u0027::congress::keystone::auth\u0027:\n  password \u003d\u003e \u0027a_big_secret\u0027,\n}\n\nclass { \u0027::congress::db\u0027:\n  database_connection \u003d\u003e \u0027mysql+pymysql...\u0027 (see patch16)\n}\n\nclass { \u0027::congress::logging\u0027:\n  debug \u003d\u003e true,\n}\n\n#the last thing in the manifest is \n\nclass { \u0027::congress\u0027:\n..\n}","commit_id":"404bd185453455fe2d1e99a84cdf45a51d837d0e"}],"spec/classes/congress_init_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"59e8eaba9b75bbd93f02a58e73fa083458960119","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    context \"on #{os}\" do"},{"line_number":282,"context_line":"      let (:facts) do"},{"line_number":283,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":284,"context_line":"      end"},{"line_number":285,"context_line":"    end"},{"line_number":286,"context_line":"  end"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"1aa78d24_df134b0c","line":284,"updated":"2016-07-02 01:22:34.000000000","message":"Also you need to add platform_params and set the package name because congress is only for Debian (https://review.openstack.org/#/c/330195/12/manifests/params.pp) and you hardcoded in line 20","commit_id":"159bc6c274ca3e6f36ec7bb015478a7bb9719282"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"305c2c08dc51a97cc8dacdfe400add0ad9f28f45","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    context \"on #{os}\" do"},{"line_number":282,"context_line":"      let (:facts) do"},{"line_number":283,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":284,"context_line":"      end"},{"line_number":285,"context_line":"    end"},{"line_number":286,"context_line":"  end"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"1aa78d24_2d091bde","line":284,"in_reply_to":"1aa78d24_df134b0c","updated":"2016-07-05 17:45:45.000000000","message":"Done","commit_id":"159bc6c274ca3e6f36ec7bb015478a7bb9719282"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"59e8eaba9b75bbd93f02a58e73fa083458960119","unresolved":false,"context_lines":[{"line_number":282,"context_line":"      let (:facts) do"},{"line_number":283,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":284,"context_line":"      end"},{"line_number":285,"context_line":"    end"},{"line_number":286,"context_line":"  end"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"1aa78d24_1f48332d","line":285,"updated":"2016-07-02 01:22:34.000000000","message":"I think you missed it_behaves_like \u0027congress\u0027","commit_id":"159bc6c274ca3e6f36ec7bb015478a7bb9719282"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"305c2c08dc51a97cc8dacdfe400add0ad9f28f45","unresolved":false,"context_lines":[{"line_number":282,"context_line":"      let (:facts) do"},{"line_number":283,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":284,"context_line":"      end"},{"line_number":285,"context_line":"    end"},{"line_number":286,"context_line":"  end"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":12,"id":"1aa78d24_8d100f03","line":285,"in_reply_to":"1aa78d24_1f48332d","updated":"2016-07-05 17:45:45.000000000","message":"Done","commit_id":"159bc6c274ca3e6f36ec7bb015478a7bb9719282"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11bfcc4b7562efd2eb73316ecab0500f2e12c109","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    context \u0027with kombu_reconnect_delay set to 5.0\u0027 do"},{"line_number":106,"context_line":"      let :params do"},{"line_number":107,"context_line":"        { :keystone_password     \u003d\u003e \u0027ks_password\u0027,"},{"line_number":108,"context_line":"          :rabbit_password   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":109,"context_line":"          :kombu_reconnect_delay \u003d\u003e \u00275.0\u0027 }"},{"line_number":110,"context_line":"      end"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":19,"id":"1aa78d24_c6d9ba24","line":108,"range":{"start_line":108,"start_character":29,"end_line":108,"end_character":31},"updated":"2016-07-14 00:44:17.000000000","message":"nit: identation","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f2b1ccc3292ce5869c4e4b56ffa4e0a07aaf78d7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    context \u0027with kombu_reconnect_delay set to 5.0\u0027 do"},{"line_number":106,"context_line":"      let :params do"},{"line_number":107,"context_line":"        { :keystone_password     \u003d\u003e \u0027ks_password\u0027,"},{"line_number":108,"context_line":"          :rabbit_password   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":109,"context_line":"          :kombu_reconnect_delay \u003d\u003e \u00275.0\u0027 }"},{"line_number":110,"context_line":"      end"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":19,"id":"9ad45d7e_6105c312","line":108,"range":{"start_line":108,"start_character":29,"end_line":108,"end_character":31},"in_reply_to":"1aa78d24_c6d9ba24","updated":"2016-08-10 18:24:12.000000000","message":"Done","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"11bfcc4b7562efd2eb73316ecab0500f2e12c109","unresolved":false,"context_lines":[{"line_number":150,"context_line":"      it \u0027configures rabbit\u0027 do"},{"line_number":151,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_host\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":152,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_port\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":153,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_hosts\u0027).with_value(\u0027rabbit:5673\u0027)"},{"line_number":154,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":155,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_use_ssl\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":156,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/amqp_durable_queues\u0027).with_value(true)"}],"source_content_type":"text/x-ruby","patch_set":19,"id":"1aa78d24_e662f63c","line":153,"range":{"start_line":153,"start_character":96,"end_line":153,"end_character":110},"updated":"2016-07-14 00:44:17.000000000","message":"You put rabbit_hosts as list and here you put string in init i don\u0027t see the join if you wan\u0027t a string in congress.conf \u003d)","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"f2b1ccc3292ce5869c4e4b56ffa4e0a07aaf78d7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"      it \u0027configures rabbit\u0027 do"},{"line_number":151,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_host\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":152,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_port\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":153,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_hosts\u0027).with_value(\u0027rabbit:5673\u0027)"},{"line_number":154,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_ha_queues\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":155,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/rabbit_use_ssl\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":156,"context_line":"        is_expected.to contain_congress_config(\u0027oslo_messaging_rabbit/amqp_durable_queues\u0027).with_value(true)"}],"source_content_type":"text/x-ruby","patch_set":19,"id":"9ad45d7e_5c6b4285","line":153,"range":{"start_line":153,"start_character":96,"end_line":153,"end_character":110},"in_reply_to":"1aa78d24_e662f63c","updated":"2016-08-10 18:24:12.000000000","message":"updated this to an array","commit_id":"8345a9ee403cefbf2a73da4676f9c2c75d0526c7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8931d2cffee2cc604093fe2ddd79fe839fe8017","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":8,"context_line":"      let :params do"},{"line_number":9,"context_line":"        { :keystone_password \u003d\u003e \u0027ks_password\u0027,"},{"line_number":10,"context_line":"          :rabbit_password   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":11,"context_line":"        }"},{"line_number":12,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_854a7024","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":46},"updated":"2016-08-11 02:40:45.000000000","message":"you don\u0027t have this parameter in init, the parameter is in congress::keystone::authtoken (password)","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"b44f331bcb841afc5d935c7e80f7d66f937719c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":8,"context_line":"      let :params do"},{"line_number":9,"context_line":"        { :keystone_password \u003d\u003e \u0027ks_password\u0027,"},{"line_number":10,"context_line":"          :rabbit_password   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":11,"context_line":"        }"},{"line_number":12,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_e51eccb9","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":46},"in_reply_to":"9ad45d7e_854a7024","updated":"2016-08-11 02:55:47.000000000","message":"Done","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8931d2cffee2cc604093fe2ddd79fe839fe8017","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":41,"context_line":"      let :params do"},{"line_number":42,"context_line":"        { :keystone_password                  \u003d\u003e \u0027ks_password\u0027,"},{"line_number":43,"context_line":"          :rabbit_host                        \u003d\u003e \u0027rabbit\u0027,"},{"line_number":44,"context_line":"          :rabbit_userid                      \u003d\u003e \u0027rabbit_user\u0027,"},{"line_number":45,"context_line":"          :rabbit_port                        \u003d\u003e \u00275673\u0027,"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_e56a4c80","line":42,"range":{"start_line":42,"start_character":9,"end_line":42,"end_character":29},"updated":"2016-08-11 02:40:45.000000000","message":"remove","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"b44f331bcb841afc5d935c7e80f7d66f937719c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":41,"context_line":"      let :params do"},{"line_number":42,"context_line":"        { :keystone_password                  \u003d\u003e \u0027ks_password\u0027,"},{"line_number":43,"context_line":"          :rabbit_host                        \u003d\u003e \u0027rabbit\u0027,"},{"line_number":44,"context_line":"          :rabbit_userid                      \u003d\u003e \u0027rabbit_user\u0027,"},{"line_number":45,"context_line":"          :rabbit_port                        \u003d\u003e \u00275673\u0027,"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_a52854e3","line":42,"range":{"start_line":42,"start_character":9,"end_line":42,"end_character":29},"in_reply_to":"9ad45d7e_e56a4c80","updated":"2016-08-11 02:55:47.000000000","message":"Done","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8931d2cffee2cc604093fe2ddd79fe839fe8017","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    context \u0027with rabbit_hosts parameter\u0027 do"},{"line_number":69,"context_line":"      let :params do"},{"line_number":70,"context_line":"        { :keystone_password \u003d\u003e \u0027ks_password\u0027,"},{"line_number":71,"context_line":"          :rabbit_password   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":72,"context_line":"          :rabbit_hosts      \u003d\u003e [\u0027rabbit:5673\u0027, \u0027rabbit2:5674\u0027]"},{"line_number":73,"context_line":"        }"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_650dbce7","line":70,"range":{"start_line":70,"start_character":10,"end_line":70,"end_character":46},"updated":"2016-08-11 02:40:45.000000000","message":"remove","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"b44f331bcb841afc5d935c7e80f7d66f937719c5","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    context \u0027with rabbit_hosts parameter\u0027 do"},{"line_number":69,"context_line":"      let :params do"},{"line_number":70,"context_line":"        { :keystone_password \u003d\u003e \u0027ks_password\u0027,"},{"line_number":71,"context_line":"          :rabbit_password   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":72,"context_line":"          :rabbit_hosts      \u003d\u003e [\u0027rabbit:5673\u0027, \u0027rabbit2:5674\u0027]"},{"line_number":73,"context_line":"        }"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_c51bc8c8","line":70,"range":{"start_line":70,"start_character":10,"end_line":70,"end_character":46},"in_reply_to":"9ad45d7e_650dbce7","updated":"2016-08-11 02:55:47.000000000","message":"Done","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8931d2cffee2cc604093fe2ddd79fe839fe8017","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    context \u0027with rabbit_hosts parameter (one server)\u0027 do"},{"line_number":88,"context_line":"      let :params do"},{"line_number":89,"context_line":"        { :keystone_password \u003d\u003e \u0027ks_password\u0027,"},{"line_number":90,"context_line":"          :rabbit_password   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":91,"context_line":"          :rabbit_hosts      \u003d\u003e [\u0027rabbit:5673\u0027] }"},{"line_number":92,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_e501acb0","line":89,"range":{"start_line":89,"start_character":10,"end_line":89,"end_character":45},"updated":"2016-08-11 02:40:45.000000000","message":"remove","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"b44f331bcb841afc5d935c7e80f7d66f937719c5","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    context \u0027with rabbit_hosts parameter (one server)\u0027 do"},{"line_number":88,"context_line":"      let :params do"},{"line_number":89,"context_line":"        { :keystone_password \u003d\u003e \u0027ks_password\u0027,"},{"line_number":90,"context_line":"          :rabbit_password   \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":91,"context_line":"          :rabbit_hosts      \u003d\u003e [\u0027rabbit:5673\u0027] }"},{"line_number":92,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_257bc4f6","line":89,"range":{"start_line":89,"start_character":10,"end_line":89,"end_character":45},"in_reply_to":"9ad45d7e_e501acb0","updated":"2016-08-11 02:55:47.000000000","message":"Done","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e8931d2cffee2cc604093fe2ddd79fe839fe8017","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    end"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    context \u0027with overriden amqp parameters\u0027 do"},{"line_number":229,"context_line":"      let :params do"},{"line_number":230,"context_line":"        { :keystone_password     \u003d\u003e \u0027ks_password\u0027,"},{"line_number":231,"context_line":"          :rpc_backend           \u003d\u003e \u0027amqp\u0027,"},{"line_number":232,"context_line":"          :amqp_idle_timeout     \u003d\u003e \u002760\u0027,"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_a5221450","line":229,"updated":"2016-08-11 02:40:45.000000000","message":"please remove all keystone_password in this file \u003d)","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"b44f331bcb841afc5d935c7e80f7d66f937719c5","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    end"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    context \u0027with overriden amqp parameters\u0027 do"},{"line_number":229,"context_line":"      let :params do"},{"line_number":230,"context_line":"        { :keystone_password     \u003d\u003e \u0027ks_password\u0027,"},{"line_number":231,"context_line":"          :rpc_backend           \u003d\u003e \u0027amqp\u0027,"},{"line_number":232,"context_line":"          :amqp_idle_timeout     \u003d\u003e \u002760\u0027,"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"9ad45d7e_058040bf","line":229,"in_reply_to":"9ad45d7e_a5221450","updated":"2016-08-11 02:55:47.000000000","message":"Done","commit_id":"839bdd39e4b92575792a182081d02526ce5a00b6"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4ab44e34d1a70be98311f5b3c94400d436f56b13","unresolved":false,"context_lines":[{"line_number":1,"context_line":"describe \u0027congress\u0027 do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  shared_examples \u0027congress\u0027 do"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":24,"id":"9ad45d7e_21243d5c","line":1,"updated":"2016-08-11 13:10:19.000000000","message":"missing require \u0027spec_helper\u0027 in the first line","commit_id":"635ec606ba1fdc956f77206826e72a89828ccbd8"},{"author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"change_message_id":"3d2111ca4261762b8916cd438fca556e05937cfe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"describe \u0027congress\u0027 do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  shared_examples \u0027congress\u0027 do"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":24,"id":"9ad45d7e_317f66e1","line":1,"in_reply_to":"9ad45d7e_21243d5c","updated":"2016-08-11 14:27:37.000000000","message":"I took that out, it\u0027s what was failing :( I guess it has to be there?","commit_id":"635ec606ba1fdc956f77206826e72a89828ccbd8"}]}