)]}'
{"manifests/db/powerdns/sync.pp":[{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"5ad4bf364bc9c312a831d2bf2907bd794f57ff94","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"class designate::db::powerdns::sync inherits designate::params {"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  Designate_config\u003c||\u003e -\u003e Exec[\u0027designate-powerdns-dbsync\u0027]"},{"line_number":7,"context_line":"  Designate_config\u003c| title \u003d\u003d \u0027bakend:powerdns/connection\u0027 |\u003e ~\u003e Exec[\u0027designate-powerdns-dbsync\u0027]"},{"line_number":8,"context_line":"  Exec[\u0027designate-powerdns-dbsync\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027designate-central\u0027 |\u003e"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_6598aec0","line":6,"updated":"2015-07-09 18:57:25.000000000","message":"Does there not need to be a package dependency here?  I am not really familiar with designate, so maybe I\u0027m just not understanding.","commit_id":"984815363a9ea99eebc74c736048fdeb15e7f6f8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"282f54707ddc5759df3971c941616f01bc70b5a8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"class designate::db::powerdns::sync inherits designate::params {"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  Designate_config\u003c||\u003e -\u003e Exec[\u0027designate-powerdns-dbsync\u0027]"},{"line_number":7,"context_line":"  Designate_config\u003c| title \u003d\u003d \u0027bakend:powerdns/connection\u0027 |\u003e ~\u003e Exec[\u0027designate-powerdns-dbsync\u0027]"},{"line_number":8,"context_line":"  Exec[\u0027designate-powerdns-dbsync\u0027] ~\u003e Service\u003c| title \u003d\u003d \u0027designate-central\u0027 |\u003e"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_4b08cd91","line":6,"in_reply_to":"ba3cc151_6598aec0","updated":"2015-07-13 13:16:06.000000000","message":"+1","commit_id":"984815363a9ea99eebc74c736048fdeb15e7f6f8"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"873a170b2caaac07e7038dd8e9262419cf12f2b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  include ::designate::params"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  Anchor\u003c| title \u003d\u003d \u0027designate::config::end\u0027 |\u003e ~\u003e Exec[\u0027designate-powerdns-dbsync\u0027]"},{"line_number":9,"context_line":"  Exec[\u0027designate-powerdns-dbsync\u0027] ~\u003e Anchor \u003c| title \u003d\u003d \u0027designate::service::begin\u0027 |\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  exec { \u0027designate-powerdns-dbsync\u0027:"},{"line_number":12,"context_line":"    command     \u003d\u003e $::designate::params::powerdns_dbsync_command,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a50d1a3_380f048a","line":9,"updated":"2015-07-30 11:37:42.000000000","message":"I think you should be able to change both of these to be subscribe and notify attributes below without using the collector syntax.  Then you\u0027ll be able to test it also.  You also need to have this subscribe to the designate::install::end anchor so that if new software is installed you attempt to run any new migrations if available.","commit_id":"3b29f82c628a7c65846ad188a60b9d6407ca2939"}],"manifests/db/sync.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"2499996918bcec0f60feb675e21f3455261f9738","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  include ::designate::params"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  Package\u003c| title \u003d\u003d \u0027designate-common\u0027 |\u003e -\u003e Class[\u0027::designate::db::sync\u0027]"},{"line_number":9,"context_line":"  Designate_config\u003c||\u003e -\u003e Exec[\u0027designate-dbsync\u0027]"},{"line_number":10,"context_line":"  Designate_config\u003c| title \u003d\u003d \u0027storage:sqlalchemy/connection\u0027 |\u003e ~\u003e Exec[\u0027designate-dbsync\u0027]"},{"line_number":11,"context_line":"  Exec[\u0027designate-dbsync\u0027] ~\u003e Service \u003c| title \u003d\u003d \u0027designate-api\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a41bdd9_d07518fa","line":8,"updated":"2015-07-14 20:09:54.000000000","message":"Package upgrades need to notify the exec so that db migrations can be run on upgrade. This is a change of semantics, however really all package upgrades should trigger a db sync, since any of them may inadvertently pull in the common package which is what actually contains the migrations.","commit_id":"740b6a46440c60a6f765ec6d5315dc01749ef4f1"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"873a170b2caaac07e7038dd8e9262419cf12f2b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  include ::designate::params"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  Anchor\u003c| title \u003d\u003d \u0027designate::config::end\u0027 |\u003e ~\u003e Exec[\u0027designate-dbsync\u0027]"},{"line_number":9,"context_line":"  Exec[\u0027designate-dbsync\u0027] ~\u003e Anchor \u003c| title \u003d\u003d \u0027designate::service::begin\u0027 |\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  exec { \u0027designate-dbsync\u0027:"},{"line_number":12,"context_line":"    command     \u003d\u003e $::designate::params::dbsync_command,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a50d1a3_388624dc","line":9,"updated":"2015-07-30 11:37:42.000000000","message":"Same as the comments on the powerdns sync.","commit_id":"3b29f82c628a7c65846ad188a60b9d6407ca2939"}]}
