)]}'
{"manifests/agent.pp":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"7504670d2d68496b8eec3527195fede86bbb9d67","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  package { \u0027designate-agent\u0027:"},{"line_number":37,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":38,"context_line":"    name   \u003d\u003e pick($agent_package_name, $::designate::params::agent_package_name),"},{"line_number":39,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027designate-package\u0027],"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  service { \u0027designate-agent\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba3cc151_b5ed4190","line":39,"updated":"2015-07-06 17:37:18.000000000","message":"There is no need for tags like that. There are already implicit tags: https://docs.puppetlabs.com/puppet/latest/reference/lang_tags.html#automatic-tagging\n\nSo you can already reference those packages with a collector:\n\n    Package\u003c| tag \u003d\u003d \u0027designate\u0027 |\u003e","commit_id":"242e44f77698cf24948f1c38ca34cd108952389d"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"cd16b21038077a65d04787f7ca6f54ea15b5dc25","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  package { \u0027designate-agent\u0027:"},{"line_number":37,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":38,"context_line":"    name   \u003d\u003e pick($agent_package_name, $::designate::params::agent_package_name),"},{"line_number":39,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027designate-package\u0027],"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  service { \u0027designate-agent\u0027:"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a41bdd9_faac24ef","line":39,"in_reply_to":"ba3cc151_b5ed4190","updated":"2015-07-13 02:53:26.000000000","message":"The implicit tags frequently end up being polluted by including classes.  For example, if you name your profiles something like this:\n\n    mycompany::profile::designate\n\nThen *all* resources included by that profile will get the designate tag.  It\u0027s even worse if that profile includes packages or services not managed by puppet-designate.  For example, if you have other packages included by that profile, then it would be caught by that collector, even though the user of the module may not intend that and there is no way for them to turn off this behavior.\n\nThat\u0027s why I had it tagged above with \u0027designate-package\u0027, since auto tagging will never generate a tag with a hyphen in it, since hyphens are not valid in class names.","commit_id":"242e44f77698cf24948f1c38ca34cd108952389d"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"e18ec38fe3e6b8943bdaba7ccce194c980f0d791","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  package { \u0027designate-agent\u0027:"},{"line_number":37,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":38,"context_line":"    name   \u003d\u003e pick($agent_package_name, $::designate::params::agent_package_name),"},{"line_number":39,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027designate-package\u0027],"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  service { \u0027designate-agent\u0027:"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a50d1a3_07a90e7b","line":39,"updated":"2015-07-22 07:50:12.000000000","message":"Shouldn\u0027t it be only designate and not designate-package.\n\nI mean the use case will certainly be\n\nPackage \u003c| tag \u003d\u003d \u0027designate\u0027 |\u003e -\u003e .....\n\nor\n\nService \u003c| tag \u003d\u003d \u0027designate\u0027 \u003e| -\u003e\n\nPackage \u003c| tag \u003d\u003d \u0027designate-package\u0027 |\u003e and Service \u003c| tag \u003d\u003d \u0027designate-servie\u0027 |\u003e sounds a bit redundant.\n\nIs there any use case I am missing ?","commit_id":"5a37cc81276cb8f8ee6dca9b9b532930e6ac86de"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"baa7256412e1d86480f3ab86d1af5c97cf8e0295","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  package { \u0027designate-agent\u0027:"},{"line_number":37,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":38,"context_line":"    name   \u003d\u003e pick($agent_package_name, $::designate::params::agent_package_name),"},{"line_number":39,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027designate-package\u0027],"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  service { \u0027designate-agent\u0027:"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a50d1a3_5cbd87b5","line":39,"in_reply_to":"3a50d1a3_07a90e7b","updated":"2015-07-22 17:55:48.000000000","message":"After reading the documentation on auto-tagging, all the package and service resources within the designate namespace will be automatically tagged with designate. Hence the need to have a clear tag that auto-tagging cannot set.","commit_id":"5a37cc81276cb8f8ee6dca9b9b532930e6ac86de"}],"manifests/db.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d6a455c8f221a818acde08ae8dc92ab8180754f7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  $database_connection \u003d \u0027mysql://designate:designate@localhost/designate\u0027"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::designate"},{"line_number":18,"context_line":"  include ::designate::params"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  case $database_connection {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a41bdd9_55cfba28","line":17,"updated":"2015-07-14 19:48:38.000000000","message":"I don\u0027t think this is necessary. The designate class should be declared before this class, so the anchors needed should already be available.","commit_id":"919bc5832ca1759aa2dd50263c14f6cbef25ade3"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"be8fa37d95f860a21d98969788af5d44b3f84140","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  $database_connection \u003d \u0027mysql://designate:designate@localhost/designate\u0027"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::designate"},{"line_number":18,"context_line":"  include ::designate::params"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  case $database_connection {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a41bdd9_30715fe1","line":17,"in_reply_to":"9a41bdd9_119cd80d","updated":"2015-07-16 23:52:03.000000000","message":"You can do it with :pre_condition\n\n    let :pre_condition do\n      \u0027include designate\u0027\n    end","commit_id":"919bc5832ca1759aa2dd50263c14f6cbef25ade3"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"cf897de3e5bf3b42893edf0711eff72c616df54e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  $database_connection \u003d \u0027mysql://designate:designate@localhost/designate\u0027"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::designate"},{"line_number":18,"context_line":"  include ::designate::params"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  case $database_connection {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a41bdd9_f65741c8","line":17,"in_reply_to":"9a41bdd9_55cfba28","updated":"2015-07-17 18:26:12.000000000","message":"Done","commit_id":"919bc5832ca1759aa2dd50263c14f6cbef25ade3"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"8448996dae6c103972d533f78ca7fc32a062d55f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  $database_connection \u003d \u0027mysql://designate:designate@localhost/designate\u0027"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::designate"},{"line_number":18,"context_line":"  include ::designate::params"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  case $database_connection {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a41bdd9_119cd80d","line":17,"in_reply_to":"9a41bdd9_55cfba28","updated":"2015-07-15 01:57:27.000000000","message":"I added it because otherwise the tests failed due to the Anchors not being available.  I think there is a way with rspec-puppet to tell it to include additional classes, but I can never remember how and couldn\u0027t find a good reference or example for it.  Do you know where I might find that?","commit_id":"919bc5832ca1759aa2dd50263c14f6cbef25ade3"}],"manifests/init.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d6a455c8f221a818acde08ae8dc92ab8180754f7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    owner \u003d\u003e \u0027designate\u0027,"},{"line_number":100,"context_line":"    group \u003d\u003e \u0027designate\u0027,"},{"line_number":101,"context_line":"    mode  \u003d\u003e \u00270640\u0027,"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Package[\u0027designate-common\u0027] -\u003e Designate_config\u003c||\u003e"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a41bdd9_75ebde78","side":"PARENT","line":102,"updated":"2015-07-14 19:48:38.000000000","message":"Why was this removed?","commit_id":"e202f75c9741a543d7de6815b2552040839f822d"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"8448996dae6c103972d533f78ca7fc32a062d55f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    owner \u003d\u003e \u0027designate\u0027,"},{"line_number":100,"context_line":"    group \u003d\u003e \u0027designate\u0027,"},{"line_number":101,"context_line":"    mode  \u003d\u003e \u00270640\u0027,"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  Package[\u0027designate-common\u0027] -\u003e Designate_config\u003c||\u003e"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9a41bdd9_71b20496","side":"PARENT","line":102,"in_reply_to":"9a41bdd9_75ebde78","updated":"2015-07-15 01:57:27.000000000","message":"I needed to remove it here because if you\u0027re not using packages, then you\u0027ll need to manage initial config file creation more directly, and having this resource here makes that pretty gross.\n\nI talked to Emilien about it and my recollection is that he said that managing the config files is something we\u0027re moving away from.  For example, neutron has ended up with just this for the config file: \n\n    https://github.com/openstack/puppet-neutron/blob/master/manifests/init.pp#L342","commit_id":"e202f75c9741a543d7de6815b2552040839f822d"}]}