)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"51580ce2c335eebae291699892b924b5649cc93d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add designate_rootwrap_config in designate::config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"this path is aim to add designate_rootwrap_config"},{"line_number":10,"context_line":"in designate::config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"use designate config resources to manage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_75df4c69","line":9,"updated":"2015-08-06 04:06:59.000000000","message":"This patch aims to add...","commit_id":"57aa4361f6079864a65bd304ad84c4fbc31bebfa"}],"lib/puppet/type/designate_rootwrap_config.rb":[{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"23a760efc16a8ed341278f3015c73bfaae57e6c2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    end"},{"line_number":34,"context_line":"  end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newparam(:secret, :boolean \u003d\u003e true) do"},{"line_number":37,"context_line":"    desc \u0027Whether to hide the value from Puppet logs. Defaults to `false`.\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    newvalues(:true, :false)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a4dcd0f_b5217dfd","line":36,"updated":"2015-08-05 11:35:44.000000000","message":"rootwrap_config doesn\u0027t need secret option.","commit_id":"d23c0c7a39d979c0a5bdbb23e7b6327ee20aa70a"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"ab84ec28704c305033bed8dacbaeeb79d5944171","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    end"},{"line_number":34,"context_line":"  end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  newparam(:secret, :boolean \u003d\u003e true) do"},{"line_number":37,"context_line":"    desc \u0027Whether to hide the value from Puppet logs. Defaults to `false`.\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    newvalues(:true, :false)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a4dcd0f_550c9540","line":36,"in_reply_to":"1a4dcd0f_b5217dfd","updated":"2015-08-06 00:53:03.000000000","message":"thanks,Done","commit_id":"d23c0c7a39d979c0a5bdbb23e7b6327ee20aa70a"}],"manifests/config.pp":[{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"51580ce2c335eebae291699892b924b5649cc93d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   or Puppet catalog compilation will fail with duplicate resources."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*rootwrap_config*]"},{"line_number":31,"context_line":"#   (optional) Allow configuration of /etc/designate/rootwrap.conf configurations."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"class designate::config ("},{"line_number":34,"context_line":"  $designate_config      \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_754d0c3d","line":31,"updated":"2015-08-06 04:06:59.000000000","message":"duplicate \"configuration\". \n\n\"Allow configuration of /etc/designate/rootwrap.conf\" is sufficient.","commit_id":"57aa4361f6079864a65bd304ad84c4fbc31bebfa"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"b3038e1357a3a37397390393d2456176267a73d7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   or Puppet catalog compilation will fail with duplicate resources."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*rootwrap_config*]"},{"line_number":31,"context_line":"#   (optional) Allow configuration of /etc/designate/rootwrap.conf configurations."},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"class designate::config ("},{"line_number":34,"context_line":"  $designate_config      \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_a3f7de89","line":31,"in_reply_to":"1a4dcd0f_754d0c3d","updated":"2015-08-06 11:45:51.000000000","message":"Done","commit_id":"57aa4361f6079864a65bd304ad84c4fbc31bebfa"}],"spec/classes/designate_config_spec.rb":[{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"51580ce2c335eebae291699892b924b5649cc93d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      :rootwrap_config \u003d\u003e {"},{"line_number":17,"context_line":"        \u0027DEFAULT/filters_path\u0027        \u003d\u003e { \u0027value\u0027  \u003d\u003e \u0027/etc/designate/rootwrap.d,/usr/share/designate/rootwrap\u0027 },"},{"line_number":18,"context_line":"        \u0027DEFAULT/exec_dirs\u0027           \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027/sbin,/usr/sbin,/bin,/usr/bin\u0027 },"},{"line_number":19,"context_line":"        \u0027DEFAULT/use_syslog\u0027          \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027False\u0027 },"},{"line_number":20,"context_line":"        \u0027DEFAULT/syslog_log_facility\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027syslog\u0027 },"},{"line_number":21,"context_line":"        \u0027DEFAULT/syslog_log_level\u0027    \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027ERROR\u0027 },"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a4dcd0f_95f8d8c4","line":19,"updated":"2015-08-06 04:06:59.000000000","message":"would it be worth setting this to lowercase \"false\" to also test the automatic capitalize functionality?","commit_id":"57aa4361f6079864a65bd304ad84c4fbc31bebfa"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"b3038e1357a3a37397390393d2456176267a73d7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      :rootwrap_config \u003d\u003e {"},{"line_number":17,"context_line":"        \u0027DEFAULT/filters_path\u0027        \u003d\u003e { \u0027value\u0027  \u003d\u003e \u0027/etc/designate/rootwrap.d,/usr/share/designate/rootwrap\u0027 },"},{"line_number":18,"context_line":"        \u0027DEFAULT/exec_dirs\u0027           \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027/sbin,/usr/sbin,/bin,/usr/bin\u0027 },"},{"line_number":19,"context_line":"        \u0027DEFAULT/use_syslog\u0027          \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027False\u0027 },"},{"line_number":20,"context_line":"        \u0027DEFAULT/syslog_log_facility\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027syslog\u0027 },"},{"line_number":21,"context_line":"        \u0027DEFAULT/syslog_log_level\u0027    \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027ERROR\u0027 },"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a4dcd0f_4375baf7","line":19,"in_reply_to":"1a4dcd0f_95f8d8c4","updated":"2015-08-06 11:45:51.000000000","message":"Done","commit_id":"57aa4361f6079864a65bd304ad84c4fbc31bebfa"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a315298a753007a80308490de29a288408a12a86","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      :rootwrap_config \u003d\u003e {"},{"line_number":17,"context_line":"        \u0027DEFAULT/filters_path\u0027        \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027/etc/designate/rootwrap.d,/usr/share/designate/rootwrap\u0027 },"},{"line_number":18,"context_line":"        \u0027DEFAULT/exec_dirs\u0027           \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027/sbin,/usr/sbin,/bin,/usr/bin\u0027 },"},{"line_number":19,"context_line":"        \u0027DEFAULT/use_syslog\u0027          \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027False\u0027 },"},{"line_number":20,"context_line":"        \u0027DEFAULT/syslog_log_facility\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027syslog\u0027 },"},{"line_number":21,"context_line":"        \u0027DEFAULT/syslog_log_level\u0027    \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027ERROR\u0027 },"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1a4dcd0f_c1fffda8","line":19,"updated":"2015-08-10 04:13:04.000000000","message":"I see you tried and undid your change. I meant only set this line to lowercase \"false\", and the test below (~line 41) should remain \"False\" as the provider will change it to that.","commit_id":"7bf0e240074b71eac91931bf898fb54819c93921"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"dc6e9d1bc4a623c930d31368f29e9786e4b70814","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      :rootwrap_config \u003d\u003e {"},{"line_number":17,"context_line":"        \u0027DEFAULT/filters_path\u0027        \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027/etc/designate/rootwrap.d,/usr/share/designate/rootwrap\u0027 },"},{"line_number":18,"context_line":"        \u0027DEFAULT/exec_dirs\u0027           \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027/sbin,/usr/sbin,/bin,/usr/bin\u0027 },"},{"line_number":19,"context_line":"        \u0027DEFAULT/use_syslog\u0027          \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027False\u0027 },"},{"line_number":20,"context_line":"        \u0027DEFAULT/syslog_log_facility\u0027 \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027syslog\u0027 },"},{"line_number":21,"context_line":"        \u0027DEFAULT/syslog_log_level\u0027    \u003d\u003e { \u0027value\u0027 \u003d\u003e \u0027ERROR\u0027 },"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1a4dcd0f_e1e6b915","line":19,"in_reply_to":"1a4dcd0f_c1fffda8","updated":"2015-08-10 04:17:29.000000000","message":"Sorry, I see the code for the type is probably just copied from another that included the capitalize function, so its not a big deal to be honest. Never mind my previous comment.","commit_id":"7bf0e240074b71eac91931bf898fb54819c93921"}]}