)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0aac4baf933038e0cffea076ffb67e3d49cd27ac","unresolved":false,"context_lines":[{"line_number":10,"context_line":"designate Mini Dns service."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iafd145b41c3e2202f3656084d365f98e6daee585"},{"line_number":13,"context_line":"Close-Bug: #1486301"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da6ed579_3cb10948","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":5},"updated":"2016-01-13 13:37:19.000000000","message":"typo: closes","commit_id":"78d79aa44a3809dfec2c9fd6804b0605884fe3b0"}],"manifests/mdns.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8006697fae9ed7679b54f1c3db4524dda937b108","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*package_ensure*]"},{"line_number":8,"context_line":"#  (optional) The state of the package."},{"line_number":9,"context_line":"#  Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_6002f80b","line":7,"updated":"2015-08-20 21:06:38.000000000","message":"please also add the manage_service, which is a standard for PO modules","commit_id":"76e1a0f20acc1c212b4fb7753e3c1d9c4dbc1c6b"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"4d8ddb71cd5d6fccdef0b199d77f43ff6c4332ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*package_ensure*]"},{"line_number":8,"context_line":"#  (optional) The state of the package."},{"line_number":9,"context_line":"#  Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_ca92faf5","line":7,"in_reply_to":"fa1b9901_6002f80b","updated":"2015-08-21 02:33:19.000000000","message":"hmm, this is because designate module use service_ensure option, which is equal to manage_service.\nA good catch!","commit_id":"76e1a0f20acc1c212b4fb7753e3c1d9c4dbc1c6b"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"6494ef388deef95cd14dfcf845c8409e0f57abe5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*mdns_package_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the package containing mdns resources."},{"line_number":13,"context_line":"#  Defaults to mdns_package_name from designate::params"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*enabled*]"},{"line_number":16,"context_line":"#   (optional) Whether to enable services."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_e37a7c23","line":13,"updated":"2015-08-21 08:42:41.000000000","message":"This doesn\u0027t match the actual code","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"0da60ea4e1258608b2eef44a7327eb0fd6c0dda0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*mdns_package_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the package containing mdns resources."},{"line_number":13,"context_line":"#  Defaults to mdns_package_name from designate::params"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*enabled*]"},{"line_number":16,"context_line":"#   (optional) Whether to enable services."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_209e0e64","line":13,"in_reply_to":"fa1b9901_288a7a64","updated":"2015-08-21 16:32:48.000000000","message":"I just ref from designate other service class, please take a look at: api,agent,central etc. class.\nIf you think they are not appropriate，I will update these option s default value together.","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"bd049ddb4141436fa5491e38138128dab8428cba","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*mdns_package_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the package containing mdns resources."},{"line_number":13,"context_line":"#  Defaults to mdns_package_name from designate::params"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*enabled*]"},{"line_number":16,"context_line":"#   (optional) Whether to enable services."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_288a7a64","line":13,"in_reply_to":"fa1b9901_3f3de48e","updated":"2015-08-21 15:27:42.000000000","message":"What I mean is that technically default is undef (cf. line 61)","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"31e88db844ce227a24e466dd662917b1a2cafae5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*mdns_package_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the package containing mdns resources."},{"line_number":13,"context_line":"#  Defaults to mdns_package_name from designate::params"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*enabled*]"},{"line_number":16,"context_line":"#   (optional) Whether to enable services."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_3f3de48e","line":13,"in_reply_to":"fa1b9901_e37a7c23","updated":"2015-08-21 15:21:29.000000000","message":"Sorry, I didn\u0027t get your idea. Could you explain this comment?","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"6494ef388deef95cd14dfcf845c8409e0f57abe5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*workers*]"},{"line_number":24,"context_line":"#  (optional) Number of Pool Manager worker processes to spawn."},{"line_number":25,"context_line":"#  Defaults to \u00270\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*threads*]"},{"line_number":28,"context_line":"#  (optional) Number of Pool Manager greenthreads to spawn."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_e3003c36","line":25,"updated":"2015-08-21 08:42:41.000000000","message":"I think this should be undef[1]. \n\nWith an if $worker { value \u003d\u003e \u0027\u0027 } else { ensure \u003d\u003e \u0027absent\u0027 }\n\n[1] https://github.com/openstack/designate/blob/master/etc/designate/designate.conf.sample#L165","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"0da60ea4e1258608b2eef44a7327eb0fd6c0dda0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*workers*]"},{"line_number":24,"context_line":"#  (optional) Number of Pool Manager worker processes to spawn."},{"line_number":25,"context_line":"#  Defaults to \u00270\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*threads*]"},{"line_number":28,"context_line":"#  (optional) Number of Pool Manager greenthreads to spawn."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_002f4af7","line":25,"in_reply_to":"fa1b9901_e3003c36","updated":"2015-08-21 16:32:48.000000000","message":"I will change it to 1 by default.\nb/c if we don\u0027t set workers option, then it will use the default value 1.\n\nhttps://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L445","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"31e88db844ce227a24e466dd662917b1a2cafae5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*workers*]"},{"line_number":24,"context_line":"#  (optional) Number of Pool Manager worker processes to spawn."},{"line_number":25,"context_line":"#  Defaults to \u00270\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*threads*]"},{"line_number":28,"context_line":"#  (optional) Number of Pool Manager greenthreads to spawn."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_6d75e4c8","line":25,"in_reply_to":"fa1b9901_e3003c36","updated":"2015-08-21 15:21:29.000000000","message":"Yes, I know the default value in designate is none.\nActually I want to avoid using ensure \u003d\u003e absent format for this option.\nset it to 0 is equal not set it: \nthere will be only one designatge-mdns process running.","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"6494ef388deef95cd14dfcf845c8409e0f57abe5","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  package { \u0027designate-mdns\u0027:"},{"line_number":77,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":78,"context_line":"    name   \u003d\u003e pick($mdns_package_name, $::designate::params::mdns_package_name),"},{"line_number":79,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027designate-package\u0027],"},{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_e324bc0d","line":78,"updated":"2015-08-21 08:42:41.000000000","message":"Are we doing that (ie. the use of pick) anywhere else ?\n\nI see in the test that you want support for non-standard packages. The idea sound interesting to me, we should bring it up in the weekly meeting, see if people would be intrested in having this feature in every module.\n\nI just checked manila[1] and others where it is not the case. \n\n[1] https://github.com/openstack/puppet-manila/blob/master/manifests/init.pp#L339","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"f454fbd04c30c6e714e6cbbac6185cb8034c949a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  package { \u0027designate-mdns\u0027:"},{"line_number":77,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":78,"context_line":"    name   \u003d\u003e pick($mdns_package_name, $::designate::params::mdns_package_name),"},{"line_number":79,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027designate-package\u0027],"},{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa1b9901_d86c06d2","line":78,"in_reply_to":"fa1b9901_e324bc0d","updated":"2015-08-21 09:00:03.000000000","message":"I see it is done this way in the overall designate modules. Never mind the comment.","commit_id":"ea4bc8e0cdcded7ae89adcc8e06c4ea4b85ea68f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e9328635450953090222f53b44eb8a7a3d1121de","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#  (optional) The state of the package."},{"line_number":9,"context_line":"#  Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*mdns_package_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the package containing mdns resources."},{"line_number":13,"context_line":"#  Defaults to mdns_package_name from designate::params"},{"line_number":14,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a2fa921_9523acbc","line":11,"updated":"2015-10-10 12:09:19.000000000","message":"we usually don\u0027t allow to override the package name by this way. You could rather use the Resource Tag if you need to change the package name. That would be consistent with how other modules work.","commit_id":"7c5c8c4d40a949bcdfbeb6e4151b568a7e665825"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"a67cc9c0eadf7424cfd9d1f82d76c0d4669ec831","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#  (optional) The state of the package."},{"line_number":9,"context_line":"#  Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*mdns_package_name*]"},{"line_number":12,"context_line":"#  (optional) Name of the package containing mdns resources."},{"line_number":13,"context_line":"#  Defaults to mdns_package_name from designate::params"},{"line_number":14,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a7b0d38_b802c209","line":11,"in_reply_to":"7a2fa921_9523acbc","updated":"2015-12-26 08:03:39.000000000","message":"Hmm, this logic is just copy from designate other class, you would find in  designate::central designate::agent, etc.\nIf you think this logic is not a good way for managing package name, I can submit another commit to fix it.","commit_id":"7c5c8c4d40a949bcdfbeb6e4151b568a7e665825"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e9328635450953090222f53b44eb8a7a3d1121de","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":90,"context_line":"    manage_service \u003d\u003e $manage_service,"},{"line_number":91,"context_line":"    ensure_package \u003d\u003e $package_ensure,"},{"line_number":92,"context_line":"    package_name   \u003d\u003e pick($mdns_package_name, $::designate::params::mdns_package_name),"},{"line_number":93,"context_line":"    service_name   \u003d\u003e $::designate::params::mdns_service_name,"},{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a2fa921_352e58a5","line":92,"updated":"2015-10-10 12:09:19.000000000","message":"ditto","commit_id":"7c5c8c4d40a949bcdfbeb6e4151b568a7e665825"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"7a4b4bc1aa84cfb44fc5ba89b3052a17c98e56c7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#  Defaults to \u0027running\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*workers*]"},{"line_number":24,"context_line":"#  (optional) Number of Pool Manager worker processes to spawn."},{"line_number":25,"context_line":"#  Defaults to \u00270\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*threads*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"da6ed579_dae32c04","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":36},"updated":"2016-01-13 02:08:20.000000000","message":"should be mdns","commit_id":"d829a48556a0cb2e3d87839b498221ba6f936a00"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0aac4baf933038e0cffea076ffb67e3d49cd27ac","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"class designate::mdns ("},{"line_number":60,"context_line":"  $package_ensure     \u003d present,"},{"line_number":61,"context_line":"  $mdns_package_name  \u003d undef,"},{"line_number":62,"context_line":"  $enabled            \u003d true,"},{"line_number":63,"context_line":"  $manage_service     \u003d \u0027running\u0027,"},{"line_number":64,"context_line":"  $workers            \u003d $::processorcount,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_bcd41920","line":61,"range":{"start_line":61,"start_character":24,"end_line":61,"end_character":29},"updated":"2016-01-13 13:37:19.000000000","message":"You can use here: $::designate::params::mdns_package_name , if you want override this.\n\nhence we don\u0027t need peek in package_name for generic_service resource.","commit_id":"78d79aa44a3809dfec2c9fd6804b0605884fe3b0"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"8d2793d39fd4808728d30b42fb8f4bb7fc437b94","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"class designate::mdns ("},{"line_number":60,"context_line":"  $package_ensure     \u003d present,"},{"line_number":61,"context_line":"  $mdns_package_name  \u003d undef,"},{"line_number":62,"context_line":"  $enabled            \u003d true,"},{"line_number":63,"context_line":"  $manage_service     \u003d \u0027running\u0027,"},{"line_number":64,"context_line":"  $workers            \u003d $::processorcount,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_e582ed93","line":61,"range":{"start_line":61,"start_character":24,"end_line":61,"end_character":29},"in_reply_to":"da6ed579_bcd41920","updated":"2016-01-13 15:51:13.000000000","message":"I obey the same method In designate::api, designate::central for choosing designate package name.","commit_id":"78d79aa44a3809dfec2c9fd6804b0605884fe3b0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"31ac1dcaa492b818ca5f59dbbf20ecfe32ed25e0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"class designate::mdns ("},{"line_number":60,"context_line":"  $package_ensure     \u003d present,"},{"line_number":61,"context_line":"  $mdns_package_name  \u003d undef,"},{"line_number":62,"context_line":"  $enabled            \u003d true,"},{"line_number":63,"context_line":"  $manage_service     \u003d \u0027running\u0027,"},{"line_number":64,"context_line":"  $workers            \u003d $::processorcount,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"da6ed579_8abe95d2","line":61,"range":{"start_line":61,"start_character":24,"end_line":61,"end_character":29},"in_reply_to":"da6ed579_e582ed93","updated":"2016-01-13 17:36:40.000000000","message":"Yeah, they need to be updated.","commit_id":"78d79aa44a3809dfec2c9fd6804b0605884fe3b0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fd55b62204875b2384c3c698eace65735c45285e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $query_enforce_tsig \u003d false,"},{"line_number":71,"context_line":"  $storage_driver     \u003d \u0027sqlalchemy\u0027,"},{"line_number":72,"context_line":"  $max_message_size   \u003d \u002765535\u0027"},{"line_number":73,"context_line":") inherits designate {"},{"line_number":74,"context_line":"  include ::designate::params"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"da6ed579_4aec1d8f","line":73,"range":{"start_line":73,"start_character":11,"end_line":73,"end_character":20},"updated":"2016-01-13 17:43:28.000000000","message":"as we used parameter from params class, to avoid warnings i guess, we should use also inherits designtate::params.\n\nAs i remember, we already faced with this problem in nova or cinder. May be someone else can clarify this moment?","commit_id":"29cc8f316d80cd2a490e96c7c97d210848b7d5c6"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"cab27ad95e19bc1d7b8d72901dfc2fbf1bde9492","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $query_enforce_tsig \u003d false,"},{"line_number":71,"context_line":"  $storage_driver     \u003d \u0027sqlalchemy\u0027,"},{"line_number":72,"context_line":"  $max_message_size   \u003d \u002765535\u0027"},{"line_number":73,"context_line":") inherits designate {"},{"line_number":74,"context_line":"  include ::designate::params"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"da6ed579_ea1b7571","line":73,"range":{"start_line":73,"start_character":11,"end_line":73,"end_character":20},"in_reply_to":"da6ed579_15796a2f","updated":"2016-01-14 05:31:03.000000000","message":"Hmm, I will submit a new patch for changing designate class inheirts relationship to make sure designate::mdns can both inheirts from designate and designate::params.","commit_id":"29cc8f316d80cd2a490e96c7c97d210848b7d5c6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6bcbd19176806a427d37ac8f1c07f40534f431f0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $query_enforce_tsig \u003d false,"},{"line_number":71,"context_line":"  $storage_driver     \u003d \u0027sqlalchemy\u0027,"},{"line_number":72,"context_line":"  $max_message_size   \u003d \u002765535\u0027"},{"line_number":73,"context_line":") inherits designate {"},{"line_number":74,"context_line":"  include ::designate::params"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"da6ed579_15796a2f","line":73,"range":{"start_line":73,"start_character":11,"end_line":73,"end_character":20},"in_reply_to":"da6ed579_4aec1d8f","updated":"2016-01-13 17:52:48.000000000","message":"This should inherit from designate::params, we just fixed a similar issue in neutron because if the designate::params is not loaded prior to this class the defaults for $mdns_package_name will throw a warning and be undefined.  Also not sure why this inherits from designate as the designate::params class is being used in the defaults...","commit_id":"29cc8f316d80cd2a490e96c7c97d210848b7d5c6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f36e51a83b4e9553e60436fc7d723809ea205a45","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $query_enforce_tsig \u003d false,"},{"line_number":71,"context_line":"  $storage_driver     \u003d \u0027sqlalchemy\u0027,"},{"line_number":72,"context_line":"  $max_message_size   \u003d \u002765535\u0027"},{"line_number":73,"context_line":") inherits designate {"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  designate_config {"},{"line_number":76,"context_line":"    \u0027service:mdns/workers\u0027            : value \u003d\u003e $workers;"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_d7763ad6","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":10},"updated":"2016-01-14 16:30:21.000000000","message":"so, as I and Alex said in prev patch set you should inherit params class here. But we can\u0027t inherit two classes in one time for another class. If inherits designate here is really needed, you can add inherits designate::params to main class to init.pp and it will work.\n\nI\u0027ve already tested it locally with puppet version 4.3.0.","commit_id":"27e27d18a92c0693519e9f71fb9b084b9688e756"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"5eaa60189ce88ceac0aedbb22fe6f22f33243171","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $query_enforce_tsig \u003d false,"},{"line_number":71,"context_line":"  $storage_driver     \u003d \u0027sqlalchemy\u0027,"},{"line_number":72,"context_line":"  $max_message_size   \u003d \u002765535\u0027"},{"line_number":73,"context_line":") inherits designate {"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  designate_config {"},{"line_number":76,"context_line":"    \u0027service:mdns/workers\u0027            : value \u003d\u003e $workers;"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_cf4d249b","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":10},"in_reply_to":"da6ed579_d7763ad6","updated":"2016-01-15 02:36:28.000000000","message":"I have done this in https://review.openstack.org/#/c/267058/","commit_id":"27e27d18a92c0693519e9f71fb9b084b9688e756"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7f3c5bed2395b16712dd55d327e5396ebf8a70d8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $storage_driver     \u003d \u0027sqlalchemy\u0027,"},{"line_number":72,"context_line":"  $max_message_size   \u003d \u002765535\u0027"},{"line_number":73,"context_line":") inherits designate {"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  designate_config {"},{"line_number":76,"context_line":"    \u0027service:mdns/workers\u0027            : value \u003d\u003e $workers;"},{"line_number":77,"context_line":"    \u0027service:mdns/threads\u0027            : value \u003d\u003e $threads;"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_6f2e2aa7","line":74,"updated":"2016-01-16 21:56:12.000000000","message":"what about using os service default like in other modules?","commit_id":"27e27d18a92c0693519e9f71fb9b084b9688e756"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7682dd0f3bf53ea137b81fb192d478efcba57b4c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $storage_driver     \u003d \u0027sqlalchemy\u0027,"},{"line_number":72,"context_line":"  $max_message_size   \u003d \u002765535\u0027"},{"line_number":73,"context_line":") inherits designate {"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  designate_config {"},{"line_number":76,"context_line":"    \u0027service:mdns/workers\u0027            : value \u003d\u003e $workers;"},{"line_number":77,"context_line":"    \u0027service:mdns/threads\u0027            : value \u003d\u003e $threads;"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_aebdff03","line":74,"in_reply_to":"da6ed579_65e64b46","updated":"2016-01-17 10:02:34.000000000","message":"Well, we already implemented a part of this feature to designate by this commit:\n\nhttps://github.com/openstack/puppet-designate/commit/a337e0188dcf425351426cc25517f48ad7f88631\n\nBut i\u0027m ok with switching to os_service_default in separate commit.","commit_id":"27e27d18a92c0693519e9f71fb9b084b9688e756"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"652b387713d70c5b5e9558b614dc9bf0cabd93d0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $storage_driver     \u003d \u0027sqlalchemy\u0027,"},{"line_number":72,"context_line":"  $max_message_size   \u003d \u002765535\u0027"},{"line_number":73,"context_line":") inherits designate {"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  designate_config {"},{"line_number":76,"context_line":"    \u0027service:mdns/workers\u0027            : value \u003d\u003e $workers;"},{"line_number":77,"context_line":"    \u0027service:mdns/threads\u0027            : value \u003d\u003e $threads;"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_65e64b46","line":74,"in_reply_to":"da6ed579_6f2e2aa7","updated":"2016-01-17 01:38:40.000000000","message":"I\u0027m afraid that designate  doesn\u0027t support os_service_default fact by now.","commit_id":"27e27d18a92c0693519e9f71fb9b084b9688e756"}],"spec/classes/designate_mdns_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3c85ecd9e689f4987e50a4377f262419ceb9b578","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":63,"context_line":"    before do"},{"line_number":64,"context_line":"      facts.merge!( :osfamily \u003d\u003e \u0027Debian\u0027 )"},{"line_number":65,"context_line":"    end"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    let :platform_params do"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"7a5de9d1_bd0e0139","line":64,"updated":"2016-01-31 20:11:40.000000000","message":"It\u0027s failing because the :os_service_default fact is not defined here.  Take a look at the other specs, I recently updated them to use rspec-puppet-facts which will simplify this.  You\u0027ll want...\n\n  on_supported_os({\n    :supported_os \u003d\u003e OSDefaults.get_supported_os\n  }).each do |os,facts|\n    context \"on #{os}\" do\n      let (:facts) do\n        facts.merge!(OSDefaults.get_facts())\n      end\n\n      let(:platform_params) do\n        case facts[:osfamily]\n        when \u0027Debian\u0027\n          {\n            :mdns_package_name \u003d\u003e \u0027designate-mdns\u0027,\n            :mdns_service_name \u003d\u003e \u0027designate-mdns\u0027\n          }\n        when \u0027RedHat\u0027\n          {\n            :mdns_package_name \u003d\u003e \u0027openstack-designate-mdns\u0027,\n            :mdns_service_name \u003d\u003e \u0027openstack-designate-mdns\u0027\n          }\n        end\n      end\n      it_behaves_like \u0027designate-mdns\u0027\n    end\n  end","commit_id":"8a3fb7c59a24deb4eb06fb647f3cb410ccd1e8d5"}]}