)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041f91c4e7172fad45bebeed5b3266260eb101fa","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  $rabbit_hosts         \u003d false,"},{"line_number":95,"context_line":"  $rabbit_userid        \u003d \u0027guest\u0027,"},{"line_number":96,"context_line":"  $rabbit_password      \u003d \u0027\u0027,"},{"line_number":97,"context_line":"  $rabbit_virtual_host   \u003d \u0027/\u0027,"},{"line_number":98,"context_line":"  $notification_driver  \u003d \u0027messaging\u0027,"},{"line_number":99,"context_line":"  $notification_topics  \u003d \u0027notifications\u0027,"},{"line_number":100,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba8a016a_9538f7a1","line":97,"updated":"2015-11-18 00:23:37.000000000","message":"This is not backward compatible at all.\nI know the parameter should be renamed but unfortunatly, we already released this module which means we need to respect backward compatibility.\nSo please add a new parameter instead of renaming it, and also add a warning if the old one is not set to false. (keep the default to \u0027/\u0027 for backward compatibility).\n\nsomething like:\n\n  ...\n  $rabbit_virtual_host \u003d false,\n  $rabbit_virtualhost  \u003d \u0027/\u0027,\n  ...\n\n  if $rabbit_virtual_host {\n    $rabbit_virtual_host_real \u003d $rabbit_virtual_host\n  } else {\n    $rabbit_virtual_host_real \u003d $rabbit_virtualhost\n    warning(\u0027...\u0027)\n  }\n  \n  designate_config (\n    \u0027.../rabbit_virtual_host\u0027: value \u003d\u003e rabbit_virtual_host_real;\n  )\n\nThis is an example, you can adjust it","commit_id":"1bee49d34d0302a1576ab9b38c27ff5150d0603f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c6ed78d3417b7ffa5a173c3c21f3a90b3b834a52","unresolved":false,"context_lines":[{"line_number":82,"context_line":"#"},{"line_number":83,"context_line":"# [*rabbit_virtualhost*]"},{"line_number":84,"context_line":"#   (optional) DEPRECATED. Use rabbit_virtual_host"},{"line_number":85,"context_line":"#   Defaults to \u0027/\u0027"},{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class designate("}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba8a016a_7d8f0775","line":85,"updated":"2015-11-19 20:09:02.000000000","message":"should be undef","commit_id":"4b59d699fc6afabdd08bfc1696081bd953420f7e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c6ed78d3417b7ffa5a173c3c21f3a90b3b834a52","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  $notification_driver  \u003d \u0027messaging\u0027,"},{"line_number":105,"context_line":"  $notification_topics  \u003d \u0027notifications\u0027,"},{"line_number":106,"context_line":"  #DEPRECATED PARAMETER"},{"line_number":107,"context_line":"  $rabbit_virtualhost   \u003d \u0027/\u0027"},{"line_number":108,"context_line":") {"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  if $rabbit_virtualhost {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba8a016a_9d8aeb62","line":107,"updated":"2015-11-19 20:09:02.000000000","message":"This should be undef","commit_id":"4b59d699fc6afabdd08bfc1696081bd953420f7e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c6ed78d3417b7ffa5a173c3c21f3a90b3b834a52","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  $rabbit_virtualhost   \u003d \u0027/\u0027"},{"line_number":108,"context_line":") {"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  if $rabbit_virtualhost {"},{"line_number":111,"context_line":"    warning(\u0027The parameter rabbit_virtualhost is deprecated, use rabbit_virtual_host.\u0027)"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba8a016a_3dec1f29","line":110,"updated":"2015-11-19 20:09:02.000000000","message":"To properly deprecate this, you should update this to be \n\nif $rabbit_virtualhost {\n  warning(\u0027....\u0027)\n  $rabbit_virtual_host_real \u003d $rabbit_virtualhost\n} else {\n  $rabbit_virtual_host_real \u003d $rabbit_virtual_host\n}","commit_id":"4b59d699fc6afabdd08bfc1696081bd953420f7e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c6ed78d3417b7ffa5a173c3c21f3a90b3b834a52","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  designate_config {"},{"line_number":157,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_userid\u0027          : value \u003d\u003e $rabbit_userid;"},{"line_number":158,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_password\u0027        : value \u003d\u003e $rabbit_password, secret \u003d\u003e true;"},{"line_number":159,"context_line":"    \u0027oslo_messaging_rabbit/rabbit_virtual_host\u0027    : value \u003d\u003e $rabbit_virtual_host;"},{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  if $rabbit_hosts {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba8a016a_5defa31d","line":159,"updated":"2015-11-19 20:09:02.000000000","message":"and then this should be value \u003d\u003e $rabbit_virtual_host_real","commit_id":"4b59d699fc6afabdd08bfc1696081bd953420f7e"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"db19d30552826408cee2b02d594f81ae444b49a6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"#"},{"line_number":83,"context_line":"# [*rabbit_virtualhost*]"},{"line_number":84,"context_line":"#   (optional) DEPRECATED. Use rabbit_virtual_host"},{"line_number":85,"context_line":"#   Defaults to \u0027/\u0027"},{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class designate("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_fcbbe0c1","line":85,"updated":"2015-11-20 09:20:45.000000000","message":"should be \"Defaults to undef\"","commit_id":"53878eb77da177efda00738bc080bbd576ec3448"}],"spec/classes/designate_init_spec.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"db19d30552826408cee2b02d594f81ae444b49a6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_userid\u0027).with_value( params[:rabbit_userid] )"},{"line_number":116,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_password\u0027).with_value( params[:rabbit_password] )"},{"line_number":117,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_password\u0027).with_value( params[:rabbit_password] ).with_secret(true)"},{"line_number":118,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_virtual_host\u0027).with_value( params[:rabbit_virtual_host] )"},{"line_number":119,"context_line":"    end"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    it { is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_host\u0027).with_value( params[:rabbit_host] ) }"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ba8a016a_dc7b7cf3","line":118,"updated":"2015-11-20 09:20:45.000000000","message":"i think we also should keep tests for deprecated parameter in this case rabbit_virtualhost","commit_id":"53878eb77da177efda00738bc080bbd576ec3448"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c4c0de114d9d8f9cdc3599b4f355ebbbdbfc3272","unresolved":false,"context_lines":[{"line_number":117,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_userid\u0027).with_value( params[:rabbit_userid] )"},{"line_number":118,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_password\u0027).with_value( params[:rabbit_password] )"},{"line_number":119,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_password\u0027).with_value( params[:rabbit_password] ).with_secret(true)"},{"line_number":120,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_virtual_host\u0027).with_value( params[:rabbit_virtual_host] )"},{"line_number":121,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_virtual_host\u0027).with_value( params[:rabbit_virtualhost] )"},{"line_number":122,"context_line":"    end"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a8ffd7b_5daddf2f","line":120,"updated":"2015-11-25 21:04:44.000000000","message":"Why do you copy-paste this test? For case of using deprecated parameter, you should use only deprecated parameter. Do not mix them.\n\nFor example, https://github.com/openstack/puppet-sahara/blob/stable/kilo/spec/classes/sahara_init_spec.rb#L57","commit_id":"e05568660ff4dfad2472b17378d5c36280652ddd"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"526af37c355777597f08070d76558ac16923cd67","unresolved":false,"context_lines":[{"line_number":117,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_userid\u0027).with_value( params[:rabbit_userid] )"},{"line_number":118,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_password\u0027).with_value( params[:rabbit_password] )"},{"line_number":119,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_password\u0027).with_value( params[:rabbit_password] ).with_secret(true)"},{"line_number":120,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_virtual_host\u0027).with_value( params[:rabbit_virtual_host] )"},{"line_number":121,"context_line":"      is_expected.to contain_designate_config(\u0027oslo_messaging_rabbit/rabbit_virtual_host\u0027).with_value( params[:rabbit_virtualhost] )"},{"line_number":122,"context_line":"    end"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"9a8ffd7b_e373bfe5","line":120,"updated":"2015-11-26 09:43:25.000000000","message":"missed this, i am agree with Denis, we should have separate shared_examples for case with deprecated parameter","commit_id":"e05568660ff4dfad2472b17378d5c36280652ddd"}]}