)]}'
{"manifests/pool_manager.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"478fbea2d193c19ca3e144d9da3e3d822e253490","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#  Defaults to $::os_service_default"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*pool_id*]"},{"line_number":32,"context_line":"#  (optional) The ID of the pool managed by this instance of the Pool Manager. "},{"line_number":33,"context_line":"#  Defaults to \u0027794ccc2c-d751-44fe-b57f-8894c9f5c842\u0027"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*threshold_percentage*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_f6738d13","line":32,"range":{"start_line":32,"start_character":78,"end_line":32,"end_character":79},"updated":"2016-01-13 14:32:01.000000000","message":"empty space","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"2e6fba9cf0db1966a085b27c8c60f6f7f53291bb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#  Defaults to $::os_service_default"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*pool_id*]"},{"line_number":32,"context_line":"#  (optional) The ID of the pool managed by this instance of the Pool Manager. "},{"line_number":33,"context_line":"#  Defaults to \u0027794ccc2c-d751-44fe-b57f-8894c9f5c842\u0027"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*threshold_percentage*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_622b9334","line":32,"range":{"start_line":32,"start_character":78,"end_line":32,"end_character":79},"in_reply_to":"da6ed579_f6738d13","updated":"2016-01-18 02:45:35.000000000","message":"thanks .The Pool Manager is configured to know which DNS servers Designate manages, I think it could has default value","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1d446c8c2e4bd3cb0f2f44720656291e6f66d08b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"class designate::pool_manager ("},{"line_number":83,"context_line":"  $package_ensure             \u003d present,"},{"line_number":84,"context_line":"  $pool_manager_package_name  \u003d undef,"},{"line_number":85,"context_line":"  $enabled                    \u003d true,"},{"line_number":86,"context_line":"  $service_ensure             \u003d \u0027running\u0027,"},{"line_number":87,"context_line":"  $workers                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_fe735b7e","line":84,"updated":"2016-01-13 16:33:43.000000000","message":"do not use pick, use params.pp instead, like other modules.","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"51ddae1d55d8382115aa5faea0b4fc0bd874d441","unresolved":false,"context_lines":[{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"class designate::pool_manager ("},{"line_number":83,"context_line":"  $package_ensure             \u003d present,"},{"line_number":84,"context_line":"  $pool_manager_package_name  \u003d undef,"},{"line_number":85,"context_line":"  $enabled                    \u003d true,"},{"line_number":86,"context_line":"  $service_ensure             \u003d \u0027running\u0027,"},{"line_number":87,"context_line":"  $workers                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_58b520ce","line":84,"in_reply_to":"da6ed579_42b44fd0","updated":"2016-01-18 04:00:39.000000000","message":"done ,just found using “inherits designate”","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"2e6fba9cf0db1966a085b27c8c60f6f7f53291bb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"class designate::pool_manager ("},{"line_number":83,"context_line":"  $package_ensure             \u003d present,"},{"line_number":84,"context_line":"  $pool_manager_package_name  \u003d undef,"},{"line_number":85,"context_line":"  $enabled                    \u003d true,"},{"line_number":86,"context_line":"  $service_ensure             \u003d \u0027running\u0027,"},{"line_number":87,"context_line":"  $workers                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_42b44fd0","line":84,"in_reply_to":"da6ed579_fe735b7e","updated":"2016-01-18 02:45:35.000000000","message":"thanks,use include ::designate::params, variable pool_manager_package_name do not equal $designate::params::pool_manager_package_name. for example:\nwhen set $pool_manager_package_name \u003d $designate::params::pool_manager_package_name ,\nthe following the package_name value clould be NULL\n$pool_manager_package_name \u003d$\ndesignate::generic_service { \n\u0027pool-manager\u0027:package_name   \u003d\u003e$pool_manager_package_name,}","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"478fbea2d193c19ca3e144d9da3e3d822e253490","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $threshold_percentage       \u003d \u0027100\u0027,"},{"line_number":91,"context_line":"  $poll_timeout               \u003d $::os_service_default,"},{"line_number":92,"context_line":"  $poll_retry_interval        \u003d $::os_service_default,"},{"line_number":93,"context_line":"  $poll_max_retries           \u003d $::os_service_default,"},{"line_number":94,"context_line":"  $poll_delay                 \u003d $::os_service_default,"},{"line_number":95,"context_line":"  $enable_recovery_timer      \u003d true,"},{"line_number":96,"context_line":"  $periodic_recovery_interval \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_7610fda8","line":93,"range":{"start_line":93,"start_character":35,"end_line":93,"end_character":53},"updated":"2016-01-13 14:32:01.000000000","message":"designate is not under os_service_default pattern yet, unfortunately.","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"2e6fba9cf0db1966a085b27c8c60f6f7f53291bb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $threshold_percentage       \u003d \u0027100\u0027,"},{"line_number":91,"context_line":"  $poll_timeout               \u003d $::os_service_default,"},{"line_number":92,"context_line":"  $poll_retry_interval        \u003d $::os_service_default,"},{"line_number":93,"context_line":"  $poll_max_retries           \u003d $::os_service_default,"},{"line_number":94,"context_line":"  $poll_delay                 \u003d $::os_service_default,"},{"line_number":95,"context_line":"  $enable_recovery_timer      \u003d true,"},{"line_number":96,"context_line":"  $periodic_recovery_interval \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_e276a3d7","line":93,"range":{"start_line":93,"start_character":35,"end_line":93,"end_character":53},"in_reply_to":"da6ed579_7610fda8","updated":"2016-01-18 02:45:35.000000000","message":"Done","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"478fbea2d193c19ca3e144d9da3e3d822e253490","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":123,"context_line":"    manage_service \u003d\u003e $service_ensure,"},{"line_number":124,"context_line":"    ensure_package \u003d\u003e $package_ensure,"},{"line_number":125,"context_line":"    package_name   \u003d\u003e pick($pool_manager_package_name, $::designate::params::pool_manager_package_name),"},{"line_number":126,"context_line":"    service_name   \u003d\u003e $::designate::params::pool_manager_service_name,"},{"line_number":127,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_36d845ef","line":125,"range":{"start_line":125,"start_character":58,"end_line":125,"end_character":67},"updated":"2016-01-13 14:32:01.000000000","message":"please use as default value $::designate::params::pool_manager_package_name for $pool_manager_package_name, it will avoid using of pick here.","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"d79cee35622f7b008989039eb6252142ee973584","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":123,"context_line":"    manage_service \u003d\u003e $service_ensure,"},{"line_number":124,"context_line":"    ensure_package \u003d\u003e $package_ensure,"},{"line_number":125,"context_line":"    package_name   \u003d\u003e pick($pool_manager_package_name, $::designate::params::pool_manager_package_name),"},{"line_number":126,"context_line":"    service_name   \u003d\u003e $::designate::params::pool_manager_service_name,"},{"line_number":127,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_bbdc1513","line":125,"range":{"start_line":125,"start_character":58,"end_line":125,"end_character":67},"in_reply_to":"da6ed579_36d845ef","updated":"2016-01-13 16:21:38.000000000","message":"@Denis\n\nI feel puzzled here. \n\nb/c in designate::api, designate::sink, designate::central, they all use pick to chose package name.\n\nCould you give the reason for avoiding using pick ?","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"747b80abf26e92102349f1e9e21b1c7712bc15ef","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":123,"context_line":"    manage_service \u003d\u003e $service_ensure,"},{"line_number":124,"context_line":"    ensure_package \u003d\u003e $package_ensure,"},{"line_number":125,"context_line":"    package_name   \u003d\u003e pick($pool_manager_package_name, $::designate::params::pool_manager_package_name),"},{"line_number":126,"context_line":"    service_name   \u003d\u003e $::designate::params::pool_manager_service_name,"},{"line_number":127,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_eacb9151","line":125,"range":{"start_line":125,"start_character":58,"end_line":125,"end_character":67},"in_reply_to":"da6ed579_bbdc1513","updated":"2016-01-13 17:39:28.000000000","message":"They are already outdated and should be updated.","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"2e6fba9cf0db1966a085b27c8c60f6f7f53291bb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":123,"context_line":"    manage_service \u003d\u003e $service_ensure,"},{"line_number":124,"context_line":"    ensure_package \u003d\u003e $package_ensure,"},{"line_number":125,"context_line":"    package_name   \u003d\u003e pick($pool_manager_package_name, $::designate::params::pool_manager_package_name),"},{"line_number":126,"context_line":"    service_name   \u003d\u003e $::designate::params::pool_manager_service_name,"},{"line_number":127,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"da6ed579_a280ab8c","line":125,"range":{"start_line":125,"start_character":58,"end_line":125,"end_character":67},"in_reply_to":"da6ed579_eacb9151","updated":"2016-01-18 02:45:35.000000000","message":"Done","commit_id":"d21011f15b45b4282e88740026cd4a809a601091"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"108a86b56c7b8eb2fa90fcb408683c2b1f8ef7d6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#  Defaults to 1000"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*pool_id*]"},{"line_number":32,"context_line":"#  (optional) The ID of the pool managed by this instance of the Pool Manager. "},{"line_number":33,"context_line":"#  Defaults to \u0027794ccc2c-d751-44fe-b57f-8894c9f5c842\u0027"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*threshold_percentage*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_461f715b","line":32,"range":{"start_line":32,"start_character":78,"end_line":32,"end_character":79},"updated":"2016-01-18 11:54:35.000000000","message":"empty space","commit_id":"2c53972b7ccfaa0915042cb2e9c5e50cfb612ae8"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"72ad59d08cdd6cc2cc8f85ac99e96e63c160d75d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#  Defaults to 1000"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*pool_id*]"},{"line_number":32,"context_line":"#  (optional) The ID of the pool managed by this instance of the Pool Manager. "},{"line_number":33,"context_line":"#  Defaults to \u0027794ccc2c-d751-44fe-b57f-8894c9f5c842\u0027"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*threshold_percentage*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_8d28c1e3","line":32,"range":{"start_line":32,"start_character":78,"end_line":32,"end_character":79},"in_reply_to":"da6ed579_461f715b","updated":"2016-01-23 02:07:39.000000000","message":"Done，thanks","commit_id":"2c53972b7ccfaa0915042cb2e9c5e50cfb612ae8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"108a86b56c7b8eb2fa90fcb408683c2b1f8ef7d6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"class designate::pool_manager ("},{"line_number":83,"context_line":"  $package_ensure             \u003d present,"},{"line_number":84,"context_line":"  $pool_manager_package_name  \u003d $::designate::params::pool_manager_package_name"},{"line_number":85,"context_line":","},{"line_number":86,"context_line":"  $enabled                    \u003d true,"},{"line_number":87,"context_line":"  $service_ensure             \u003d \u0027running\u0027,"},{"line_number":88,"context_line":"  $workers                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_e630e5ea","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":1},"updated":"2016-01-18 11:54:35.000000000","message":"i think it should be on prev line :)","commit_id":"2c53972b7ccfaa0915042cb2e9c5e50cfb612ae8"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"72ad59d08cdd6cc2cc8f85ac99e96e63c160d75d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"class designate::pool_manager ("},{"line_number":83,"context_line":"  $package_ensure             \u003d present,"},{"line_number":84,"context_line":"  $pool_manager_package_name  \u003d $::designate::params::pool_manager_package_name"},{"line_number":85,"context_line":","},{"line_number":86,"context_line":"  $enabled                    \u003d true,"},{"line_number":87,"context_line":"  $service_ensure             \u003d \u0027running\u0027,"},{"line_number":88,"context_line":"  $workers                    \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_4d1e49bc","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":1},"in_reply_to":"da6ed579_e630e5ea","updated":"2016-01-23 02:07:39.000000000","message":"Done，thanks","commit_id":"2c53972b7ccfaa0915042cb2e9c5e50cfb612ae8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"108a86b56c7b8eb2fa90fcb408683c2b1f8ef7d6","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":123,"context_line":"    manage_service \u003d\u003e $service_ensure,"},{"line_number":124,"context_line":"    ensure_package \u003d\u003e $package_ensure,"},{"line_number":125,"context_line":"    package_name   \u003d\u003e $::designate::params::pool_manager_package_name,"},{"line_number":126,"context_line":"    service_name   \u003d\u003e $::designate::params::pool_manager_service_name,"},{"line_number":127,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da6ed579_26659de0","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":16},"updated":"2016-01-18 11:54:35.000000000","message":"another services have configurable package name. do we need it here?","commit_id":"2c53972b7ccfaa0915042cb2e9c5e50cfb612ae8"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"72ad59d08cdd6cc2cc8f85ac99e96e63c160d75d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    enabled        \u003d\u003e $enabled,"},{"line_number":123,"context_line":"    manage_service \u003d\u003e $service_ensure,"},{"line_number":124,"context_line":"    ensure_package \u003d\u003e $package_ensure,"},{"line_number":125,"context_line":"    package_name   \u003d\u003e $::designate::params::pool_manager_package_name,"},{"line_number":126,"context_line":"    service_name   \u003d\u003e $::designate::params::pool_manager_service_name,"},{"line_number":127,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_486ab782","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":16},"in_reply_to":"da6ed579_26659de0","updated":"2016-01-23 02:07:39.000000000","message":"Done","commit_id":"2c53972b7ccfaa0915042cb2e9c5e50cfb612ae8"}]}