)]}'
{"manifests/agent.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"413b6e8462207c6504169a974e266c865d655bae","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  $enabled            \u003d true,"},{"line_number":31,"context_line":"  $service_ensure     \u003d \u0027running\u0027,"},{"line_number":32,"context_line":"  $backend_driver     \u003d \u0027bind9\u0027,"},{"line_number":33,"context_line":") inherits designate {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  designate_config {"},{"line_number":36,"context_line":"    \u0027service:agent/backend_driver\u0027         : value \u003d\u003e $backend_driver;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_1f688086","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":20},"updated":"2016-01-14 10:14:10.000000000","message":"as we discussed on irc channel with Alex, why we need here inherit from designate main class?\n\nAlso, we need inherit from ::designate::params class, as we using default value from this class.\n\nAnd i\u0027m not sure that we can inherit two classes in one time.\n\nThoughts?","commit_id":"681250724c2dfb5a40d8cfce4b655d1ab62511ba"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"90b5deb1544787595e150237118720fa2713d68e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  $enabled            \u003d true,"},{"line_number":31,"context_line":"  $service_ensure     \u003d \u0027running\u0027,"},{"line_number":32,"context_line":"  $backend_driver     \u003d \u0027bind9\u0027,"},{"line_number":33,"context_line":") inherits designate {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  designate_config {"},{"line_number":36,"context_line":"    \u0027service:agent/backend_driver\u0027         : value \u003d\u003e $backend_driver;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_e3194589","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":20},"in_reply_to":"da6ed579_1f688086","updated":"2016-01-14 15:04:54.000000000","message":"If we don\u0027t inherits from designate, or we just inherits from designate::params, then Exec[\u0027post-designate_config\u0027] ~\u003e Service\u003c| title \u003d\u003d $designate_title |\u003e in designate::generic_service will fail.\nTo avoid this,  I set  inherits from designate::params in class designate, then set inherits from designate in other classes.\n\nSo each service class can inherit two classes now.","commit_id":"681250724c2dfb5a40d8cfce4b655d1ab62511ba"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"2cfaf3ae4296a6192a173c706d9ff69ca0cb8c21","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  $enabled            \u003d true,"},{"line_number":31,"context_line":"  $service_ensure     \u003d \u0027running\u0027,"},{"line_number":32,"context_line":"  $backend_driver     \u003d \u0027bind9\u0027,"},{"line_number":33,"context_line":") inherits designate {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  designate_config {"},{"line_number":36,"context_line":"    \u0027service:agent/backend_driver\u0027         : value \u003d\u003e $backend_driver;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_8c02cc08","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":20},"in_reply_to":"da6ed579_b82853e3","updated":"2016-01-15 09:20:01.000000000","message":"If you consider this is ok, please change vote number :)","commit_id":"681250724c2dfb5a40d8cfce4b655d1ab62511ba"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c8446a53d2bf80723d0f4ee5e914ed566f3bebf6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  $enabled            \u003d true,"},{"line_number":31,"context_line":"  $service_ensure     \u003d \u0027running\u0027,"},{"line_number":32,"context_line":"  $backend_driver     \u003d \u0027bind9\u0027,"},{"line_number":33,"context_line":") inherits designate {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  designate_config {"},{"line_number":36,"context_line":"    \u0027service:agent/backend_driver\u0027         : value \u003d\u003e $backend_driver;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da6ed579_b82853e3","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":20},"in_reply_to":"da6ed579_e3194589","updated":"2016-01-14 16:51:36.000000000","message":"I\u0027m ok with such way, make sense.","commit_id":"681250724c2dfb5a40d8cfce4b655d1ab62511ba"}]}
