)]}'
{"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a7c350efa82da094c68546236015fb4331cdf89f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  $rabbit_password       \u003d \u0027\u0027,"},{"line_number":130,"context_line":"  $rabbit_virtual_host   \u003d \u0027/\u0027,"},{"line_number":131,"context_line":"  $rabbit_use_ssl        \u003d false,"},{"line_number":132,"context_line":"  $kombu_ssl_ca_certs    \u003d undef,"},{"line_number":133,"context_line":"  $kombu_ssl_certfile    \u003d undef,"},{"line_number":134,"context_line":"  $kombu_ssl_keyfile     \u003d undef,"},{"line_number":135,"context_line":"  $kombu_ssl_version     \u003d \u0027TLSv1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a5de9d1_2cdc0945","line":132,"range":{"start_line":132,"start_character":27,"end_line":132,"end_character":32},"updated":"2016-02-01 13:18:26.000000000","message":"We can use $::os_service_default here now\n\nTake a look on cinder module for example.","commit_id":"60a19c36727ec8b0df9280d29f728c511be4377e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2fe9f41457c5eac991843aca7ca76f6ef938800b","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    $rabbit_virtual_host_real \u003d $rabbit_virtual_host"},{"line_number":148,"context_line":"  }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  if $kombu_ssl_ca_certs !\u003d $::os_service_default and !$rabbit_use_ssl {"},{"line_number":151,"context_line":"    fail(\u0027The kombu_ssl_ca_certs parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":"  if $kombu_ssl_certfile !\u003d $::os_service_default and !$rabbit_use_ssl {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_931bd580","line":150,"range":{"start_line":150,"start_character":5,"end_line":150,"end_character":48},"updated":"2016-02-01 15:42:09.000000000","message":"we have actually function for this: is_service_default(parameter) :)","commit_id":"7bc48b3b983f965a7556a9e111b86e3bc0cfc96e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2fe9f41457c5eac991843aca7ca76f6ef938800b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"      \u0027oslo_messaging_rabbit/kombu_ssl_keyfile\u0027:  ensure \u003d\u003e absent;"},{"line_number":253,"context_line":"      \u0027oslo_messaging_rabbit/kombu_ssl_version\u0027:  ensure \u003d\u003e absent;"},{"line_number":254,"context_line":"    }"},{"line_number":255,"context_line":"  }"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"  # default setting"},{"line_number":258,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a5de9d1_d64a9b54","line":255,"updated":"2016-02-01 15:42:09.000000000","message":"as we have os_service_default function we can use one config executing for all of them, because also we have checks above.","commit_id":"7bc48b3b983f965a7556a9e111b86e3bc0cfc96e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8fd0482d2126d75b4a21ccf678aa12b3df3d8f36","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  }"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  if $rabbit_use_ssl {"},{"line_number":223,"context_line":"    designate_config {"},{"line_number":224,"context_line":"      \u0027oslo_messaging_rabbit/kombu_ssl_ca_certs\u0027:    value \u003d\u003e $kombu_ssl_ca_certs;"},{"line_number":225,"context_line":"      \u0027oslo_messaging_rabbit/kombu_ssl_certfile\u0027:    value \u003d\u003e $kombu_ssl_certfile;"},{"line_number":226,"context_line":"      \u0027oslo_messaging_rabbit/kombu_ssl_keyfile\u0027:     value \u003d\u003e $kombu_ssl_keyfile;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a5ae5dd_2a72254a","line":223,"updated":"2016-02-04 10:19:07.000000000","message":"We also have this one:\n\noslo_messaging_rabbit/rabbit_use_ssl: value \u003d\u003e $rabbit_use_ssl;\n\nIf this parameter is unset, it will be disabled, isn\u0027t it? I guess you accidentally missed that.\n\nSo you can simply move these lines to above (in section with 205-207) to another default rabbit parameters. Because of using os_service_default fact, it will have ensure \u003d\u003e absent by default. When we will have \u0027true\u0027 for rabbit_ssl - we have also validation above.","commit_id":"c329d9852994458ffa75a936076bf373b99e3287"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4f8aeb7a62afac52168c99f292940434cb55338d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  if !is_service_default($kombu_ssl_keyfile) and !$rabbit_use_ssl {"},{"line_number":157,"context_line":"    fail(\u0027The kombu_ssl_keyfile parameter requires rabbit_use_ssl to be set to true\u0027)"},{"line_number":158,"context_line":"  }"},{"line_number":159,"context_line":"  if (is_service_default($kombu_ssl_certfile) and ! is_service_default($kombu_ssl_keyfile)) or (is_service_default($kombu_ssl_keyfile) and ! is_service_default($kombu_ssl_certfile)) {"},{"line_number":160,"context_line":"    fail(\u0027The kombu_ssl_certfile and kombu_ssl_keyfile parameters must be used together\u0027)"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a5ae5dd_65ecb48f","line":159,"updated":"2016-02-04 19:00:01.000000000","message":"Can you add a test around this logic?","commit_id":"8af6af267d1895464fc55dd0a75f05a011708856"}],"spec/defines/designate_generic_service_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4f8aeb7a62afac52168c99f292940434cb55338d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    end"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    let :facts do"},{"line_number":20,"context_line":"      { :osfamily \u003d\u003e \u0027Debian\u0027 }.merge!(OSDefaults.get_facts())"},{"line_number":21,"context_line":"    end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    let :title do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5a5ae5dd_45e9787f","line":20,"updated":"2016-02-04 19:00:01.000000000","message":"get_facts takes a parameter to use the defaults, no need to merge here as that is done in get_facts\n\nOSDefaults.get_facts({ :osfamily \u003d\u003e \u0027Debian\u0027 })","commit_id":"8af6af267d1895464fc55dd0a75f05a011708856"}]}