)]}'
{"manifests/pool.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"26472daa80d2542136d91dd3eedfd2f2f8c05edd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"define designate::pool("},{"line_number":17,"context_line":"  $nameservers,"},{"line_number":18,"context_line":"  $targets,"},{"line_number":19,"context_line":"  $also_notifies \u003d [],"},{"line_number":20,"context_line":"){"},{"line_number":21,"context_line":"  validate_array($nameservers)"},{"line_number":22,"context_line":"  validate_array($targets)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a5ae5dd_afb707f4","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":16},"updated":"2016-02-04 10:12:02.000000000","message":"We can path it as non-array anyway. So, we can also add here validate_array or any2array function before join this.","commit_id":"6ea7eed1454be623b9bdf6ebe63b2a9b83d06778"}],"manifests/pool_manager_cache/memcache.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"26472daa80d2542136d91dd3eedfd2f2f8c05edd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*memcached_servers*]"},{"line_number":8,"context_line":"#  (optional) Memcache servers."},{"line_number":9,"context_line":"#  Defaults to 127.0.0.1."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*expiration*]"},{"line_number":12,"context_line":"#  Cache expiration time."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a5ae5dd_8a579901","line":9,"updated":"2016-02-04 10:12:02.000000000","message":"it is string, default is array.\n\nthe same here: need to add validate_array, or any2array","commit_id":"6ea7eed1454be623b9bdf6ebe63b2a9b83d06778"}],"manifests/pool_nameserver.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"798191750067765a5d6ea0a358a2396fea5f96ee","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $port \u003d 53,"},{"line_number":13,"context_line":"  $host \u003d \u0027127.0.0.1\u0027,"},{"line_number":14,"context_line":"){"},{"line_number":15,"context_line":"  include ::designate"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  designate_config {"},{"line_number":18,"context_line":"    \"pool_nameserver:${name}/port\":    value \u003d\u003e $port;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a5ae5dd_6b205af8","line":15,"updated":"2016-02-03 12:49:57.000000000","message":"why we need this include here?","commit_id":"b9db8ef3faec4861339cfb46080b7cf746c82301"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5fdfdba207179f55c899dccf5b23d00c748b7fc3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"){"},{"line_number":15,"context_line":"  designate_config {"},{"line_number":16,"context_line":"    \"pool_nameserver:${name}/port\":    value \u003d\u003e $port;"},{"line_number":17,"context_line":"    \"pool_nameserver:${name}/host\":    value \u003d\u003e $host;"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5a5ae5dd_23764bd7","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":39},"updated":"2016-02-08 12:05:08.000000000","message":"alignment","commit_id":"9dd967c94ab20f2bd9466341c310679af109844c"}],"manifests/pool_target.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"798191750067765a5d6ea0a358a2396fea5f96ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*options*]"},{"line_number":8,"context_line":"#  Options to be passed to the backend DNS server. This should include host and"},{"line_number":9,"context_line":"#  port. For instance for a bind9 "},{"line_number":10,"context_line":"#  target this could be:"},{"line_number":11,"context_line":"#    rndc_host: 192.168.27.100, rndc_port: 953, rndc_config_file: /etc/bind/rndc.conf, rndc_key_file: /etc/bind/rndc.key, port: 53, host: 192.168.27.100"},{"line_number":12,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a5ae5dd_cb6aae1a","line":9,"updated":"2016-02-03 12:49:57.000000000","message":"empty space","commit_id":"b9db8ef3faec4861339cfb46080b7cf746c82301"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"26472daa80d2542136d91dd3eedfd2f2f8c05edd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*options*]"},{"line_number":8,"context_line":"#  Options to be passed to the backend DNS server. This should include host and"},{"line_number":9,"context_line":"#  port. For instance for a bind9 "},{"line_number":10,"context_line":"#  target this could be:"},{"line_number":11,"context_line":"#    rndc_host: 192.168.27.100, rndc_port: 953, rndc_config_file: /etc/bind/rndc.conf, rndc_key_file: /etc/bind/rndc.key, port: 53, host: 192.168.27.100"},{"line_number":12,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a5ae5dd_6a3d7dba","line":9,"updated":"2016-02-04 10:12:02.000000000","message":"empty space","commit_id":"6ea7eed1454be623b9bdf6ebe63b2a9b83d06778"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"26472daa80d2542136d91dd3eedfd2f2f8c05edd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# [*masters*]"},{"line_number":14,"context_line":"#  (optional) IP addresses and ports of the master DNS server. This should point"},{"line_number":15,"context_line":"#  to the Designate mDNS servers and ports."},{"line_number":16,"context_line":"#  Defaults to 127.0.0.1:5354"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*type*]"},{"line_number":19,"context_line":"#  (optional) Port number of the target DNS server."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a5ae5dd_2a5ea512","line":16,"updated":"2016-02-04 10:12:02.000000000","message":"[\u0027127.0.0.1:5354\u0027]","commit_id":"6ea7eed1454be623b9bdf6ebe63b2a9b83d06778"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"26472daa80d2542136d91dd3eedfd2f2f8c05edd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"define designate::pool_target ("},{"line_number":23,"context_line":"  $options,"},{"line_number":24,"context_line":"  $type,"},{"line_number":25,"context_line":"  $masters          \u003d [\u0027127.0.0.1:5354\u0027],"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":"  if target \u003d\u003d \u0027powerdns\u0027 {"},{"line_number":28,"context_line":"    include ::powerdns"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a5ae5dd_6a649de4","line":25,"updated":"2016-02-04 10:12:02.000000000","message":"alignment","commit_id":"6ea7eed1454be623b9bdf6ebe63b2a9b83d06778"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"af4aefc337e3a78bb0d05b23ba07e254f6de5ea1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*type*]"},{"line_number":19,"context_line":"#  (optional) Port number of the target DNS server."},{"line_number":20,"context_line":"#  Defaults to bind9"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"define designate::pool_target ("},{"line_number":23,"context_line":"  $options,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a5ae5dd_c0a036a8","line":20,"updated":"2016-02-09 16:38:00.000000000","message":"that\u0027s not optional :)","commit_id":"4da37f26074f599d3fd2ff35c6960dbcc7960f03"}],"spec/defines/designate_pool_nameserver_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0182be5ce8663316a05bb3393d10a4d383bccfb3","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027designate::pool_nameserver\u0027 do"},{"line_number":4,"context_line":"  let :facts do"},{"line_number":5,"context_line":"    @default_facts.merge({:osfamily \u003d\u003e \u0027Debian\u0027})"},{"line_number":6,"context_line":"  end"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  let :params do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a5ae5dd_0c49a55f","line":5,"updated":"2016-02-03 20:42:36.000000000","message":"It would be nice if this used on_supported_os rather than just locking to Debian, but at a minimum please switch this to be OSDefaults.get_Facts({:osfmaily \u003d\u003e \u0027Debian\u0027}). I\u0027m trying to get rid of the @default_facts access now that OSDefaults is available","commit_id":"6ea7eed1454be623b9bdf6ebe63b2a9b83d06778"}],"spec/defines/designate_pool_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0182be5ce8663316a05bb3393d10a4d383bccfb3","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027designate::pool\u0027 do"},{"line_number":4,"context_line":"  let :facts do"},{"line_number":5,"context_line":"    @default_facts.merge({:osfamily \u003d\u003e \u0027Debian\u0027})"},{"line_number":6,"context_line":"  end"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  let :params do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a5ae5dd_cc794d95","line":5,"updated":"2016-02-03 20:42:36.000000000","message":"ditto","commit_id":"6ea7eed1454be623b9bdf6ebe63b2a9b83d06778"}],"spec/defines/designate_pool_target_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0182be5ce8663316a05bb3393d10a4d383bccfb3","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027designate::pool_target\u0027 do"},{"line_number":4,"context_line":"  let :facts do"},{"line_number":5,"context_line":"    @default_facts.merge({:osfamily \u003d\u003e \u0027Debian\u0027})"},{"line_number":6,"context_line":"  end"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  let :params do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a5ae5dd_ac74119c","line":5,"updated":"2016-02-03 20:42:36.000000000","message":"ditto","commit_id":"6ea7eed1454be623b9bdf6ebe63b2a9b83d06778"}]}