)]}'
{"manifests/zone_manager.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"dd1e2ac5eb5a2199f14f2b4579243f81ce2dc4ce","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $threads                   \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $enabled_tasks             \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $export_synchronous        \u003d $::os_service_default,"},{"line_number":49,"context_line":"  ) inherits designate {"},{"line_number":50,"context_line":"  include ::designate::params"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5aef4532_e22629b9","line":49,"updated":"2016-03-08 16:22:07.000000000","message":"You should just inherit from designate::params instead of designate because you are using $::designate::params::zone_manager_package_name as default for package_name.  Or are you pulling in designate for some other reason?","commit_id":"61dad69771f95b5cda1e28ae7167f07326dd7053"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f696423581f049e7c24645bba34c5bf07dda7b0f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $threads                   \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $enabled_tasks             \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $export_synchronous        \u003d $::os_service_default,"},{"line_number":49,"context_line":"  ) inherits designate {"},{"line_number":50,"context_line":"  include ::designate::params"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5aef4532_2732b65f","line":49,"in_reply_to":"5aef4532_e22629b9","updated":"2016-03-09 11:01:21.000000000","message":"Alex, probably because of this: https://review.openstack.org/#/c/267058/2/manifests/agent.pp","commit_id":"61dad69771f95b5cda1e28ae7167f07326dd7053"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f696423581f049e7c24645bba34c5bf07dda7b0f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $enabled_tasks             \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $export_synchronous        \u003d $::os_service_default,"},{"line_number":49,"context_line":"  ) inherits designate {"},{"line_number":50,"context_line":"  include ::designate::params"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  designate_config {"},{"line_number":53,"context_line":"    \u0027service:zone_manager/workers\u0027            : value \u003d\u003e $workers;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5aef4532_870aaa77","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":29},"updated":"2016-03-09 11:01:21.000000000","message":"+ to comment above, then we don\u0027t need this include","commit_id":"61dad69771f95b5cda1e28ae7167f07326dd7053"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"2d443fc30f5a4f1680c6ac4489584a51cf66196d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#  (optional) Whether the designate zone manager service will be running."},{"line_number":21,"context_line":"#  Defaults to \u0027running\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*workers*]"},{"line_number":24,"context_line":"#  (optional) Number of workers to spawn."},{"line_number":25,"context_line":"#  Defaults to \u0027None\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*threads*]"},{"line_number":28,"context_line":"#  (optional) Number of greenthreads to spawn"},{"line_number":29,"context_line":"#  Defaults to \u00271000\u0027"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*enabled_tasks*]"},{"line_number":32,"context_line":"#  (optional) List of tasks to enable, the default enables all tasks."},{"line_number":33,"context_line":"#  tasks"},{"line_number":34,"context_line":"#  Defaults to \u0027None\u0027"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*export_synchronous*]"},{"line_number":37,"context_line":"#  (optional) Whether to allow synchronous zone exports"},{"line_number":38,"context_line":"#  Defaults to true"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"class designate::zone_manager ("},{"line_number":41,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_913b2e38","line":38,"range":{"start_line":23,"start_character":0,"end_line":38,"end_character":19},"updated":"2016-12-02 09:42:23.000000000","message":"default values here and in class definition should match","commit_id":"4988133da8c7fb6dafb7393f846d492aae8f30b7"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"2d443fc30f5a4f1680c6ac4489584a51cf66196d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $package_name              \u003d $::designate::params::zone_manager_package_name,"},{"line_number":43,"context_line":"  $enabled                   \u003d true,"},{"line_number":44,"context_line":"  $service_ensure            \u003d running,"},{"line_number":45,"context_line":"  $workers                   \u003d $::os_service_default,"},{"line_number":46,"context_line":"  $threads                   \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $enabled_tasks             \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $export_synchronous        \u003d $::os_service_default,"},{"line_number":49,"context_line":"  ) inherits designate {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_71f93280","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":53},"updated":"2016-12-02 09:42:23.000000000","message":"is it possible to use $::os_workers fact here?","commit_id":"4988133da8c7fb6dafb7393f846d492aae8f30b7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d186be38b7494c0cf7fa473daed906bfbeab2340","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*package_ensure*]"},{"line_number":8,"context_line":"#  (optional) The state of the package"},{"line_number":9,"context_line":"#  Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*package_name*]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a71b18c_2e552df9","line":8,"updated":"2016-12-06 00:33:47.000000000","message":"Please folow this style for all parameters here\n[*parameter*]\n  (optional) ...\n  Defaults ...","commit_id":"dfe362cc06cb4eb2c0e945ad8c48caeece004f95"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"ada771ddc5bbaa4c465b8a36866a8e519fe39516","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*package_ensure*]"},{"line_number":8,"context_line":"#  (optional) The state of the package"},{"line_number":9,"context_line":"#  Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*package_name*]"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a71b18c_fa504834","line":8,"in_reply_to":"3a71b18c_2e552df9","updated":"2016-12-06 05:43:49.000000000","message":"Sorry I can\u0027t see what the difference is? Aren\u0027t I following that format?","commit_id":"dfe362cc06cb4eb2c0e945ad8c48caeece004f95"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecd79f640069eea1688e900b2e2e6cad39c91833","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*enabled_tasks*]"},{"line_number":32,"context_line":"#  (optional) List of tasks to enable, the default enables all tasks."},{"line_number":33,"context_line":"#  tasks"},{"line_number":34,"context_line":"#  Defaults to $::os_service_default."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*export_synchronous*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_e575efca","line":33,"updated":"2016-12-06 17:00:17.000000000","message":"remove this line please","commit_id":"7e3ce04ce279b6e177b787cbb1d19c33b531b579"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"ecd79f640069eea1688e900b2e2e6cad39c91833","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $threads                   \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $enabled_tasks             \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $export_synchronous        \u003d $::os_service_default,"},{"line_number":49,"context_line":"  ) inherits designate {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  designate_config {"},{"line_number":52,"context_line":"    \u0027service:zone_manager/workers\u0027            : value \u003d\u003e $workers;"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_252a8790","line":49,"updated":"2016-12-06 17:00:17.000000000","message":"may be inherits designate::params?","commit_id":"7e3ce04ce279b6e177b787cbb1d19c33b531b579"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"19cb97e23907d2f747a5af30159766764b11612c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  $threads                   \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $enabled_tasks             \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $export_synchronous        \u003d $::os_service_default,"},{"line_number":49,"context_line":"  ) inherits designate {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  designate_config {"},{"line_number":52,"context_line":"    \u0027service:zone_manager/workers\u0027            : value \u003d\u003e $workers;"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_453a14e8","line":49,"in_reply_to":"3a71b18c_252a8790","updated":"2016-12-06 22:57:41.000000000","message":"Can\u0027t do that, see comments on patchset 4","commit_id":"7e3ce04ce279b6e177b787cbb1d19c33b531b579"}],"spec/classes/designate_zone_manager_spec.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"1e86b31654a0bf76fc22b0690fd7b55055b3c838","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Unit tests for designate::zone_manager"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"require \u0027spec_helper\u0027"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"describe \u0027designate::zone_manager\u0027 do"},{"line_number":8,"context_line":"  let :params do"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a71b18c_701e4560","line":5,"updated":"2016-12-05 09:54:18.000000000","message":"could you please use osdefaults facts here and on_supported_os method, like it was done e.g https://github.com/openstack/puppet-designate/tree/master/spec/classes, thank you!","commit_id":"964b6c12f1d1892572117401c78da28bb7ef1d9d"}]}