)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"ab9a597e52ec9796c44aa205ff3333502d9d9df8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"spec: Add Unit-Test for designate rootwrap_config and paste_ini types/providers."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Additionally it contains patch with autorequire of designate-common package for rootwrap_conf."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I64a75948f30661706ee6338448d9f662d28e871f"},{"line_number":12,"context_line":"Partial-bug: #1440401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_c1dbf44d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":94},"updated":"2016-03-09 13:54:28.000000000","message":"it\u0027s overflow symbols in line.","commit_id":"c68f3ade2e183ece6ebf82819484706823b193b6"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c65b9a37b3cc0e56ab09ce9f6b73ff118fd19605","unresolved":false,"context_lines":[{"line_number":8,"context_line":"paste_ini types/providers."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Additionally it contains patch with autorequire of designate-common"},{"line_number":11,"context_line":"package for rootwrap_conf."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I64a75948f30661706ee6338448d9f662d28e871f"},{"line_number":14,"context_line":"Partial-bug: #1440401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_864d1ec6","line":11,"updated":"2016-03-10 22:24:48.000000000","message":"This should be in a separate patch.","commit_id":"e2a9ddf21cabce637296c1a31bcea89455183383"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c21415620ef00d70c1acf642a5ae4ba8c194f7e1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"paste_ini types/providers."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Additionally it contains patch with autorequire of designate-common"},{"line_number":11,"context_line":"package for rootwrap_conf."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I64a75948f30661706ee6338448d9f662d28e871f"},{"line_number":14,"context_line":"Partial-bug: #1440401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afc51ec_3f2b4632","line":11,"in_reply_to":"3afc51ec_7617d0ed","updated":"2016-03-11 20:34:14.000000000","message":"I mean adding the autorequire and the new test for it should be in a separate patch, since this patch is supposed to be about \"Add Unit-Test for designate rootwrap_config and\npaste_ini types/providers.\" I won\u0027t block on it though, just keep in mind for the future that it\u0027s better to have a commit do just one small thing at a time.","commit_id":"e2a9ddf21cabce637296c1a31bcea89455183383"},{"author":{"_account_id":18810,"name":"alexey-mr","email":"alexey.morlang@gmail.com","username":"alexey-mr"},"change_message_id":"7bc0f81327a18c9c0caf690203f17a936086032e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"paste_ini types/providers."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Additionally it contains patch with autorequire of designate-common"},{"line_number":11,"context_line":"package for rootwrap_conf."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I64a75948f30661706ee6338448d9f662d28e871f"},{"line_number":14,"context_line":"Partial-bug: #1440401"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afc51ec_7617d0ed","line":11,"in_reply_to":"5aef4532_864d1ec6","updated":"2016-03-11 12:39:25.000000000","message":"Do you mean \u0027move to separate review the patch and its unit-test\u0027 or just the patch? From my view it\u0027s quite suitable having a change and its test in one patch.","commit_id":"e2a9ddf21cabce637296c1a31bcea89455183383"}],"spec/unit/provider/designate_api_paste_ini/ini_setting_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c65b9a37b3cc0e56ab09ce9f6b73ff118fd19605","unresolved":false,"context_lines":[{"line_number":24,"context_line":"provider_class \u003d Puppet::Type.type(:designate_api_paste_ini).provider(:ini_setting)"},{"line_number":25,"context_line":"describe provider_class do"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  it \u0027should default to the default setting when no other one is specified\u0027 do"},{"line_number":28,"context_line":"    resource \u003d Puppet::Type::Designate_api_paste_ini.new("},{"line_number":29,"context_line":"      {:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027plop\u0027}"},{"line_number":30,"context_line":"    )"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5aef4532_a61dba74","line":27,"updated":"2016-03-10 22:24:48.000000000","message":"This test looks basically identical to the test below, and isn\u0027t testing a default setting because it is setting it to \u0027DEFAULT\u0027.","commit_id":"e2a9ddf21cabce637296c1a31bcea89455183383"}],"spec/unit/type/designate_api_paste_ini.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c65b9a37b3cc0e56ab09ce9f6b73ff118fd19605","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  end"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  it \u0027should not require a value when ensure is absent\u0027 do"},{"line_number":27,"context_line":"    Puppet::Type.type(:designate_api_paste_ini).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :ensure \u003d\u003e :absent)"},{"line_number":28,"context_line":"  end"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  it \u0027should accept a valid value\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5aef4532_f1593efe","line":27,"updated":"2016-03-10 22:24:48.000000000","message":"Should probably have expect {..}.not_to raise_error ?\n\nIf this test is here it should probably also have a \u0027should require a value when ensure is present\u0027 test?","commit_id":"e2a9ddf21cabce637296c1a31bcea89455183383"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c65b9a37b3cc0e56ab09ce9f6b73ff118fd19605","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  it \u0027should not accept a value with whitespace\u0027 do"},{"line_number":36,"context_line":"    @designate_api_paste_ini[:value] \u003d \u0027b ar\u0027"},{"line_number":37,"context_line":"    expect(@designate_api_paste_ini[:value]).to eq(\u0027b ar\u0027)"},{"line_number":38,"context_line":"  end"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  it \u0027should accept valid ensure values\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5aef4532_d1eb6211","line":37,"updated":"2016-03-10 22:24:48.000000000","message":"This seems like it\u0027s accepting the value?","commit_id":"e2a9ddf21cabce637296c1a31bcea89455183383"}],"spec/unit/type/designate_rootwrap_config_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c65b9a37b3cc0e56ab09ce9f6b73ff118fd19605","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  it \u0027should not require a value when ensure is absent\u0027 do"},{"line_number":27,"context_line":"    Puppet::Type.type(:designate_rootwrap_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :ensure \u003d\u003e :absent)"},{"line_number":28,"context_line":"  end"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  it \u0027should accept a valid value\u0027 do"},{"line_number":31,"context_line":"    @designate_rootwrap_config[:value] \u003d \u0027bar\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5aef4532_711a4ec7","line":28,"updated":"2016-03-10 22:24:48.000000000","message":"Should probably have an expect statement and another test to test the opposite","commit_id":"e2a9ddf21cabce637296c1a31bcea89455183383"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c65b9a37b3cc0e56ab09ce9f6b73ff118fd19605","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  it \u0027should not accept a value with whitespace\u0027 do"},{"line_number":36,"context_line":"    @designate_rootwrap_config[:value] \u003d \u0027b ar\u0027"},{"line_number":37,"context_line":"    expect(@designate_rootwrap_config[:value]).to eq(\u0027b ar\u0027)"},{"line_number":38,"context_line":"  end"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  it \u0027should accept valid ensure values\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5aef4532_9176fa03","line":37,"updated":"2016-03-10 22:24:48.000000000","message":"This seems to be accepting the value","commit_id":"e2a9ddf21cabce637296c1a31bcea89455183383"}]}