)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"14e5372e13ccccd464760d803a6e62e9d01af8a4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   Should designate endpoint be configured? Optional. Defaults to \u0027true\u0027."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*configure_user*]"},{"line_number":20,"context_line":"#   Should Trove user be configured?"},{"line_number":21,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*configure_user_role*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_b780dc4a","line":20,"range":{"start_line":20,"start_character":11,"end_line":20,"end_character":16},"updated":"2016-06-16 13:41:40.000000000","message":"designate?","commit_id":"5767f7767f91d6b04d10a6820730d490238cde49"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"14e5372e13ccccd464760d803a6e62e9d01af8a4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*configure_user_role*]"},{"line_number":24,"context_line":"#   Should Trove user_role be configured?"},{"line_number":25,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*service_name*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_37950c88","line":24,"range":{"start_line":24,"start_character":11,"end_line":24,"end_character":16},"updated":"2016-06-16 13:41:40.000000000","message":"designate?","commit_id":"5767f7767f91d6b04d10a6820730d490238cde49"}],"spec/classes/designate_keystone_auth_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6adf52c749289cb543f938be04356fa03be9fab4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    end"},{"line_number":104,"context_line":"    it { is_expected.to_not contain_keystone_user(\u0027designate\u0027) }"},{"line_number":105,"context_line":"    it { is_expected.to_not contain_keystone_user_role(\u0027designate@services\u0027) }"},{"line_number":106,"context_line":"    it { is_expected.to contain_keystone_service(\u0027designate::dns\u0027).with("},{"line_number":107,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":108,"context_line":"        :description \u003d\u003e \u0027Openstack DNSaas Service\u0027"},{"line_number":109,"context_line":"    ) }"},{"line_number":110,"context_line":"  end"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  on_supported_os({"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9abb7d3a_440b0c2c","line":109,"range":{"start_line":106,"start_character":0,"end_line":109,"end_character":7},"updated":"2016-06-02 09:55:54.000000000","message":"passed parameters are not affect this","commit_id":"c65692c40426163cb480d3f0a7b845ee89550501"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"14e52eb6dcc4f64acf475bef796d6b6d29024f04","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    end"},{"line_number":104,"context_line":"    it { is_expected.to_not contain_keystone_user(\u0027designate\u0027) }"},{"line_number":105,"context_line":"    it { is_expected.to_not contain_keystone_user_role(\u0027designate@services\u0027) }"},{"line_number":106,"context_line":"    it { is_expected.to contain_keystone_service(\u0027designate::dns\u0027).with("},{"line_number":107,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":108,"context_line":"        :description \u003d\u003e \u0027Openstack DNSaas Service\u0027"},{"line_number":109,"context_line":"    ) }"},{"line_number":110,"context_line":"  end"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  on_supported_os({"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9abb7d3a_ee449a1c","line":109,"range":{"start_line":106,"start_character":0,"end_line":109,"end_character":7},"in_reply_to":"9abb7d3a_440b0c2c","updated":"2016-06-04 05:51:30.000000000","message":"Denis, these parameters are just to ensure keystone service for designate when disabling user \u0026 user_role configuration.\n\nIts always better to ensure keystone service, keystone endpoint during enable or disable configuration changes.\n\nIt was followed even in zaqar, even in keystone also -\n\nhttps://github.com/openstack/puppet-keystone/blob/master/spec/defines/keystone_resource_service_identity_spec.rb\n\nhttps://github.com/openstack/puppet-zaqar/blob/master/spec/classes/zaqar_keystone_auth_spec.rb\n\nWith this change, everything looks good.","commit_id":"c65692c40426163cb480d3f0a7b845ee89550501"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"04c4c28a34bd1c96cf7087ed59e19441bb44647a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    end"},{"line_number":104,"context_line":"    it { is_expected.to_not contain_keystone_user(\u0027designate\u0027) }"},{"line_number":105,"context_line":"    it { is_expected.to_not contain_keystone_user_role(\u0027designate@services\u0027) }"},{"line_number":106,"context_line":"    it { is_expected.to contain_keystone_service(\u0027designate::dns\u0027).with("},{"line_number":107,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":108,"context_line":"        :description \u003d\u003e \u0027Openstack DNSaas Service\u0027"},{"line_number":109,"context_line":"    ) }"},{"line_number":110,"context_line":"  end"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  on_supported_os({"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7aa08908_efc47241","line":109,"range":{"start_line":106,"start_character":0,"end_line":109,"end_character":7},"in_reply_to":"9abb7d3a_ee449a1c","updated":"2016-06-06 11:02:27.000000000","message":"Passed parameters are not affect this test. Why do we need to test everything in each test?","commit_id":"c65692c40426163cb480d3f0a7b845ee89550501"}]}