)]}'
{"manifests/keystone/auth.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ce2d1a0fab93261e1c979d79874152275bc8b34c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  Keystone_user_role[\"${auth_name}@${tenant}\"] ~\u003e"},{"line_number":73,"context_line":"    Service \u003c| name \u003d\u003d \u0027designate-api\u0027 |\u003e"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  keystone::resource::service_identity { $real_service_name:"},{"line_number":76,"context_line":"    configure_user      \u003d\u003e true,"},{"line_number":77,"context_line":"    configure_user_role \u003d\u003e true,"},{"line_number":78,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_6c6997be","line":75,"range":{"start_line":75,"start_character":42,"end_line":75,"end_character":59},"updated":"2016-06-06 16:45:36.000000000","message":"I\u0027m not sure this makes sense because $auth_name could be like admin or something and shared between services. Why do we need to unhardcode this?","commit_id":"c0921eb26588b4fcc3169667a789026be4f085f4"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"921f60125e8e07028e529d434edd160615f3db2c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  Keystone_user_role[\"${auth_name}@${tenant}\"] ~\u003e"},{"line_number":73,"context_line":"    Service \u003c| name \u003d\u003d \u0027designate-api\u0027 |\u003e"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  keystone::resource::service_identity { $real_service_name:"},{"line_number":76,"context_line":"    configure_user      \u003d\u003e true,"},{"line_number":77,"context_line":"    configure_user_role \u003d\u003e true,"},{"line_number":78,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_f01c1c15","line":75,"range":{"start_line":75,"start_character":42,"end_line":75,"end_character":59},"in_reply_to":"7aa08908_6c6997be","updated":"2016-06-07 08:14:34.000000000","message":"most of the services use either a hardcoded name reflecting the service name, or an auth_name (which defaults to something similar). If we want to un-hardcode this, I think we should just use the auth_name.","commit_id":"c0921eb26588b4fcc3169667a789026be4f085f4"}],"spec/classes/designate_keystone_auth_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"920e7c20c05c25b9f8bfcf5eb92fee34954d5469","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    context \u0027when overriding auth name\u0027 do"},{"line_number":55,"context_line":"      let :params do"},{"line_number":56,"context_line":"        { :password \u003d\u003e \u0027foo\u0027,"},{"line_number":57,"context_line":"          :auth_name \u003d\u003e \u0027designate\u0027 }"},{"line_number":58,"context_line":"      end"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"      it { is_expected.to contain_keystone_user(\u0027designate\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_1a15a548","line":57,"updated":"2016-06-10 10:25:35.000000000","message":"please do not use defaults for overriding tests","commit_id":"939c95c2552141a42b048c1a5f8b0dd894405002"}]}