)]}'
{"manifests/dns.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2e8a9664161785e0e65cf22257c7e1af66fd1305","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  $designatefile  \u003d undef,"},{"line_number":22,"context_line":") {"},{"line_number":23,"context_line":"  warning(\u0027The class designate::dns is depecrated. Use designate::backend::bind9 instead.\u0027)"},{"line_number":24,"context_line":"  include ::designate::backend::bind9"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_f16052d1","line":24,"updated":"2016-07-06 16:38:59.000000000","message":"the problem is that your deprecation is not completed. Because parameters are not consumed anymore. Can you reach Nectar \u0026 TWC to make sure we don\u0027t break them?\nI\u0027m ok with the change otherwise.","commit_id":"350b4938a3c8332089d214ac527c3c432272e6a7"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"b6de5dc71228d3c692e2ee2afc227fac791a4fc3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  $designatefile  \u003d undef,"},{"line_number":22,"context_line":") {"},{"line_number":23,"context_line":"  warning(\u0027The class designate::dns is depecrated. Use designate::backend::bind9 instead.\u0027)"},{"line_number":24,"context_line":"  include ::designate::backend::bind9"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_d75b3984","line":24,"in_reply_to":"1aa78d24_88154b9d","updated":"2016-07-07 20:38:43.000000000","message":"makes sense","commit_id":"350b4938a3c8332089d214ac527c3c432272e6a7"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"506cb705383e0254cd417de1540bef7281a0e740","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  $designatefile  \u003d undef,"},{"line_number":22,"context_line":") {"},{"line_number":23,"context_line":"  warning(\u0027The class designate::dns is depecrated. Use designate::backend::bind9 instead.\u0027)"},{"line_number":24,"context_line":"  include ::designate::backend::bind9"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_88154b9d","line":24,"in_reply_to":"1aa78d24_a87e4767","updated":"2016-07-07 02:11:21.000000000","message":"The dns class had for sole purpose to create bind9 specific files (/var/lib/designate/bind9, /var/lib/designate/bind9/zones.config), it was meant to be used in combination with designate::backend::bind9. That\u0027s why it just \u0027redirects\u0027 to the backend now, so it doesn\u0027t break users.\n\nIt wouldn\u0027t make sense to use this class along with powerdns, it adds a line to /etc/named.conf...","commit_id":"350b4938a3c8332089d214ac527c3c432272e6a7"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"9b342b2f8a293d9b7d821c743a05b60c5435c341","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  $designatefile  \u003d undef,"},{"line_number":22,"context_line":") {"},{"line_number":23,"context_line":"  warning(\u0027The class designate::dns is depecrated. Use designate::backend::bind9 instead.\u0027)"},{"line_number":24,"context_line":"  include ::designate::backend::bind9"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_a87e4767","line":24,"in_reply_to":"1aa78d24_b1d08a20","updated":"2016-07-07 01:56:26.000000000","message":"We\u0027re not using this class, we include the powerdns backend. I think you need to change the comment to mention both and take out the auto include of bind9","commit_id":"350b4938a3c8332089d214ac527c3c432272e6a7"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"9ecbc0001920fb499b0721b772d7bae309ad44dd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  $designatefile  \u003d undef,"},{"line_number":22,"context_line":") {"},{"line_number":23,"context_line":"  warning(\u0027The class designate::dns is depecrated. Use designate::backend::bind9 instead.\u0027)"},{"line_number":24,"context_line":"  include ::designate::backend::bind9"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_b1d08a20","line":24,"in_reply_to":"1aa78d24_f16052d1","updated":"2016-07-06 16:43:50.000000000","message":"The parameters have nowhere to be consumed, the only place they are used is to create the files that are also no longer managed as of this commit. I\u0027ve asked TWC for review.","commit_id":"350b4938a3c8332089d214ac527c3c432272e6a7"}]}
