)]}'
{"manifests/central.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"83fab7af77977f01847c522d9de803b59c90d44a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"# [*threads*]"},{"line_number":53,"context_line":"#  (optional) Number of central greenthreads to spawn."},{"line_number":54,"context_line":"#  Defaults to 1000"},{"line_number":55,"context_line":"# "},{"line_number":56,"context_line":"# [*storage_driver*]"},{"line_number":57,"context_line":"#  (optional) The storage driver to use."},{"line_number":58,"context_line":"#  Defaults to sqlalchemy"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a98d1f4_765c97ed","line":55,"updated":"2016-09-30 10:28:28.000000000","message":"please remove this space","commit_id":"2feea911b98087af404813a6c28a9e389f9d7d59"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"83fab7af77977f01847c522d9de803b59c90d44a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"# [*default_pool_id*]"},{"line_number":65,"context_line":"#  (optional) The name of the default pool."},{"line_number":66,"context_line":"#  Defaults to 794ccc2c-d751-44fe-b57f-8894c9f5c842"},{"line_number":67,"context_line":"# "},{"line_number":68,"context_line":"class designate::central ("},{"line_number":69,"context_line":"  $package_ensure                \u003d present,"},{"line_number":70,"context_line":"  $central_package_name          \u003d $::designate::params::central_package_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a98d1f4_d66d6b99","line":67,"updated":"2016-09-30 10:28:28.000000000","message":"this too","commit_id":"2feea911b98087af404813a6c28a9e389f9d7d59"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"83fab7af77977f01847c522d9de803b59c90d44a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  $max_domain_name_len           \u003d \u0027255\u0027,"},{"line_number":77,"context_line":"  $max_recordset_name_len        \u003d \u0027255\u0027,"},{"line_number":78,"context_line":"  $min_ttl                       \u003d $::os_service_default,"},{"line_number":79,"context_line":"  $workers                       \u003d \u0027None\u0027,"},{"line_number":80,"context_line":"  $threads                       \u003d \u00271000\u0027,"},{"line_number":81,"context_line":"  $storage_driver                \u003d \u0027sqlalchemy\u0027,"},{"line_number":82,"context_line":"  $enabled_notification_handlers \u003d \u0027[]\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a98d1f4_d6048bc1","line":79,"updated":"2016-09-30 10:28:28.000000000","message":"should defaults to $::os_workers fact","commit_id":"2feea911b98087af404813a6c28a9e389f9d7d59"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32c0a437964d0c6cc38878baab7347147a3d7496","unresolved":false,"context_lines":[{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*threads*]"},{"line_number":53,"context_line":"#  (optional) Number of central greenthreads to spawn."},{"line_number":54,"context_line":"#  Defaults to 1000"},{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"# [*storage_driver*]"},{"line_number":57,"context_line":"#  (optional) The storage driver to use."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a98d1f4_bf96cfed","line":54,"updated":"2016-09-30 21:37:48.000000000","message":"These values should be $::os_service_default rather than specifying the default thats in the config.  Also this default value seems odd but i guess we should take that up with the designate devlopers","commit_id":"25371e607158174f480152809f0007272286eef4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32c0a437964d0c6cc38878baab7347147a3d7496","unresolved":false,"context_lines":[{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"# [*storage_driver*]"},{"line_number":57,"context_line":"#  (optional) The storage driver to use."},{"line_number":58,"context_line":"#  Defaults to sqlalchemy"},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*enabled_notification_handlers*]"},{"line_number":61,"context_line":"#  (optional) Enabled Notification Handlers."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a98d1f4_df9b9b16","line":58,"updated":"2016-09-30 21:37:48.000000000","message":"$::os_service_default","commit_id":"25371e607158174f480152809f0007272286eef4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32c0a437964d0c6cc38878baab7347147a3d7496","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*default_pool_id*]"},{"line_number":65,"context_line":"#  (optional) The name of the default pool."},{"line_number":66,"context_line":"#  Defaults to 794ccc2c-d751-44fe-b57f-8894c9f5c842"},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"class designate::central ("},{"line_number":69,"context_line":"  $package_ensure                \u003d present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a98d1f4_ff9cd70f","line":66,"updated":"2016-09-30 21:37:48.000000000","message":"$::os_service_default","commit_id":"25371e607158174f480152809f0007272286eef4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"81eba87a1681add85c8215b0ffc347e4068dde48","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  $max_domain_name_len           \u003d \u0027255\u0027,"},{"line_number":77,"context_line":"  $max_recordset_name_len        \u003d \u0027255\u0027,"},{"line_number":78,"context_line":"  $min_ttl                       \u003d $::os_service_default,"},{"line_number":79,"context_line":"  $workers                       \u003d $::os_workers,"},{"line_number":80,"context_line":"  $threads                       \u003d \u00271000\u0027,"},{"line_number":81,"context_line":"  $storage_driver                \u003d \u0027sqlalchemy\u0027,"},{"line_number":82,"context_line":"  $enabled_notification_handlers \u003d \u0027[]\u0027,"},{"line_number":83,"context_line":"  $default_pool_id               \u003d \u0027794ccc2c-d751-44fe-b57f-8894c9f5c842\u0027,"},{"line_number":84,"context_line":") inherits designate {"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  designate_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a98d1f4_1e55e5c4","line":83,"range":{"start_line":79,"start_character":2,"end_line":83,"end_character":74},"updated":"2016-10-03 08:54:44.000000000","message":"i don\u0027t see that these parameters are passed into designate_config, so spec tests will always fail","commit_id":"0f3ab73f61ca3939018e37ecfab29d27451bda4c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"71105282eaf9e37a80d39a448e9ab2e0c1bdb357","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  $max_recordset_name_len        \u003d \u0027255\u0027,"},{"line_number":78,"context_line":"  $min_ttl                       \u003d $::os_service_default,"},{"line_number":79,"context_line":"  $workers                       \u003d $::os_workers,"},{"line_number":80,"context_line":"  $threads                       \u003d \u0027$::os_service_default\u0027,"},{"line_number":81,"context_line":"  $storage_driver                \u003d \u0027$::os_service_default\u0027,"},{"line_number":82,"context_line":"  $enabled_notification_handlers \u003d \u0027[]\u0027,"},{"line_number":83,"context_line":"  $default_pool_id               \u003d \u0027$::os_service_default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a98d1f4_567f3fdf","line":80,"updated":"2016-10-03 16:03:22.000000000","message":"$::os_service_default should not be in single quotes for these values.","commit_id":"94045a09a3f1e7dc079f6aa6f78ccb2ec8aea593"}]}