)]}'
{"manifests/central.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f8aeda310baf648dc144bdb04c46598cbd1e02a0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  $max_domain_name_len        \u003d \u0027255\u0027,"},{"line_number":70,"context_line":"  $max_recordset_name_len     \u003d \u0027255\u0027,"},{"line_number":71,"context_line":"  $min_ttl                    \u003d $::os_service_default,"},{"line_number":72,"context_line":"  $workers                    \u003d $::os_service_default,"},{"line_number":73,"context_line":"  $threads                    \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $default_pool_id            \u003d $::os_service_default,"},{"line_number":75,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f485f77_85b6d43d","line":72,"updated":"2017-11-15 21:55:42.000000000","message":"should we use ::os_workers ?","commit_id":"74aee65cdfeae494c12e88bce5da4491a17fe2be"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"4a4a4e4e12ebe575458e299462756de943acd13b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  $max_domain_name_len        \u003d \u0027255\u0027,"},{"line_number":70,"context_line":"  $max_recordset_name_len     \u003d \u0027255\u0027,"},{"line_number":71,"context_line":"  $min_ttl                    \u003d $::os_service_default,"},{"line_number":72,"context_line":"  $workers                    \u003d $::os_service_default,"},{"line_number":73,"context_line":"  $threads                    \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $default_pool_id            \u003d $::os_service_default,"},{"line_number":75,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1f485f77_c702873d","line":72,"in_reply_to":"1f485f77_85b6d43d","updated":"2017-11-16 07:43:17.000000000","message":"It\u0027s used very inconsistently across the code base. If you want I can do a patch after to use it everywhere.","commit_id":"74aee65cdfeae494c12e88bce5da4491a17fe2be"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"07d91fe16d14219b1ccb6b5cdfeb3f1841ef0205","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  $max_domain_name_len        \u003d \u0027255\u0027,"},{"line_number":70,"context_line":"  $max_recordset_name_len     \u003d \u0027255\u0027,"},{"line_number":71,"context_line":"  $min_ttl                    \u003d $::os_service_default,"},{"line_number":72,"context_line":"  $workers                    \u003d $::os_service_default,"},{"line_number":73,"context_line":"  $threads                    \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $default_pool_id            \u003d $::os_service_default,"},{"line_number":75,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ff82abbf_247b4f7b","line":72,"in_reply_to":"1f485f77_c702873d","updated":"2017-11-27 17:18:11.000000000","message":"yes workers should be configured with $::os_workers depending on which one threads/workers should be configured based on CPU count. Please do this in a follow up. Along with the designate worker class (i commented on that)","commit_id":"74aee65cdfeae494c12e88bce5da4491a17fe2be"}]}