)]}'
{"manifests/backend/bind9.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"385fe995f45637ad89efd8e13080300b10a029d6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":51,"context_line":"    file { \u0027/var/named\u0027:"},{"line_number":52,"context_line":"      owner \u003d\u003e \u0027named\u0027"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f91af0f_915d24eb","line":53,"updated":"2018-01-03 18:44:31.000000000","message":"I think this should probably be ensure_resource(\u0027file\u0027, \u0027/var/named\u0027, { ensure \u003d\u003e \u0027directory\u0027, \u0027owner\u0027 \u003d\u003e \u0027named\u0027 }) to prevent possible duplication errors.  Also we should probably make this management optional via a config flag of some sort.","commit_id":"3ddf2d0766fc06bf3a1b84416ddaf1c27c9da55a"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"86531f4be96de214f3665348c9dd381d11086a57","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027) {"},{"line_number":51,"context_line":"    file { \u0027/var/named\u0027:"},{"line_number":52,"context_line":"      owner \u003d\u003e \u0027named\u0027"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f91af0f_5668ed1f","line":53,"in_reply_to":"9f91af0f_915d24eb","updated":"2018-01-03 23:04:47.000000000","message":"Okay, will do.","commit_id":"3ddf2d0766fc06bf3a1b84416ddaf1c27c9da55a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b439704a124de5e5378c269327332fb49db6944f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # write access to the /var/named directory.  The default permissions only"},{"line_number":55,"context_line":"  # allow the owner write access, so make named the owner."},{"line_number":56,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and $set_var_named_owner) {"},{"line_number":57,"context_line":"    ensure_resource(\u0027file\u0027, \u0027/var/named\u0027, { ensure \u003d\u003e \u0027directory\u0027, owner \u003d\u003e \u0027named\u0027 })"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9f91af0f_971dfd74","line":57,"updated":"2018-01-04 19:36:53.000000000","message":"this file is already managed by puppet-designate:\nhttp://logs.openstack.org/84/530984/3/check/puppet-openstack-integration-4-scenario003-tempest-centos-7/fd75b7a/job-output.txt.gz#_2018-01-04_18_16_55_230069","commit_id":"92eafa6b9175d79b2608ca6a1ccbaafb3a965afd"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"2dcfae6f583da4c47caa88aa491c5f4263940773","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # write access to the /var/named directory.  The default permissions only"},{"line_number":55,"context_line":"  # allow the owner write access, so make named the owner."},{"line_number":56,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and $set_var_named_owner) {"},{"line_number":57,"context_line":"    ensure_resource(\u0027file\u0027, \u0027/var/named\u0027, { ensure \u003d\u003e \u0027directory\u0027, owner \u003d\u003e \u0027named\u0027 })"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9f91af0f_79362be9","line":57,"in_reply_to":"9f91af0f_56bc56ba","updated":"2018-01-04 21:12:55.000000000","message":"That\u0027s what I was thinking.  I didn\u0027t realize Ubuntu had the same issue, but since it does we might as well just fix both.","commit_id":"92eafa6b9175d79b2608ca6a1ccbaafb3a965afd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fd9658eedab9c80b5fa43e4165402b86b73d6b3b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # write access to the /var/named directory.  The default permissions only"},{"line_number":55,"context_line":"  # allow the owner write access, so make named the owner."},{"line_number":56,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and $set_var_named_owner) {"},{"line_number":57,"context_line":"    ensure_resource(\u0027file\u0027, \u0027/var/named\u0027, { ensure \u003d\u003e \u0027directory\u0027, owner \u003d\u003e \u0027named\u0027 })"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9f91af0f_b63cc2c8","line":57,"in_reply_to":"9f91af0f_971dfd74","updated":"2018-01-04 20:22:49.000000000","message":"No it\u0027s being managed by p-o-i.\n\n/etc/puppetlabs/code/modules/openstack_integration/manifests/bind.pp","commit_id":"92eafa6b9175d79b2608ca6a1ccbaafb3a965afd"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"24eea74e36b372a5233c8399ab959441b8d87547","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # write access to the /var/named directory.  The default permissions only"},{"line_number":55,"context_line":"  # allow the owner write access, so make named the owner."},{"line_number":56,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and $set_var_named_owner) {"},{"line_number":57,"context_line":"    ensure_resource(\u0027file\u0027, \u0027/var/named\u0027, { ensure \u003d\u003e \u0027directory\u0027, owner \u003d\u003e \u0027named\u0027 })"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9f91af0f_b66a82b0","line":57,"in_reply_to":"9f91af0f_b63cc2c8","updated":"2018-01-04 20:24:40.000000000","message":"Yeah, that seems like it belongs here.  Any objection to just moving that logic to this module?","commit_id":"92eafa6b9175d79b2608ca6a1ccbaafb3a965afd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0912915cb088628716d20b22a5649cf90b216268","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  # write access to the /var/named directory.  The default permissions only"},{"line_number":55,"context_line":"  # allow the owner write access, so make named the owner."},{"line_number":56,"context_line":"  if ($::osfamily \u003d\u003d \u0027RedHat\u0027 and $set_var_named_owner) {"},{"line_number":57,"context_line":"    ensure_resource(\u0027file\u0027, \u0027/var/named\u0027, { ensure \u003d\u003e \u0027directory\u0027, owner \u003d\u003e \u0027named\u0027 })"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9f91af0f_56bc56ba","line":57,"in_reply_to":"9f91af0f_b66a82b0","updated":"2018-01-04 20:47:29.000000000","message":"No objections but we seem to have different logic in p-o-i that covers both OS cases.\n\nhttps://github.com/openstack/puppet-openstack-integration/blob/master/manifests/bind.pp#L32-L38\n\nShould we just move that here instead?","commit_id":"92eafa6b9175d79b2608ca6a1ccbaafb3a965afd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a928f04c88093865604dd72a331790d67437b95f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  $rndc_port           \u003d \u0027953\u0027,"},{"line_number":31,"context_line":"  $rndc_config_file    \u003d \u0027/etc/rndc.conf\u0027,"},{"line_number":32,"context_line":"  $rndc_key_file       \u003d \u0027/etc/rndc.key\u0027,"},{"line_number":33,"context_line":"  $set_var_named_owner \u003d true"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  include ::designate::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f91af0f_a7032e0f","line":33,"updated":"2018-01-04 23:54:20.000000000","message":"where is this new parameter used?","commit_id":"6f308a063fc2ecf1796698a7f6c36816550ee104"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"df4891b45959364655b3d20f05b8ff2f357f4275","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  $rndc_port           \u003d \u0027953\u0027,"},{"line_number":31,"context_line":"  $rndc_config_file    \u003d \u0027/etc/rndc.conf\u0027,"},{"line_number":32,"context_line":"  $rndc_key_file       \u003d \u0027/etc/rndc.key\u0027,"},{"line_number":33,"context_line":"  $set_var_named_owner \u003d true"},{"line_number":34,"context_line":") {"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  include ::designate::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f91af0f_9af42bd1","line":33,"in_reply_to":"9f91af0f_a7032e0f","updated":"2018-01-05 18:09:15.000000000","message":"Oops, forgot to remove it.  I didn\u0027t think we needed to make it configurable now since the original p-o-i version wasn\u0027t.","commit_id":"6f308a063fc2ecf1796698a7f6c36816550ee104"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2e53310219eb2bc77a36b93041b755d4febdfd3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  # /var/named is root:named on RedHat and /var/cache/bind is root:bind on"},{"line_number":48,"context_line":"  # Debian. Both groups only have read access but require write permission in"},{"line_number":49,"context_line":"  # order to be able to use rndc addzone/delzone commands that Designate uses."},{"line_number":50,"context_line":"  file { $::dns::params::vardir:"},{"line_number":51,"context_line":"    mode    \u003d\u003e \u0027g+w\u0027,"},{"line_number":52,"context_line":"    require \u003d\u003e Package[$dns::params::dns_server_package]"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9f91af0f_6ba11646","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":3},"updated":"2018-01-09 18:48:00.000000000","message":"Need to use ensure_resource since this conflicts with p-o-i and drop it from p-o-i later\n\nensure_resource(\u0027file\u0027, $::dns::params::vardir, {\n  mode    \u003d\u003e \u0027g+w,\n  require \u003d\u003e Package[$::dns::params::dns_server_package]\n})\n\nOr you could drop the require and use:\n\nPackage\u003c| title \u003d\u003d $::dns::params::dns_server_package |\u003e -\u003e File\u003c| title \u003d\u003d $::dns::params::vardir |\u003e","commit_id":"5dc49e685f4942a66eb5358e654d16f75a3b74c8"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"10bfc03f246634e6b38982e1473d2b994e2cccd9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  # /var/named is root:named on RedHat and /var/cache/bind is root:bind on"},{"line_number":48,"context_line":"  # Debian. Both groups only have read access but require write permission in"},{"line_number":49,"context_line":"  # order to be able to use rndc addzone/delzone commands that Designate uses."},{"line_number":50,"context_line":"  file { $::dns::params::vardir:"},{"line_number":51,"context_line":"    mode    \u003d\u003e \u0027g+w\u0027,"},{"line_number":52,"context_line":"    require \u003d\u003e Package[$dns::params::dns_server_package]"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9f91af0f_d67c8273","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":3},"in_reply_to":"9f91af0f_6ba11646","updated":"2018-01-09 23:20:29.000000000","message":"Ack, that occurred to me after I pushed this.  Will change it.","commit_id":"5dc49e685f4942a66eb5358e654d16f75a3b74c8"}]}
