)]}'
{"manifests/backend/bind9.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3c2338ea3aa4a69ece001ca60bdfe521f1f9dade","unresolved":true,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*configure_named*]"},{"line_number":28,"context_line":"#  (optional) Enables running named configuration for hosts where designate and"},{"line_number":29,"context_line":"#  designate bind services are collocated. Defaults to true"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"class designate::backend::bind9 ("},{"line_number":32,"context_line":"  $rndc_host           \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"daa0768f_10766ce5","line":29,"range":{"start_line":29,"start_character":42,"end_line":29,"end_character":43},"updated":"2021-02-24 14:14:07.000000000","message":"Please add a new line here","commit_id":"b1ac0e4dfd386e426a3b28e582565cb099aaf62c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3c2338ea3aa4a69ece001ca60bdfe521f1f9dade","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  $rndc_config_file    \u003d \u0027/etc/rndc.conf\u0027,"},{"line_number":35,"context_line":"  $rndc_key_file       \u003d \u0027/etc/rndc.key\u0027,"},{"line_number":36,"context_line":"  $rndc_controls       \u003d undef,"},{"line_number":37,"context_line":"  $configure_named \u003d true,"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include designate::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3be1e1c0_fb9c1639","line":37,"range":{"start_line":37,"start_character":3,"end_line":37,"end_character":18},"updated":"2021-02-24 14:14:07.000000000","message":"I think configured_bind is the better parameter name because \"bind\" is generally used as package name in different distributions.\nI feel like \"named\" is too specific to CentOS/RHEL.","commit_id":"b1ac0e4dfd386e426a3b28e582565cb099aaf62c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3c2338ea3aa4a69ece001ca60bdfe521f1f9dade","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  $rndc_config_file    \u003d \u0027/etc/rndc.conf\u0027,"},{"line_number":35,"context_line":"  $rndc_key_file       \u003d \u0027/etc/rndc.key\u0027,"},{"line_number":36,"context_line":"  $rndc_controls       \u003d undef,"},{"line_number":37,"context_line":"  $configure_named \u003d true,"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include designate::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5442edc4_22319157","line":37,"range":{"start_line":37,"start_character":19,"end_line":37,"end_character":20},"updated":"2021-02-24 14:14:07.000000000","message":"Please align \u0027\u003d\u0027","commit_id":"b1ac0e4dfd386e426a3b28e582565cb099aaf62c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3c2338ea3aa4a69ece001ca60bdfe521f1f9dade","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  include designate::deps"},{"line_number":41,"context_line":"  include designate"},{"line_number":42,"context_line":"  if $configure_named {"},{"line_number":43,"context_line":"      if $rndc_controls {"},{"line_number":44,"context_line":"        class { \u0027dns\u0027:"},{"line_number":45,"context_line":"          controls \u003d\u003e $rndc_controls,"},{"line_number":46,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ab09e5aa_cc667b64","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":6},"updated":"2021-02-24 14:14:07.000000000","message":"Please use 2 spaces instead of 4 spaces for indent.","commit_id":"b1ac0e4dfd386e426a3b28e582565cb099aaf62c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1bb17e63c57fd80c10aaadf91bbdaa6c08c6806d","unresolved":true,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*configure_bind*]"},{"line_number":28,"context_line":"#  (optional) Enables running named configuration for hosts where designate and"},{"line_number":29,"context_line":"#  designate bind services are collocated. "},{"line_number":30,"context_line":"#  Defaults to true"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"class designate::backend::bind9 ("}],"source_content_type":"text/x-puppet","patch_set":3,"id":"0a3c915c_94bbdea3","line":29,"range":{"start_line":29,"start_character":42,"end_line":29,"end_character":43},"updated":"2021-02-25 14:08:47.000000000","message":"trailing space?","commit_id":"8089f9ac7151768af476cf68c9327081c5a64bed"}],"spec/classes/designate_backend_bind9_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3c2338ea3aa4a69ece001ca60bdfe521f1f9dade","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        is_expected.to contain_designate_config(\u0027backend:bind9/rndc_port\u0027).with_value(\u0027953\u0027)"},{"line_number":28,"context_line":"        is_expected.to contain_designate_config(\u0027backend:bind9/rndc_config_file\u0027).with_value(\u0027/etc/rndc.conf\u0027)"},{"line_number":29,"context_line":"        is_expected.to contain_designate_config(\u0027backend:bind9/rndc_key_file\u0027).with_value(\u0027/etc/rndc.key\u0027)"},{"line_number":30,"context_line":"        is_expected.not_to contain_concat_fragment(\u0027dns allow-new-zones\u0027).with("},{"line_number":31,"context_line":"          :target \u003d\u003e platform_params[:dns_optionspath],"},{"line_number":32,"context_line":"          :content \u003d\u003e \u0027allow-new-zones yes;\u0027)"},{"line_number":33,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fd311289_c757b65b","line":30,"updated":"2021-02-24 14:14:07.000000000","message":"You can remove \"with\" because it is enough that the concat_fragment resource with this name is not contained.","commit_id":"b1ac0e4dfd386e426a3b28e582565cb099aaf62c"}]}